Skip to contentSkip to conversation

mailbox: mtk-cmdq: Fix uninitialized variable in cmdq_mbox_flush()

PATCH In review Dan Carpenter 2 participants 2 messages Jun 22, 2021 – Jun 25, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mailbox: mtk-cmdq: Fix uninitialized variable in cmdq_mbox_flush()

The "cb" pointer needs to be initialized before can assign "data.data = cb->data;".

Fixes 4a3cb0303984 ("mailbox: mtk-cmdq: Use mailbox rx_callback")
---
 drivers/mailbox/mtk-cmdq-mailbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mailbox/mtk-cmdq-mailbox.c +1 -1
index 301e65b9527a..67a42b514429 100644
@@ -455,10 +455,10 @@ static int cmdq_mbox_flush(struct mbox_chan *chan, unsigned long timeout)
 
 	list_for_each_entry_safe(task, tmp, &thread->task_busy_list,
 				 list_entry) {
+		cb = &task->pkt->async_cb;
 		data.sta = -ECONNABORTED;
 		data.data = cb->data;
 		data.pkt = task->pkt;
-		cb = &task->pkt->async_cb;
 		if (cb->cb)
 			cb->cb(data);
 
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw

Hi, Dan:

Dan Carpenter <[email protected]> 於 2021年6月22日 週二 下午9:09寫道:

Quoted 3 lines

The "cb" pointer needs to be initialized before can assign "data.data = cb->data;".

Quoted 26 lines
Fixes 4a3cb0303984 ("mailbox: mtk-cmdq: Use mailbox rx_callback")
---
 drivers/mailbox/mtk-cmdq-mailbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mailbox/mtk-cmdq-mailbox.c +1 -2
index 301e65b9527a..67a42b514429 100644
@@ -455,10 +455,10 @@ static int cmdq_mbox_flush(struct mbox_chan *chan, unsigned long timeout)
 
        list_for_each_entry_safe(task, tmp, &thread->task_busy_list,
                                 list_entry) {
+               cb = &task->pkt->async_cb;
                data.sta = -ECONNABORTED;
                data.data = cb->data;
                data.pkt = task->pkt;
-               cb = &task->pkt->async_cb;
                if (cb->cb)
                        cb->cb(data);
 
--

2.30.2