Skip to contentSkip to conversation

device-drivers/cpufreq_boost: skip test on virtual machines

PATCH New Krzysztof Kozlowski 2 participants 6 messages Jun 23, 2021 – Sep 8, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 device-drivers/cpufreq_boost: skip test on virtual machines

Testing CPU frequency boost on a virtual machines is not reliable. Even if cpufreq driver reports boost frequencies, the underlying hypervisor might decide otherwise.

For example on AWS x1e.xlarge instance (claimed to be running on Intel Xeon E7 8880) under Xen hypervisor the test always fails:

    cpufreq_boost    0  TINFO  :  found 'intel_pstate' driver, sysfs knob '/sys/devices/system/cpu/intel_pstate/no_turbo'
    cpufreq_boost    0  TINFO  :  maximum speed is 3100000 KHz
    cpufreq_boost    0  TINFO  :  load CPU0 with boost enabled
    cpufreq_boost    0  TINFO  :  elapsed time is 1155 ms
    cpufreq_boost    0  TINFO  :  load CPU0 with boost disabled
    cpufreq_boost    0  TINFO  :  elapsed time is 1155 ms
    cpufreq_boost    1  TFAIL  :  cpufreq_boost.c:186: compare time spent with and without boost (-2%)
---
 testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c | 3 +++
 1 file changed, 3 insertions(+)
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c +3 -0
index b9739db37cb7..67917b3fea25 100644
@@ -90,6 +90,9 @@ static void setup(void)
 	unsigned int i;
 	tst_require_root();
 
+	if (tst_is_virt(VIRT_ANY))
+		tst_brkm(TCONF, NULL, "running in a virtual machine, overclock not reliably measureable");
+
 	for (i = 0; i < ARRAY_SIZE(cdrv); ++i) {
 		fd = open(cdrv[i].file, O_RDWR);
 		if (fd == -1)
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 device-drivers/cpufreq_boost: skip test on virtual machines

Quoted 26 lines · Krzysztof Kozlowski

Testing CPU frequency boost on a virtual machines is not reliable. Even if cpufreq driver reports boost frequencies, the underlying hypervisor might decide otherwise.

For example on AWS x1e.xlarge instance (claimed to be running on Intel Xeon E7 8880) under Xen hypervisor the test always fails:

    cpufreq_boost    0  TINFO  :  found 'intel_pstate' driver, sysfs knob '/sys/devices/system/cpu/intel_pstate/no_turbo'
    cpufreq_boost    0  TINFO  :  maximum speed is 3100000 KHz
    cpufreq_boost    0  TINFO  :  load CPU0 with boost enabled
    cpufreq_boost    0  TINFO  :  elapsed time is 1155 ms
    cpufreq_boost    0  TINFO  :  load CPU0 with boost disabled
    cpufreq_boost    0  TINFO  :  elapsed time is 1155 ms
    cpufreq_boost    1  TFAIL  :  cpufreq_boost.c:186: compare time spent with and without boost (-2%)
---
 testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c | 3 +++
 1 file changed, 3 insertions(+)
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c +0 -0
index b9739db37cb7..67917b3fea25 100644

testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c static void setup(void) · line 98

Quoted 9 lines
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c +3 -0
@@ -90,6 +90,9 @@ static void setup(void)
 	unsigned int i;
 	tst_require_root();
 
+	if (tst_is_virt(VIRT_ANY))
+		tst_brkm(TCONF, NULL, "running in a virtual machine, overclock not reliably measureable");
+
 	for (i = 0; i < ARRAY_SIZE(cdrv); ++i) {
 		fd = open(cdrv[i].file, O_RDWR);
 		if (fd == -1)

Optionally, under virtual machine the test failure could be converted to accepted pass. This would still allow to test CPUfreq boosting interface. Any preferences?

Best regards,
Krzysztof

#2 lore raw

PATCH 1/1 device-drivers/cpufreq_boost: skip test on virtual machines

Hi!

Quoted 8 lines
Quoted 8 lines
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c +0 -0
index b9739db37cb7..67917b3fea25 100644
@@ -90,6 +90,9 @@ static void setup(void)
 	unsigned int i;
 	tst_require_root();
 
Quoted 11 lines

testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c static void setup(void) · line 98

Quoted 7 lines
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c +3 -0
+	if (tst_is_virt(VIRT_ANY))
+		tst_brkm(TCONF, NULL, "running in a virtual machine, overclock not reliably measureable");
+
 	for (i = 0; i < ARRAY_SIZE(cdrv); ++i) {
 		fd = open(cdrv[i].file, O_RDWR);
 		if (fd == -1)

Optionally, under virtual machine the test failure could be converted to accepted pass. This would still allow to test CPUfreq boosting interface. Any preferences?

I wonder what is the likehood of actually dicovering a bug by writing to the cpufreq boost file from within a VM, I guess that it's non-zero at least.

Signature · 2 lines
Cyril Hrubis
[email protected]
#3 lore raw

PATCH 1/1 device-drivers/cpufreq_boost: skip test on virtual machines

Quoted 21 lines · Cyril Hrubis

Hi!

Quoted 8 lines
Quoted 8 lines
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c +0 -0
index b9739db37cb7..67917b3fea25 100644
@@ -90,6 +90,9 @@ static void setup(void)
 	unsigned int i;
 	tst_require_root();
 
Quoted 11 lines

testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c static void setup(void) · line 98

Quoted 7 lines
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c +3 -0
+	if (tst_is_virt(VIRT_ANY))
+		tst_brkm(TCONF, NULL, "running in a virtual machine, overclock not reliably measureable");
+
 	for (i = 0; i < ARRAY_SIZE(cdrv); ++i) {
 		fd = open(cdrv[i].file, O_RDWR);
 		if (fd == -1)

Optionally, under virtual machine the test failure could be converted to accepted pass. This would still allow to test CPUfreq boosting interface. Any preferences?

Quoted 3 lines

I wonder what is the likehood of actually dicovering a bug by writing to the cpufreq boost file from within a VM, I guess that it's non-zero at least.

It's a test of kernel interface and whether the driver accepts input via sysfs... so not much of a real cpufreq test. Indeed maybe better to skip the test explicitly instead of giving some false hopes that cpufreq is being tested.

Best regards,
Krzysztof

#4 lore raw

PATCH 1/1 device-drivers/cpufreq_boost: skip test on virtual machines

Quoted 22 lines · Krzysztof Kozlowski
Quoted 21 lines · Cyril Hrubis

Hi!

Quoted 19 lines
Quoted 6 lines
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c +0 -0
index b9739db37cb7..67917b3fea25 100644

testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c static void setup(void) · line 98

Quoted 9 lines
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c +3 -0
@@ -90,6 +90,9 @@ static void setup(void)
 	unsigned int i;
 	tst_require_root();
 
+	if (tst_is_virt(VIRT_ANY))
+		tst_brkm(TCONF, NULL, "running in a virtual machine, overclock not reliably measureable");
+
 	for (i = 0; i < ARRAY_SIZE(cdrv); ++i) {
 		fd = open(cdrv[i].file, O_RDWR);
 		if (fd == -1)

Optionally, under virtual machine the test failure could be converted to accepted pass. This would still allow to test CPUfreq boosting interface. Any preferences?

Quoted 8 lines
Quoted 3 lines

I wonder what is the likehood of actually dicovering a bug by writing to the cpufreq boost file from within a VM, I guess that it's non-zero at least.

It's a test of kernel interface and whether the driver accepts input via sysfs... so not much of a real cpufreq test. Indeed maybe better to skip the test explicitly instead of giving some false hopes that cpufreq is being tested.

Hi Cyril and all,

Anything stops this patch from being applied?

Best regards,
Krzysztof

#5 lore raw

PATCH 1/1 device-drivers/cpufreq_boost: skip test on virtual machines

Hi!

Quoted 3 lines

Hi Cyril and all,

Anything stops this patch from being applied?

Thanks for the reminded, pushed.

Signature · 2 lines
Cyril Hrubis
[email protected]