Skip to contentSkip to conversation

trace: Add timerlat tracer

bug report Dan Carpenter 1 participant 1 message Jun 29, 2021 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Daniel Bristot de Oliveira,

The patch a955d7eac177: "trace: Add timerlat tracer" from Jun 22, 2021, leads to the following static checker warning:

kernel/trace/trace_osnoise.c:1400 timerlat_main()
warn: inconsistent indenting

kernel/trace/trace_osnoise.c
1385 wait_next_period(tlat);
1386
1387 osn_var->sampling = 1;
1388
1389 while (!kthread_should_stop()) {
1390 now = ktime_to_ns(hrtimer_cb_get_time(&tlat->timer));
1391 diff = now - tlat->abs_period;
1392

  1393                  s.seqnum = tlat->count;
  1394                  s.timer_latency = diff;
  1395                  s.context = THREAD_CONTEXT;
  1396  
  1397                  trace_timerlat_sample(&s);
  1398  
  1399  #ifdef CONFIG_STACKTRACE
  1400          if (osnoise_data.print_stack)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This should be indented another tab?

  1401                  if (osnoise_data.print_stack <= time_to_us(diff))
  1402                          timerlat_dump_stack();
  1403  #endif /* CONFIG_STACKTRACE */
  1404  
  1405                  tlat->tracing_thread = false;
  1406                  if (osnoise_data.stop_tracing_total)
  1407                          if (time_to_us(diff) >= osnoise_data.stop_tracing_total)
  1408                                  osnoise_stop_tracing();
  1409  
  1410                  wait_next_period(tlat);
  1411          }
  1412  
  1413          hrtimer_cancel(&tlat->timer);
  1414          return 0;
  1415  }

regards,
dan carpenter