Skip to contentSkip to conversation

remoteproc: export rproc re/unregister to virtio device APIs

PATCH In review Phil Chang 2 participants 2 messages Jun 29, 2021

Subsystems (2)
lore
Share & tools
lore

Phil Chang

author
#0 lore raw

PATCH 1/1 remoteproc: export rproc re/unregister to virtio device APIs

In some case, the remote processor already boot up on previous state, but still need register to virtio device, so that exported those APIs.

---
Hi

In our case, the remote processor is already boot up in u-boot, we don't want to boot again or load fw in driver but register to virtio device for rpmsg. so that needs those API exported. Furthermore, the rproc_vq_interrupt is exported, so those functions should be exported also.

thanks

 drivers/remoteproc/remoteproc_virtio.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/remoteproc/remoteproc_virtio.c +2 -0
index 0cc617f76068..e23658a76f5e 100644
@@ -425,6 +425,7 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
 out:
 	return ret;
 }
+EXPORT_SYMBOL(rproc_add_virtio_dev);
 
 /**
  * rproc_remove_virtio_dev() - remove an rproc-induced virtio device
@@ -440,3 +441,4 @@ int rproc_remove_virtio_dev(struct device *dev, void *data)
 	unregister_virtio_device(vdev);
 	return 0;
 }
+EXPORT_SYMBOL(rproc_remove_virtio_dev);
Signature · 1 line
2.18.0
#1 lore raw
Quoted 5 lines · Phil Chang

In some case, the remote processor already boot up on previous state, but still need register to virtio device, so that exported those APIs.

Quoted 9 lines

---
Hi

In our case, the remote processor is already boot up in u-boot, we don't want to boot again or load fw in driver but register to virtio device for rpmsg. so that needs those API exported. Furthermore, the rproc_vq_interrupt is exported, so those functions should be exported also.

Would the recently introduces support in remoteproc for "attaching" to an already running remote processor be useful to you?

If you don't need a remoteproc driver, but rather just want e.g. a platform_driver that spawns the appropriate virtio devices, wouldn't virtio_mmio work?

Regards,
Bjorn

Quoted 25 lines

thanks

 drivers/remoteproc/remoteproc_virtio.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/remoteproc/remoteproc_virtio.c +2 -0
index 0cc617f76068..e23658a76f5e 100644
@@ -425,6 +425,7 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
 out:
 	return ret;
 }
+EXPORT_SYMBOL(rproc_add_virtio_dev);
 
 /**
  * rproc_remove_virtio_dev() - remove an rproc-induced virtio device
@@ -440,3 +441,4 @@ int rproc_remove_virtio_dev(struct device *dev, void *data)
 	unregister_virtio_device(vdev);
 	return 0;
 }
+EXPORT_SYMBOL(rproc_remove_virtio_dev);
Signature · 1 line
2.18.0