Skip to contentSkip to conversation

package/nfs-utils: enable nfsv4/nfsv4.1 support

PATCH Superseded James Hilliard 3 participants 11 messages Jul 13, 2021 – Jul 15, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

---
 package/nfs-utils/Config.in    | 10 ++++++++++
 package/nfs-utils/nfs-utils.mk |  9 +++++++--
 2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +10 -0
index da563db0f1..b736f6c973 100644
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 
 if BR2_PACKAGE_NFS_UTILS
 
+config BR2_PACKAGE_NFS_UTILS_NFSV4
+	bool "NFSv4/NFSv4.1"
+	depends on !BR2_STATIC_LIBS # keyutils, lvm2
+	select BR2_PACKAGE_KEYUTILS
+	select BR2_PACKAGE_LIBEVENT
+	select BR2_PACKAGE_LVM2
+	select BR2_PACKAGE_SQLITE
+	help
+	  Enable NFSv4/NFSv4.1 support
+
 config BR2_PACKAGE_NFS_UTILS_RPCDEBUG
 	bool "rpcdebug"
 	help
package/nfs-utils/nfs-utils.mk +7 -2
index c384e939d8..2598f0908b 100644
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES
 NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no
 
 NFS_UTILS_CONF_OPTS = \
-	--disable-nfsv4 \
-	--disable-nfsv41 \
 	--disable-gss \
 	--disable-uuid \
 	--enable-tirpc \
@@ -46,6 +44,13 @@ NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_NFSD) += usr/sbin/exportfs \
 	usr/sbin/rpc.mountd usr/sbin/rpc.nfsd usr/lib/systemd/system/nfs-server.service
 
+ifeq ($(BR2_PACKAGE_NFS_UTILS_NFSV4),y)
+NFS_UTILS_CONF_OPTS += --enable-nfsv4 --enable-nfsv41
+NFS_UTILS_DEPENDENCIES += keyutils libevent lvm2 sqlite
+else
+NFS_UTILS_CONF_OPTS += --disable-nfsv4 --disable-nfsv41
+endif
+
 ifeq ($(BR2_PACKAGE_LIBCAP),y)
 NFS_UTILS_CONF_OPTS += --enable-caps
 NFS_UTILS_DEPENDENCIES += libcap
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

Hello James,

Quoted 37 lines

Il giorno 13 lug 2021, alle ore 05:14, James Hilliard <[email protected]> ha scritto:

?Signed-off-by: James Hilliard <[email protected]>
---
package/nfs-utils/Config.in | 10 ++++++++++
package/nfs-utils/nfs-utils.mk | 9 +++++++--

2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +0 -0
index da563db0f1..b736f6c973 100644
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 

if BR2_PACKAGE_NFS_UTILS

package/nfs-utils/Config.in +10 -0
+config BR2_PACKAGE_NFS_UTILS_NFSV4
+    bool "NFSv4/NFSv4.1"
+    depends on !BR2_STATIC_LIBS # keyutils, lvm2
+    select BR2_PACKAGE_KEYUTILS
+    select BR2_PACKAGE_LIBEVENT
+    select BR2_PACKAGE_LVM2
+    select BR2_PACKAGE_SQLITE
+    help
+      Enable NFSv4/NFSv4.1 support
+

config BR2_PACKAGE_NFS_UTILS_RPCDEBUG
bool "rpcdebug"
help

package/nfs-utils/nfs-utils.mk +0 -0
index c384e939d8..2598f0908b 100644
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES

NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no

NFS_UTILS_CONF_OPTS = \

package/nfs-utils/nfs-utils.mk NFS_UTILS_AUTORECONF = YES · line 20

Quoted 2 lines
package/nfs-utils/nfs-utils.mk +0 -2
-    --disable-nfsv4 \
-    --disable-nfsv41 \

Is this ^^^ what prevents uuid.h build error?

Giulio

Quoted 20 lines
   --disable-gss \
   --disable-uuid \
   --enable-tirpc \
package/nfs-utils/nfs-utils.mk +7 -0
@@ -46,6 +44,13 @@ NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_NFSD) += usr/sbin/exportfs \
   usr/sbin/rpc.mountd usr/sbin/rpc.nfsd usr/lib/systemd/system/nfs-server.service
 
+ifeq ($(BR2_PACKAGE_NFS_UTILS_NFSV4),y)
+NFS_UTILS_CONF_OPTS += --enable-nfsv4 --enable-nfsv41
+NFS_UTILS_DEPENDENCIES += keyutils libevent lvm2 sqlite
+else
+NFS_UTILS_CONF_OPTS += --disable-nfsv4 --disable-nfsv41
+endif
+
 ifeq ($(BR2_PACKAGE_LIBCAP),y)

NFS_UTILS_CONF_OPTS += --enable-caps
NFS_UTILS_DEPENDENCIES += libcap

Signature · 1 line
2.25.1
#2 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

Quoted 39 lines · Giulio Benetti

Hello James,

Quoted 36 lines

Il giorno 13 lug 2021, alle ore 05:14, James Hilliard <[email protected]> ha scritto:

?Signed-off-by: James Hilliard <[email protected]>
---
package/nfs-utils/Config.in | 10 ++++++++++
package/nfs-utils/nfs-utils.mk | 9 +++++++--

2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +0 -0
index da563db0f1..b736f6c973 100644
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 

if BR2_PACKAGE_NFS_UTILS

package/nfs-utils/Config.in +10 -0
+config BR2_PACKAGE_NFS_UTILS_NFSV4
+    bool "NFSv4/NFSv4.1"
+    depends on !BR2_STATIC_LIBS # keyutils, lvm2
+    select BR2_PACKAGE_KEYUTILS
+    select BR2_PACKAGE_LIBEVENT
+    select BR2_PACKAGE_LVM2
+    select BR2_PACKAGE_SQLITE
+    help
+      Enable NFSv4/NFSv4.1 support
+

config BR2_PACKAGE_NFS_UTILS_RPCDEBUG
bool "rpcdebug"
help

package/nfs-utils/nfs-utils.mk +0 -0
index c384e939d8..2598f0908b 100644
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES

NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no

Quoted 5 lines

package/nfs-utils/nfs-utils.mk NFS_UTILS_AUTORECONF = YES · line 20

Quoted 3 lines

NFS_UTILS_CONF_OPTS = \

package/nfs-utils/nfs-utils.mk +0 -2
-    --disable-nfsv4 \
-    --disable-nfsv41 \

Is this ^^^ what prevents uuid.h build error?

No idea, have some background on that issue?

Quoted 24 lines

Giulio

Quoted 20 lines
   --disable-gss \
   --disable-uuid \
   --enable-tirpc \
package/nfs-utils/nfs-utils.mk +7 -0
@@ -46,6 +44,13 @@ NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_NFSD) += usr/sbin/exportfs \
   usr/sbin/rpc.mountd usr/sbin/rpc.nfsd usr/lib/systemd/system/nfs-server.service
 
+ifeq ($(BR2_PACKAGE_NFS_UTILS_NFSV4),y)
+NFS_UTILS_CONF_OPTS += --enable-nfsv4 --enable-nfsv41
+NFS_UTILS_DEPENDENCIES += keyutils libevent lvm2 sqlite
+else
+NFS_UTILS_CONF_OPTS += --disable-nfsv4 --disable-nfsv41
+endif
+
 ifeq ($(BR2_PACKAGE_LIBCAP),y)

NFS_UTILS_CONF_OPTS += --enable-caps
NFS_UTILS_DEPENDENCIES += libcap
--
2.25.1

#3 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

Quoted 44 lines

Il giorno 13 lug 2021, alle ore 10:19, James Hilliard <[email protected]> ha scritto:

?On Tue, Jul 13, 2021 at 2:03 AM Giulio Benetti

Quoted 39 lines · <[email protected]> wrote:

Hello James,

Quoted 36 lines
Quoted 1 line

Il giorno 13 lug 2021, alle ore 05:14, James Hilliard <[email protected]> ha scritto:

?Signed-off-by: James Hilliard <[email protected]>
---
package/nfs-utils/Config.in | 10 ++++++++++
package/nfs-utils/nfs-utils.mk | 9 +++++++--

2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +0 -0
index da563db0f1..b736f6c973 100644
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 

if BR2_PACKAGE_NFS_UTILS

package/nfs-utils/Config.in +10 -0
+config BR2_PACKAGE_NFS_UTILS_NFSV4
+    bool "NFSv4/NFSv4.1"
+    depends on !BR2_STATIC_LIBS # keyutils, lvm2
+    select BR2_PACKAGE_KEYUTILS
+    select BR2_PACKAGE_LIBEVENT
+    select BR2_PACKAGE_LVM2
+    select BR2_PACKAGE_SQLITE
+    help
+      Enable NFSv4/NFSv4.1 support
+

config BR2_PACKAGE_NFS_UTILS_RPCDEBUG
bool "rpcdebug"
help

package/nfs-utils/nfs-utils.mk +0 -0
index c384e939d8..2598f0908b 100644
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES

NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no

Quoted 7 lines
Quoted 5 lines

package/nfs-utils/nfs-utils.mk NFS_UTILS_AUTORECONF = YES · line 20

Quoted 3 lines

NFS_UTILS_CONF_OPTS = \

package/nfs-utils/nfs-utils.mk +0 -2
-    --disable-nfsv4 \
-    --disable-nfsv41 \

Is this ^^^ what prevents uuid.h build error?

No idea, have some background on that issue?

Yes, I had that issue on this commit:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blobdiff;f=support/export/v4root.c;h=c12a7d8562b22616fbc7840faf6719443dac64d3;hp=3654bd7c10c059d6a6ae32001ca979d671ef38f2;hb=c5528f40f9db5061e06dcf1f9b7fce5185b376c6;hpb=ed83085ff310fdc95badb06a26289efb70f99ccd

But it seems that ?disable-nfsv4 avoid building it, so we should have no problem.

Can you double check building with nfsv4 support and find it failing wi uuid.h? I don?t have time at the moment.

Thanks a lot

Giulio

Quoted 11 lines
Quoted 11 lines

Giulio

Quoted 7 lines
  --disable-gss \
  --disable-uuid \
  --enable-tirpc \
package/nfs-utils/nfs-utils.mk +0 -0
@@ -46,6 +44,13 @@ NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_NFSD) += usr/sbin/exportfs \
  usr/sbin/rpc.mountd usr/sbin/rpc.nfsd usr/lib/systemd/system/nfs-server.service
 
Quoted 14 lines
Quoted 5 lines
Quoted 5 lines
package/nfs-utils/nfs-utils.mk +5 -0
+ifeq ($(BR2_PACKAGE_NFS_UTILS_NFSV4),y)
+NFS_UTILS_CONF_OPTS += --enable-nfsv4 --enable-nfsv41
+NFS_UTILS_DEPENDENCIES += keyutils libevent lvm2 sqlite
+else
+NFS_UTILS_CONF_OPTS += --disable-nfsv4 --disable-nfsv41
Quoted 9 lines
Quoted 8 lines
package/nfs-utils/nfs-utils.mk +2 -0
+endif
+
 ifeq ($(BR2_PACKAGE_LIBCAP),y)

NFS_UTILS_CONF_OPTS += --enable-caps
NFS_UTILS_DEPENDENCIES += libcap
--
2.25.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210713/a7baad5d/attachment.html>

#4 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

Hi Giulio, all,

[Cc Thomas, Peter ]

Quoted 49 lines
Quoted 48 lines

Il giorno 13 lug 2021, alle ore 10:19, James Hilliard <[email protected]> ha scritto:

?On Tue, Jul 13, 2021 at 2:03 AM Giulio Benetti

Quoted 43 lines · <[email protected]> wrote:

Hello James,

Quoted 37 lines
Quoted 1 line

Il giorno 13 lug 2021, alle ore 05:14, James Hilliard <[email protected]> ha scritto:

?Signed-off-by: James Hilliard <[email protected]>
---
package/nfs-utils/Config.in | 10 ++++++++++
package/nfs-utils/nfs-utils.mk | 9 +++++++--

2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +0 -0
index da563db0f1..b736f6c973 100644
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 

if BR2_PACKAGE_NFS_UTILS

package/nfs-utils/Config.in +10 -0
+config BR2_PACKAGE_NFS_UTILS_NFSV4
+    bool "NFSv4/NFSv4.1"
+    depends on !BR2_STATIC_LIBS # keyutils, lvm2
+    select BR2_PACKAGE_KEYUTILS
+    select BR2_PACKAGE_LIBEVENT
+    select BR2_PACKAGE_LVM2
+    select BR2_PACKAGE_SQLITE
+    help
+      Enable NFSv4/NFSv4.1 support
+

config BR2_PACKAGE_NFS_UTILS_RPCDEBUG
bool "rpcdebug"
help

package/nfs-utils/nfs-utils.mk +0 -0
index c384e939d8..2598f0908b 100644
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES

NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no

NFS_UTILS_CONF_OPTS = \

package/nfs-utils/nfs-utils.mk NFS_UTILS_AUTORECONF = YES · line 20

Quoted 2 lines
package/nfs-utils/nfs-utils.mk +0 -2
-    --disable-nfsv4 \
-    --disable-nfsv41 \

Is this ^^^ what prevents uuid.h build error?

Quoted 8 lines
Quoted 1 line

No idea, have some background on that issue?

Yes, I had that issue on this commit:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blobdiff;f=support/export/v4root.c;h=c12a7d8562b22616fbc7840faf6719443dac64d3;hp=3654bd7c10c059d6a6ae32001ca979d671ef38f2;hb=c5528f40f9db5061e06dcf1f9b7fce5185b376c6;hpb=ed83085ff310fdc95badb06a26289efb70f99ccd

But it seems that ?disable-nfsv4 avoid building it, so we should have no problem.

Can you be more specific how c5528f40 ("Fix NFSv4 export of tmpfs filesystems") affects Buildroot? Is it a problem with -luuid

Anyway, we disabled nfsv4/nfsv4.1 from the start, I wonder why. @Thomas, @Peter: do you remember it?

But generally good idea, thus:

Quoted 1 line

Can you double check building with nfsv4 support and find it failing wi uuid.h? I don?t have time at the moment.

I'll try to test it this week.

Kind regards,
Petr

Quoted 3 lines

Thanks a lot

Giulio

#5 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

Hi Petr, James, All,

Quoted 59 lines

Il giorno 13 lug 2021, alle ore 23:51, Petr Vorel <[email protected]> ha scritto:

?Hi Giulio, all,

[Cc Thomas, Peter ]

Quoted 52 lines
Quoted 43 lines
Quoted 3 lines

Il giorno 13 lug 2021, alle ore 10:19, James Hilliard <[email protected]> ha scritto:

?On Tue, Jul 13, 2021 at 2:03 AM Giulio Benetti

Quoted 37 lines · <[email protected]> wrote:

Hello James,

Quoted 35 lines
Quoted 1 line

Il giorno 13 lug 2021, alle ore 05:14, James Hilliard <[email protected]> ha scritto:

?Signed-off-by: James Hilliard <[email protected]>
---
package/nfs-utils/Config.in | 10 ++++++++++
package/nfs-utils/nfs-utils.mk | 9 +++++++--

2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +0 -0
index da563db0f1..b736f6c973 100644
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 

if BR2_PACKAGE_NFS_UTILS

package/nfs-utils/Config.in +10 -0
+config BR2_PACKAGE_NFS_UTILS_NFSV4
+    bool "NFSv4/NFSv4.1"
+    depends on !BR2_STATIC_LIBS # keyutils, lvm2
+    select BR2_PACKAGE_KEYUTILS
+    select BR2_PACKAGE_LIBEVENT
+    select BR2_PACKAGE_LVM2
+    select BR2_PACKAGE_SQLITE
+    help
+      Enable NFSv4/NFSv4.1 support
+

config BR2_PACKAGE_NFS_UTILS_RPCDEBUG
bool "rpcdebug"
help

package/nfs-utils/nfs-utils.mk +0 -0
index c384e939d8..2598f0908b 100644
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES

NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no

Quoted 7 lines
Quoted 5 lines

package/nfs-utils/nfs-utils.mk NFS_UTILS_AUTORECONF = YES · line 20

Quoted 3 lines

NFS_UTILS_CONF_OPTS = \

package/nfs-utils/nfs-utils.mk +0 -2
-    --disable-nfsv4 \
-    --disable-nfsv41 \

Is this ^^^ what prevents uuid.h build error?

No idea, have some background on that issue?

Yes, I had that issue on this commit:

Quoted 7 lines
Quoted 4 lines

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blobdiff;f=support/export/v4root.c;h=c12a7d8562b22616fbc7840faf6719443dac64d3;hp=3654bd7c10c059d6a6ae32001ca979d671ef38f2;hb=c5528f40f9db5061e06dcf1f9b7fce5185b376c6;hpb=ed83085ff310fdc95badb06a26289efb70f99ccd

But it seems that ?disable-nfsv4 avoid building it, so we should have no problem.

Can you be more specific how c5528f40 ("Fix NFSv4 export of tmpfs filesystems") affects Buildroot? Is it a problem with -luuid

Yes, in nfs-utils ?disable-uuid options doesn?t take into account v4nfs that from that commit on uses uuid. It only prevents bulding libblkid support that they still declare buggy here:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/

Quoted 2 lines

Anyway, we disabled nfsv4/nfsv4.1 from the start, I wonder why.

As I see from James patch, he disables nfsv4 that is the part where uuid is required.
That is why it builds fine without uuid. If we want nfsv4 we need uuid, but then nfs-utile must be patched to make things more clear, but substituting ?disable-uuid with ?disable-libblkid and using ?disable-uuid to remove the above commit code from building.

Anyway what is supplied by James builds then, I didn?t try but it makes sense. So it depends if someone wants to create patches to send upstream like I?ve described(if it makes sense for you all of course.

Best regards
Giulio

Quoted 12 lines

@Thomas, @Peter: do you remember it?

But generally good idea, thus:

Quoted 1 line

Can you double check building with nfsv4 support and find it failing wi uuid.h? I don?t have time at the moment.

I'll try to test it this week.

Kind regards,
Petr

Quoted 7 lines
Quoted 3 lines

Thanks a lot

Giulio

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210715/92c00aaf/attachment-0002.html>

#6 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

Quoted 69 lines

Il giorno 15 lug 2021, alle ore 03:37, Giulio Benetti <[email protected]> ha scritto:

?Hi Petr, James, All,

Quoted 64 lines
Quoted 2 lines

Il giorno 13 lug 2021, alle ore 23:51, Petr Vorel <[email protected]> ha scritto:

?Hi Giulio, all,

[Cc Thomas, Peter ]

Quoted 57 lines
Quoted 43 lines

Il giorno 13 lug 2021, alle ore 10:19, James Hilliard <[email protected]> ha scritto:

?On Tue, Jul 13, 2021 at 2:03 AM Giulio Benetti

Quoted 37 lines · <[email protected]> wrote:

Hello James,

Quoted 35 lines
Quoted 1 line

Il giorno 13 lug 2021, alle ore 05:14, James Hilliard <[email protected]> ha scritto:

?Signed-off-by: James Hilliard <[email protected]>
---
package/nfs-utils/Config.in | 10 ++++++++++
package/nfs-utils/nfs-utils.mk | 9 +++++++--

2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +0 -0
index da563db0f1..b736f6c973 100644
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 

if BR2_PACKAGE_NFS_UTILS

package/nfs-utils/Config.in +10 -0
+config BR2_PACKAGE_NFS_UTILS_NFSV4
+    bool "NFSv4/NFSv4.1"
+    depends on !BR2_STATIC_LIBS # keyutils, lvm2
+    select BR2_PACKAGE_KEYUTILS
+    select BR2_PACKAGE_LIBEVENT
+    select BR2_PACKAGE_LVM2
+    select BR2_PACKAGE_SQLITE
+    help
+      Enable NFSv4/NFSv4.1 support
+

config BR2_PACKAGE_NFS_UTILS_RPCDEBUG
bool "rpcdebug"
help

package/nfs-utils/nfs-utils.mk +0 -0
index c384e939d8..2598f0908b 100644
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES

NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no

Quoted 7 lines
Quoted 5 lines

package/nfs-utils/nfs-utils.mk NFS_UTILS_AUTORECONF = YES · line 20

Quoted 3 lines

NFS_UTILS_CONF_OPTS = \

package/nfs-utils/nfs-utils.mk +0 -2
-    --disable-nfsv4 \
-    --disable-nfsv41 \

Is this ^^^ what prevents uuid.h build error?

No idea, have some background on that issue?

Yes, I had that issue on this commit:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blobdiff;f=support/export/v4root.c;h=c12a7d8562b22616fbc7840faf6719443dac64d3;hp=3654bd7c10c059d6a6ae32001ca979d671ef38f2;hb=c5528f40f9db5061e06dcf1f9b7fce5185b376c6;hpb=ed83085ff310fdc95badb06a26289efb70f99ccd

But it seems that ?disable-nfsv4 avoid building it, so we should have no problem.

Quoted 7 lines
Quoted 2 lines

Can you be more specific how c5528f40 ("Fix NFSv4 export of tmpfs filesystems") affects Buildroot? Is it a problem with -luuid

Yes, in nfs-utils ?disable-uuid options doesn?t take into account v4nfs that from that commit on uses uuid. It only prevents bulding libblkid support that they still declare buggy here:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/

Sorry wrong link, this is the right one:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=configure.ac;h=93520a8052bcbc2a4f57090f89f606d8aa76c801;hb=HEAD#l169

Quoted 4 lines
Quoted 3 lines

Anyway, we disabled nfsv4/nfsv4.1 from the start, I wonder why.

Quoted 28 lines

As I see from James patch, he disables nfsv4 that is the part where uuid is required.
That is why it builds fine without uuid. If we want nfsv4 we need uuid, but then nfs-utile must be patched to make things more clear, but substituting ?disable-uuid with ?disable-libblkid and using ?disable-uuid to remove the above commit code from building.

Anyway what is supplied by James builds then, I didn?t try but it makes sense. So it depends if someone wants to create patches to send upstream like I?ve described(if it makes sense for you all of course.

Best regards
Giulio

Quoted 19 lines

@Thomas, @Peter: do you remember it?

But generally good idea, thus:

Quoted 1 line

Can you double check building with nfsv4 support and find it failing wi uuid.h? I don?t have time at the moment.

I'll try to test it this week.

Kind regards,
Petr

Quoted 3 lines

Thanks a lot

Giulio

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210715/5be90102/attachment-0001.html>

#7 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

Quoted 121 lines · Giulio Benetti

Il giorno 15 lug 2021, alle ore 03:37, Giulio Benetti <[email protected]> ha scritto:

?Hi Petr, James, All,

Il giorno 13 lug 2021, alle ore 23:51, Petr Vorel <[email protected]> ha scritto:

?Hi Giulio, all,

[Cc Thomas, Peter ]

Il giorno 13 lug 2021, alle ore 10:19, James Hilliard <[email protected]> ha scritto:

?On Tue, Jul 13, 2021 at 2:03 AM Giulio Benetti

<[email protected]> wrote:

Hello James,

Il giorno 13 lug 2021, alle ore 05:14, James Hilliard <[email protected]> ha scritto:

?Signed-off-by: James Hilliard <[email protected]>

---

package/nfs-utils/Config.in | 10 ++++++++++

package/nfs-utils/nfs-utils.mk | 9 +++++++--

2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +0 -0

index da563db0f1..b736f6c973 100644

--- a/package/nfs-utils/Config.in

+++ b/package/nfs-utils/Config.in

package/nfs-utils/Config.in +0 -0
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 
 

if BR2_PACKAGE_NFS_UTILS

package/nfs-utils/Config.in +10 -0
+config BR2_PACKAGE_NFS_UTILS_NFSV4
 
+    bool "NFSv4/NFSv4.1"
 
+    depends on !BR2_STATIC_LIBS # keyutils, lvm2
 
+    select BR2_PACKAGE_KEYUTILS
 
+    select BR2_PACKAGE_LIBEVENT
 
+    select BR2_PACKAGE_LVM2
 
+    select BR2_PACKAGE_SQLITE
 
+    help
 
+      Enable NFSv4/NFSv4.1 support
 
+

config BR2_PACKAGE_NFS_UTILS_RPCDEBUG

bool "rpcdebug"

help

package/nfs-utils/nfs-utils.mk +0 -0

index c384e939d8..2598f0908b 100644

--- a/package/nfs-utils/nfs-utils.mk

+++ b/package/nfs-utils/nfs-utils.mk

package/nfs-utils/nfs-utils.mk +0 -0
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES
 

NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no

NFS_UTILS_CONF_OPTS = \

package/nfs-utils/nfs-utils.mk +0 -2
-    --disable-nfsv4 \
 
-    --disable-nfsv41 \

Is this ^^^ what prevents uuid.h build error?

No idea, have some background on that issue?

Yes, I had that issue on this commit:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blobdiff;f=support/export/v4root.c;h=c12a7d8562b22616fbc7840faf6719443dac64d3;hp=3654bd7c10c059d6a6ae32001ca979d671ef38f2;hb=c5528f40f9db5061e06dcf1f9b7fce5185b376c6;hpb=ed83085ff310fdc95badb06a26289efb70f99ccd

But it seems that ?disable-nfsv4 avoid building it,

so we should have no problem.

Can you be more specific how c5528f40 ("Fix NFSv4 export of tmpfs filesystems") affects Buildroot? Is it a problem with -luuid

Yes, in nfs-utils ?disable-uuid options doesn?t take into account v4nfs that from that commit on uses uuid. It only prevents bulding libblkid support that they still declare buggy here:

Quoted 6 lines

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/

Sorry wrong link, this is the right one:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=configure.ac;h=93520a8052bcbc2a4f57090f89f606d8aa76c801;hb=HEAD#l169

But isn't our libblkid new enough to not have the bug? See the version check here:
http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=aclocal/libblkid.m4;h=10824e9f58f1ae5164945f6baf14c000ba7949fd;hb=0ffef5f9a448013bcc551407134db84796fd2a4e#l13

Quoted 37 lines

Anyway, we disabled nfsv4/nfsv4.1 from the start, I wonder why.

As I see from James patch, he disables nfsv4 that is the part where uuid is required.
That is why it builds fine without uuid. If we want nfsv4 we need uuid, but then nfs-utile must be patched to make things more clear, but substituting ?disable-uuid with ?disable-libblkid and using ?disable-uuid to remove the above commit code from building.

Anyway what is supplied by James builds then, I didn?t try but it makes sense. So it depends if someone wants to create patches to send upstream like I?ve described(if it makes sense for you all of course.

Best regards
Giulio

@Thomas, @Peter: do you remember it?

But generally good idea, thus:

Can you double check building with nfsv4 support and find it failing wi uuid.h? I don?t have time at the moment.

I'll try to test it this week.

Kind regards,
Petr

Thanks a lot

Giulio

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#8 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

Hi James,

Quoted 126 lines · James Hilliard
Quoted 124 lines · Giulio Benetti

Il giorno 15 lug 2021, alle ore 03:37, Giulio Benetti <[email protected]> ha scritto:

?Hi Petr, James, All,

Il giorno 13 lug 2021, alle ore 23:51, Petr Vorel <[email protected]> ha scritto:

?Hi Giulio, all,

[Cc Thomas, Peter ]

Il giorno 13 lug 2021, alle ore 10:19, James Hilliard <[email protected]> ha scritto:

?On Tue, Jul 13, 2021 at 2:03 AM Giulio Benetti

<[email protected]> wrote:

Hello James,

Il giorno 13 lug 2021, alle ore 05:14, James Hilliard <[email protected]> ha scritto:

?Signed-off-by: James Hilliard <[email protected]>

---

package/nfs-utils/Config.in | 10 ++++++++++

package/nfs-utils/nfs-utils.mk | 9 +++++++--

2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +0 -0

index da563db0f1..b736f6c973 100644

--- a/package/nfs-utils/Config.in

+++ b/package/nfs-utils/Config.in

package/nfs-utils/Config.in +0 -0
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 
 

if BR2_PACKAGE_NFS_UTILS

package/nfs-utils/Config.in +10 -0
+config BR2_PACKAGE_NFS_UTILS_NFSV4
 
+    bool "NFSv4/NFSv4.1"
 
+    depends on !BR2_STATIC_LIBS # keyutils, lvm2
 
+    select BR2_PACKAGE_KEYUTILS
 
+    select BR2_PACKAGE_LIBEVENT
 
+    select BR2_PACKAGE_LVM2
 
+    select BR2_PACKAGE_SQLITE
 
+    help
 
+      Enable NFSv4/NFSv4.1 support
 
+

config BR2_PACKAGE_NFS_UTILS_RPCDEBUG

bool "rpcdebug"

help

package/nfs-utils/nfs-utils.mk +0 -0

index c384e939d8..2598f0908b 100644

--- a/package/nfs-utils/nfs-utils.mk

+++ b/package/nfs-utils/nfs-utils.mk

package/nfs-utils/nfs-utils.mk +0 -0
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES
 

NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no

NFS_UTILS_CONF_OPTS = \

package/nfs-utils/nfs-utils.mk +0 -2
-    --disable-nfsv4 \
 
-    --disable-nfsv41 \

Is this ^^^ what prevents uuid.h build error?

No idea, have some background on that issue?

Yes, I had that issue on this commit:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blobdiff;f=support/export/v4root.c;h=c12a7d8562b22616fbc7840faf6719443dac64d3;hp=3654bd7c10c059d6a6ae32001ca979d671ef38f2;hb=c5528f40f9db5061e06dcf1f9b7fce5185b376c6;hpb=ed83085ff310fdc95badb06a26289efb70f99ccd

But it seems that ?disable-nfsv4 avoid building it,

so we should have no problem.

Can you be more specific how c5528f40 ("Fix NFSv4 export of tmpfs filesystems") affects Buildroot? Is it a problem with -luuid

Yes, in nfs-utils ?disable-uuid options doesn?t take into account v4nfs that from that commit on uses uuid. It only prevents bulding libblkid support that they still declare buggy here:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/

Quoted 8 lines
Quoted 3 lines

Sorry wrong link, this is the right one:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=configure.ac;h=93520a8052bcbc2a4f57090f89f606d8aa76c801;hb=HEAD#l169

But isn't our libblkid new enough to not have the bug? See the version check here:
http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=aclocal/libblkid.m4;h=10824e9f58f1ae5164945f6baf14c000ba7949fd;hb=0ffef5f9a448013bcc551407134db84796fd2a4e#l13

Aah, my bad, I've interpreted --disable-uuid bad, sorry. Yes, then what you're adding makes a lot of sense!

Thank you
Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
Quoted 42 lines
Quoted 31 lines

Anyway, we disabled nfsv4/nfsv4.1 from the start, I wonder why.

As I see from James patch, he disables nfsv4 that is the part where uuid is required.
That is why it builds fine without uuid. If we want nfsv4 we need uuid, but then nfs-utile must be patched to make things more clear, but substituting ?disable-uuid with ?disable-libblkid and using ?disable-uuid to remove the above commit code from building.

Anyway what is supplied by James builds then, I didn?t try but it makes sense. So it depends if someone wants to create patches to send upstream like I?ve described(if it makes sense for you all of course.

Best regards
Giulio

@Thomas, @Peter: do you remember it?

But generally good idea, thus:

Can you double check building with nfsv4 support and find it failing wi uuid.h? I don?t have time at the moment.

I'll try to test it this week.

Kind regards,
Petr

Thanks a lot

Quoted 6 lines

Giulio

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#9 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

In reply to Giulio Benetti
Quoted 91 lines · Giulio Benetti

Il giorno 13 lug 2021, alle ore 10:19, James Hilliard <[email protected]> ha scritto:

?On Tue, Jul 13, 2021 at 2:03 AM Giulio Benetti
<[email protected]> wrote:

Hello James,

Il giorno 13 lug 2021, alle ore 05:14, James Hilliard <[email protected]> ha scritto:

?Signed-off-by: James Hilliard <[email protected]>

---

package/nfs-utils/Config.in | 10 ++++++++++

package/nfs-utils/nfs-utils.mk | 9 +++++++--

2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +0 -0

index da563db0f1..b736f6c973 100644

--- a/package/nfs-utils/Config.in

+++ b/package/nfs-utils/Config.in

package/nfs-utils/Config.in +0 -0
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 
 

if BR2_PACKAGE_NFS_UTILS

package/nfs-utils/Config.in +10 -0
+config BR2_PACKAGE_NFS_UTILS_NFSV4
 
+    bool "NFSv4/NFSv4.1"
 
+    depends on !BR2_STATIC_LIBS # keyutils, lvm2
 
+    select BR2_PACKAGE_KEYUTILS
 
+    select BR2_PACKAGE_LIBEVENT
 
+    select BR2_PACKAGE_LVM2
 
+    select BR2_PACKAGE_SQLITE
 
+    help
 
+      Enable NFSv4/NFSv4.1 support
 
+

config BR2_PACKAGE_NFS_UTILS_RPCDEBUG

bool "rpcdebug"

help

package/nfs-utils/nfs-utils.mk +0 -0

index c384e939d8..2598f0908b 100644

--- a/package/nfs-utils/nfs-utils.mk

+++ b/package/nfs-utils/nfs-utils.mk

package/nfs-utils/nfs-utils.mk +0 -0
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES
 

NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no

NFS_UTILS_CONF_OPTS = \

package/nfs-utils/nfs-utils.mk +0 -2
-    --disable-nfsv4 \
 
-    --disable-nfsv41 \

Is this ^^^ what prevents uuid.h build error?

No idea, have some background on that issue?

Quoted 8 lines

Yes, I had that issue on this commit:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blobdiff;f=support/export/v4root.c;h=c12a7d8562b22616fbc7840faf6719443dac64d3;hp=3654bd7c10c059d6a6ae32001ca979d671ef38f2;hb=c5528f40f9db5061e06dcf1f9b7fce5185b376c6;hpb=ed83085ff310fdc95badb06a26289efb70f99ccd

But it seems that ?disable-nfsv4 avoid building it, so we should have no problem.

Can you double check building with nfsv4 support and find it failing wi uuid.h? I don?t have time at the moment.

I wasn't seeing a failure but I sent a patch enabling it when available here:
https://patchwork.ozlabs.org/project/buildroot/patch/20210714231702.850078-1-james.hilliard1 at gmail.com/

Quoted 49 lines

Thanks a lot

Giulio

Giulio

  --disable-gss \

  --disable-uuid \

  --enable-tirpc \
package/nfs-utils/nfs-utils.mk +7 -0
@@ -46,6 +44,13 @@ NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
 
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_NFSD) += usr/sbin/exportfs \
 
  usr/sbin/rpc.mountd usr/sbin/rpc.nfsd usr/lib/systemd/system/nfs-server.service
 
 
+ifeq ($(BR2_PACKAGE_NFS_UTILS_NFSV4),y)
 
+NFS_UTILS_CONF_OPTS += --enable-nfsv4 --enable-nfsv41
 
+NFS_UTILS_DEPENDENCIES += keyutils libevent lvm2 sqlite
 
+else
 
+NFS_UTILS_CONF_OPTS += --disable-nfsv4 --disable-nfsv41
 
+endif
 
+

ifeq ($(BR2_PACKAGE_LIBCAP),y)

NFS_UTILS_CONF_OPTS += --enable-caps

NFS_UTILS_DEPENDENCIES += libcap

--

2.25.1

#10 lore raw

PATCH 1/1 package/nfs-utils: enable nfsv4/nfsv4.1 support

Hi James,

Quoted 99 lines

Il giorno 15 lug 2021, alle ore 01:19, James Hilliard <[email protected]> ha scritto:

?On Tue, Jul 13, 2021 at 3:28 AM Giulio Benetti

Quoted 95 lines · <[email protected]> wrote:

Il giorno 13 lug 2021, alle ore 10:19, James Hilliard <[email protected]> ha scritto:

?On Tue, Jul 13, 2021 at 2:03 AM Giulio Benetti
<[email protected]> wrote:

Hello James,

Il giorno 13 lug 2021, alle ore 05:14, James Hilliard <[email protected]> ha scritto:

?Signed-off-by: James Hilliard <[email protected]>

---

package/nfs-utils/Config.in | 10 ++++++++++

package/nfs-utils/nfs-utils.mk | 9 +++++++--

2 files changed, 17 insertions(+), 2 deletions(-)
package/nfs-utils/Config.in +0 -0

index da563db0f1..b736f6c973 100644

--- a/package/nfs-utils/Config.in

+++ b/package/nfs-utils/Config.in

package/nfs-utils/Config.in +0 -0
@@ -14,6 +14,16 @@ config BR2_PACKAGE_NFS_UTILS
 
 

if BR2_PACKAGE_NFS_UTILS

package/nfs-utils/Config.in +10 -0
+config BR2_PACKAGE_NFS_UTILS_NFSV4
 
+    bool "NFSv4/NFSv4.1"
 
+    depends on !BR2_STATIC_LIBS # keyutils, lvm2
 
+    select BR2_PACKAGE_KEYUTILS
 
+    select BR2_PACKAGE_LIBEVENT
 
+    select BR2_PACKAGE_LVM2
 
+    select BR2_PACKAGE_SQLITE
 
+    help
 
+      Enable NFSv4/NFSv4.1 support
 
+

config BR2_PACKAGE_NFS_UTILS_RPCDEBUG

bool "rpcdebug"

help

package/nfs-utils/nfs-utils.mk +0 -0

index c384e939d8..2598f0908b 100644

--- a/package/nfs-utils/nfs-utils.mk

+++ b/package/nfs-utils/nfs-utils.mk

package/nfs-utils/nfs-utils.mk +0 -0
@@ -16,8 +16,6 @@ NFS_UTILS_AUTORECONF = YES
 

NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no

NFS_UTILS_CONF_OPTS = \

package/nfs-utils/nfs-utils.mk +0 -2
-    --disable-nfsv4 \
 
-    --disable-nfsv41 \

Is this ^^^ what prevents uuid.h build error?

No idea, have some background on that issue?

Yes, I had that issue on this commit:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blobdiff;f=support/export/v4root.c;h=c12a7d8562b22616fbc7840faf6719443dac64d3;hp=3654bd7c10c059d6a6ae32001ca979d671ef38f2;hb=c5528f40f9db5061e06dcf1f9b7fce5185b376c6;hpb=ed83085ff310fdc95badb06a26289efb70f99ccd

Quoted 7 lines
Quoted 4 lines

But it seems that ?disable-nfsv4 avoid building it, so we should have no problem.

Can you double check building with nfsv4 support and find it failing wi uuid.h? I don?t have time at the moment.

I wasn't seeing a failure but I sent a patch enabling it when available here:
https://patchwork.ozlabs.org/project/buildroot/patch/20210714231702.850078-1-james.hilliard1 at gmail.com/

This patch can work for building libblkid but nfs-utils still declare its support buggy here:

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=configure.ac;h=93520a8052bcbc2a4f57090f89f606d8aa76c801;hb=HEAD#l169

So maybe it?s better ask upstream about it.
Can you do it?

Thanks in advance
Giulio

Quoted 42 lines
Quoted 42 lines

Thanks a lot

Giulio

Giulio

--disable-gss \

--disable-uuid \

--enable-tirpc \

package/nfs-utils/nfs-utils.mk +7 -0
@@ -46,6 +44,13 @@ NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
 
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_NFSD) += usr/sbin/exportfs \
 
 usr/sbin/rpc.mountd usr/sbin/rpc.nfsd usr/lib/systemd/system/nfs-server.service
 
 
+ifeq ($(BR2_PACKAGE_NFS_UTILS_NFSV4),y)
 
+NFS_UTILS_CONF_OPTS += --enable-nfsv4 --enable-nfsv41
 
+NFS_UTILS_DEPENDENCIES += keyutils libevent lvm2 sqlite
 
+else
 
+NFS_UTILS_CONF_OPTS += --disable-nfsv4 --disable-nfsv41
 
+endif
 
+

ifeq ($(BR2_PACKAGE_LIBCAP),y)

NFS_UTILS_CONF_OPTS += --enable-caps

Quoted 8 lines
Quoted 8 lines

NFS_UTILS_DEPENDENCIES += libcap

--

2.25.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210715/79d37820/attachment-0002.html>