Skip to contentSkip to conversation

tools headers: Remove broken definition of __LITTLE_ENDIAN

PATCH New Arnaldo Carvalho de Melo 1 participant 1 message Jul 14, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools headers: Remove broken definition of __LITTLE_ENDIAN

FYI, added this to my local tree.

commit adfb906cb3ee7b941a5de71dbb72b6de1ee258db

Author: Arnaldo Carvalho de Melo <[email protected]>
Date:   Wed Jul 14 14:28:02 2021 -0300

tools headers: Remove broken definition of __LITTLE_ENDIAN

The linux/kconfig.h file was copied from the kernel but the line where with the generated/autoconf.h include from where the CONFIG_ entries would come from was deleted, as tools/ build system don't create that file, so we ended up always defining just __LITTLE_ENDIAN as CONFIG_CPU_BIG_ENDIAN was nowhere to be found.

This in turn ended up breaking the build in some systems where __LITTLE_ENDIAN was already defined, such as the androind NDK.

So just ditch that block that depends on the CONFIG_CPU_BIG_ENDIAN define.

The kconfig.h file was copied just to get IS_ENABLED() and a 'make -C tools/all' doesn't breaks with this removal.

Fixes 93281c4a96572a34 ("x86/insn: Add an insn_decode() API")
Cc Borislav Petkov <[email protected]>
tools/include/linux/kconfig.h +0 -6
index 1555a0c4f34514bf..13b86bd3b7461d27 100644
@@ -4,12 +4,6 @@
 
 /* CONFIG_CC_VERSION_TEXT (Do not delete this comment. See help in Kconfig) */
 
-#ifdef CONFIG_CPU_BIG_ENDIAN
-#define __BIG_ENDIAN 4321
-#else
-#define __LITTLE_ENDIAN 1234
-#endif
-
 #define __ARG_PLACEHOLDER_1 0,
 #define __take_second_arg(__ignored, val, ...) val