Skip to contentSkip to conversation

cc-can-link.sh: check for linking capability in a more robust way

PATCH In review Alexey Dobriyan 2 participants 3 messages Jul 3, 2021 – Jul 5, 2021 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cc-can-link.sh: check for linking capability in a more robust way

Compiling "printf("");" doesn't necessarily check for linking capability as printf can be optimised for constants strings even at -O0:

	0000000000401106 <main>:
	  401106:       push   rbp
	  401107:       mov    rbp,rsp
	  40110a:       mov    eax,0x0
	  40110f:       pop    rbp
	  401110:       ret

Pass something from the command line to disable optimisations:

	0000000000401126 <main>:
	  401126:       push   rbp
	  401127:       mov    rbp,rsp
	  40112a:       sub    rsp,0x10
	  40112e:       mov    DWORD PTR [rbp-0x4],edi
	  401131:       mov    QWORD PTR [rbp-0x10],rsi
	  401135:       mov    rax,QWORD PTR [rbp-0x10]
	  401139:       add    rax,0x8
	  40113d:       mov    rax,QWORD PTR [rax]
	  401140:       mov    rdi,rax
	  401143:       mov    eax,0x0
	  401148:  ***  call   401030 <printf@plt>
	  40114d:       mov    eax,0x0
	  401152:       leave
	  401153:       ret

---

 scripts/cc-can-link.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/cc-can-link.sh +2 -2
@@ -3,9 +3,9 @@
 
 cat << "END" | $@ -x c - -o /dev/null >/dev/null 2>&1
 #include <stdio.h>
-int main(void)
+int main(int argc, char *argv[])
 {
-	printf("");
+	printf(argv[1]);
 	return 0;
 }
 END
#1 lore raw
Quoted 39 lines · Alexey Dobriyan

Compiling "printf("");" doesn't necessarily check for linking capability as printf can be optimised for constants strings even at -O0:

        0000000000401106 <main>:
          401106:       push   rbp
          401107:       mov    rbp,rsp
          40110a:       mov    eax,0x0
          40110f:       pop    rbp
          401110:       ret

Pass something from the command line to disable optimisations:

        0000000000401126 <main>:
          401126:       push   rbp
          401127:       mov    rbp,rsp
          40112a:       sub    rsp,0x10
          40112e:       mov    DWORD PTR [rbp-0x4],edi
          401131:       mov    QWORD PTR [rbp-0x10],rsi
          401135:       mov    rax,QWORD PTR [rbp-0x10]
          401139:       add    rax,0x8
          40113d:       mov    rax,QWORD PTR [rax]
          401140:       mov    rdi,rax
          401143:       mov    eax,0x0
          401148:  ***  call   401030 <printf@plt>
          40114d:       mov    eax,0x0
          401152:       leave
          401153:       ret

---

 scripts/cc-can-link.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/cc-can-link.sh +0 -0
@@ -3,9 +3,9 @@
 

scripts/cc-can-link.sh line 11

Quoted 10 lines
scripts/cc-can-link.sh +2 -2
 cat << "END" | $@ -x c - -o /dev/null >/dev/null 2>&1
 #include <stdio.h>
-int main(void)
+int main(int argc, char *argv[])
 {
-       printf("");
+       printf(argv[1]);
        return 0;
 }
 END

Ah, right.

But, we should not merge a bad coding example.

argv[1] may contain '%' format string, and
recent GCC versions warn about it.

$ cat test.c
#include <stdio.h>

int main(int argc, char *argv[])

{
    printf(argv[1]);
    return 0;
}
$ gcc -c -o test.o  test.c
test.c: In function ‘main’:
test.c:5:5: warning: format not a string literal and no format
arguments [-Wformat-security]
    5 |     printf(argv[1]);
      |     ^~~~~~

I think replacing printf("") with printf("a")
(or any string you like)
is enough.

Signature · 2 lines
Best Regards
Masahiro Yamada
#2 lore raw
Quoted 75 lines · Masahiro Yamada
Quoted 39 lines · Alexey Dobriyan

Compiling "printf("");" doesn't necessarily check for linking capability as printf can be optimised for constants strings even at -O0:

        0000000000401106 <main>:
          401106:       push   rbp
          401107:       mov    rbp,rsp
          40110a:       mov    eax,0x0
          40110f:       pop    rbp
          401110:       ret

Pass something from the command line to disable optimisations:

        0000000000401126 <main>:
          401126:       push   rbp
          401127:       mov    rbp,rsp
          40112a:       sub    rsp,0x10
          40112e:       mov    DWORD PTR [rbp-0x4],edi
          401131:       mov    QWORD PTR [rbp-0x10],rsi
          401135:       mov    rax,QWORD PTR [rbp-0x10]
          401139:       add    rax,0x8
          40113d:       mov    rax,QWORD PTR [rax]
          401140:       mov    rdi,rax
          401143:       mov    eax,0x0
          401148:  ***  call   401030 <printf@plt>
          40114d:       mov    eax,0x0
          401152:       leave
          401153:       ret

---

 scripts/cc-can-link.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/cc-can-link.sh +0 -0
@@ -3,9 +3,9 @@
 

scripts/cc-can-link.sh line 11

Quoted 10 lines
scripts/cc-can-link.sh +2 -2
 cat << "END" | $@ -x c - -o /dev/null >/dev/null 2>&1
 #include <stdio.h>
-int main(void)
+int main(int argc, char *argv[])
 {
-       printf("");
+       printf(argv[1]);
        return 0;
 }
 END

Ah, right.

But, we should not merge a bad coding example.

argv[1] may contain '%' format string, and
recent GCC versions warn about it.

$ cat test.c
#include <stdio.h>

int main(int argc, char *argv[])

{
    printf(argv[1]);
    return 0;
}
$ gcc -c -o test.o  test.c
test.c: In function ‘main’:
test.c:5:5: warning: format not a string literal and no format
arguments [-Wformat-security]
    5 |     printf(argv[1]);
      |     ^~~~~~
Quoted 3 lines

I think replacing printf("") with printf("a")
(or any string you like)
is enough.

I get putchar() for "a". puts(argv[1]) works too.
I think argv[1] should be used to defeat optimisers, current and future.