drm/panel: simple: Add support for EDT ETMV570G2DHU panel
Subsystems (3)
PATCH v3 1/2 drm/panel: simple: Add support for EDT ETMV570G2DHU panel
From: Stefan Riedmueller <[email protected]>
This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel to DRM simple panel driver.
---
Changes in v3:
- No changes in general, added additional maintainers and also sending to general kernel mailing list
--- drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +29 -0
@@ -2008,6 +2008,32 @@ static const struct panel_desc edt_et057090dhu = { .connector_type = DRM_MODE_CONNECTOR_DPI, }; +static const struct drm_display_mode edt_etmv570g2dhu_mode = { + .clock =25175 , + .hdisplay =640 , + .hsync_start =640 , + .hsync_end =640 +16 , + .htotal =640 +16 +30 +114 , + .vdisplay =480 , + .vsync_start =480 +10 , + .vsync_end =480 +10 +3 , + .vtotal =480 +10 +3 +35 , + .flags =DRM_MODE_FLAG_PVSYNC |DRM_MODE_FLAG_PHSYNC , +}; + +static const struct panel_desc edt_etmv570g2dhu = { + .modes = &edt_etmv570g2dhu_mode, + .num_modes =1 , + .bpc =6 , + .size = { + .width =115 , + .height =86 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE , + .connector_type =DRM_MODE_CONNECTOR_DPI , +}; +static const struct drm_display_mode edt_etm0700g0dh6_mode = { .clock =33260 , .hdisplay =800 ,
@@ -4338,6 +4364,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et057090dhu", .data = &edt_et057090dhu, + }, { + .compatible = "edt,etmv570g2dhu", + .data = &edt_etmv570g2dhu, }, { .compatible = "edt,et070080dh6", .data = &edt_etm0700g0dh6,
Signature · 1 line
2.30.0
PATCH v3 2/2 drm/panel: simple: Add support for EDT ETM0350G0DH6 panel
From: Stefan Riedmueller <[email protected]>
This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver.
---
Changes in v3:
- No changes in general, added additional maintainers and also sending to general kernel mailing list
--- drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +29 -0
@@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = { .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE, }; +static const struct drm_display_mode edt_etm0350g0dh6_mode = { + .clock =6520 , + .hdisplay =320 , + .hsync_start =320 +20 , + .hsync_end =320 +20 +68 , + .htotal =320 +20 +68 , + .vdisplay =240 , + .vsync_start =240 +4 , + .vsync_end =240 +4 +18 , + .vtotal =240 +4 +18 , + .flags =DRM_MODE_FLAG_NVSYNC |DRM_MODE_FLAG_NHSYNC , +}; + +static const struct panel_desc edt_etm0350g0dh6 = { + .modes = &edt_etm0350g0dh6_mode, + .num_modes =1 , + .bpc =6 , + .size = { + .width =70 , + .height =53 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE , + .connector_type =DRM_MODE_CONNECTOR_DPI , +}; +static const struct drm_display_mode edt_etm043080dh6gp_mode = { .clock =10870 , .hdisplay =480 ,
@@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6, + }, { + .compatible = "edt,etm0350g0dh6", + .data = &edt_etm0350g0dh6, }, { .compatible = "edt,etm043080dh6gp", .data = &edt_etm043080dh6gp,
Signature · 1 line
2.30.0
Re: [PATCH v3 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel
Hi Yunus,
Quoted 53 lines · Yunus Bas
From: Stefan Riedmueller <[email protected]>
This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver.
Signed-off-by Stefan Riedmueller <[email protected]>Signed-off-by Yunus Bas <[email protected]>---
Changes in v3:
- No changes in general, added additional maintainers and also sending to general kernel mailing list--- drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)drivers/gpu/drm/panel/panel-simple.c +26
-0@@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = { .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE, }; +static const struct drm_display_mode edt_etm0350g0dh6_mode = { + .clock =6520 , + .hdisplay =320 , + .hsync_start =320 +20 , + .hsync_end =320 +20 +68 , + .htotal =320 +20 +68 , + .vdisplay =240 , + .vsync_start =240 +4 , + .vsync_end =240 +4 +18 , + .vtotal =240 +4 +18 , + .flags =DRM_MODE_FLAG_NVSYNC |DRM_MODE_FLAG_NHSYNC , +}; + +static const struct panel_desc edt_etm0350g0dh6 = { + .modes = &edt_etm0350g0dh6_mode, + .num_modes =1 , + .bpc =6 , + .size = { + .width =70 , + .height =53 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE , + .connector_type =DRM_MODE_CONNECTOR_DPI , +}; +static const struct drm_display_mode edt_etm043080dh6gp_mode = { .clock =10870 , .hdisplay =480 ,
drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id platform_of_match[] = { · line 4386
Quoted 6 lines
drivers/gpu/drm/panel/panel-simple.c +3
-0@@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6, + }, { + .compatible = "edt,etm0350g0dh6", + .data = &edt_etm0350g0dh6,
The compatible "edt,etm0350g0dh6" is not documented.
You likely need to add it to panel-simple.yaml - and likewise for the first patch.
dt people like binding patches in separate patches so add them both in one dedicated patch.
Sam
Re: [PATCH v3 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel
Hi Sam,
Am Freitag, dem 09.07.2021 um 20:12 +0200 schrieb Sam Ravnborg:
Quoted 74 lines
Hi Yunus,
Quoted 59 lines · Yunus Bas
From: Stefan Riedmueller <[email protected]>
This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver.
Signed-off-by Stefan Riedmueller <[email protected]>Signed-off-by Yunus Bas <[email protected]>---
Changes in v3:
- No changes in general, added additional maintainers and also sending
to general kernel mailing list
---
drivers/gpu/drm/panel/panel-simple.c | 29
++++++++++++++++++++++++++++1 file changed, 29 insertions(+)drivers/gpu/drm/panel/panel-simple.c +0
-0@@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = {.bus_flags =
DRM_BUS_FLAG_DE_LOW|DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE,
};drivers/gpu/drm/panel/panel-simple.c +23
-0+static const struct drm_display_mode edt_etm0350g0dh6_mode = { + .clock = 6520, + .hdisplay = 320, + .hsync_start = 320 + 20, + .hsync_end = 320 + 20 + 68, + .htotal = 320 + 20 + 68, + .vdisplay = 240, + .vsync_start = 240 + 4, + .vsync_end = 240 + 4 + 18, + .vtotal = 240 + 4 + 18, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc edt_etm0350g0dh6 = { + .modes = &edt_etm0350g0dh6_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 70, + .height = 53, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
+ .connector_type =DRM_MODE_CONNECTOR_DPI,drivers/gpu/drm/panel/panel-simple.c +2
-0+}; +static const struct
drm_display_modeedt_etm043080dh6gp_mode= { .clock = 10870,
.hdisplay = 480,drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 4387
Quoted 7 lines
drivers/gpu/drm/panel/panel-simple.c +3
-0@@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6, + }, { + .compatible = "edt,etm0350g0dh6", + .data = &edt_etm0350g0dh6,The compatible "edt,etm0350g0dh6" is not documented.
You likely need to add it topanel-simple.yaml- and likewise for the first patch.
Quoted 2 lines
dt people like binding patches in separate patches so add them both in one dedicated patch.
I've already sent devicetree patches. Here is the link:
https://lore.kernel.org/linux-devicetree/[email protected]/
It was just pending and waiting for these patches. Shall I send again?
Regards, Yunus
Quoted 2 lines
Sam
Signature · 22 lines
Mit freundlichen Grüßen Yunus Bas -Software Engineer- PHYTEC Messtechnik GmbH Robert-Koch-Str. 39 55129 Mainz Germany Tel.: +49 (0)6131 9221- 466 Web: www.phytec.de Sie finden uns auch auf: Facebook, LinkedIn, Xing, YouTube PHYTEC Messtechnik GmbH | Robert-Koch-Str. 39 | 55129 Mainz, Germany Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber | Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 266500608, DE 149059855 This E-Mail may contain confidential or privileged information. If you are not the intended recipient (or have received this E-Mail in error) please notify the sender immediately and destroy this E-Mail. Any unauthorized copying, disclosure or distribution of the material in this E-Mail is strictly forbidden.
Re: [PATCH v3 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel
Hi Yunus,
Quoted 77 lines · Yunus Bas
Hi Sam,
Am Freitag, dem 09.07.2021 um 20:12 +0200 schrieb Sam Ravnborg:
Quoted 74 lines
Hi Yunus,
Quoted 59 lines · Yunus Bas
From: Stefan Riedmueller <[email protected]>
This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver.
Signed-off-by Stefan Riedmueller <[email protected]>Signed-off-by Yunus Bas <[email protected]>---
Changes in v3:
- No changes in general, added additional maintainers and also sending
to general kernel mailing list
---
drivers/gpu/drm/panel/panel-simple.c | 29
++++++++++++++++++++++++++++1 file changed, 29 insertions(+)drivers/gpu/drm/panel/panel-simple.c +0
-0@@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = {.bus_flags =
DRM_BUS_FLAG_DE_LOW|DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE,
};drivers/gpu/drm/panel/panel-simple.c +23
-0+static const struct drm_display_mode edt_etm0350g0dh6_mode = { + .clock = 6520, + .hdisplay = 320, + .hsync_start = 320 + 20, + .hsync_end = 320 + 20 + 68, + .htotal = 320 + 20 + 68, + .vdisplay = 240, + .vsync_start = 240 + 4, + .vsync_end = 240 + 4 + 18, + .vtotal = 240 + 4 + 18, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc edt_etm0350g0dh6 = { + .modes = &edt_etm0350g0dh6_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 70, + .height = 53, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
+ .connector_type =DRM_MODE_CONNECTOR_DPI,drivers/gpu/drm/panel/panel-simple.c +2
-0+}; +static const struct
drm_display_modeedt_etm043080dh6gp_mode= { .clock = 10870,
.hdisplay = 480,drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 4387
Quoted 7 lines
drivers/gpu/drm/panel/panel-simple.c +3
-0@@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6, + }, { + .compatible = "edt,etm0350g0dh6", + .data = &edt_etm0350g0dh6,The compatible "edt,etm0350g0dh6" is not documented.
You likely need to add it topanel-simple.yaml- and likewise for the first patch.
Quoted 7 lines
Quoted 2 lines
dt people like binding patches in separate patches so add them both in one dedicated patch.
I've already sent devicetree patches. Here is the link:
https://lore.kernel.org/linux-devicetree/[email protected]/It was just pending and waiting for these patches. Shall I send again?
I have likely deleted the patches already, so please resend. Been mostly offline for a period and then one week wihtout access to my linux box, and have to delete a lot to avoid getting too much behind.
Sam
Re: [PATCH v3 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel
Am Freitag, dem 09.07.2021 um 21:30 +0200 schrieb Sam Ravnborg:
Quoted 91 lines
Hi Yunus,
Quoted 88 lines · Yunus Bas
Hi Sam,
Am Freitag, dem 09.07.2021 um 20:12 +0200 schrieb Sam Ravnborg:
Quoted 78 lines
Hi Yunus,
Quoted 62 lines · Yunus Bas
From: Stefan Riedmueller <[email protected]>
This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd
panel to DRM simple panel driver.Signed-off-by Stefan Riedmueller <[email protected]>Signed-off-by Yunus Bas <[email protected]>---
Changes in v3:
- No changes in general, added additional maintainers and also sending
to general kernel mailing list
---
drivers/gpu/drm/panel/panel-simple.c | 29
++++++++++++++++++++++++++++1 file changed, 29 insertions(+)drivers/gpu/drm/panel/panel-simple.c +0
-0@@ -1929,6 +1929,32 @@ static const struct panel_desc
edt_et035012dm6
= {
.bus_flags =DRM_BUS_FLAG_DE_LOW|DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE,
};drivers/gpu/drm/panel/panel-simple.c +23
-0+static const struct drm_display_mode edt_etm0350g0dh6_mode = { + .clock = 6520, + .hdisplay = 320, + .hsync_start = 320 + 20, + .hsync_end = 320 + 20 + 68, + .htotal = 320 + 20 + 68, + .vdisplay = 240, + .vsync_start = 240 + 4, + .vsync_end = 240 + 4 + 18, + .vtotal = 240 + 4 + 18, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc edt_etm0350g0dh6 = { + .modes = &edt_etm0350g0dh6_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 70, + .height = 53, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
+ .connector_type =DRM_MODE_CONNECTOR_DPI,drivers/gpu/drm/panel/panel-simple.c +2
-0+}; +static const struct
drm_display_modeedt_etm043080dh6gp_mode= {
.clock = 10870,
.hdisplay = 480,drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 4387
Quoted 7 lines
drivers/gpu/drm/panel/panel-simple.c +3
-0@@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6, + }, { + .compatible = "edt,etm0350g0dh6", + .data = &edt_etm0350g0dh6,The compatible "edt,etm0350g0dh6" is not documented. You likely need to add it to
panel-simple.yaml- and likewise for the
first patch.Quoted 3 lines
dt people like binding patches in separate patches so add them both in
one dedicated patch.I've already sent devicetree patches. Here is the link:
https://lore.kernel.org/linux-devicetree/[email protected]/
Quoted 6 lines
Quoted 2 lines
It was just pending and waiting for these patches. Shall I send again?
I have likely deleted the patches already, so please resend. Been mostly offline for a period and then one week wihtout access to my
linux box, and have to delete a lot to avoid getting too much behind.
No problem, I'll resend them ASAP.
Regards, Yunus
Quoted 2 lines
Sam
Signature · 22 lines
Mit freundlichen Grüßen Yunus Bas -Software Engineer- PHYTEC Messtechnik GmbH Robert-Koch-Str. 39 55129 Mainz Germany Tel.: +49 (0)6131 9221- 466 Web: www.phytec.de Sie finden uns auch auf: Facebook, LinkedIn, Xing, YouTube PHYTEC Messtechnik GmbH | Robert-Koch-Str. 39 | 55129 Mainz, Germany Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber | Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 266500608, DE 149059855 This E-Mail may contain confidential or privileged information. If you are not the intended recipient (or have received this E-Mail in error) please notify the sender immediately and destroy this E-Mail. Any unauthorized copying, disclosure or distribution of the material in this E-Mail is strictly forbidden.
Hi Yunus,
Quoted 53 lines · Yunus Bas
From: Stefan Riedmueller <[email protected]>
This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel to DRM simple panel driver.
Signed-off-by Stefan Riedmueller <[email protected]>Signed-off-by Yunus Bas <[email protected]>---
Changes in v3:
- No changes in general, added additional maintainers and also sending to general kernel mailing list--- drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)drivers/gpu/drm/panel/panel-simple.c +26
-0@@ -2008,6 +2008,32 @@ static const struct panel_desc edt_et057090dhu = { .connector_type = DRM_MODE_CONNECTOR_DPI, }; +static const struct drm_display_mode edt_etmv570g2dhu_mode = { + .clock =25175 , + .hdisplay =640 , + .hsync_start =640 , + .hsync_end =640 +16 , + .htotal =640 +16 +30 +114 , + .vdisplay =480 , + .vsync_start =480 +10 , + .vsync_end =480 +10 +3 , + .vtotal =480 +10 +3 +35 , + .flags =DRM_MODE_FLAG_PVSYNC |DRM_MODE_FLAG_PHSYNC , +}; + +static const struct panel_desc edt_etmv570g2dhu = { + .modes = &edt_etmv570g2dhu_mode, + .num_modes =1 , + .bpc =6 , + .size = { + .width =115 , + .height =86 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE , + .connector_type =DRM_MODE_CONNECTOR_DPI , +}; +static const struct drm_display_mode edt_etm0700g0dh6_mode = { .clock =33260 , .hdisplay =800 ,
drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id platform_of_match[] = { · line 4372
Quoted 9 lines
drivers/gpu/drm/panel/panel-simple.c +3
-0@@ -4338,6 +4364,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et057090dhu", .data = &edt_et057090dhu, + }, { + .compatible = "edt,etmv570g2dhu", + .data = &edt_etmv570g2dhu, }, { .compatible = "edt,et070080dh6", .data = &edt_etm0700g0dh6,
This list must be alphabetically sorted after compatible.
"edt,etmv570g2dhu" comes after "edt,et070080dh6"
The same order must be used where edt_etmv570g2dhu is defined. Sorry for this nit, but if we fails to follw it we will soon have chaos.
The rest looks good, everything needed is defined.
Sam
Hi Sam,
Am Freitag, dem 09.07.2021 um 20:08 +0200 schrieb Sam Ravnborg:
Quoted 75 lines
Hi Yunus,
Quoted 68 lines · Yunus Bas
From: Stefan Riedmueller <[email protected]>
This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel
to DRM simple panel driver.Signed-off-by Stefan Riedmueller <[email protected]>Signed-off-by Yunus Bas <[email protected]>---
Changes in v3:
- No changes in general, added additional maintainers and also sending
to general kernel mailing list
---
drivers/gpu/drm/panel/panel-simple.c | 29
++++++++++++++++++++++++++++1 file changed, 29 insertions(+)drivers/gpu/drm/panel/panel-simple.c +0
-0@@ -2008,6 +2008,32 @@ static const struct panel_desc edt_et057090dhu = { .connector_type = DRM_MODE_CONNECTOR_DPI, };drivers/gpu/drm/panel/panel-simple.c +23
-0+static const struct drm_display_mode edt_etmv570g2dhu_mode = { + .clock = 25175, + .hdisplay = 640, + .hsync_start = 640, + .hsync_end = 640 + 16, + .htotal = 640 + 16 + 30 + 114, + .vdisplay = 480, + .vsync_start = 480 + 10, + .vsync_end = 480 + 10 + 3, + .vtotal = 480 + 10 + 3 + 35, + .flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC, +}; + +static const struct panel_desc edt_etmv570g2dhu = { + .modes = &edt_etmv570g2dhu_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 115, + .height = 86, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
+ .connector_type =DRM_MODE_CONNECTOR_DPI,drivers/gpu/drm/panel/panel-simple.c +2
-0+}; +static const struct
drm_display_modeedt_etm0700g0dh6_mode= { .clock = 33260,
.hdisplay = 800,drivers/gpu/drm/panel/panel-simple.c +3
-0@@ -4338,6 +4364,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et057090dhu", .data = &edt_et057090dhu, + }, { + .compatible = "edt,etmv570g2dhu", + .data = &edt_etmv570g2dhu, }, { .compatible = "edt,et070080dh6",Quoted 1 line
.data =
&edt_etm0700g0dh6,This list must be alphabetically sorted after compatible.
Quoted 5 lines
"edt,etmv570g2dhu" comes after "edt,et070080dh6"
The same order must be used where
edt_etmv570g2dhuis defined. Sorry for this nit, but if we fails to follw it we will soon have chaos.
Of course, sorry for not noticing earlier. I will change this.
Regards, Yunus
Quoted 4 lines
The rest looks good, everything needed is defined.
Sam
Signature · 22 lines
Mit freundlichen Grüßen Yunus Bas -Software Engineer- PHYTEC Messtechnik GmbH Robert-Koch-Str. 39 55129 Mainz Germany Tel.: +49 (0)6131 9221- 466 Web: www.phytec.de Sie finden uns auch auf: Facebook, LinkedIn, Xing, YouTube PHYTEC Messtechnik GmbH | Robert-Koch-Str. 39 | 55129 Mainz, Germany Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber | Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 266500608, DE 149059855 This E-Mail may contain confidential or privileged information. If you are not the intended recipient (or have received this E-Mail in error) please notify the sender immediately and destroy this E-Mail. Any unauthorized copying, disclosure or distribution of the material in this E-Mail is strictly forbidden.