locking fixes
Linus,
Please pull the latest locking/urgent git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-2021-07-11
# HEAD: 7e1088760cfe0bb1fdb1f0bd155bfd52f080683a locking/atomic: sparc: Fix arch_cmpxchg64_local()
Locking fixes:
- Fix a Sparc crash
- Fix a number of objtool warnings
- Fix /proc/lockdep output on certain configs
- Restore a kprobes fail-safe
Thanks,
Ingo
------------------>
Mark Rutland (1):
locking/atomic: sparc: Fix arch_cmpxchg64_local()
Peter Zijlstra (3):
jump_label: Fix jump_label_text_reserved() vs __init
static_call: Fix static_call_text_reserved() vs __init kprobe/static_call: Restore missing static_call_text_reserved()
Xiongwei Song (1):
locking/lockdep: Fix meaningless /proc/lockdep output of lock classes on !CONFIG_PROVE_LOCKING
arch/sparc/include/asm/cmpxchg_64.h | 2 +- kernel/jump_label.c | 13 ++++++++----- kernel/kprobes.c | 2 ++ kernel/locking/lockdep_proc.c | 26 ++++++++++++++------------ kernel/static_call.c | 13 ++++++++----- 5 files changed, 33 insertions(+), 23 deletions(-)
arch/sparc/include/asm/cmpxchg_64.h +1 -1
@@ -201,7 +201,7 @@ static inline unsigned long __cmpxchg_local(volatile void *ptr,#define arch_cmpxchg64_local (ptr, o, n) \ ({ \ BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ - cmpxchg_local((ptr), (o), (n)); \ + arch_cmpxchg_local((ptr), (o), (n)); \ })#define arch_cmpxchg64 (ptr, o, n) arch_cmpxchg64_local((ptr), (o), (n))
kernel/jump_label.c +8 -5
@@ -316,14 +316,16 @@ static int addr_conflict(struct jump_entry *entry, void *start, void *end) }static int __jump_label_text_reserved (struct jump_entry *iter_start, -struct jump_entry *iter_stop,void *start,void *end) +struct jump_entry *iter_stop,void *start,void *end,bool init) {struct jump_entry *iter; iter = iter_start;while (iter < iter_stop) { -if (addr_conflict (iter, start, end)) -return 1 ; +if (init || !jump_entry_is_init (iter)) { +if (addr_conflict (iter, start, end)) +return 1 ; + } iter++; }
@@ -562,7 +564,7 @@ static int __jump_label_mod_text_reserved(void *start, void *end) ret =__jump_label_text_reserved (mod->jump_entries, mod->jump_entries + mod->num_jump_entries, - start, end); + start, end, mod->state ==MODULE_STATE_COMING );module_put (mod);
@@ -788,8 +790,9 @@ early_initcall(jump_label_init_module);*/ int jump_label_text_reserved (void *start,void *end) { +bool init = system_state <SYSTEM_RUNNING ;int ret =__jump_label_text_reserved (__start___jump_table, - __stop___jump_table, start, end); + __stop___jump_table, start, end, init);if (ret)return ret;
kernel/kprobes.c +2 -0
@@ -35,6 +35,7 @@#include <linux/ftrace.h> #include <linux/cpu.h> #include <linux/jump_label.h> +#include <linux/static_call.h> #include <linux/perf_event.h> #include <asm/sections.h>
@@ -1551,6 +1552,7 @@ static int check_kprobe_address_safe(struct kprobe *p,if (!kernel_text_address ((unsigned long ) p->addr) ||within_kprobe_blacklist ((unsigned long ) p->addr) ||jump_label_text_reserved (p->addr, p->addr) || +static_call_text_reserved (p->addr, p->addr) ||find_bug ((unsigned long )p->addr)) { ret = -EINVAL ; goto out;
kernel/locking/lockdep_proc.c +14 -12
@@ -70,26 +70,28 @@ static int l_show(struct seq_file *m, void *v)#ifdef CONFIG_DEBUG_LOCKDEP seq_printf (m," OPS:%8ld" ,debug_class_ops_read (class));#endif -#ifdef CONFIG_PROVE_LOCKING -seq_printf (m," FD:%5ld" ,lockdep_count_forward_deps (class)); -seq_printf (m," BD:%5ld" ,lockdep_count_backward_deps (class)); -#endif +if (IS_ENABLED (CONFIG_PROVE_LOCKING )) { +seq_printf (m," FD:%5ld" ,lockdep_count_forward_deps (class)); +seq_printf (m," BD:%5ld" ,lockdep_count_backward_deps (class)); -get_usage_chars (class, usage); -seq_printf (m," %s" , usage); +get_usage_chars (class, usage); +seq_printf (m," %s" , usage); + }seq_printf (m,": " );print_name (m, class);seq_puts (m,"\n" ); -list_for_each_entry (entry, &class->locks_after, entry) { -if (entry->distance ==1 ) { -seq_printf (m," -> [%p] " , entry->class->key); -print_name (m, entry->class); -seq_puts (m,"\n" ); +if (IS_ENABLED (CONFIG_PROVE_LOCKING )) { +list_for_each_entry (entry, &class->locks_after, entry) { +if (entry->distance ==1 ) { +seq_printf (m," -> [%p] " , entry->class->key); +print_name (m, entry->class); +seq_puts (m,"\n" ); + } } +seq_puts (m,"\n" ); } -seq_puts (m,"\n" );return 0 ; }
kernel/static_call.c +8 -5
@@ -292,13 +292,15 @@ static int addr_conflict(struct static_call_site *site, void *start, void *end)static int __static_call_text_reserved (struct static_call_site *iter_start,struct static_call_site *iter_stop, -void *start,void *end) +void *start,void *end,bool init) {struct static_call_site *iter = iter_start;while (iter < iter_stop) { -if (addr_conflict (iter, start, end)) -return 1 ; +if (init || !static_call_is_init (iter)) { +if (addr_conflict (iter, start, end)) +return 1 ; + } iter++; }
@@ -324,7 +326,7 @@ static int __static_call_mod_text_reserved(void *start, void *end) ret =__static_call_text_reserved (mod->static_call_sites, mod->static_call_sites + mod->num_static_call_sites, - start, end); + start, end, mod->state ==MODULE_STATE_COMING );module_put (mod);
@@ -459,8 +461,9 @@ static inline int __static_call_mod_text_reserved(void *start, void *end)int static_call_text_reserved (void *start,void *end) { +bool init = system_state <SYSTEM_RUNNING ;int ret =__static_call_text_reserved (__start_static_call_sites, - __stop_static_call_sites, start, end); + __stop_static_call_sites, start, end, init);if (ret)return ret;
The pull request you sent on Sun, 11 Jul 2021 15:22:47 +0200:
The pull request you sent on Sun, 11 Jul 2021 15:22:47 +0200:
Quoted 1 line
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.gitlocking-urgent-2021-07-11
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/301c8b1d7c2373f85ed5d944a8e9264dad36064c
Thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html