Skip to contentSkip to conversation

package/libtirpc: add missing !BR2_STATIC_LIBS dependency

PATCH Applied James Hilliard 3 participants 6 messages Jul 25, 2021 – Jul 26, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/libtirpc: add missing !BR2_STATIC_LIBS dependency

---
Changes v1 -> v2:
- add comment requiring dynamic libraries

---
 package/libtirpc/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/libtirpc/Config.in +6 -0
index 1899edefbf..31f1636ef5 100644
@@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
 config BR2_PACKAGE_LIBTIRPC_GSS
 	bool "gss"
 	depends on BR2_USE_MMU # libkrb5
+	depends on !BR2_STATIC_LIBS # libkrb5
 	depends on BR2_PACKAGE_LIBTIRPC
 	select BR2_PACKAGE_LIBKRB5
 	help
@@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
 
 comment "libtirpc needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "libtirpc gss support needs a toolchain w/ dynamic library"
+	depends on BR2_USE_MMU
+	depends on BR2_STATIC_LIBS
+	depends on BR2_PACKAGE_LIBTIRPC
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#1 lore raw

Hi James,

Quoted 21 lines

---
Changes v1 -> v2:
- add comment requiring dynamic libraries

---
 package/libtirpc/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/libtirpc/Config.in +1 -0
index 1899edefbf..31f1636ef5 100644
@@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
 config BR2_PACKAGE_LIBTIRPC_GSS
 	bool "gss"
 	depends on BR2_USE_MMU # libkrb5
+	depends on !BR2_STATIC_LIBS # libkrb5
 	depends on BR2_PACKAGE_LIBTIRPC
 	select BR2_PACKAGE_LIBKRB5
 	help

package/libtirpc/Config.in config BR2_PACKAGE_LIBTIRPC_GSS · line 25

Quoted 8 lines
package/libtirpc/Config.in +5 -0
@@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
 
 comment "libtirpc needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "libtirpc gss support needs a toolchain w/ dynamic library"
+	depends on BR2_USE_MMU
+	depends on BR2_STATIC_LIBS
+	depends on BR2_PACKAGE_LIBTIRPC

Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS? I'd also name it "libtirpc GSS support ..." (capitalize GSS)

Kind regards,
Petr
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw
Quoted 25 lines · Petr Vorel

Hi James,

Quoted 21 lines

---
Changes v1 -> v2:
- add comment requiring dynamic libraries

---
 package/libtirpc/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/libtirpc/Config.in +1 -0
index 1899edefbf..31f1636ef5 100644
@@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
 config BR2_PACKAGE_LIBTIRPC_GSS
      bool "gss"
      depends on BR2_USE_MMU # libkrb5
+     depends on !BR2_STATIC_LIBS # libkrb5
      depends on BR2_PACKAGE_LIBTIRPC
      select BR2_PACKAGE_LIBKRB5
      help
@@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
Quoted 8 lines

package/libtirpc/Config.in config BR2_PACKAGE_LIBTIRPC_GSS · line 25

Quoted 7 lines
package/libtirpc/Config.in +5 -0
 comment "libtirpc needs a toolchain w/ threads"
      depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "libtirpc gss support needs a toolchain w/ dynamic library"
+     depends on BR2_USE_MMU
+     depends on BR2_STATIC_LIBS
+     depends on BR2_PACKAGE_LIBTIRPC

Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS?

I don't think so, then it would never be shown AFAIU.

Quoted 1 line

I'd also name it "libtirpc GSS support ..." (capitalize GSS)

I kept it lowercase for consistency with:
config BR2_PACKAGE_LIBTIRPC_GSS
bool "gss"

Maybe we should change both?

Quoted 3 lines

Kind regards,
Petr

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#3 lore raw
Quoted 35 lines · Petr Vorel
Quoted 25 lines

Hi James,

Quoted 21 lines

---
Changes v1 -> v2:
- add comment requiring dynamic libraries

---
 package/libtirpc/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/libtirpc/Config.in +1 -0
index 1899edefbf..31f1636ef5 100644
@@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
 config BR2_PACKAGE_LIBTIRPC_GSS
      bool "gss"
      depends on BR2_USE_MMU # libkrb5
+     depends on !BR2_STATIC_LIBS # libkrb5
      depends on BR2_PACKAGE_LIBTIRPC
      select BR2_PACKAGE_LIBKRB5
      help
@@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
Quoted 8 lines

package/libtirpc/Config.in config BR2_PACKAGE_LIBTIRPC_GSS · line 25

Quoted 7 lines
package/libtirpc/Config.in +5 -0
 comment "libtirpc needs a toolchain w/ threads"
      depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "libtirpc gss support needs a toolchain w/ dynamic library"
+     depends on BR2_USE_MMU
+     depends on BR2_STATIC_LIBS
+     depends on BR2_PACKAGE_LIBTIRPC

Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS?

Quoted 1 line

I don't think so, then it would never be shown AFAIU.

Looking into package/apcupsd/Config.in shows 1) comment should be just below config (problem also on previous patch) and 2) IMHO "depends on BR2_PACKAGE_LIBTIRPC" should not be there at all. Or am I missing something?

Quoted 7 lines
Quoted 1 line

I'd also name it "libtirpc GSS support ..." (capitalize GSS)

I kept it lowercase for consistency with:
config BR2_PACKAGE_LIBTIRPC_GSS
bool "gss"

Maybe we should change both?

Well, probably better to keep it lowercase.
I thought that first is identifier, other is abbreviation in the name, but again, looking into package/apcupsd/Config.in shows I$m wrong.

Kind regards,
Petr

Quoted 2 lines
Quoted 2 lines

Kind regards,
Petr

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#4 lore raw
Quoted 35 lines
Quoted 34 lines · Petr Vorel
Quoted 33 lines

Hi James,

Quoted 21 lines

---
Changes v1 -> v2:
- add comment requiring dynamic libraries

---
 package/libtirpc/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/libtirpc/Config.in +1 -0
index 1899edefbf..31f1636ef5 100644
@@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
 config BR2_PACKAGE_LIBTIRPC_GSS
      bool "gss"
      depends on BR2_USE_MMU # libkrb5
+     depends on !BR2_STATIC_LIBS # libkrb5
      depends on BR2_PACKAGE_LIBTIRPC
      select BR2_PACKAGE_LIBKRB5
      help

package/libtirpc/Config.in config BR2_PACKAGE_LIBTIRPC_GSS · line 25

Quoted 8 lines
package/libtirpc/Config.in +5 -0
@@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
 
 comment "libtirpc needs a toolchain w/ threads"
      depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "libtirpc gss support needs a toolchain w/ dynamic library"
+     depends on BR2_USE_MMU
+     depends on BR2_STATIC_LIBS
+     depends on BR2_PACKAGE_LIBTIRPC

Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS?

Quoted 4 lines
Quoted 1 line

I don't think so, then it would never be shown AFAIU.

Looking into package/apcupsd/Config.in shows 1) comment should be just below config (problem also on previous patch) and 2) IMHO "depends on BR2_PACKAGE_LIBTIRPC" should not be there at all. Or am I missing something?

Yes, I was missing something :). "depends on BR2_PACKAGE_LIBTIRPC" is correct. It works, not sure if 1) is relevant, thus sorry for confusion.

Kind regards,
Petr

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

I'd also name it "libtirpc GSS support ..." (capitalize GSS)

I kept it lowercase for consistency with:
config BR2_PACKAGE_LIBTIRPC_GSS
bool "gss"

Quoted 10 lines
Quoted 1 line

Maybe we should change both?

Well, probably better to keep it lowercase.
I thought that first is identifier, other is abbreviation in the name, but again, looking into package/apcupsd/Config.in shows I$m wrong.

Kind regards,
Petr

Quoted 2 lines
Quoted 2 lines

Kind regards,
Petr

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#5 lore raw
In reply to James Hilliard
Quoted 7 lines · On Sun, 25 Jul 2021 15:34:22 -0600 James Hilliard <[email protected]>…

---
Changes v1 -> v2:
- add comment requiring dynamic libraries

---
 package/libtirpc/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot