tests/qtest/migration-test.c: use 127.0.0.1 instead of 0
PATCH 1/1 tests/qtest/migration-test.c: use 127.0.0.1 instead of 0
From: "Dr. David Alan Gilbert" <[email protected]>
OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 in baddest; it's really testing the :0 port number that isn't allowed on anything.
(The test doesn't currently run anyway because of the userfault problem that Peter noticed, but this gets us closer to being able to reenable it)
--- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tests/qtest/migration-test.c +2 -2
@@ -787,10 +787,10 @@ static void test_baddest(void) args->hide_stderr = true; -if (test_migrate_start (&from, &to,"tcp:0:0" , args)) { +if (test_migrate_start (&from, &to,"tcp:127.0.0.1:0" , args)) {return ; } -migrate_qmp (from,"tcp:0:0" ,"{}" ); +migrate_qmp (from,"tcp:127.0.0.1:0" ,"{}" );wait_for_migration_fail (from, false);test_migrate_end (from, to, false); }
Signature · 1 line
2.31.1
Quoted 11 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 in baddest; it's really testing the :0 port number that isn't allowed on anything.
(The test doesn't currently run anyway because of the userfault problem that Peter noticed, but this gets us closer to being able to reenable it)
Signed-off-by Dr. David Alan Gilbert <[email protected]>
Signature · 1 line
Peter Xu
Quoted 6 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 in baddest; it's really testing the :0 port number that isn't allowed on anything.
Quoted 8 lines
(The test doesn't currently run anyway because of the userfault problem that Peter noticed, but this gets us closer to being able to reenable it)
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 11 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 in baddest; it's really testing the :0 port number that isn't allowed on anything.
(The test doesn't currently run anyway because of the userfault problem that Peter noticed, but this gets us closer to being able to reenable it)
Signed-off-by Dr. David Alan Gilbert <[email protected]>
Why, o why networkinghas to be so difficult.
Quoted 6 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 in baddest; it's really testing the :0 port number that isn't allowed on anything.
Quoted 8 lines
(The test doesn't currently run anyway because of the userfault problem that Peter noticed, but this gets us closer to being able to reenable it)
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 11 lines · * Dr. David Alan Gilbert (git) ([email protected]) wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 in baddest; it's really testing the :0 port number that isn't allowed on anything.
(The test doesn't currently run anyway because of the userfault problem that Peter noticed, but this gets us closer to being able to reenable it)
Signed-off-by Dr. David Alan Gilbert <[email protected]>
Queued
Quoted 25 lines
--- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tests/qtest/migration-test.c +2
-2@@ -787,10 +787,10 @@ static void test_baddest(void) args->hide_stderr = true; -if (test_migrate_start (&from, &to,"tcp:0:0" , args)) { +if (test_migrate_start (&from, &to,"tcp:127.0.0.1:0" , args)) {return ; } -migrate_qmp (from,"tcp:0:0" ,"{}" ); +migrate_qmp (from,"tcp:127.0.0.1:0" ,"{}" );wait_for_migration_fail (from, false);test_migrate_end (from, to, false); }Signature · 1 line
2.31.1
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK