mm/util: Rephrase documentation for kmemdup_nul() to clarify input
Subsystems (2)
PATCH 1/1 mm/util: Rephrase documentation for kmemdup_nul() to clarify input
kmemdup_nul() strictly speaking is not related to the string API, while being quite useful for it. Rephrase documentation to make it clear that input data can be anything (any data, which may contain any bytes, including 0x00).
--- mm/util.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
mm/util.c +5 -2
@@ -133,13 +133,16 @@ void *kmemdup(const void *src, size_t len, gfp_t gfp)EXPORT_SYMBOL (kmemdup);/** -* kmemdup_nul - Create a NUL-terminated string from unterminated data +* kmemdup_nul - Create a NUL-terminated data from unterminated one * @s: The data to stringify * @len: The size of the data * @gfp: the GFP mask used in the kmalloc() call when allocating memory * +* In particular this function is useful to add NUL-termination to +* unterminated strings. +* * Return: newly allocated copy of @s with NUL-termination or %NULL in -* case of error +* case of error. */ char *kmemdup_nul (const char *s,size_t len,gfp_t gfp) {
Signature · 1 line
2.30.2
Quoted 4 lines · Andy Shevchenko
kmemdup_nul()strictly speaking is not related to the string API, while being quite useful for it. Rephrase documentation to make it clear that input data can be anything (any data, which may contain any bytes, including0x00).
That's not a useful thing to do, though. This rephrasing you've done is more confusing than the original.
Quoted 8 lines · Matthew Wilcox
Quoted 4 lines · Andy Shevchenko
kmemdup_nul()strictly speaking is not related to the string API, while being quite useful for it. Rephrase documentation to make it clear that input data can be anything (any data, which may contain any bytes, including0x00).That's not a useful thing to do, though. This rephrasing you've done is more confusing than the original.
Okay, then drop it. Sorry for the noise.
Signature · 2 lines
With Best Regards, Andy Shevchenko