Skip to contentSkip to conversation

MAINTAINERS: Update for VMCI driver

PATCH In review Jorgen Hansen 3 participants 8 messages Jul 20, 2021 – Jul 21, 2021 virtio core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Update for VMCI driver

Add maintainer info for the VMware VMCI driver.

---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)
MAINTAINERS +8 -0
index a61f4f3..7e7c6fa 100644
@@ -19792,6 +19792,14 @@ L:	[email protected]
 S:	Supported
 F:	drivers/ptp/ptp_vmw.c
 
+VMWARE VMCI DRIVER
+M:	Jorgen Hansen <[email protected]>
+M:	Vishnu Dasa <[email protected]>
+M:	"VMware, Inc." <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	drivers/misc/vmw_vmci/
+
 VMWARE VMMOUSE SUBDRIVER
 M:	"VMware Graphics" <[email protected]>
 M:	"VMware, Inc." <[email protected]>
Signature · 6 lines
2.6.2

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
#1 lore raw
Quoted 12 lines · Jorgen Hansen

Add maintainer info for the VMware VMCI driver.

---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)
MAINTAINERS +0 -0
index a61f4f3..7e7c6fa 100644

MAINTAINERS L: [email protected] · line 19798

Quoted 7 lines
MAINTAINERS +4 -0
@@ -19792,6 +19792,14 @@ L:	[email protected]
 S:	Supported
 F:	drivers/ptp/ptp_vmw.c
 
+VMWARE VMCI DRIVER
+M:	Jorgen Hansen <[email protected]>
+M:	Vishnu Dasa <[email protected]>
+M:	"VMware, Inc." <[email protected]>

Please do not use generic aliases as they provide no personal responsibility. Just stick with real people.

Also I would need an ack from Vishnu.

thanks,

greg k-h
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#3 lore raw
Quoted 6 lines · Vishnu Dasa

On Jul 20, 2021, at 3:39 AM, Greg KH <[email protected]<mailto:[email protected]>> wrote:

Also I would need an ack from Vishnu.

A maintainer that sends html email isn't going to work very well :(

Please fix.

greg k-h
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#4 lore raw
In reply to Greg KH
Quoted 20 lines · Greg KH
Quoted 15 lines · Jorgen Hansen

Add maintainer info for the VMware VMCI driver.

---
MAINTAINERS | 8 ++++++++

1 file changed, 8 insertions(+)
MAINTAINERS +0 -0
index a61f4f3..7e7c6fa 100644
@@ -19792,6 +19792,14 @@ L:	[email protected]

S: Supported
F: drivers/ptp/ptp_vmw.c

Quoted 7 lines

MAINTAINERS L: [email protected] · line 19798

Quoted 4 lines
MAINTAINERS +4 -0
+VMWARE VMCI DRIVER
+M:	Jorgen Hansen <[email protected]>
+M:	Vishnu Dasa <[email protected]>
+M:	"VMware, Inc." <[email protected]>

Please do not use generic aliases as they provide no personal responsibility. Just stick with real people.

That makes sense. However, the pv-drivers list is used for keeping managers and people helping with testing in the loop. So would adding pv-drivers as a second L: entry be OK?

Thanks,
Jorgen
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#5 lore raw
Quoted 28 lines · Jorgen Hansen
Quoted 20 lines · Greg KH
Quoted 15 lines · Jorgen Hansen

Add maintainer info for the VMware VMCI driver.

---
MAINTAINERS | 8 ++++++++

1 file changed, 8 insertions(+)
MAINTAINERS +0 -0
index a61f4f3..7e7c6fa 100644
@@ -19792,6 +19792,14 @@ L:	[email protected]

S: Supported
F: drivers/ptp/ptp_vmw.c

Quoted 7 lines

MAINTAINERS L: [email protected] · line 19798

Quoted 4 lines
MAINTAINERS +4 -0
+VMWARE VMCI DRIVER
+M:	Jorgen Hansen <[email protected]>
+M:	Vishnu Dasa <[email protected]>
+M:	"VMware, Inc." <[email protected]>

Please do not use generic aliases as they provide no personal responsibility. Just stick with real people.

Quoted 3 lines

That makes sense. However, the pv-drivers list is used for keeping managers and people helping with testing in the loop. So would adding pv-drivers as a second L: entry be OK?

Is it really a list? If not, then that would not make much sense.
_______________________________________________
Virtualization mailing list [email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#6 lore raw
Quoted 33 lines · Greg KH
Quoted 28 lines · Jorgen Hansen
Quoted 27 lines · Greg KH
Quoted 15 lines · Jorgen Hansen

Add maintainer info for the VMware VMCI driver.

---
MAINTAINERS | 8 ++++++++

1 file changed, 8 insertions(+)
MAINTAINERS +0 -0
index a61f4f3..7e7c6fa 100644
@@ -19792,6 +19792,14 @@ L:	[email protected]

S: Supported
F: drivers/ptp/ptp_vmw.c

MAINTAINERS L: [email protected] · line 19798

Quoted 4 lines
MAINTAINERS +4 -0
+VMWARE VMCI DRIVER
+M:	Jorgen Hansen <[email protected]>
+M:	Vishnu Dasa <[email protected]>
+M:	"VMware, Inc." <[email protected]>

Please do not use generic aliases as they provide no personal responsibility. Just stick with real people.

Quoted 5 lines
Quoted 3 lines

That makes sense. However, the pv-drivers list is used for keeping managers and people helping with testing in the loop. So would adding pv-drivers as a second L: entry be OK?

Is it really a list? If not, then that would not make much sense.

It is - with VMware subscribers only but anyone can post to it. If the intent of the
L: entries is to allow folks to subscribe to relevant information, then it isn’t appropriate.

All existing vmw driver maintainer entries have pv-drivers as an M: entry, so has there been a change in policy regarding this? The approach has been quite useful for us.
_______________________________________________
Virtualization mailing list [email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#7 lore raw
Quoted 37 lines · Jorgen Hansen
Quoted 37 lines · Greg KH
Quoted 31 lines · Jorgen Hansen
Quoted 20 lines · Greg KH
Quoted 15 lines · Jorgen Hansen

Add maintainer info for the VMware VMCI driver.

---
MAINTAINERS | 8 ++++++++

1 file changed, 8 insertions(+)
MAINTAINERS +0 -0
index a61f4f3..7e7c6fa 100644
@@ -19792,6 +19792,14 @@ L:	[email protected]

S: Supported
F: drivers/ptp/ptp_vmw.c

Quoted 7 lines

MAINTAINERS L: [email protected] · line 19798

Quoted 4 lines
MAINTAINERS +4 -0
+VMWARE VMCI DRIVER
+M:	Jorgen Hansen <[email protected]>
+M:	Vishnu Dasa <[email protected]>
+M:	"VMware, Inc." <[email protected]>

Please do not use generic aliases as they provide no personal responsibility. Just stick with real people.

That makes sense. However, the pv-drivers list is used for keeping managers and people helping with testing in the loop. So would adding pv-drivers as a second L: entry be OK?

Quoted 5 lines
Quoted 1 line

Is it really a list? If not, then that would not make much sense.

It is - with VMware subscribers only but anyone can post to it. If the intent of the
L: entries is to allow folks to subscribe to relevant information, then it isn’t appropriate.

Then mark it as a private list.

Quoted 3 lines

All existing vmw driver maintainer entries have pv-drivers as an M: entry, so has there been a change in policy regarding this? The approach has been quite useful for us.

It's a hit-or-miss policy, some of us notice it, others do not. nothing official at all, just those of us with more experience know that aliases like this usually atrophy and become useless. There are many such examples of useless ones in the MAINTAINERS file right now :(

thanks,

greg k-h
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization