Skip to contentSkip to conversation

mm/memcg: fix NULL pointer dereference in memcg_slab_free_hook()

PATCH Applied Wang Hai 6 participants 6 messages Jul 28, 2021 – Jul 29, 2021

Subsystems (2)
lore
Share & tools
lore

Wang Hai

author
#0 lore raw

PATCH v2 1/1 mm/memcg: fix NULL pointer dereference in memcg_slab_free_hook()

When I use kfree_rcu() to free a large memory allocated by kmalloc_node(), the following dump occurs.

BUG: kernel NULL pointer dereference, address: 0000000000000020
[...]
Oops: 0000 [#1] SMP
[...]
Workqueue: events kfree_rcu_work
RIP: 0010:__obj_to_index include/linux/slub_def.h:182 [inline]
RIP: 0010:obj_to_index include/linux/slub_def.h:191 [inline]
RIP: 0010:memcg_slab_free_hook+0x120/0x260 mm/slab.h:363
[...]
Call Trace:
 kmem_cache_free_bulk+0x58/0x630 mm/slub.c:3293
 kfree_bulk include/linux/slab.h:413 [inline]
 kfree_rcu_work+0x1ab/0x200 kernel/rcu/tree.c:3300
 process_one_work+0x207/0x530 kernel/workqueue.c:2276
 worker_thread+0x320/0x610 kernel/workqueue.c:2422
 kthread+0x13d/0x160 kernel/kthread.c:313
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294

When kmalloc_node() a large memory, page is allocated, not slab, so when freeing memory via kfree_rcu(), this large memory should not be used by memcg_slab_free_hook(), because memcg_slab_free_hook() is is used for slab.

Using page_objcgs_check() instead of page_objcgs() in memcg_slab_free_hook() to fix this bug.

Fixes 270c6a71460e ("mm: memcontrol/slab: Use helpers to access slab page's memcg_data")

---
v1->v2: Use page_objcgs_check() to fix this bug

 mm/slab.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/slab.h +1 -1
index 67e06637ff2e..59db4797acd4 100644
@@ -339,7 +339,7 @@ static inline void memcg_slab_free_hook(struct kmem_cache *s_orig,
 			continue;
 
 		page = virt_to_head_page(p[i]);
-		objcgs = page_objcgs(page);
+		objcgs = page_objcgs_check(page);
 		if (!objcgs)
 			continue;
 
Signature · 1 line
2.17.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 27 lines · Wang Hai

When I use kfree_rcu() to free a large memory allocated by kmalloc_node(), the following dump occurs.

BUG: kernel NULL pointer dereference, address: 0000000000000020
[...]
Oops: 0000 [#1] SMP
[...]
Workqueue: events kfree_rcu_work
RIP: 0010:__obj_to_index include/linux/slub_def.h:182 [inline]
RIP: 0010:obj_to_index include/linux/slub_def.h:191 [inline]
RIP: 0010:memcg_slab_free_hook+0x120/0x260 mm/slab.h:363
[...]
Call Trace:
 kmem_cache_free_bulk+0x58/0x630 mm/slub.c:3293
 kfree_bulk include/linux/slab.h:413 [inline]
 kfree_rcu_work+0x1ab/0x200 kernel/rcu/tree.c:3300
 process_one_work+0x207/0x530 kernel/workqueue.c:2276
 worker_thread+0x320/0x610 kernel/workqueue.c:2422
 kthread+0x13d/0x160 kernel/kthread.c:313
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294

When kmalloc_node() a large memory, page is allocated, not slab, so when freeing memory via kfree_rcu(), this large memory should not be used by memcg_slab_free_hook(), because memcg_slab_free_hook() is is used for slab.

Quoted 5 lines

Using page_objcgs_check() instead of page_objcgs() in memcg_slab_free_hook() to fix this bug.

Fixes 270c6a71460e ("mm: memcontrol/slab: Use helpers to access slab page's memcg_data")
Acked-by on v2 1/1
#2 lore raw
In reply to Wang Hai
Quoted 26 lines · Wang Hai

When I use kfree_rcu() to free a large memory allocated by kmalloc_node(), the following dump occurs.

BUG: kernel NULL pointer dereference, address: 0000000000000020
[...]
Oops: 0000 [#1] SMP
[...]
Workqueue: events kfree_rcu_work
RIP: 0010:__obj_to_index include/linux/slub_def.h:182 [inline]
RIP: 0010:obj_to_index include/linux/slub_def.h:191 [inline]
RIP: 0010:memcg_slab_free_hook+0x120/0x260 mm/slab.h:363
[...]
Call Trace:
 kmem_cache_free_bulk+0x58/0x630 mm/slub.c:3293
 kfree_bulk include/linux/slab.h:413 [inline]
 kfree_rcu_work+0x1ab/0x200 kernel/rcu/tree.c:3300
 process_one_work+0x207/0x530 kernel/workqueue.c:2276
 worker_thread+0x320/0x610 kernel/workqueue.c:2422
 kthread+0x13d/0x160 kernel/kthread.c:313
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294

When kmalloc_node() a large memory, page is allocated, not slab, so when freeing memory via kfree_rcu(), this large memory should not be used by memcg_slab_free_hook(), because memcg_slab_free_hook() is is used for slab.

Quoted 5 lines

Using page_objcgs_check() instead of page_objcgs() in memcg_slab_free_hook() to fix this bug.

Fixes 270c6a71460e ("mm: memcontrol/slab: Use helpers to access slab page's memcg_data")

This looks like a much better fix. Thanks!

Quoted 20 lines

---
v1->v2: Use page_objcgs_check() to fix this bug

 mm/slab.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/slab.h +1 -1
index 67e06637ff2e..59db4797acd4 100644
@@ -339,7 +339,7 @@ static inline void memcg_slab_free_hook(struct kmem_cache *s_orig,
 			continue;
 
 		page = virt_to_head_page(p[i]);
-		objcgs = page_objcgs(page);
+		objcgs = page_objcgs_check(page);
 		if (!objcgs)
 			continue;
 
Signature · 1 line
2.17.1
Signature · 2 lines
Michal Hocko
SUSE Labs
#3 lore raw
Quoted 27 lines · Michal Hocko
Quoted 26 lines · Wang Hai

When I use kfree_rcu() to free a large memory allocated by kmalloc_node(), the following dump occurs.

BUG: kernel NULL pointer dereference, address: 0000000000000020
[...]
Oops: 0000 [#1] SMP
[...]
Workqueue: events kfree_rcu_work
RIP: 0010:__obj_to_index include/linux/slub_def.h:182 [inline]
RIP: 0010:obj_to_index include/linux/slub_def.h:191 [inline]
RIP: 0010:memcg_slab_free_hook+0x120/0x260 mm/slab.h:363
[...]
Call Trace:
 kmem_cache_free_bulk+0x58/0x630 mm/slub.c:3293
 kfree_bulk include/linux/slab.h:413 [inline]
 kfree_rcu_work+0x1ab/0x200 kernel/rcu/tree.c:3300
 process_one_work+0x207/0x530 kernel/workqueue.c:2276
 worker_thread+0x320/0x610 kernel/workqueue.c:2422
 kthread+0x13d/0x160 kernel/kthread.c:313
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294

When kmalloc_node() a large memory, page is allocated, not slab, so when freeing memory via kfree_rcu(), this large memory should not be used by memcg_slab_free_hook(), because memcg_slab_free_hook() is is used for slab.

Quoted 7 lines
Quoted 5 lines

Using page_objcgs_check() instead of page_objcgs() in memcg_slab_free_hook() to fix this bug.

Fixes 270c6a71460e ("mm: memcontrol/slab: Use helpers to access slab page's memcg_data")

This looks like a much better fix. Thanks!

+1

Thank you, Wang!

Reviewed-by on v2 1/1
#4 lore raw
In reply to Wang Hai
Quoted 27 lines · Wang Hai

When I use kfree_rcu() to free a large memory allocated by kmalloc_node(), the following dump occurs.

BUG: kernel NULL pointer dereference, address: 0000000000000020
[...]
Oops: 0000 [#1] SMP
[...]
Workqueue: events kfree_rcu_work
RIP: 0010:__obj_to_index include/linux/slub_def.h:182 [inline]
RIP: 0010:obj_to_index include/linux/slub_def.h:191 [inline]
RIP: 0010:memcg_slab_free_hook+0x120/0x260 mm/slab.h:363
[...]
Call Trace:
 kmem_cache_free_bulk+0x58/0x630 mm/slub.c:3293
 kfree_bulk include/linux/slab.h:413 [inline]
 kfree_rcu_work+0x1ab/0x200 kernel/rcu/tree.c:3300
 process_one_work+0x207/0x530 kernel/workqueue.c:2276
 worker_thread+0x320/0x610 kernel/workqueue.c:2422
 kthread+0x13d/0x160 kernel/kthread.c:313
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294

When kmalloc_node() a large memory, page is allocated, not slab, so when freeing memory via kfree_rcu(), this large memory should not be used by memcg_slab_free_hook(), because memcg_slab_free_hook() is is used for slab.

Quoted 5 lines

Using page_objcgs_check() instead of page_objcgs() in memcg_slab_free_hook() to fix this bug.

Fixes 270c6a71460e ("mm: memcontrol/slab: Use helpers to access slab page's memcg_data")

More simpler than v1. Thanks.

Reviewed-by on v2 1/1
#5 lore raw
In reply to Wang Hai
Quoted 26 lines · Wang Hai

When I use kfree_rcu() to free a large memory allocated by kmalloc_node(), the following dump occurs.

BUG: kernel NULL pointer dereference, address: 0000000000000020
[...]
Oops: 0000 [#1] SMP
[...]
Workqueue: events kfree_rcu_work
RIP: 0010:__obj_to_index include/linux/slub_def.h:182 [inline]
RIP: 0010:obj_to_index include/linux/slub_def.h:191 [inline]
RIP: 0010:memcg_slab_free_hook+0x120/0x260 mm/slab.h:363
[...]
Call Trace:
  kmem_cache_free_bulk+0x58/0x630 mm/slub.c:3293
  kfree_bulk include/linux/slab.h:413 [inline]
  kfree_rcu_work+0x1ab/0x200 kernel/rcu/tree.c:3300
  process_one_work+0x207/0x530 kernel/workqueue.c:2276
  worker_thread+0x320/0x610 kernel/workqueue.c:2422
  kthread+0x13d/0x160 kernel/kthread.c:313
  ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294

When kmalloc_node() a large memory, page is allocated, not slab, so when freeing memory via kfree_rcu(), this large memory should not be used by memcg_slab_free_hook(), because memcg_slab_free_hook() is is used for slab.

Quoted 5 lines

Using page_objcgs_check() instead of page_objcgs() in memcg_slab_free_hook() to fix this bug.

Fixes 270c6a71460e ("mm: memcontrol/slab: Use helpers to access slab page's memcg_data")
Quoted 18 lines

---
v1->v2: Use page_objcgs_check() to fix this bug

  mm/slab.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
mm/slab.h +1 -1
index 67e06637ff2e..59db4797acd4 100644
@@ -339,7 +339,7 @@ static inline void memcg_slab_free_hook(struct kmem_cache *s_orig,
  			continue;
 
  		page = virt_to_head_page(p[i]);
-		objcgs = page_objcgs(page);
+		objcgs = page_objcgs_check(page);
  		if (!objcgs)
  			continue;