thunderbolt: For dev authorization changes, include the actual event in udev change notification
Subsystems (2)
PATCH v3 1/1 thunderbolt: For dev authorization changes, include the actual event in udev change notification
For security, we would like to monitor and track when the thunderbolt devices are authorized and deauthorized (i.e. when the thunderbolt sysfs "authorized" attribute changes). Currently the userspace gets a udev change notification when there is a change, but the state may have changed (again) by the time we look at the authorized attribute in sysfs. So an authorization event may go unnoticed. Thus make it easier by informing the actual change (new value of authorized attribute) in the udev change notification.
The change is included as a key value "authorized=<val>" where <val> is the new value of sysfs attribute "authorized", and is described at Documentation/ABI/testing/sysfs-bus-thunderbolt under /sys/bus/thunderbolt/devices/.../authorized
---
v3: rearrange the local variable definitions, add comments
v2: Commit log changes
drivers/thunderbolt/switch.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/thunderbolt/switch.c +10 -3
@@ -1498,6 +1498,7 @@ static ssize_t authorized_show(struct device *dev,static int disapprove_switch (struct device *dev,void *not_used) { +char *envp[] = {"AUTHORIZED=0" ,NULL };struct tb_switch *sw; sw =tb_to_switch (dev);
@@ -1514,7 +1515,7 @@ static int disapprove_switch(struct device *dev, void *not_used)return ret; sw->authorized =0 ; -kobject_uevent (&sw->dev.kobj,KOBJ_CHANGE ); +kobject_uevent_env (&sw->dev.kobj,KOBJ_CHANGE , envp); }return 0 ;
@@ -1522,7 +1523,9 @@ static int disapprove_switch(struct device *dev, void *not_used)static int tb_switch_set_authorized (struct tb_switch *sw,unsigned int val) { +char envp_string[13 ];int ret = -EINVAL ; +char *envp[] = { envp_string,NULL };if (!mutex_trylock (&sw->tb->lock))return restart_syscall ();
@@ -1559,8 +1562,12 @@ static int tb_switch_set_authorized(struct tb_switch *sw, unsigned int val)if (!ret) { sw->authorized = val; -/* Notify status change to the userspace */ -kobject_uevent (&sw->dev.kobj,KOBJ_CHANGE ); +/* +* Notify status change to the userspace, informing the new +* value of /sys/bus/thunderbolt/devices/.../authorized +*/ +sprintf (envp_string,"AUTHORIZED=%u" , sw->authorized); +kobject_uevent_env (&sw->dev.kobj,KOBJ_CHANGE , envp); } unlock:
Signature · 1 line
2.32.0.554.ge1b32706d8-goog
Hi Rajat,
Quoted 9 lines · Rajat Jain
For security, we would like to monitor and track when the thunderbolt devices are authorized and deauthorized (i.e. when the thunderbolt sysfs "authorized" attribute changes). Currently the userspace gets a udev change notification when there is a change, but the state may have changed (again) by the time we look at the authorized attribute in sysfs. So an authorization event may go unnoticed. Thus make it easier by informing the actual change (new value of authorized attribute) in the udev change notification.
Quoted 6 lines
The change is included as a key value "authorized=<val>" where <val> is the new value of sysfs attribute "authorized", and is described at
Documentation/ABI/testing/sysfs-bus-thunderboltunder/sys/bus/thunderbolt/devices/.../authorizedSigned-off-by Rajat Jain <[email protected]>
I did some tiny changes to the title, commit message and the comment and applied to thunderbolt.git/next, thanks!
Quoted 18 lines · Mika Westerberg
Hi Rajat,
Quoted 14 lines · Rajat Jain
For security, we would like to monitor and track when the thunderbolt devices are authorized and deauthorized (i.e. when the thunderbolt sysfs "authorized" attribute changes). Currently the userspace gets a udev change notification when there is a change, but the state may have changed (again) by the time we look at the authorized attribute in sysfs. So an authorization event may go unnoticed. Thus make it easier by informing the actual change (new value of authorized attribute) in the udev change notification.
The change is included as a key value "authorized=<val>" where <val> is the new value of sysfs attribute "authorized", and is described at
Documentation/ABI/testing/sysfs-bus-thunderboltunder/sys/bus/thunderbolt/devices/.../authorized
Quoted 4 lines
Quoted 1 line
Signed-off-by Rajat Jain <[email protected]>I did some tiny changes to the title, commit message and the comment and applied to thunderbolt.git/next, thanks!
Thank you!
Rajat