Skip to contentSkip to conversation

drm/i915/gem/ttm: prefer kernel types

PATCH In review Jani Nikula 3 participants 4 messages Aug 10, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gem/ttm: prefer kernel types

Avoid uintXX_t types in the driver.

Fixes 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend")
Cc Thomas Hellström <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Maarten Lankhorst <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +1 -1
index 771eb2963123..ffda88156e32 100644
@@ -168,7 +168,7 @@ i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
 }
 
 static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,
-					 uint32_t page_flags)
+					 u32 page_flags)
 {
 	struct ttm_resource_manager *man =
 		ttm_manager_type(bo->bdev, bo->resource->mem_type);
Signature · 1 line
2.20.1
#1 lore raw
Quoted 16 lines · Jani Nikula

Avoid uintXX_t types in the driver.

Fixes 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend")
Cc Thomas Hellström <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Maarten Lankhorst <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +0 -0
index 771eb2963123..ffda88156e32 100644

drivers/gpu/drm/i915/gem/i915_gem_ttm.c i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj, · line 171

Quoted 5 lines
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +1 -1
@@ -168,7 +168,7 @@ i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
 }
 
 static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,
-					 uint32_t page_flags)
+					 u32 page_flags)

It's for the ttm_device_funcs ops table, I thinhk we should fix it there and across the board?

Otherwise a bit ocd mismatch :-)
-Daniel

Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +0 -0
 {
 	struct ttm_resource_manager *man =
 		ttm_manager_type(bo->bdev, bo->resource->mem_type);
Signature · 1 line
2.20.1
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#2 lore raw
Quoted 19 lines · Daniel Vetter
Quoted 18 lines · Jani Nikula

Avoid uintXX_t types in the driver.

Fixes 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend")
Cc Thomas Hellström <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Maarten Lankhorst <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +0 -0
index 771eb2963123..ffda88156e32 100644
@@ -168,7 +168,7 @@ i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
 }
 
Quoted 8 lines

drivers/gpu/drm/i915/gem/i915_gem_ttm.c i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj, · line 171

Quoted 3 lines
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +1 -1
 static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,
-					 uint32_t page_flags)
+					 u32 page_flags)

It's for the ttm_device_funcs ops table, I thinhk we should fix it there and across the board?

Otherwise a bit ocd mismatch :-)

Well, the above is the only uintXX_t reference in i915.

BR,
Jani.

Quoted 8 lines

-Daniel

Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +0 -0
 {
 	struct ttm_resource_manager *man =
 		ttm_manager_type(bo->bdev, bo->resource->mem_type);
Signature · 1 line
2.20.1
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#3 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem/ttm: prefer kernel types

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915/gem/ttm: prefer kernel types
URL : https://patchwork.freedesktop.org/series/93541/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10464 -> Patchwork_20791
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_20791 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_20791, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_20791:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html

Known issues
------------

Here are the changes found in Patchwork_20791 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-gfx:
- fi-rkl-guc: NOTRUN -> [SKIP][2] ([fdo#109315]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@amdgpu/[email protected]

* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [PASS][3] -> [FAIL][4] ([i915#1888])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10464/fi-tgl-1115g4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-tgl-1115g4/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-rkl-guc: NOTRUN -> [SKIP][5] ([i915#3844] / [i915#579])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-rkl-guc: NOTRUN -> [SKIP][6] ([i915#3301])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@[email protected]

* igt@prime_vgem@basic-write:
- fi-rkl-guc: NOTRUN -> [SKIP][7] ([i915#3291]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0:
- fi-tgl-1115g4: [FAIL][8] ([i915#1888]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10464/fi-tgl-1115g4/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-tgl-1115g4/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- fi-rkl-guc: [DMESG-WARN][10] ([i915#3925]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10464/fi-rkl-guc/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@[email protected]

[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3844]: https://gitlab.freedesktop.org/drm/intel/issues/3844
[i915#3925]: https://gitlab.freedesktop.org/drm/intel/issues/3925
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579

Participating hosts (37 -> 33)
------------------------------

Missing (4): fi-bdw-samus fi-bsw-cyan bat-jsl-1 fi-apl-guc

Build changes
-------------

* Linux: CI_DRM_10464 -> Patchwork_20791

CI-20190529: 20190529
CI_DRM_10464: 294a55f328023a4e36f46e5eb6c4859076efd850 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6165: df5d05d742275b049f6f3c852a86c4769966b126 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20791: 5f5e1301423731d5c2deee844b627636e6208b02 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

5f5e13014237 drm/i915/gem/ttm: prefer kernel types

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/index.html