nvmet: pass back cntlid on successful completion
Subsystems (2)
PATCH 1/1 nvmet: pass back cntlid on successful completion
From: Amit Engel <[email protected]>
According to NVMe specification,
connect response dword 0 value is based on status code:
return cntlid for successful compeltion
return IPO and IATTR for connect invalid parameters
Signed-off-by Amit Engel <[email protected]>
--- drivers/nvme/target/fabrics-cmd.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/nvme/target/fabrics-cmd.c +5 -4
@@ -120,6 +120,7 @@ static u16 nvmet_install_queue(struct nvmet_ctrl *ctrl, struct nvmet_req *req)if (!sqsize) {pr_warn ("queue size zero!\n" ); req->error_loc = offsetof(struct nvmf_connect_command , sqsize); + req->cqe->result.u32 =IPO_IATTR_CONNECT_SQE (sqsize); ret =NVME_SC_CONNECT_INVALID_PARAM |NVME_SC_DNR ; goto err; }
@@ -260,11 +261,11 @@ static void nvmet_execute_io_connect(struct nvmet_req *req) } status =nvmet_install_queue (ctrl, req); -if (status) { -/* pass back cntlid that had the issue of installing queue */ - req->cqe->result.u16 =cpu_to_le16 (ctrl->cntlid); +if (status) goto out_ctrl_put; - } + +/* pass back cntlid for successful completion */ + req->cqe->result.u16 =cpu_to_le16 (ctrl->cntlid);pr_debug ("adding queue %d to ctrl %d.\n" , qid, ctrl->cntlid);
Signature · 7 lines
2.18.2 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Christoph Hellwig
AppliedThanks, applied with a slightly updated commit message.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme