syscalls/sysfs: Convert sysfs01 to the new API
PATCH v3 1/6 syscalls/sysfs: Convert sysfs01 to the new API
Signed-off-by sujiaxun <[email protected]>
--- testcases/kernel/syscalls/sysfs/sysfs01.c | 132 +++------------------- 1 file changed, 16 insertions(+), 116 deletions(-)
testcases/kernel/syscalls/sysfs/sysfs01.c +16 -116
@@ -1,129 +1,29 @@ +// SPDX-License-Identifier: GPL-2.0-only /* * Copyright (c) Wipro Technologies Ltd, 2002. All Rights Reserved. -* -* This program is free software; you can redistribute it and/or modify it -* under the terms of version 2 of the GNU General Public License as -* published by the Free Software Foundation. -* -* This program is distributed in the hope that it would be useful, but -* WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. -* -* You should have received a copy of the GNU General Public License along -* with this program; if not, write the Free Software Foundation, Inc., -* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -* */ -/************************************************************************** -* -* TEST IDENTIFIER : sysfs01 -* -* EXECUTED BY : anyone -* -* TEST TITLE : Basic test for sysfs(2) -* -* TEST CASE TOTAL : 1 -* -* AUTHOR : Aniruddha Marathe <[email protected]> -* -* SIGNALS -* Uses SIGUSR1 to pause before test if option set. -* (See the parse_opts(3) man page). -* -* DESCRIPTION -* This is a Phase I test for the sysfs(2) system call. -* This test is carried out for option 1 for sysfs(2). -* It is intended to provide a limited exposure of the system call. -* -* -* Setup: -* Setup signal handling. -* Pause for SIGUSR1 if option specified. -* -* Test: -* Loop if the proper options are given. -* Execute system call -* Check return code, if system call failed (return=-1) -* Log the errno and Issue a FAIL message. -* Otherwise, Issue a PASS message. -* -* Cleanup: -* Print errno log and/or timing stats if options given -* -* USAGE: <for command-line> -* sysfs01 [-c n] [-e] [-i n] [-I x] [-p x] [-t] [-h] [-f] [-p] -* where: -* -c n : run n copies simultaneously. -* -e : Turn on errno logging. -* -i n : Execute test n times. -* -I x : Execute test for x seconds. -* -p : Pause for SIGUSR1 before starting -* -P x : Pause for x seconds between iterations. -* -t : Turn on syscall timing. -* -*RESTRICTIONS: -*There is no glibc or libc support -*Kernel should be compiled with proc filesystem support -******************************************************************************/ + +/*\ +* [Description] +* This test is run for option 1 for sysfs(2). +* Translate the filesystem identifier string fsname into a filesystem type index. +*/ #include <errno.h> #include <unistd.h> #include <sys/syscall.h> -#include "test.h" +#include "tst_test.h" #include "lapi/syscalls.h" -static void setup (); -static void cleanup (); - -char *TCID ="sysfs01" ; -int TST_TOTAL =1 ; - -int main (int ac,char **av) +static void verify_sysfs01 (void ) { -int lc; - -tst_parse_opts (ac, av,NULL ,NULL ); - -setup (); - -for (lc =0 ;TEST_LOOPING (lc); lc++) { - - tst_count =0 ; - -/* option 1, buf holds fs name */ -TEST (ltp_syscall (__NR_sysfs,1 ,"proc" )); - -/* check return code */ -if (TEST_RETURN ==-1 ) { -tst_resm (TFAIL ,"sysfs(2) Failed for " -"option 1 and set errno to %d" ,TEST_ERRNO ); - }else { -tst_resm (TPASS ,"sysfs(2) Passed for " "option 1" ); - } - }/*End of TEST_LOOPING */ - -/*Clean up and exit */ -cleanup (); -tst_exit (); +/* option 1, buf holds fs name */ +TST_EXP_POSITIVE (tst_syscall (__NR_sysfs,1 ,"proc" ),"sysfs(1,'proc')" ); +if (TST_PASS ==1 ) +tst_res (TPASS ,"sysfs(2) Passed for option 1" ); } -/* setup() - performs all ONE TIME setup for this test */ -void setup (void ) -{ - -tst_sig (NOFORK ,DEF_HANDLER , cleanup); - -TEST_PAUSE ; - -} - -/* -* cleanup() - Performs one time cleanup for this test at -* completion or premature exit -*/ - -void cleanup (void ) -{ - -} +static struct tst_test test = { + .test_all = verify_sysfs01, +};
--
2.20.1
PATCH v3 1/6 syscalls/sysfs: Convert sysfs01 to the new API
Hi!
testcases/kernel/syscalls/sysfs/sysfs01.c line 24
Quoted 5 lines
testcases/kernel/syscalls/sysfs/sysfs01.c +4
-0+/* option 1, buf holds fs name */ +TST_EXP_POSITIVE (tst_syscall (__NR_sysfs,1 ,"proc" ),"sysfs(1,'proc')" ); +if (TST_PASS ==1 ) +tst_res (TPASS ,"sysfs(2) Passed for option 1" );
Ah, TST_EXP_POSITIVE() does not produce TPASS message, that should be fixed so that we don't have to add the TPASS message manually here. I will send a patch.
Signature · 2 lines
Cyril Hrubis [email protected]