Skip to contentSkip to conversation

configure: Remove spurious [] from tr

PATCH In review Dr. David Alan Gilbert (git) 4 participants 7 messages Aug 12, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: Remove spurious [] from tr

From: "Dr. David Alan Gilbert" <[email protected]>

ShellCheck points out that tr '[a-z]' actually replaces the []'s and only the a-z is needed.

Remove the spurious [] - although in this use it will make no difference.

Fixes bb55b712e8dc4d4eb515144d5c26798fea178cba
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index 9a79a004d7..5bb8c2a59d 100755
@@ -4549,7 +4549,7 @@ if test "$gprof" = "yes" ; then
 fi
 echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
 for drv in $audio_drv_list; do
-    def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr '[a-z]' '[A-Z]')
+    def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr 'a-z' 'A-Z')
     echo "$def=y" >> $config_host_mak
 done
 if test "$alsa" = "yes" ; then
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

ShellCheck points out that tr '[a-z]' actually replaces the []'s and only the a-z is needed.

Remove the spurious [] - although in this use it will make no difference.

Fixes bb55b712e8dc4d4eb515144d5c26798fea178cba
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index 9a79a004d7..5bb8c2a59d 100755

configure if test "$gprof" = "yes" ; then

Quoted 9 lines
configure +1 -2
@@ -4549,7 +4549,7 @@ if test "$gprof" = "yes" ; then
 fi
 echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
 for drv in $audio_drv_list; do
-    def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr '[a-z]' '[A-Z]')
+    def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr 'a-z' 'A-Z')
     echo "$def=y" >> $config_host_mak
 done
 if test "$alsa" = "yes" ; then
-

(Is this the only thing shellcheck complains about in configure? I'm guessing not...)

thanks
-- PMM

#2 lore raw
Quoted 17 lines · * Peter Maydell ([email protected]) wrote:
Quoted 15 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

ShellCheck points out that tr '[a-z]' actually replaces the []'s and only the a-z is needed.

Remove the spurious [] - although in this use it will make no difference.

Fixes bb55b712e8dc4d4eb515144d5c26798fea178cba
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 5 lines
configure +0 -0
index 9a79a004d7..5bb8c2a59d 100755

configure if test "$gprof" = "yes" ; then

Quoted 9 lines
configure +1 -2
@@ -4549,7 +4549,7 @@ if test "$gprof" = "yes" ; then
 fi
 echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
 for drv in $audio_drv_list; do
-    def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr '[a-z]' '[A-Z]')
+    def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr 'a-z' 'A-Z')
     echo "$def=y" >> $config_host_mak
 done
 if test "$alsa" = "yes" ; then
-

Thanks.

Quoted 2 lines

(Is this the only thing shellcheck complains about in configure? I'm guessing not...)

Indeed it's not; there's LOTS of warnings; although most of them are probably irrelevant; there are also two others at the error level:

In configure line 4406:

        if "$ld" -verbose 2>&1 | grep -q "^[[:space:]]*$emu[[:space:]]*$"; then
                                                       ^-- SC1087: Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).

which is probably just needing the ${emu} to shut it up.

In configure line 4464:
if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
^-- SC1035: You are missing a required space after the !.

which hmm I've not quite got my head around yet; but maybe that one is real.

https://www.shellcheck.net/wiki/SC1035 -- You are missing a required space ...
https://www.shellcheck.net/wiki/SC1087 -- Use braces when expanding arrays,...

Dave

Quoted 3 lines

thanks
-- PMM

Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK
#3 lore raw
Quoted 8 lines · Dr. David Alan Gilbert

Indeed it's not; there's LOTS of warnings; although most of them are probably irrelevant; there are also two others at the error level:

In configure line 4406:

        if "$ld" -verbose 2>&1 | grep -q "^[[:space:]]*$emu[[:space:]]*$"; then
                                                       ^-- SC1087: Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).

which is probably just needing the ${emu} to shut it up.

Yep. ${var[idx]} is a bashism, but our configure is /bin/sh and not bash, and we don't want an array access, so using ${emu}[ to shut up the checker is the right action.

Quoted 7 lines

In configure line 4464:
if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
^-- SC1035: You are missing a required space after the !.

which hmm I've not quite got my head around yet; but maybe that one is real.

In bash, !() is an extended glob when using 'shopt -s extglob' - but we aren't using bash, and we _don't_ want extended glob (execute the command formed from the set of all filenames in the current working directory that do not match the contents inside (...), which is likely to not be a valid command). When the bash extension is not in use, 'if !()' is the same as 'if ! ()', checking if the exit status of the subshell is non-zero. Adding the space ensures we don't trigger an unintended bash extglob, but would still waste the effort on a subshell. So I would suggest we fix the line to:

if ! GIT="$git" "$source_path..".."..$git_submodules"; then

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
#4 lore raw
In reply to Dr. David Alan Gilbert
Quoted 6 lines · Dr. David Alan Gilbert

In configure line 4464:
if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
^-- SC1035: You are missing a required space after the !.

which hmm I've not quite got my head around yet; but maybe that one is real.

Trying

! (echo abc); echo $?
!(echo abc); echo $?

both work in bash, but the latter fails with zsh:

abc
1
ff:2: no matches found: !(echo abc)

Paolo

#5 lore raw
In reply to Dr. David Alan Gilbert (git)
Quoted 20 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

ShellCheck points out that tr '[a-z]' actually replaces the []'s and only the a-z is needed.

Remove the spurious [] - although in this use it will make no difference.

Fixes bb55b712e8dc4d4eb515144d5c26798fea178cba
---
  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index 9a79a004d7..5bb8c2a59d 100755

configure if test "$gprof" = "yes" ; then · line 4555

Quoted 8 lines
configure +1 -1
@@ -4549,7 +4549,7 @@ if test "$gprof" = "yes" ; then
  fi
  echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
  for drv in $audio_drv_list; do
-    def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr '[a-z]' '[A-Z]')
+    def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr 'a-z' 'A-Z')
      echo "$def=y" >> $config_host_mak
  done
  if test "$alsa" = "yes" ; then

Do we want this in 6.1? For the next release I'm moving all audio stuff to meson anyway. :)

Paolo

#6 lore raw
Quoted 24 lines · * Paolo Bonzini ([email protected]) wrote:
Quoted 23 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

ShellCheck points out that tr '[a-z]' actually replaces the []'s and only the a-z is needed.

Remove the spurious [] - although in this use it will make no difference.

Fixes bb55b712e8dc4d4eb515144d5c26798fea178cba
---
  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -1
index 9a79a004d7..5bb8c2a59d 100755
@@ -4549,7 +4549,7 @@ if test "$gprof" = "yes" ; then
  fi
  echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
  for drv in $audio_drv_list; do
-    def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr '[a-z]' '[A-Z]')
Quoted 8 lines

configure if test "$gprof" = "yes" ; then · line 4555

Quoted 5 lines
configure +1 -0
+    def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr 'a-z' 'A-Z')
      echo "$def=y" >> $config_host_mak
  done
  if test "$alsa" = "yes" ; then

Do we want this in 6.1? For the next release I'm moving all audio stuff to meson anyway. :)

Bah! Not bothered; I just tripped over ShellCheck and that looked like a trivial one.

Dave

Quoted 2 lines

Paolo

Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK