Skip to contentSkip to conversation

dt: bindings: net: mt76: add eeprom-data property

PATCH In review Daniel Golle 3 participants 4 messages Aug 25, 2021 – Oct 5, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 dt: bindings: net: mt76: add eeprom-data property

EEPROM data for mt76 can be embedded into device-tree as an array.

---
 .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml +5 -0
index 3e2c2e43175e5..1489d3c1cd6ec 100644
@@ -47,6 +47,11 @@ properties:
 
   ieee80211-freq-limit: true
 
+  mediatek,eeprom-data:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    description:
+      EEPROM data embedded as array.
+
   mediatek,mtd-eeprom:
     $ref: /schemas/types.yaml#/definitions/phandle-array
     description:
Signature · 1 line
2.32.0
maintainer
#2 lore raw
In reply to Daniel Golle
Quoted 12 lines · Daniel Golle

EEPROM data for mt76 can be embedded into device-tree as an array.

---
 .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml +0 -0
index 3e2c2e43175e5..1489d3c1cd6ec 100644

Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml properties: · line 51

Quoted 5 lines
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml +2 -0
@@ -47,6 +47,11 @@ properties:
 
   ieee80211-freq-limit: true
 
+  mediatek,eeprom-data:
+    $ref: /schemas/types.yaml#/definitions/uint32-array

Given that the driver patch simply uses memcpy on the data, shouldn't we use an uint8-array here?

- Felix

#3 lore raw
Quoted 15 lines · Felix Fietkau
Quoted 13 lines · Daniel Golle

EEPROM data for mt76 can be embedded into device-tree as an array.

---
 .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml +0 -0
index 3e2c2e43175e5..1489d3c1cd6ec 100644
@@ -47,6 +47,11 @@ properties:
 
Quoted 6 lines

Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml properties: · line 51

Quoted 4 lines
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml +2 -0
   ieee80211-freq-limit: true
 
+  mediatek,eeprom-data:
+    $ref: /schemas/types.yaml#/definitions/uint32-array

Given that the driver patch simply uses memcpy on the data, shouldn't we use an uint8-array here?

When using the /incbin/('file.bin'); syntax the result is included as what appears to be a uint32-array when decompiling again with dtc.

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek