arm64: dts: meson: sm1: add Ethernet PHY reset line for ODROID-C4/HC4
Subsystems (2)
PATCH 1/1 arm64: dts: meson: sm1: add Ethernet PHY reset line for ODROID-C4/HC4
This patch is to fix an issue that the ethernet link doesn't come up when using ip link set down/up:
[ 11.428114] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down [ 14.428595] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31) [ 14.428610] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma [ 14.428974] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed [ 14.711185] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed
This fix has been referred two commits applied for ODROID-N2 (G12B).
commit 658e4129bb81 ("arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line")
commit 1c7412530d5d0 ("arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements")--- arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +4 -0
@@ -256,6 +256,10 @@ external_phy: ethernet-phy@0 { reg = <0>; max-speed = <1000>; + reset-assert-us = <10000>; + reset-deassert-us = <80000>; + reset-gpios = <&gpio GPIOZ_15 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>; + interrupt-parent = <&gpio_intc>; /* MAC_INTR on GPIOZ_14 */ interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.30.2
Hi,
Thanks for this patch!
my first suggestion is about the patch subject (first line):
arm64: dts: meson-sm1-odroid: add Ethernet PHY reset for ODROID-C4/HC4
This makes it match the pattern of the most recent commits there:45d736ab17b4 arm64: dts: meson-sm1-odroid: add 5v regulator gpio 7881df513680 arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as open source
Quoted 9 lines · Dongjin Kim
This patch is to fix an issue that the ethernet link doesn't come up when using ip link set down/up:
[ 11.428114] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down [ 14.428595] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31) [ 14.428610] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma [ 14.428974] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed [ 14.711185] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed
Quoted 3 lines
This fix has been referred two commits applied for ODROID-N2 (G12B).
commit 658e4129bb81 ("arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line") commit 1c7412530d5d0 ("arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements")
I am not 100% sure but I think you can just add two "Fixes: ..." tags here That way this patch is also backported automatically
Quoted 1 line
Signed-off-by Dongjin Kim <[email protected]>
Neil Armstrong
AppliedHi,
Quoted 9 lines · Dongjin Kim
This patch is to fix an issue that the ethernet link doesn't come up when using ip link set down/up:
[ 11.428114] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down [ 14.428595] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31) [ 14.428610] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma [ 14.428974] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed [ 14.711185] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed[...]
Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v5.16/dt64)
[1/1] arm64: dts: meson: sm1: add Ethernet PHY reset line for ODROID-C4/HC4
https://git.kernel.org/amlogic/c/9d02214f8332d5dbbcce3d6c5c915e54d43a0c46
Signature · 1 line
Neil