Skip to contentSkip to conversation

drm/i915/gt: Register the migrate contexts with their engines

PATCH In review Thomas Hellström 4 participants 8 messages Aug 26, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/i915/gt: Register the migrate contexts with their engines

Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts.

Add a list to struct intel_engine_cs where we add all pinned contexts on creation, and traverse that list at resume time to reset the pinned contexts.

This fixes the kms_pipe_crc_basic@suspend-read-crc-pipe-a selftest for now, but proper LMEM backup / restore is needed for full suspend functionality. However, note that even with full LMEM backup / restore it may be desirable to keep the reset since backing up the migrate context images must happen using memcpy() after the migrate context has become inactive, and for performance- and other reasons we want to avoid memcpy() from LMEM.

Also traverse the list at guc_init_lrc_mapping() calling guc_kernel_context_pin() for the pinned contexts, like is already done for the kernel context.

v2:
- Don't reset the contexts on each __engine_unpark() but rather at resume time (Chris Wilson).

Cc Tvrtko Ursulin <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Brost Matthew <[email protected]>
Cc Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/gt/intel_context_types.h |  8 +++++++
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  4 ++++
 drivers/gpu/drm/i915/gt/intel_engine_pm.c     | 23 +++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_engine_pm.h     |  2 ++
 drivers/gpu/drm/i915/gt/intel_engine_types.h  |  7 ++++++
 drivers/gpu/drm/i915/gt/intel_gt_pm.c         |  3 +++
 drivers/gpu/drm/i915/gt/mock_engine.c         |  1 +
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 10 +++++---
 8 files changed, 55 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/intel_context_types.h +8 -0
index e54351a170e2..a63631ea0ec4 100644
@@ -152,6 +152,14 @@ struct intel_context {
 	/** sseu: Control eu/slice partitioning */
 	struct intel_sseu sseu;
 
+	/**
+	 * pinned_contexts_link: List link for the engine's pinned contexts.
+	 * This is only used if this is a perma-pinned kernel context and
+	 * the list is assumed to only be manipulated during driver load
+	 * or unload time so no mutex protection currently.
+	 */
+	struct list_head pinned_contexts_link;
+
 	u8 wa_bb_page; /* if set, page num reserved for context workarounds */
 
 	struct {
drivers/gpu/drm/i915/gt/intel_engine_cs.c +4 -0
index 332efea696a5..c606a4714904 100644
@@ -320,6 +320,7 @@ static int intel_engine_setup(struct intel_gt *gt, enum intel_engine_id id)
 
 	BUILD_BUG_ON(BITS_PER_TYPE(engine->mask) < I915_NUM_ENGINES);
 
+	INIT_LIST_HEAD(&engine->pinned_contexts_list);
 	engine->id = id;
 	engine->legacy_idx = INVALID_ENGINE;
 	engine->mask = BIT(id);
@@ -875,6 +876,8 @@ intel_engine_create_pinned_context(struct intel_engine_cs *engine,
 		return ERR_PTR(err);
 	}
 
+	list_add_tail(&ce->pinned_contexts_link, &engine->pinned_contexts_list);
+
 	/*
 	 * Give our perma-pinned kernel timelines a separate lockdep class,
 	 * so that we can use them from within the normal user timelines
@@ -897,6 +900,7 @@ void intel_engine_destroy_pinned_context(struct intel_context *ce)
 	list_del(&ce->timeline->engine_link);
 	mutex_unlock(&hwsp->vm->mutex);
 
+	list_del(&ce->pinned_contexts_link);
 	intel_context_unpin(ce);
 	intel_context_put(ce);
 }
drivers/gpu/drm/i915/gt/intel_engine_pm.c +23 -0
index 1f07ac4e0672..dacd62773735 100644
@@ -298,6 +298,29 @@ void intel_engine_init__pm(struct intel_engine_cs *engine)
 	intel_engine_init_heartbeat(engine);
 }
 
+/**
+ * intel_engine_reset_pinned_contexts - Reset the pinned contexts of
+ * an engine.
+ * @engine: The engine whose pinned contexts we want to reset.
+ *
+ * Typically the pinned context LMEM images lose or get their content
+ * corrupted on suspend. This function resets their images.
+ */
+void intel_engine_reset_pinned_contexts(struct intel_engine_cs *engine)
+{
+	struct intel_context *ce;
+
+	list_for_each_entry(ce, &engine->pinned_contexts_list,
+			    pinned_contexts_link) {
+		/* kernel context gets reset at __engine_unpark() */
+		if (ce == engine->kernel_context)
+			continue;
+
+		dbg_poison_ce(ce);
+		ce->ops->reset(ce);
+	}
+}
+
 #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
 #include "selftest_engine_pm.c"
 #endif
drivers/gpu/drm/i915/gt/intel_engine_pm.h +2 -0
index 70ea46d6cfb0..8520c595f5e1 100644
@@ -69,4 +69,6 @@ intel_engine_create_kernel_request(struct intel_engine_cs *engine)
 
 void intel_engine_init__pm(struct intel_engine_cs *engine);
 
+void intel_engine_reset_pinned_contexts(struct intel_engine_cs *engine);
+
 #endif /* INTEL_ENGINE_PM_H */
drivers/gpu/drm/i915/gt/intel_engine_types.h +7 -0
index bfbfe53c23dd..5ae1207c363b 100644
@@ -307,6 +307,13 @@ struct intel_engine_cs {
 
 	struct intel_context *kernel_context; /* pinned */
 
+	/**
+	 * pinned_contexts_list: List of pinned contexts. This list is only
+	 * assumed to be manipulated during driver load- or unload time and
+	 * does therefore not have any additional protection.
+	 */
+	struct list_head pinned_contexts_list;
+
 	intel_engine_mask_t saturated; /* submitting semaphores too late? */
 
 	struct {
drivers/gpu/drm/i915/gt/intel_gt_pm.c +3 -0
index dea8e2479897..c9bae2ef92df 100644
@@ -192,6 +192,9 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
 
 	intel_rps_sanitize(&gt->rps);
 
+	for_each_engine(engine, gt, id)
+		intel_engine_reset_pinned_contexts(engine);
+
 	intel_uncore_forcewake_put(gt->uncore, FORCEWAKE_ALL);
 	intel_runtime_pm_put(gt->uncore->rpm, wakeref);
 }
drivers/gpu/drm/i915/gt/mock_engine.c +1 -0
index 2c1af030310c..8a14982a9691 100644
@@ -376,6 +376,7 @@ int mock_engine_init(struct intel_engine_cs *engine)
 {
 	struct intel_context *ce;
 
+	INIT_LIST_HEAD(&engine->pinned_contexts_list);
 	engine->sched_engine = i915_sched_engine_create(ENGINE_MOCK);
 	if (!engine->sched_engine)
 		return -ENOMEM;
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +7 -3
index 87d8dc8f51b9..55709206b95e 100644
@@ -2385,9 +2385,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc)
 	 * and even it did this code would be run again.
 	 */
 
-	for_each_engine(engine, gt, id)
-		if (engine->kernel_context)
-			guc_kernel_context_pin(guc, engine->kernel_context);
+	for_each_engine(engine, gt, id) {
+		struct intel_context *ce;
+
+		list_for_each_entry(ce, &engine->pinned_contexts_list,
+				    pinned_contexts_link)
+			guc_kernel_context_pin(guc, ce);
+	}
 }
 
 static void guc_release(struct intel_engine_cs *engine)
Signature · 1 line
2.31.1
#1 lore raw
Quoted 24 lines · Thomas Hellström

Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts.

Add a list to struct intel_engine_cs where we add all pinned contexts on creation, and traverse that list at resume time to reset the pinned contexts.

This fixes the kms_pipe_crc_basic@suspend-read-crc-pipe-a selftest for now, but proper LMEM backup / restore is needed for full suspend functionality. However, note that even with full LMEM backup / restore it may be desirable to keep the reset since backing up the migrate context images must happen using memcpy() after the migrate context has become inactive, and for performance- and other reasons we want to avoid memcpy() from LMEM.

Also traverse the list at guc_init_lrc_mapping() calling guc_kernel_context_pin() for the pinned contexts, like is already done for the kernel context.

v2:
- Don't reset the contexts on each __engine_unpark() but rather at resume time (Chris Wilson).

Quoted 6 lines
Cc Tvrtko Ursulin <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Brost Matthew <[email protected]>
Cc Chris Wilson <[email protected]>

I guess it got lost, but I few weeks ago I stumbled over this and wondered why we're even setting up a separate context or at least why a separate vm compared to the gt->vm we have already?

Even on chips with bazillions of copy engines the plan is that we only reserve a single one for kernel migrations, so there's not really a need for quite this much generality I think. Maybe check with Jon Bloomfield on this.

Iirc I had also a few other questions on simplifying this area. -Daniel

Quoted 172 lines
---
 drivers/gpu/drm/i915/gt/intel_context_types.h |  8 +++++++
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  4 ++++
 drivers/gpu/drm/i915/gt/intel_engine_pm.c     | 23 +++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_engine_pm.h     |  2 ++
 drivers/gpu/drm/i915/gt/intel_engine_types.h  |  7 ++++++
 drivers/gpu/drm/i915/gt/intel_gt_pm.c         |  3 +++
 drivers/gpu/drm/i915/gt/mock_engine.c         |  1 +
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 10 +++++---
 8 files changed, 55 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/intel_context_types.h +8 -0
index e54351a170e2..a63631ea0ec4 100644
@@ -152,6 +152,14 @@ struct intel_context {
 	/** sseu: Control eu/slice partitioning */
 	struct intel_sseu sseu;
 
+	/**
+	 * pinned_contexts_link: List link for the engine's pinned contexts.
+	 * This is only used if this is a perma-pinned kernel context and
+	 * the list is assumed to only be manipulated during driver load
+	 * or unload time so no mutex protection currently.
+	 */
+	struct list_head pinned_contexts_link;
+
 	u8 wa_bb_page; /* if set, page num reserved for context workarounds */
 
 	struct {
drivers/gpu/drm/i915/gt/intel_engine_cs.c +4 -0
index 332efea696a5..c606a4714904 100644
@@ -320,6 +320,7 @@ static int intel_engine_setup(struct intel_gt *gt, enum intel_engine_id id)
 
 	BUILD_BUG_ON(BITS_PER_TYPE(engine->mask) < I915_NUM_ENGINES);
 
+	INIT_LIST_HEAD(&engine->pinned_contexts_list);
 	engine->id = id;
 	engine->legacy_idx = INVALID_ENGINE;
 	engine->mask = BIT(id);
@@ -875,6 +876,8 @@ intel_engine_create_pinned_context(struct intel_engine_cs *engine,
 		return ERR_PTR(err);
 	}
 
+	list_add_tail(&ce->pinned_contexts_link, &engine->pinned_contexts_list);
+
 	/*
 	 * Give our perma-pinned kernel timelines a separate lockdep class,
 	 * so that we can use them from within the normal user timelines
@@ -897,6 +900,7 @@ void intel_engine_destroy_pinned_context(struct intel_context *ce)
 	list_del(&ce->timeline->engine_link);
 	mutex_unlock(&hwsp->vm->mutex);
 
+	list_del(&ce->pinned_contexts_link);
 	intel_context_unpin(ce);
 	intel_context_put(ce);
 }
drivers/gpu/drm/i915/gt/intel_engine_pm.c +23 -0
index 1f07ac4e0672..dacd62773735 100644
@@ -298,6 +298,29 @@ void intel_engine_init__pm(struct intel_engine_cs *engine)
 	intel_engine_init_heartbeat(engine);
 }
 
+/**
+ * intel_engine_reset_pinned_contexts - Reset the pinned contexts of
+ * an engine.
+ * @engine: The engine whose pinned contexts we want to reset.
+ *
+ * Typically the pinned context LMEM images lose or get their content
+ * corrupted on suspend. This function resets their images.
+ */
+void intel_engine_reset_pinned_contexts(struct intel_engine_cs *engine)
+{
+	struct intel_context *ce;
+
+	list_for_each_entry(ce, &engine->pinned_contexts_list,
+			    pinned_contexts_link) {
+		/* kernel context gets reset at __engine_unpark() */
+		if (ce == engine->kernel_context)
+			continue;
+
+		dbg_poison_ce(ce);
+		ce->ops->reset(ce);
+	}
+}
+
 #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
 #include "selftest_engine_pm.c"
 #endif
drivers/gpu/drm/i915/gt/intel_engine_pm.h +2 -0
index 70ea46d6cfb0..8520c595f5e1 100644
@@ -69,4 +69,6 @@ intel_engine_create_kernel_request(struct intel_engine_cs *engine)
 
 void intel_engine_init__pm(struct intel_engine_cs *engine);
 
+void intel_engine_reset_pinned_contexts(struct intel_engine_cs *engine);
+
 #endif /* INTEL_ENGINE_PM_H */
drivers/gpu/drm/i915/gt/intel_engine_types.h +7 -0
index bfbfe53c23dd..5ae1207c363b 100644
@@ -307,6 +307,13 @@ struct intel_engine_cs {
 
 	struct intel_context *kernel_context; /* pinned */
 
+	/**
+	 * pinned_contexts_list: List of pinned contexts. This list is only
+	 * assumed to be manipulated during driver load- or unload time and
+	 * does therefore not have any additional protection.
+	 */
+	struct list_head pinned_contexts_list;
+
 	intel_engine_mask_t saturated; /* submitting semaphores too late? */
 
 	struct {
drivers/gpu/drm/i915/gt/intel_gt_pm.c +3 -0
index dea8e2479897..c9bae2ef92df 100644
@@ -192,6 +192,9 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
 
 	intel_rps_sanitize(&gt->rps);
 
+	for_each_engine(engine, gt, id)
+		intel_engine_reset_pinned_contexts(engine);
+
 	intel_uncore_forcewake_put(gt->uncore, FORCEWAKE_ALL);
 	intel_runtime_pm_put(gt->uncore->rpm, wakeref);
 }
drivers/gpu/drm/i915/gt/mock_engine.c +1 -0
index 2c1af030310c..8a14982a9691 100644
@@ -376,6 +376,7 @@ int mock_engine_init(struct intel_engine_cs *engine)
 {
 	struct intel_context *ce;
 
+	INIT_LIST_HEAD(&engine->pinned_contexts_list);
 	engine->sched_engine = i915_sched_engine_create(ENGINE_MOCK);
 	if (!engine->sched_engine)
 		return -ENOMEM;
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +7 -3
index 87d8dc8f51b9..55709206b95e 100644
@@ -2385,9 +2385,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc)
 	 * and even it did this code would be run again.
 	 */
 
-	for_each_engine(engine, gt, id)
-		if (engine->kernel_context)
-			guc_kernel_context_pin(guc, engine->kernel_context);
+	for_each_engine(engine, gt, id) {
+		struct intel_context *ce;
+
+		list_for_each_entry(ce, &engine->pinned_contexts_list,
+				    pinned_contexts_link)
+			guc_kernel_context_pin(guc, ce);
+	}
 }
 
 static void guc_release(struct intel_engine_cs *engine)
Signature · 1 line
2.31.1
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#2 lore raw
Quoted 45 lines · Daniel Vetter
Quoted 31 lines · Thomas Hellström

Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts.

Add a list to struct intel_engine_cs where we add all pinned contexts on
creation, and traverse that list at resume time to reset the pinned contexts.

This fixes the kms_pipe_crc_basic@suspend-read-crc-pipe-a selftest for now,
but proper LMEM backup / restore is needed for full suspend functionality.
However, note that even with full LMEM backup / restore it may be desirable to keep the reset since backing up the migrate context images
must happen using memcpy() after the migrate context has become inactive,
and for performance- and other reasons we want to avoid memcpy() from
LMEM.

Also traverse the list at guc_init_lrc_mapping() calling guc_kernel_context_pin() for the pinned contexts, like is already done
for the kernel context.

v2:
- Don't reset the contexts on each __engine_unpark() but rather at resume time (Chris Wilson).

Quoted 6 lines
Cc Tvrtko Ursulin <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Brost Matthew <[email protected]>
Cc Chris Wilson <[email protected]>

I guess it got lost, but I few weeks ago I stumbled over this and wondered
why we're even setting up a separate context or at least why a separate vm
compared to the gt->vm we have already?

Quoted 7 lines

Even on chips with bazillions of copy engines the plan is that we only
reserve a single one for kernel migrations, so there's not really a need
for quite this much generality I think. Maybe check with Jon Bloomfield on
this.

Are you referring to the generality of the migration code itself or to the generality of using a list in this patch to register multiple pinned contexts to an engine?

For the migration code itself, I figured reserving one copy engine for migration was strictly needed for recoverable page-faults? In the current version we're not doing that, but just tying a pinned migration context to the first available copy engine on the gt, to be used when we don't have a ww context available to pin a separate context using a random copy engine. Note also the ring size of the migration contexts; since we're populating the page-tables for each blit, it's not hard to fill the ring and in the end multiple contexts I guess boils down to avoiding priority inversion on migration, including blocking high priority kernel context tasks.

As for not using the gt->vm, I'm not completely sure if we can do our special page-table setup on that, Got to defer that question to Chris, but once Ram's work of supporting 64K LMEM PTEs on that has landed I guess we could easily reuse the gt->vm if possible and suitable.

Thanks,
/Thomas

#3 lore raw
Quoted 69 lines · Thomas Hellström
Quoted 45 lines · Daniel Vetter
Quoted 31 lines · Thomas Hellström

Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts.

Add a list to struct intel_engine_cs where we add all pinned contexts on
creation, and traverse that list at resume time to reset the pinned contexts.

This fixes the kms_pipe_crc_basic@suspend-read-crc-pipe-a selftest for now,
but proper LMEM backup / restore is needed for full suspend functionality.
However, note that even with full LMEM backup / restore it may be desirable to keep the reset since backing up the migrate context images
must happen using memcpy() after the migrate context has become inactive,
and for performance- and other reasons we want to avoid memcpy() from
LMEM.

Also traverse the list at guc_init_lrc_mapping() calling guc_kernel_context_pin() for the pinned contexts, like is already done
for the kernel context.

v2:
- Don't reset the contexts on each __engine_unpark() but rather at resume time (Chris Wilson).

Quoted 6 lines
Cc Tvrtko Ursulin <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Brost Matthew <[email protected]>
Cc Chris Wilson <[email protected]>

I guess it got lost, but I few weeks ago I stumbled over this and wondered
why we're even setting up a separate context or at least why a separate vm
compared to the gt->vm we have already?

Quoted 7 lines

Even on chips with bazillions of copy engines the plan is that we only
reserve a single one for kernel migrations, so there's not really a need
for quite this much generality I think. Maybe check with Jon Bloomfield on
this.

Are you referring to the generality of the migration code itself or to the generality of using a list in this patch to register multiple pinned contexts to an engine?

For the migration code itself, I figured reserving one copy engine for migration was strictly needed for recoverable page-faults? In the current version we're not doing that, but just tying a pinned migration context to the first available copy engine on the gt, to be used when we don't have a ww context available to pin a separate context using a random copy engine. Note also the ring size of the migration contexts; since we're populating the page-tables for each blit, it's not hard to fill the ring and in the end multiple contexts I guess boils down to avoiding priority inversion on migration, including blocking high priority kernel context tasks.

Quoted 4 lines

As for not using the gt->vm, I'm not completely sure if we can do our special page-table setup on that, Got to defer that question to Chris, but once Ram's work of supporting 64K LMEM PTEs on that has landed I guess we could easily reuse the gt->vm if possible and suitable.

Just on why we have gt->vm and then also the migration vm. The old mail I typed up on this:

https://lore.kernel.org/dri-devel/CAKMK7uG6g+DQQEcjqeA6=Z2ENHogaMuvKERDgKm5jKq3u+a1jQ@mail.gmail.com/

-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#4 lore raw
In reply to Thomas Hellström
Quoted 3 lines · Thomas Hellström

Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts.

So kernel context can get corrupt because we park the GPU with it active. Blitter context for a different reason - which is that it is used to copy itself over to smem, no?

If that is correct, then why bother copying the blitter context in the first place and not just always re-create it on resume?

That would be along the lines of marking the backing store as "dontneed" (however the exact mechanics of that look these days) so suspend can skip them.

Quoted 11 lines

Add a list to struct intel_engine_cs where we add all pinned contexts on creation, and traverse that list at resume time to reset the pinned contexts.

This fixes the kms_pipe_crc_basic@suspend-read-crc-pipe-a selftest for now, but proper LMEM backup / restore is needed for full suspend functionality. However, note that even with full LMEM backup / restore it may be desirable to keep the reset since backing up the migrate context images must happen using memcpy() after the migrate context has become inactive, and for performance- and other reasons we want to avoid memcpy() from LMEM.

Hm I guess this talks about the issue - so are these images migrated at all today or not?

Regards,

Tvrtko

Quoted 185 lines

Also traverse the list at guc_init_lrc_mapping() calling guc_kernel_context_pin() for the pinned contexts, like is already done for the kernel context.

v2:
- Don't reset the contexts on each __engine_unpark() but rather at resume time (Chris Wilson).

Cc Tvrtko Ursulin <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Brost Matthew <[email protected]>
Cc Chris Wilson <[email protected]>
---
  drivers/gpu/drm/i915/gt/intel_context_types.h |  8 +++++++
  drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  4 ++++
  drivers/gpu/drm/i915/gt/intel_engine_pm.c     | 23 +++++++++++++++++++
  drivers/gpu/drm/i915/gt/intel_engine_pm.h     |  2 ++
  drivers/gpu/drm/i915/gt/intel_engine_types.h  |  7 ++++++
  drivers/gpu/drm/i915/gt/intel_gt_pm.c         |  3 +++
  drivers/gpu/drm/i915/gt/mock_engine.c         |  1 +
  .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 10 +++++---
  8 files changed, 55 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/intel_context_types.h +8 -0
index e54351a170e2..a63631ea0ec4 100644
@@ -152,6 +152,14 @@ struct intel_context {
  	/** sseu: Control eu/slice partitioning */
  	struct intel_sseu sseu;
 
+	/**
+	 * pinned_contexts_link: List link for the engine's pinned contexts.
+	 * This is only used if this is a perma-pinned kernel context and
+	 * the list is assumed to only be manipulated during driver load
+	 * or unload time so no mutex protection currently.
+	 */
+	struct list_head pinned_contexts_link;
+
  	u8 wa_bb_page; /* if set, page num reserved for context workarounds */
 
  	struct {
drivers/gpu/drm/i915/gt/intel_engine_cs.c +4 -0
index 332efea696a5..c606a4714904 100644
@@ -320,6 +320,7 @@ static int intel_engine_setup(struct intel_gt *gt, enum intel_engine_id id)
 
  	BUILD_BUG_ON(BITS_PER_TYPE(engine->mask) < I915_NUM_ENGINES);
 
+	INIT_LIST_HEAD(&engine->pinned_contexts_list);
  	engine->id = id;
  	engine->legacy_idx = INVALID_ENGINE;
  	engine->mask = BIT(id);
@@ -875,6 +876,8 @@ intel_engine_create_pinned_context(struct intel_engine_cs *engine,
  		return ERR_PTR(err);
  	}
 
+	list_add_tail(&ce->pinned_contexts_link, &engine->pinned_contexts_list);
+
  	/*
  	 * Give our perma-pinned kernel timelines a separate lockdep class,
  	 * so that we can use them from within the normal user timelines
@@ -897,6 +900,7 @@ void intel_engine_destroy_pinned_context(struct intel_context *ce)
  	list_del(&ce->timeline->engine_link);
  	mutex_unlock(&hwsp->vm->mutex);
 
+	list_del(&ce->pinned_contexts_link);
  	intel_context_unpin(ce);
  	intel_context_put(ce);
  }
drivers/gpu/drm/i915/gt/intel_engine_pm.c +23 -0
index 1f07ac4e0672..dacd62773735 100644
@@ -298,6 +298,29 @@ void intel_engine_init__pm(struct intel_engine_cs *engine)
  	intel_engine_init_heartbeat(engine);
  }
 
+/**
+ * intel_engine_reset_pinned_contexts - Reset the pinned contexts of
+ * an engine.
+ * @engine: The engine whose pinned contexts we want to reset.
+ *
+ * Typically the pinned context LMEM images lose or get their content
+ * corrupted on suspend. This function resets their images.
+ */
+void intel_engine_reset_pinned_contexts(struct intel_engine_cs *engine)
+{
+	struct intel_context *ce;
+
+	list_for_each_entry(ce, &engine->pinned_contexts_list,
+			    pinned_contexts_link) {
+		/* kernel context gets reset at __engine_unpark() */
+		if (ce == engine->kernel_context)
+			continue;
+
+		dbg_poison_ce(ce);
+		ce->ops->reset(ce);
+	}
+}
+
  #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
  #include "selftest_engine_pm.c"
  #endif
drivers/gpu/drm/i915/gt/intel_engine_pm.h +2 -0
index 70ea46d6cfb0..8520c595f5e1 100644
@@ -69,4 +69,6 @@ intel_engine_create_kernel_request(struct intel_engine_cs *engine)
 
  void intel_engine_init__pm(struct intel_engine_cs *engine);
 
+void intel_engine_reset_pinned_contexts(struct intel_engine_cs *engine);
+
  #endif /* INTEL_ENGINE_PM_H */
drivers/gpu/drm/i915/gt/intel_engine_types.h +7 -0
index bfbfe53c23dd..5ae1207c363b 100644
@@ -307,6 +307,13 @@ struct intel_engine_cs {
 
  	struct intel_context *kernel_context; /* pinned */
 
+	/**
+	 * pinned_contexts_list: List of pinned contexts. This list is only
+	 * assumed to be manipulated during driver load- or unload time and
+	 * does therefore not have any additional protection.
+	 */
+	struct list_head pinned_contexts_list;
+
  	intel_engine_mask_t saturated; /* submitting semaphores too late? */
 
  	struct {
drivers/gpu/drm/i915/gt/intel_gt_pm.c +3 -0
index dea8e2479897..c9bae2ef92df 100644
@@ -192,6 +192,9 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
 
  	intel_rps_sanitize(&gt->rps);
 
+	for_each_engine(engine, gt, id)
+		intel_engine_reset_pinned_contexts(engine);
+
  	intel_uncore_forcewake_put(gt->uncore, FORCEWAKE_ALL);
  	intel_runtime_pm_put(gt->uncore->rpm, wakeref);
  }
drivers/gpu/drm/i915/gt/mock_engine.c +1 -0
index 2c1af030310c..8a14982a9691 100644
@@ -376,6 +376,7 @@ int mock_engine_init(struct intel_engine_cs *engine)
  {
  	struct intel_context *ce;
 
+	INIT_LIST_HEAD(&engine->pinned_contexts_list);
  	engine->sched_engine = i915_sched_engine_create(ENGINE_MOCK);
  	if (!engine->sched_engine)
  		return -ENOMEM;
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +7 -3
index 87d8dc8f51b9..55709206b95e 100644
@@ -2385,9 +2385,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc)
  	 * and even it did this code would be run again.
  	 */
 
-	for_each_engine(engine, gt, id)
-		if (engine->kernel_context)
-			guc_kernel_context_pin(guc, engine->kernel_context);
+	for_each_engine(engine, gt, id) {
+		struct intel_context *ce;
+
+		list_for_each_entry(ce, &engine->pinned_contexts_list,
+				    pinned_contexts_link)
+			guc_kernel_context_pin(guc, ce);
+	}
  }
 
  static void guc_release(struct intel_engine_cs *engine)
#5 lore raw
Quoted 10 lines · Tvrtko Ursulin
Quoted 3 lines · Thomas Hellström

Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts.

So kernel context can get corrupt because we park the GPU with it active. Blitter context for a different reason - which is that it is used to copy itself over to smem, no?

Quoted 8 lines

If that is correct, then why bother copying the blitter context in the
first place and not just always re-create it on resume?

That would be along the lines of marking the backing store as "dontneed"
(however the exact mechanics of that look these days) so suspend can skip them.

I think that is marking the object with I915_BO_ALLOC_VOLATILE. However I assume this follows the rule of the internal backend objects:
Contents are valid while pinned (or locked), and these images are indeed pinned on suspend so we need to come up with something else. Perhaps I915_BO_ALLOC_PM_NOSAVE for the context images (and engine status pages?) I915_BO_ALLOC_PM_MEMCPY for the migrate vm pagetables only. The latter will come in handy also for supporting small apertures where we need to pin these in the mappable area.

Quoted 19 lines
Quoted 6 lines

Add a list to struct intel_engine_cs where we add all pinned contexts on
creation, and traverse that list at resume time to reset the pinned contexts.

Quoted 12 lines

This fixes the kms_pipe_crc_basic@suspend-read-crc-pipe-a selftest for now,
but proper LMEM backup / restore is needed for full suspend functionality.
However, note that even with full LMEM backup / restore it may be desirable to keep the reset since backing up the migrate context images
must happen using memcpy() after the migrate context has become inactive,
and for performance- and other reasons we want to avoid memcpy() from
LMEM.

Quoted 3 lines

Hm I guess this talks about the issue - so are these images migrated at
all today or not?

My current WIP backs them up. But with something like the above flags, that's easily changed. Suggestions welcome.

/Thomas

#6 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Register the migrate contexts with their engines (rev2)

In reply to Thomas Hellström
== Series Details ==

== Series Details ==

Series: drm/i915/gt: Register the migrate contexts with their engines (rev2)
URL : https://patchwork.freedesktop.org/series/94058/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10525 -> Patchwork_20902
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/index.html

Known issues
------------

Here are the changes found in Patchwork_20902 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@sync-compute0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/fi-kbl-soraka/igt@amdgpu/[email protected]

* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [PASS][2] -> [DMESG-WARN][3] ([i915#3958])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html

#### Possible fixes ####

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- {fi-dg1-1}: [INCOMPLETE][4] ([i915#3717]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/fi-dg1-1/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/fi-dg1-1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#3717]: https://gitlab.freedesktop.org/drm/intel/issues/3717
[i915#3958]: https://gitlab.freedesktop.org/drm/intel/issues/3958

Participating hosts (40 -> 33)
------------------------------

Missing (7): fi-ilk-m540 bat-adls-5 fi-hsw-4200u fi-tgl-1115g4 fi-bsw-cyan fi-bdw-samus bat-jsl-1

Build changes
-------------

* Linux: CI_DRM_10525 -> Patchwork_20902

CI-20190529: 20190529
CI_DRM_10525: 059309d37ac2de5d93cf6d71fd7fe33c9c2c66ea @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6186: 250081b306c6fa8f95405fab6a7604f1968dd4ec @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20902: c3a760daf2a2b36d07c1ce110c988fda0bd1d16a @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

c3a760daf2a2 drm/i915/gt: Register the migrate contexts with their engines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/index.html

#7 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Register the migrate contexts with their engines (rev2)

In reply to Thomas Hellström
== Series Details ==

== Series Details ==

Series: drm/i915/gt: Register the migrate contexts with their engines (rev2)
URL : https://patchwork.freedesktop.org/series/94058/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10525_full -> Patchwork_20902_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_20902_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_20902_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_20902_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_parallel@fds@vcs0:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-iclb4/igt@gem_exec_parallel@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb5/igt@gem_exec_parallel@[email protected]

Known issues
------------

Here are the changes found in Patchwork_20902_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@psr2:
- shard-iclb: [PASS][3] -> [SKIP][4] ([i915#658])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-iclb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb6/igt@[email protected]

* igt@gem_ctx_persistence@idempotent:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-snb2/igt@[email protected]

* igt@gem_ctx_sseu@mmap-args:
- shard-tglb: NOTRUN -> [SKIP][6] ([i915#280])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-kbl: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-kbl4/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl4/igt@gem_exec_fair@[email protected]
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-tglb6/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-tglb: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: NOTRUN -> [FAIL][12] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-kbl4/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-snb: NOTRUN -> [SKIP][15] ([fdo#109271]) +376 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-snb2/igt@[email protected]

* igt@gem_exec_params@secure-non-master:
- shard-tglb: NOTRUN -> [SKIP][16] ([fdo#112283])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- shard-skl: [PASS][17] -> [INCOMPLETE][18] ([i915#198])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-skl2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl10/igt@[email protected]

* igt@gem_exec_whisper@basic-normal:
- shard-glk: [PASS][19] -> [DMESG-WARN][20] ([i915#118] / [i915#95])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-glk5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-glk4/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][21] ([i915#2658]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl2/igt@[email protected]

* igt@gem_render_copy@yf-tiled-to-vebox-linear:
- shard-skl: NOTRUN -> [SKIP][22] ([fdo#109271]) +21 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#768])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3323])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl3/igt@[email protected]

* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-tglb: NOTRUN -> [SKIP][25] ([i915#3297])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][26] ([i915#3297])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][27] ([i915#2724])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-snb7/igt@[email protected]

* igt@gen3_render_tiledy_blits:
- shard-tglb: NOTRUN -> [SKIP][28] ([fdo#109289])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@gen3_render_tiledy_blits.html

* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][29] -> [DMESG-WARN][30] ([i915#1436] / [i915#716])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-skl4/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl4/igt@[email protected]

* igt@i915_pm_backlight@basic-brightness:
- shard-skl: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-skl6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl9/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][33] -> [FAIL][34] ([i915#454])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-iclb1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb2/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#1937])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl2/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rpm@gem-mmap-type@fixed:
- shard-apl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3976])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl1/igt@i915_pm_rpm@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111644] / [i915#1397] / [i915#2411])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#3777])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl8/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3777]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl1/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3777])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl3/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271]) +307 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl1/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111615])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3886]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl5/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3886]) +5 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl3/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +16 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl7/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109278] / [i915#3886])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#3689] / [i915#3886])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium@dp-audio:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#109284] / [fdo#111827]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109284] / [fdo#111827]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@[email protected]

* igt@kms_color@pipe-d-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109278] / [i915#1149])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-snb: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +18 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-snb2/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +12 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl3/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +26 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl6/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-tglb: NOTRUN -> [SKIP][54] ([fdo#111828]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109300] / [fdo#111066])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@[email protected]

* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][56] ([i915#2105])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#3319])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-32x10-onscreen:
- shard-tglb: NOTRUN -> [SKIP][58] ([i915#3359])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-512x512-random:
- shard-tglb: NOTRUN -> [SKIP][59] ([fdo#109279] / [i915#3359])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109274])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][61] -> [FAIL][62] ([i915#79])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-skl8/igt@kms_flip@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][63] -> [DMESG-WARN][64] ([i915#180]) +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-kbl3/igt@kms_flip@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#2672]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109280]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-gtt.html
- shard-tglb: NOTRUN -> [SKIP][67] ([fdo#111825]) +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-gtt.html

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][68] -> [FAIL][69] ([i915#1188]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-skl6/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl5/igt@[email protected]

* igt@kms_panel_fitting@legacy:
- shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271]) +109 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl3/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#533]) +3 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl1/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-apl: [PASS][72] -> [DMESG-WARN][73] ([i915#180]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-apl2/igt@kms_plane@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl7/igt@kms_plane@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][74] ([fdo#108145] / [i915#265]) +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][75] ([i915#265])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][76] ([fdo#108145] / [i915#265]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][77] -> [FAIL][78] ([fdo#108145] / [i915#265])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-skl4/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl4/igt@[email protected]

* igt@kms_plane_cursor@pipe-d-viewport-size-64:
- shard-iclb: NOTRUN -> [SKIP][79] ([fdo#109278]) +6 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@[email protected]

* igt@kms_plane_lowres@pipe-d-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][80] ([i915#3536])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@kms_prime@basic-crc@first-to-second:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#1836])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@kms_prime@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#658]) +6 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl2/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#2920])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#658])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#658])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-kbl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#658]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl2/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][87] -> [SKIP][88] ([fdo#109642] / [fdo#111068] / [i915#658])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-iclb2/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb6/igt@[email protected]

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109441])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][90] -> [SKIP][91] ([fdo#109441]) +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][92] ([IGT#2])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl6/igt@kms_sysfs_edid_timing.html

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][93] -> [DMESG-WARN][94] ([i915#180] / [i915#295])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-kbl6/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl1/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#533])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl3/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-iclb: NOTRUN -> [SKIP][96] ([i915#2437])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb8/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2437])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][98] ([i915#2437])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#2437])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl6/igt@[email protected]

* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][100] ([i915#2530])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@perf@polling-small-buf:
- shard-skl: [PASS][101] -> [FAIL][102] ([i915#1722])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-skl7/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl6/igt@[email protected]

* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-tglb: NOTRUN -> [SKIP][103] ([fdo#109291])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html

* igt@prime_nv_test@i915_import_gtt_mmap:
- shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109291])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb7/igt@prime_nv_test@i915_import_gtt_mmap.html

* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2994]) +6 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-apl7/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#2994])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl5/igt@[email protected]

* igt@sysfs_clients@sema-10:
- shard-tglb: NOTRUN -> [SKIP][107] ([i915#2994]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb1/igt@[email protected]

* igt@sysfs_clients@split-50:
- shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#2994]) +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl3/igt@[email protected]

#### Possible fixes ####

* igt@fbdev@unaligned-write:
- {shard-rkl}: [SKIP][109] ([i915#2582]) -> [PASS][110] +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-rkl-1/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-rkl-6/igt@[email protected]

* igt@gem_eio@in-flight-contexts-1us:
- shard-tglb: [TIMEOUT][111] ([i915#3063]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-tglb7/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb6/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][113] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-tglb1/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb8/igt@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-tglb: [FAIL][115] ([i915#2842]) -> [PASS][116] +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-tglb5/igt@gem_exec_fair@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][117] ([i915#2849]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-iclb8/igt@gem_exec_fair@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-scanout@vecs0:
- {shard-rkl}: [SKIP][119] ([i915#3639]) -> [PASS][120] +3 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-rkl-1/igt@gem_exec_reloc@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-rkl-6/igt@gem_exec_reloc@[email protected]

* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-glk: [FAIL][121] ([i915#1888] / [i915#307]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-glk4/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-glk6/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf:
- {shard-rkl}: [SKIP][123] ([fdo#109308]) -> [PASS][124] +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-rkl-1/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-rkl-6/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp:
- {shard-rkl}: [SKIP][125] ([i915#1397]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-rkl-1/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-rkl-6/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][127] ([i915#2521]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-skl2/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-skl2/igt@[email protected]

* igt@kms_big_fb@linear-max-hw-stride-64bpp-rotate-0:
- {shard-rkl}: [SKIP][129] ([i915#3721]) -> [PASS][130] +3 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-rkl-1/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-rkl-6/igt@[email protected]

* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- {shard-rkl}: [SKIP][131] ([i915#3638]) -> [PASS][132] +2 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-rkl-1/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-rkl-6/igt@[email protected]

* igt@kms_color@pipe-a-ctm-0-5:
- {shard-rkl}: [SKIP][133] ([i915#1149] / [i915#1849]) -> [PASS][134] +2 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-rkl-1/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-rkl-6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][135] ([i915#180]) -> [PASS][136] +4 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10525/shard-kbl4/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/shard-kbl3/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
- {shard-rkl}: [SKIP][137] ([fdo#112022]) -> [PASS][138] +8 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DR

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20902/index.html