Skip to contentSkip to conversation

ARM: dts: stm32: set the DCMI pins on stm32mp157c-odyssey

PATCH In review Grzegorz Szymaszek 3 participants 3 messages Aug 26, 2021 – Sep 20, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: set the DCMI pins on stm32mp157c-odyssey

The Seeed Odyssey-STM32MP157C board has a 20-pin DVP camera output. The DCMI pins used on this output are defined in the pin state definition &pinctrl/dcmi-1, AKA &dcmi_pins_b (added in mainline commit 02814a41529a55dbfb9fbb2a3728e78e70646ea6). Set these pins as the default pinctrl of the DCMI peripheral in the board device tree.

The pins are not used for any other purpose, so it seems safe to assume most users will not need to override (delete) what this patch provides. status defaults to "disabled", so the peripheral will not be unnecessarily started. And the users who actually intend to make use of a camera on the DVP port will have this little part of the configuration ready.

---
 arch/arm/boot/dts/stm32mp157c-odyssey.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/stm32mp157c-odyssey.dts +6 -0
index be1dd5e9e744..554f5d3bcdc3 100644
@@ -22,6 +22,12 @@ chosen {
 	};
 };
 
+&dcmi {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&dcmi_pins_b>;
+	pinctrl-1 = <&dcmi_sleep_pins_b>;
+};
+
 &ethernet0 {
 	status = "okay";
 	pinctrl-0 = <&ethernet0_rgmii_pins_a>;
Signature · 7 lines
2.30.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Grzegorz Szymaszek

The Seeed Odyssey-STM32MP157C board has a 20-pin DVP camera output. The DCMI pins used on this output are defined in the pin state definition &pinctrl/dcmi-1, AKA &dcmi_pins_b (added in mainline commit 02814a41529a55dbfb9fbb2a3728e78e70646ea6). Set these pins as the default pinctrl of the DCMI peripheral in the board device tree.

Quoted 8 lines

The pins are not used for any other purpose, so it seems safe to assume most users will not need to override (delete) what this patch provides. status defaults to "disabled", so the peripheral will not be unnecessarily started. And the users who actually intend to make use of a camera on the DVP port will have this little part of the configuration ready.

Quoted 22 lines
---
 arch/arm/boot/dts/stm32mp157c-odyssey.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/stm32mp157c-odyssey.dts +6 -0
index be1dd5e9e744..554f5d3bcdc3 100644
@@ -22,6 +22,12 @@ chosen {
 	};
 };
 
+&dcmi {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&dcmi_pins_b>;
+	pinctrl-1 = <&dcmi_sleep_pins_b>;
+};
+
 &ethernet0 {
 	status = "okay";
 	pinctrl-0 = <&ethernet0_rgmii_pins_a>;
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
maintainer
#2 lore raw
In reply to Grzegorz Szymaszek

Hi

Quoted 26 lines · Grzegorz Szymaszek

The Seeed Odyssey-STM32MP157C board has a 20-pin DVP camera output. The DCMI pins used on this output are defined in the pin state definition &pinctrl/dcmi-1, AKA &dcmi_pins_b (added in mainline commit 02814a41529a55dbfb9fbb2a3728e78e70646ea6). Set these pins as the default pinctrl of the DCMI peripheral in the board device tree.

The pins are not used for any other purpose, so it seems safe to assume most users will not need to override (delete) what this patch provides. status defaults to "disabled", so the peripheral will not be unnecessarily started. And the users who actually intend to make use of a camera on the DVP port will have this little part of the configuration ready.

---
  arch/arm/boot/dts/stm32mp157c-odyssey.dts | 6 ++++++
  1 file changed, 6 insertions(+)
arch/arm/boot/dts/stm32mp157c-odyssey.dts +0 -0
index be1dd5e9e744..554f5d3bcdc3 100644
@@ -22,6 +22,12 @@ chosen {
  	};
  };

arch/arm/boot/dts/stm32mp157c-odyssey.dts chosen { · line 33

Quoted 10 lines
arch/arm/boot/dts/stm32mp157c-odyssey.dts +6 -0
 
+&dcmi {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&dcmi_pins_b>;
+	pinctrl-1 = <&dcmi_sleep_pins_b>;
+};
+
  &ethernet0 {
  	status = "okay";
  	pinctrl-0 = <&ethernet0_rgmii_pins_a>;

Applied on stm32-next.

Thanks
Alex