Skip to contentSkip to conversation

doc: TST_MNTPOINT should be full path

PATCH New Petr Vorel 3 participants 4 messages Aug 25, 2021 – Aug 27, 2021

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/1 doc: TST_MNTPOINT should be full path

Document changed behavior in 205a43dfb ("Make argument to tst_umount an absolute path").

---
 doc/shell-test-api.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
doc/shell-test-api.txt +2 -2
index ecdbe9e6a..afc01dd01 100644
@@ -515,8 +515,8 @@ The 'tst_mount' mounts '$TST_DEVICE' of '$TST_FS_TYPE' (optional) to
 '$TST_MNT_PARAMS'. The '$TST_MNTPOINT' directory is created if it didn't
 exist prior to the function call.
 
-If the path passed (optional, defaults to '$TST_MNTPOINT') to the 'tst_umount' is
-not mounted (present in '/proc/mounts') it's noop.
+If the path passed (optional, should be full path, defaults to '$TST_MNTPOINT')
+to the 'tst_umount' is not mounted (present in '/proc/mounts') it's noop.
 Otherwise it retries to umount the filesystem a few times on failure.
 This is a workaround since there are daemons dumb enough to probe all newly
 mounted filesystems, and prevents them from being umounted shortly after they
Signature · 1 line
2.32.0
#2 lore raw

PATCH 1/1 doc: TST_MNTPOINT should be full path

In reply to Petr Vorel

Hi!

Quoted 13 lines

Document changed behavior in 205a43dfb ("Make argument to tst_umount an absolute path").

---
 doc/shell-test-api.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
doc/shell-test-api.txt +0 -0
index ecdbe9e6a..afc01dd01 100644

doc/shell-test-api.txt The 'tst_mount' mounts '$TST_DEVICE' of '$TST_FS_TYPE' (optional) to · line 518

Quoted 6 lines
doc/shell-test-api.txt +1 -2
@@ -515,8 +515,8 @@ The 'tst_mount' mounts '$TST_DEVICE' of '$TST_FS_TYPE' (optional) to
 '$TST_MNT_PARAMS'. The '$TST_MNTPOINT' directory is created if it didn't
 exist prior to the function call.
 
-If the path passed (optional, defaults to '$TST_MNTPOINT') to the 'tst_umount' is
-not mounted (present in '/proc/mounts') it's noop.
+If the path passed (optional, should be full path, defaults to '$TST_MNTPOINT')

^ ^
must absolute

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#3 lore raw

PATCH 1/1 doc: TST_MNTPOINT should be full path

Hi Cyril,

Quoted 5 lines

doc/shell-test-api.txt The 'tst_mount' mounts '$TST_DEVICE' of '$TST_FS_TYPE' (optional) to · line 518

Quoted 3 lines
doc/shell-test-api.txt +1 -2
-If the path passed (optional, defaults to '$TST_MNTPOINT') to the 'tst_umount' is
-not mounted (present in '/proc/mounts') it's noop.
+If the path passed (optional, should be full path, defaults to '$TST_MNTPOINT')

^ ^
must absolute

I used 'should' because the warning, but 'must' is more appropriate. Fixed and merged.

Kind regards,
Petr