Skip to contentSkip to conversation

staging: r8188eu: core: remove null check before vfree

PATCH Superseded Saurav Girepunje 2 participants 2 messages Aug 29, 2021 Staging

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: r8188eu: core: remove null check before vfree

Remove NULL check. NULL check before freeing function is not needed. Correct the indentation.

ChangeLog V3:
-Added change log.

ChangeLog V2:
-Correct the indentation.

---
 drivers/staging/r8188eu/core/rtw_sta_mgt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/r8188eu/core/rtw_sta_mgt.c +2 -3
index f6dffed53a60..c3600cb1790a 100644
@@ -155,9 +155,8 @@ u32	_rtw_free_sta_priv(struct	sta_priv *pstapriv)
 		spin_unlock_bh(&pstapriv->sta_hash_lock);
 		/*===============================*/
 
-		if (pstapriv->pallocated_stainfo_buf)
-			vfree(pstapriv->pallocated_stainfo_buf);
-		}
+		vfree(pstapriv->pallocated_stainfo_buf);
+	}
 
 	return _SUCCESS;
 }

--
2.32.0

maintainer
#1 lore raw
Quoted 8 lines · Saurav Girepunje

Remove NULL check. NULL check before freeing function is not needed. Correct the indentation.

ChangeLog V3:
-Added change log.

ChangeLog V2:
-Correct the indentation.

Please put this information below the --- line, as the documentation says to do.

thanks,

greg k-h