Skip to contentSkip to conversation

scripts: Remove legacy script tests

RFC PATCH New Petr Vorel 3 participants 5 messages Aug 27, 2021 – Aug 31, 2021

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

RFC PATCH 1/1 scripts: Remove legacy script tests

Tests were testing real/absolute path for testing make 3.80 compatibility, also detecting if something tries to removing root directory.

Tests were added 11 years ago, not used now.

---
Hi,

IMHO useless now.

Kind regards,
Petr

 scripts/abspath.sh            |  30 ---------
 scripts/lib/file_functions.sh |  71 --------------------
 scripts/realpath.sh           |  30 ---------
 scripts/safe_rm.sh            |  76 ---------------------
 scripts/tests/test_abspath.sh | 121 ----------------------------------
 scripts/tests/test_safe_rm.sh |  52 ---------------
 6 files changed, 380 deletions(-)
 delete mode 100755 scripts/abspath.sh
 delete mode 100644 scripts/lib/file_functions.sh
 delete mode 100755 scripts/realpath.sh
 delete mode 100755 scripts/safe_rm.sh
 delete mode 100755 scripts/tests/test_abspath.sh
 delete mode 100755 scripts/tests/test_safe_rm.sh
scripts/abspath.sh deleted +0 -30
deleted file mode 100755
index f0862480a..000000000
@@ -1,30 +0,0 @@
-#!/bin/sh
-#
-#    make 3.81 $(abspath .. ) emulation layer
-#
-#    Copyright (C) 2010, Cisco Systems Inc.
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-# Ngie Cooper, January 2010
-#
-
-. "${0%/*}/lib/file_functions.sh"
-
-while [ $# -gt 0 ] ; do
-	echo -n $(_abspath "$1")
-	[ $# -gt 1 ] && echo -n " "
-	shift
-done
scripts/lib/file_functions.sh deleted +0 -71

71 lines not on this page · raw message

scripts/realpath.sh deleted +0 -30
deleted file mode 100755
index d05088eb3..000000000
@@ -1,30 +0,0 @@
-#!/bin/sh
-#
-#    make 3.81 $(realpath .. ) emulation layer
-#
-#    Copyright (C) 2010, Cisco Systems Inc.
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-# Ngie Cooper, January 2010
-#
-
-. "${0%/*}/lib/file_functions.sh"
-
-while [ $# -gt 0 ] ; do
-	echo -n $(_realpath "$1")
-	[ $# -gt 1 ] && echo -n " "
-	shift
-done
scripts/safe_rm.sh deleted +0 -76

76 lines not on this page · raw message

scripts/tests/test_abspath.sh deleted +0 -121

121 lines not on this page · raw message

scripts/tests/test_safe_rm.sh deleted +0 -52

52 lines not on this page · raw message

Signature · 1 line
2.32.0
author
#1 lore raw

RFC PATCH 1/1 scripts: Remove legacy script tests

Hi,

and I suppose, we could remove also detect_distro.sh (we have lsb-release nowadays) and git2changelog.sh (we write release notes manually).

Kind regards,
Petr

#2 lore raw

RFC PATCH 1/1 scripts: Remove legacy script tests

ACK.

Quoted 11 lines · Petr Vorel

?Hi,

and I suppose, we could remove also detect_distro.sh (we have lsb-release nowadays) and git2changelog.sh (we write release notes manually).

Kind regards,
Petr

author
#4 lore raw

RFC PATCH 1/1 scripts: Remove legacy script tests

Hi Cyril,

Quoted 5 lines

Hi!

Quoted 2 lines

and I suppose, we could remove also detect_distro.sh (we have lsb-release nowadays) and git2changelog.sh (we write release notes manually).

Looks good.

Thanks, merged!

I'll send another patch to remove detect_distro.sh and git2changelog.sh.

Kind regards,
Petr