Skip to contentSkip to conversation

Fix formatting for file "hsdma-mt7621.c"

PATCH In review Krish Jain 2 participants 10 messages Sep 1, 2021 – Sep 4, 2021

Subsystems (2)
lore
Share & tools
lore

Krish Jain

author
#0 lore raw

PATCH 1/1 Fix formatting for file "hsdma-mt7621.c"

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

---
 drivers/staging/mt7621-dma/hsdma-mt7621.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/staging/mt7621-dma/hsdma-mt7621.c +3 -7
index b0ed935de7ac..89b72a802800 100644
@@ -162,8 +162,7 @@ struct mtk_hsdam_engine {
 	struct mtk_hsdma_chan chan[1];
 };
 
-static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(
-		struct mtk_hsdma_chan *chan)
+static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct mtk_hsdma_chan *chan)
 {
 	return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
 			ddev);
@@ -174,8 +173,7 @@ static inline struct mtk_hsdma_chan *to_mtk_hsdma_chan(struct dma_chan *c)
 	return container_of(c, struct mtk_hsdma_chan, vchan.chan);
 }
 
-static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(
-		struct virt_dma_desc *vdesc)
+static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(struct virt_dma_desc *vdesc)
 {
 	return container_of(vdesc, struct mtk_hsdma_desc, vdesc);
 }
@@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
 	spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-		size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
 {
 	struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
 	struct mtk_hsdma_desc *desc;
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 1 line · Krish Jain

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

Please properly line-wrap your changelog text like your editor asked you to.

Also, your subject line needs work, look at other commits for this driver with:

	git log --oneline drivers/staging/mt7621-dma/

and notice how they say the driver name and the subsystem.

Please fix up and resend a v2.

thanks,

greg k-h

author
#2 lore raw

Hi, I use nano. I don't see my editor asking me to wrap the changelog text? What exactly can I do to get it properly line wrapped properly?

Best Regards,

Krish

Quoted 17 lines · Greg KH
Quoted 1 line · Krish Jain

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

Please properly line-wrap your changelog text like your editor asked you to.

Also, your subject line needs work, look at other commits for this driver with:

        git log --oneline drivers/staging/mt7621-dma/

and notice how they say the driver name and the subsystem.

Please fix up and resend a v2.

thanks,

greg k-h

maintainer
#3 lore raw

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

Quoted 2 lines · Krish Jain

Hi, I use nano. I don't see my editor asking me to wrap the changelog text? What exactly can I do to get it properly line wrapped properly?

If you have an editor that is not set up to wrap your lines at 72 columns, then you need to do it "by hand".

thanks,

greg k-h

author
#4 lore raw
Quoted 17 lines · Greg KH

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

Quoted 2 lines · Krish Jain

Hi, I use nano. I don't see my editor asking me to wrap the changelog text? What exactly can I do to get it properly line wrapped properly?

Quoted 6 lines

If you have an editor that is not set up to wrap your lines at 72 columns, then you need to do it "by hand".

thanks,

greg k-h

Ok, doing that right now. And sorry about top posting, you know it takes a while till a habit goes away. On autopilot mode, I just am used to writing on top.

Best Regards

author
#5 lore raw
In reply to Greg KH
Quoted 9 lines · Greg KH
Quoted 1 line · Krish Jain

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

Please properly line-wrap your changelog text like your editor asked you to.

Also, your subject line needs work, look at other commits for this driver with:

Quoted 8 lines
        git log --oneline drivers/staging/mt7621-dma/

and notice how they say the driver name and the subsystem.

Please fix up and resend a v2.

thanks,

greg k-h

Do you mean I should line-wrap (at 72 columns) the entire thing or only that line? " This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl."

Best Regards

maintainer
#6 lore raw
Quoted 13 lines · Krish Jain
Quoted 12 lines · Greg KH
Quoted 1 line · Krish Jain

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

Please properly line-wrap your changelog text like your editor asked you to.

Also, your subject line needs work, look at other commits for this driver with:

        git log --oneline drivers/staging/mt7621-dma/

and notice how they say the driver name and the subsystem.

Quoted 8 lines
Quoted 5 lines

Please fix up and resend a v2.

thanks,

greg k-h

Do you mean I should line-wrap (at 72 columns) the entire thing or only that line?

Your whole changelog text needs to be wrapped at 72 columns.

Look at the 'git log' in the kernel tree for hundreds of thousands of examples :)

thanks,

greg k-h

author
#7 lore raw
Quoted 24 lines · Greg KH
Quoted 13 lines · Krish Jain
Quoted 12 lines · Greg KH
Quoted 1 line · Krish Jain

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

Please properly line-wrap your changelog text like your editor asked you to.

Also, your subject line needs work, look at other commits for this driver with:

        git log --oneline drivers/staging/mt7621-dma/

and notice how they say the driver name and the subsystem.

Quoted 8 lines
Quoted 5 lines

Please fix up and resend a v2.

thanks,

greg k-h

Do you mean I should line-wrap (at 72 columns) the entire thing or only that line?

Quoted 8 lines

Your whole changelog text needs to be wrapped at 72 columns.

Look at the 'git log' in the kernel tree for hundreds of thousands of examples :)

thanks,

greg k-h

Hi, so you mean only the change-log text (as in the text telling what changes have been made) needs to be wrapped at 72 columns but the code itself (the git diff) doesn't, right ? Because then the entire purpose of my formatting the code will be lost. Sorry for the confusion. Learning

Best Regards,

Krish

maintainer
#8 lore raw
Quoted 30 lines · Krish Jain
Quoted 29 lines · Greg KH
Quoted 13 lines · Krish Jain
Quoted 12 lines · Greg KH
Quoted 1 line · Krish Jain

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

Please properly line-wrap your changelog text like your editor asked you to.

Also, your subject line needs work, look at other commits for this driver with:

        git log --oneline drivers/staging/mt7621-dma/

and notice how they say the driver name and the subsystem.

Quoted 8 lines
Quoted 5 lines

Please fix up and resend a v2.

thanks,

greg k-h

Do you mean I should line-wrap (at 72 columns) the entire thing or only that line?

Your whole changelog text needs to be wrapped at 72 columns.

Look at the 'git log' in the kernel tree for hundreds of thousands of examples :)

Quoted 7 lines
Quoted 3 lines

thanks,

greg k-h

Hi, so you mean only the change-log text (as in the text telling what changes have been made) needs to be wrapped at 72 columns but the code itself (the git diff) doesn't, right ?

Yes, just the text that you add to the commit message.

author
#9 lore raw
Quoted 34 lines · Greg KH
Quoted 32 lines · Krish Jain
Quoted 31 lines · Greg KH
Quoted 13 lines · Krish Jain
Quoted 12 lines · Greg KH
Quoted 1 line · Krish Jain

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

Please properly line-wrap your changelog text like your editor asked you to.

Also, your subject line needs work, look at other commits for this driver with:

        git log --oneline drivers/staging/mt7621-dma/

and notice how they say the driver name and the subsystem.

Quoted 8 lines
Quoted 5 lines

Please fix up and resend a v2.

thanks,

greg k-h

Do you mean I should line-wrap (at 72 columns) the entire thing or only that line?

Your whole changelog text needs to be wrapped at 72 columns.

Look at the 'git log' in the kernel tree for hundreds of thousands of examples :)

thanks,

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

greg k-h

Hi, so you mean only the change-log text (as in the text telling what changes have been made) needs to be wrapped at 72 columns but the code itself (the git diff) doesn't, right ?

Yes, just the text that you add to the commit message.

Oh, wow, thank you. That's rather easy. You'll have it ASAP when I reach home

Best Regards