staging: vt6656: Fix warning message generated by checkpatch.pl
PATCH 1/1 staging: vt6656: Fix warning message generated by checkpatch.pl
Description: Address the following checkpatch warning:
* WARNING: Unnecessary ftrace-like logging - prefer using ftrace
--- drivers/staging/vt6656/rxtx.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/vt6656/rxtx.c +0 -1
@@ -58,7 +58,6 @@ static struct vnt_usb_send_contextstruct vnt_usb_send_context *context =NULL ;int ii; -dev_dbg (&priv->usb->dev,"%s\n" , __func__);for (ii =0 ; ii < priv->num_tx_context; ii++) {if (!priv->tx_context[ii])
Signature · 1 line
2.30.2
Quoted 13 lines · Joshua de Block
Description: Address the following checkpatch warning:
* WARNING: Unnecessary ftrace-like logging - prefer using ftraceSigned-off-by Joshua de Block <[email protected]>--- drivers/staging/vt6656/rxtx.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/vt6656/rxtx.c +0
-0
drivers/staging/vt6656/rxtx.c static struct vnt_usb_send_context · line 61
Quoted 5 lines
drivers/staging/vt6656/rxtx.c +0
-1@@ -58,7 +58,6 @@ static struct vnt_usb_send_contextstruct vnt_usb_send_context *context =NULL ;int ii; -dev_dbg (&priv->usb->dev,"%s\n" , __func__);
Delete the next blank line as well. Otherwise it introduces a new checkpatch warning.
drivers/staging/vt6656/rxtx.c static struct vnt_usb_send_context · line 63
Quoted 2 lines
drivers/staging/vt6656/rxtx.c +0
-0for (ii =0 ; ii < priv->num_tx_context; ii++) {if (!priv->tx_context[ii])
regards,
dan carpenter
PATCH v2 1/1 staging: vt6656: Fix warning message generated by checkpatch.pl
Description: Address the following checkpatch warning:
* WARNING: Unnecessary ftrace-like logging - prefer using ftrace
--- drivers/staging/vt6656/rxtx.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/vt6656/rxtx.c +0 -2
@@ -58,8 +58,6 @@ static struct vnt_usb_send_contextstruct vnt_usb_send_context *context =NULL ;int ii; -dev_dbg (&priv->usb->dev,"%s\n" , __func__); -for (ii =0 ; ii < priv->num_tx_context; ii++) {if (!priv->tx_context[ii])return NULL ;
Signature · 7 lines
2.30.2 Hi Dan, Thanks for catching that. I've modified my commit. Joshua
Greg KH
maintainerQuoted 30 lines · Joshua de Block
Description: Address the following checkpatch warning:
* WARNING: Unnecessary ftrace-like logging - prefer using ftraceSigned-off-by Joshua de Block <[email protected]>--- drivers/staging/vt6656/rxtx.c | 2 -- 1 file changed, 2 deletions(-)drivers/staging/vt6656/rxtx.c +0
-2@@ -58,8 +58,6 @@ static struct vnt_usb_send_contextstruct vnt_usb_send_context *context =NULL ;int ii; -dev_dbg (&priv->usb->dev,"%s\n" , __func__); -for (ii =0 ; ii < priv->num_tx_context; ii++) {if (!priv->tx_context[ii])return NULL ;Signature · 7 lines
2.30.2 Hi Dan, Thanks for catching that. I've modified my commit. Joshua
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot