Input: st1232 - increase "wait ready" timeout
Subsystems (2)
PATCH 1/1 Input: st1232 - increase "wait ready" timeout
I have a ST1633 touch controller which fails to probe due to a timeout waiting for the controller to become ready. Increasing the minimum delay to 100ms ensures that the probe sequence completes successfully.
The ST1633 datasheet says nothing about the maximum delay here and the ST1232 I2C protocol document says "wait until" with no notion of a timeout.
Since this only runs once during probe, being generous with the timout seems reasonable and most likely the device will become ready eventually.
(It may be worth noting that I saw this issue with a PREEMPT_RT patched kernel which probably has tighter wakeups from usleep_range() than other preemption models.)
--- drivers/input/touchscreen/st1232.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/st1232.c +1 -1
@@ -92,7 +92,7 @@ static int st1232_ts_wait_ready(struct st1232_ts_data *ts)unsigned int retries;int error; -for (retries =10 ; retries; retries--) { +for (retries =100 ; retries; retries--) { error =st1232_ts_read_data (ts,REG_STATUS ,1 );if (!error) {switch (ts->read_buf[0 ]) {
Signature · 1 line
2.33.0
Quoted 12 lines · John Keeping
I have a ST1633 touch controller which fails to probe due to a timeout waiting for the controller to become ready. Increasing the minimum delay to 100ms ensures that the probe sequence completes successfully.
The ST1633 datasheet says nothing about the maximum delay here and the ST1232 I2C protocol document says "wait until" with no notion of a timeout.
Since this only runs once during probe, being generous with the timout seems reasonable and most likely the device will become ready eventually.
Quoted 6 lines
(It may be worth noting that I saw this issue with a
PREEMPT_RTpatched kernel which probably has tighter wakeups fromusleep_range()than other preemption models.)Fixes f605be6a57b4 ("Input: st1232 - wait until device is ready before reading resolution")Signed-off-by John Keeping <[email protected]>
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Dmitry Torokhov
maintainerQuoted 11 lines · John Keeping
I have a ST1633 touch controller which fails to probe due to a timeout waiting for the controller to become ready. Increasing the minimum delay to 100ms ensures that the probe sequence completes successfully.
The ST1633 datasheet says nothing about the maximum delay here and the ST1232 I2C protocol document says "wait until" with no notion of a timeout.
Since this only runs once during probe, being generous with the timout seems reasonable and most likely the device will become ready eventually.
I'll apply this, but I wonder if it would not make sense to mark the driver as preferring asynchronous probing, so we do not delay initializing other devices while we are waiting for the touch controller to reset? Could you send me a patch for that?
Quoted 27 lines
(It may be worth noting that I saw this issue with a
PREEMPT_RTpatched kernel which probably has tighter wakeups fromusleep_range()than other preemption models.)Fixes f605be6a57b4 ("Input: st1232 - wait until device is ready before reading resolution")Signed-off-by John Keeping <[email protected]>--- drivers/input/touchscreen/st1232.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/input/touchscreen/st1232.c +1
-1@@ -92,7 +92,7 @@ static int st1232_ts_wait_ready(struct st1232_ts_data *ts)unsigned int retries;int error; -for (retries =10 ; retries; retries--) { +for (retries =100 ; retries; retries--) { error =st1232_ts_read_data (ts,REG_STATUS ,1 );if (!error) {switch (ts->read_buf[0 ]) {Signature · 1 line
2.33.0
Thanks.
Signature · 1 line
Dmitry