Skip to contentSkip to conversation

mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash

PATCH Superseded Andy Shevchenko 2 participants 3 messages Oct 1, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash

Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP. Add Ice Lake-N PCI ID to the driver list of supported devices.

The device can be found on MacBookPro16,2 [1].

[1]: https://linux-hardware.org/?probe=f1c5cf0c43

---
 drivers/mtd/spi-nor/controllers/intel-spi-pci.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi-nor/controllers/intel-spi-pci.c +1 -0
index 1bc53b8bb88a..f9bcd2dabb4f 100644
@@ -70,6 +70,7 @@ static const struct pci_device_id intel_spi_pci_ids[] = {
 	{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
 	{ PCI_VDEVICE(INTEL, 0x1bca), (unsigned long)&bxt_info },
 	{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
+	{ PCI_VDEVICE(INTEL, 0x38a4), (unsigned long)&bxt_info },
 	{ PCI_VDEVICE(INTEL, 0x43a4), (unsigned long)&cnl_info },
 	{ PCI_VDEVICE(INTEL, 0x4b24), (unsigned long)&bxt_info },
 	{ PCI_VDEVICE(INTEL, 0x4da4), (unsigned long)&bxt_info },
Signature · 1 line
2.33.0
#1 lore raw

Am 1. Oktober 2021 19:15:30 MESZ schrieb Andy Shevchenko <[email protected]>:

Quoted 8 lines

Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP. Add Ice Lake-N PCI ID to the driver list of supported devices.

The device can be found on MacBookPro16,2 [1].

[1]: https://linux-hardware.org/?probe=f1c5cf0c43

Hi Andy,

there is currently a rewrite of this driver (to use spi-mem) in progress:

https://lore.kernel.org/linux-mtd/[email protected]/

Could you try that series with your hardware?

-michael

#2 lore raw
Quoted 10 lines · Michael Walle

Am 1. Oktober 2021 19:15:30 MESZ schrieb Andy Shevchenko <[email protected]>:

Quoted 8 lines

Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP. Add Ice Lake-N PCI ID to the driver list of supported devices.

The device can be found on MacBookPro16,2 [1].

[1]: https://linux-hardware.org/?probe=f1c5cf0c43

Quoted 8 lines

Hi Andy,

there is currently a rewrite of this driver (to use spi-mem) in progress:

https://lore.kernel.org/linux-mtd/[email protected]/

Could you try that series with your hardware?

It's not mine - can't test myself. I'm helping to enable Linux on it. But okay, I postpone this till the reworked version will be applied.

Signature · 2 lines
With Best Regards,
Andy Shevchenko