drm/bridge: display-connector: fix an uninitialized pointer in probe()
Subsystems (4)
PATCH 1/1 drm/bridge: display-connector: fix an uninitialized pointer in probe()
The "label" pointer is used for debug output. The code assumes that it is either NULL or valid, but it is never set to NULL. It is either valid or uninitialized.
Fixes 0c275c30176b ("drm/bridge: Add bridge driver for display connectors")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/bridge/display-connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/display-connector.c +1 -1
@@ -107,7 +107,7 @@ static int display_connector_probe(struct platform_device *pdev) {struct display_connector *conn;unsigned int type; -const char *label; +const char *label =NULL ;int ret; conn =devm_kzalloc (&pdev->dev,sizeof (*conn),GFP_KERNEL );
Signature · 1 line
2.20.1
Sam Ravnborg
AppliedHi Dan,
Quoted 6 lines · Dan Carpenter
The "label" pointer is used for debug output. The code assumes that it is either NULL or valid, but it is never set to NULL. It is either valid or uninitialized.
Fixes 0c275c30176b ("drm/bridge: Add bridge driver for display connectors")Signed-off-by Dan Carpenter <[email protected]>
Thanks, applied to drm-misc-next.
It was IMO not urgent.
Sam