comment spelling errors
cover comment spelling errors
After finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments.
Stephen Hemminger (18):
node: fix typos
ipsec: fix spelling errors
eventdev: fix typo in comment
power: fix typo in comment
rcu: fix typo in comment
bpf: fix spelling in comments
acl: fix spelling errors
eal: fix typos in comments
net: fix spelling error in gtp comment
bbdev: fix typo in comment
pipeline: fix spellin error in comment
hash: fix typo in comment
rib: fix typo in comment
sched: fix typo in comment
vhost: fix typo in comment
ip_frag: fix typos
test: fix spelling errors in comments
test-pmd: fix spelling errors in comments
app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_compressdev_test_buffer.h | 4 ++-- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_malloc.c | 4 ++-- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_timer.c | 2 +- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- lib/bbdev/rte_bbdev.c | 2 +- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_validate.c | 4 ++-- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- lib/eventdev/rte_event_timer_adapter.c | 2 +- lib/hash/rte_thash.c | 2 +- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- lib/net/rte_gtp.h | 6 +++--- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- lib/pipeline/rte_swx_pipeline.h | 2 +- lib/power/power_acpi_cpufreq.c | 2 +- lib/rcu/rte_rcu_qsbr.h | 2 +- lib/rib/rte_rib6.c | 2 +- lib/sched/rte_sched.c | 2 +- lib/vhost/rte_vhost.h | 4 ++-- 46 files changed, 67 insertions(+), 67 deletions(-)
Signature · 1 line
2.30.2
PATCH 1/18 node: fix typos
Spelling errors in comments including doxygen
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
lib/node/ethdev_rx_priv.h +1 -1
@@ -71,7 +71,7 @@ struct ethdev_rx_node_main *ethdev_rx_get_node_data_get(void);* * Get the Ethernet Rx node. * -* @retrun +* @return * Pointer to the Ethernet Rx node. */ struct rte_node_register *ethdev_rx_node_get (void );
lib/node/ethdev_tx_priv.h +1 -1
@@ -50,7 +50,7 @@ struct ethdev_tx_node_main *ethdev_tx_node_data_get(void);* * Get the Ethernet Tx node. * -* @retrun +* @return * Pointer to the Ethernet Tx node. */ struct rte_node_register *ethdev_tx_node_get (void );
lib/node/ip4_rewrite_priv.h +1 -1
@@ -53,7 +53,7 @@ struct ip4_rewrite_node_main {* * Get the ipv4 rewrite node. * -* @retrun +* @return * Pointer to the ipv4 rewrite node. */ struct rte_node_register *ip4_rewrite_node_get (void );
Signature · 1 line
2.30.2
PATCH 2/18 ipsec: fix spelling errors
In reply to Stephen HemmingerLots of typos in comments found by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)
lib/ipsec/esp_inb.c +2 -2
@@ -415,7 +415,7 @@ trs_process_check(struct rte_mbuf *mb, struct rte_mbuf **ml,/* * packet checks for tunnel mode: -* - same as for trasnport mode +* - same as for transport mode * - esp tail next proto contains expected for that SA value */ static inline int32_t
@@ -501,7 +501,7 @@ trs_process_step3(struct rte_mbuf *mb)static inline void tun_process_step3 (struct rte_mbuf *mb,uint64_t txof_msk,uint64_t txof_val) { -/* reset mbuf metatdata: L2/L3 len, packet type */ +/* reset mbuf metadata: L2/L3 len, packet type */ mb->packet_type =RTE_PTYPE_UNKNOWN ; mb->tx_offload = (mb->tx_offload & txof_msk) | txof_val;
lib/ipsec/esp_outb.c +1 -1
@@ -525,7 +525,7 @@ cpu_outb_trs_pkt_prepare(const struct rte_ipsec_session *ss,/* * process outbound packets for SA with ESN support, -* for algorithms that require SQN.hibits to be implictly included +* for algorithms that require SQN.hibits to be implicitly included * into digest computation. * In that case we have to move ICV bytes back to their proper place. */
lib/ipsec/ipsec_sad.c +1 -1
@@ -62,7 +62,7 @@ EAL_REGISTER_TAILQ(rte_ipsec_sad_tailq)* Inserts a rule into an appropriate hash table, * updates the value for a given SPI in SPI_ONLY hash table * reflecting presence of more specific rule type in two LSBs. -* Updates a counter that reflects the number of rules whith the same SPI. +* Updates a counter that reflects the number of rules with the same SPI. */ static inline int add_specific(struct rte_ipsec_sad *sad, const void *key,
lib/ipsec/sa.c +1 -1
@@ -126,7 +126,7 @@ ipsec_sa_size(uint64_t type, uint32_t *wnd_sz, uint32_t *nb_bucket)/* * RFC 4303 recommends 64 as minimum window size. * there is no point to use ESN mode without SQN window, -* so make sure we have at least 64 window when ESN is enalbed. +* so make sure we have at least 64 window when ESN is enabled. */ wsz = ((type &RTE_IPSEC_SATP_ESN_MASK ) == RTE_IPSEC_SATP_ESN_DISABLE) ?
lib/ipsec/sa.h +1 -1
@@ -116,7 +116,7 @@ struct rte_ipsec_sa {* In case of SA handled by multiple threads *sqn* cacheline * could be shared by multiple cores. * To minimise performance impact, we try to locate in a separate -* place from other frequently accesed data. +* place from other frequently accessed data. */ union {uint64_t outb;
Signature · 1 line
2.30.2
PATCH 3/18 eventdev: fix typo in comment
In reply to Stephen HemmingerTypo in comment found by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/eventdev/rte_event_timer_adapter.c +1 -1
@@ -493,7 +493,7 @@ event_buffer_flush(struct event_buffer *bufp, uint8_t dev_id, uint8_t port_id,RTE_ASSERT (head_idx <EVENT_BUFFER_SZ && tail_idx <EVENT_BUFFER_SZ ); -/* Determine the largest contigous run we can attempt to enqueue to the +/* Determine the largest contiguous run we can attempt to enqueue to the * event device. */ if (head_idx > tail_idx)
Signature · 1 line
2.30.2
PATCH 4/18 power: fix typo in comment
In reply to Stephen HemmingerMore spelling errors caught by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/power/power_acpi_cpufreq.c +1 -1
@@ -159,7 +159,7 @@ power_get_available_freqs(struct acpi_power_info *pi) goto out; } -/* Store the available frequncies into power context */ +/* Store the available frequencies into power context */ for (i =0 , pi->nb_freqs =0 ; i < count; i++) {POWER_DEBUG_TRACE ("Lcore %u frequency[%d]: %s\n" , pi->lcore_id, i, freqs[i]);
Signature · 1 line
2.30.2
PATCH 5/18 rcu: fix typo in comment
In reply to Stephen HemmingerAnother codespell find.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rcu/rte_rcu_qsbr.h +1 -1
@@ -362,7 +362,7 @@ rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id)/* The reader can go offline only after the load of the * data structure is completed. i.e. any load of the -* data strcture can not move after this store. +* data structure can not move after this store. */ __atomic_store_n(&v->qsbr_cnt[thread_id].cnt,
Signature · 1 line
2.30.2
PATCH 6/18 bpf: fix spelling in comments
In reply to Stephen HemmingerFound by running codespell on the bpf implementation.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_validate.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
lib/bpf/bpf_jit_x86.c +1 -1
@@ -1245,7 +1245,7 @@ emit_epilog(struct bpf_jit_state *st)uint32_t i;int32_t spil, ofs; -/* if we allready have an epilog generate a jump to it */ +/* if we already have an epilog generate a jump to it */ if (st->exit.num++ !=0 ) {emit_abs_jmp (st, st->exit.off);return ;
lib/bpf/bpf_validate.c +2 -2
@@ -1723,7 +1723,7 @@ static const struct bpf_ins_check ins_chk[UINT8_MAX + 1] = {/* * make sure that instruction syntax is valid, -* and it fields don't violate partciular instrcution type restrictions. +* and it fields don't violate particular instruction type restrictions. */ static const char *check_syntax (const struct ebpf_insn *ins)
@@ -1981,7 +1981,7 @@ validate(struct bpf_verifier *bvf)/* * construct CFG, jcc nodes have to outgoing edges, -* 'exit' nodes - none, all others nodes have exaclty one +* 'exit' nodes - none, all others nodes have exactly one * outgoing edge. */ switch (ins->code) {
Signature · 1 line
2.30.2
PATCH 7/18 acl: fix spelling errors
In reply to Stephen HemmingerLots of little typos in comments
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
lib/acl/acl.h +2 -2
@@ -45,7 +45,7 @@ struct rte_acl_bitset {* Each transition is 64 bit value with the following format: * | node_type_specific : 32 | node_type : 3 | node_addr : 29 | * For all node types except RTE_ACL_NODE_MATCH, node_addr is an index -* to the start of the node in the transtions array. +* to the start of the node in the transitions array. * Few different node types are used: * RTE_ACL_NODE_MATCH: * node_addr value is and index into an array that contains the return value
@@ -66,7 +66,7 @@ struct rte_acl_bitset {* RTE_ACL_NODE_SINGLE: * always transitions to the same node regardless of the input value. * RTE_ACL_NODE_DFA: -* that node consits of up to 256 transitions. +* that node consists of up to 256 transitions. * In attempt to conserve space all transitions are divided into 4 consecutive * groups, by 64 transitions per group: * group64[i] contains transitions[i * 64, .. i * 64 + 63].
lib/acl/acl_bld.c +1 -1
@@ -1494,7 +1494,7 @@ acl_set_data_indexes(struct rte_acl_ctx *ctx)/* * Internal routine, performs 'build' phase of trie generation: * - setups build context. -* - analizes given set of rules. +* - analyzes given set of rules. * - builds internal tree(s). */ static int
lib/acl/acl_run_avx2.h +1 -1
@@ -125,7 +125,7 @@ acl_process_matches_avx2x8(const struct rte_acl_ctx *ctx,/* For each transition: put low 32 into tr_lo and high 32 into tr_hi */ ACL_TR_HILO (mm256, __m256, t0, t1, lo, hi); -/* Keep transitions wth NOMATCH intact. */ +/* Keep transitions with NOMATCH intact. */ *tr_lo =_mm256_blendv_epi8 (*tr_lo, lo, matches); *tr_hi =_mm256_blendv_epi8 (*tr_hi, hi, matches); }
Signature · 1 line
2.30.2
PATCH 8/18 eal: fix typos in comments
In reply to Stephen HemmingerMinor spelling errors.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
lib/eal/include/rte_function_versioning.h +1 -1
@@ -15,7 +15,7 @@/* * Provides backwards compatibility when updating exported functions. -* When a symol is exported from a library to provide an API, it also provides a +* When a symbol is exported from a library to provide an API, it also provides a * calling convention (ABI) that is embodied in its name, return type, * arguments, etc. On occasion that function may need to change to accommodate * new functionality, behavior, etc. When that occurs, it is desirable to
lib/eal/windows/include/fnmatch.h +1 -1
@@ -30,7 +30,7 @@ extern "C" {* with the given regular expression pattern. * * @param pattern -* regular expression notation decribing the pattern to match +* regular expression notation describing the pattern to match * * @param string * source string to searcg for the pattern
Signature · 1 line
2.30.2
PATCH 9/18 net: fix spelling error in gtp comment
In reply to Stephen HemmingerMore codespell finds.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/net/rte_gtp.h +3 -3
@@ -64,9 +64,9 @@ struct rte_gtp_hdr_ext_word {/** GTP header length */ #define RTE_ETHER_GTP_HLEN \ (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr)) -/* GTP next protocal type */ -#define RTE_GTP_TYPE_IPV4 0x40/**< GTP next protocal type IPv4 */ -#define RTE_GTP_TYPE_IPV6 0x60/**< GTP next protocal type IPv6 */ +/* GTP next protocol type */ +#define RTE_GTP_TYPE_IPV4 0x40/**< GTP next protocol type IPv4 */ +#define RTE_GTP_TYPE_IPV6 0x60/**< GTP next protocol type IPv6 */ /* GTP destination port number */ #define RTE_GTPC_UDP_PORT 2123/**< GTP-C UDP destination port */ #define RTE_GTPU_UDP_PORT 2152/**< GTP-U UDP destination port */
Signature · 1 line
2.30.2
PATCH 10/18 bbdev: fix typo in comment
In reply to Stephen HemmingerSigned-off-by Stephen Hemminger <[email protected]>
--- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/bbdev/rte_bbdev.c +1 -1
@@ -138,7 +138,7 @@ rte_bbdev_data_alloc(void) }/* -* Find data alocated for the device or if not found return first unused bbdev +* Find data allocated for the device or if not found return first unused bbdev * data. If all structures are in use and none is used by the device return * NULL. */
Signature · 1 line
2.30.2
PATCH 11/18 pipeline: fix spellin error in comment
In reply to Stephen HemmingerMinor typo
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/pipeline/rte_swx_pipeline.h +1 -1
@@ -620,7 +620,7 @@ struct rte_swx_pipeline_selector_params {const char *group_id_field_name;/** The set of fields used to select (through a hashing scheme) the -* member within the current group. Inputs into the seletion operation. +* member within the current group. Inputs into the selection operation. * Restriction: All the selector fields must be part of the same struct, * i.e. part of the same header or part of the meta-data structure. */
Signature · 1 line
2.30.2
PATCH 12/18 hash: fix typo in comment
In reply to Stephen HemmingerSigned-off-by Stephen Hemminger <[email protected]>
--- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/hash/rte_thash.c +1 -1
@@ -26,7 +26,7 @@ EAL_REGISTER_TAILQ(rte_thash_tailq)/** * Table of some irreducible polinomials over GF(2). -* For lfsr they are reperesented in BE bit order, and +* For lfsr they are represented in BE bit order, and * x^0 is masked out. * For example, poly x^5 + x^2 + 1 will be represented * as (101001b & 11111b) = 01001b = 0x9
Signature · 1 line
2.30.2
PATCH 13/18 rib: fix typo in comment
In reply to Stephen HemmingerSigned-off-by Stephen Hemminger <[email protected]>
--- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rib/rte_rib6.c +1 -1
@@ -199,7 +199,7 @@ rte_rib6_lookup_exact(struct rte_rib6 *rib, }/* -* Traverses on subtree and retreeves more specific routes +* Traverses on subtree and retrieves more specific routes * for a given in args ip/depth prefix * last = NULL means the first invocation */
Signature · 1 line
2.30.2
PATCH 14/18 sched: fix typo in comment
In reply to Stephen HemmingerSigned-off-by Stephen Hemminger <[email protected]>
--- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/sched/rte_sched.c +1 -1
@@ -579,7 +579,7 @@ rte_sched_subport_config_qsize(struct rte_sched_subport *subport) subport->qsize_add[0 ] =0 ; -/* Strict prority traffic class */ +/* Strict priority traffic class */ for (i =1 ; i <RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE ; i++) subport->qsize_add[i] = subport->qsize_add[i-1 ] + subport->qsize[i-1 ];
Signature · 1 line
2.30.2
PATCH 15/18 vhost: fix typo in comment
In reply to Stephen HemmingerSigned-off-by Stephen Hemminger <[email protected]>
--- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/vhost/rte_vhost.h +2 -2
@@ -776,7 +776,7 @@ rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx,/** * Set split inflight descriptor. * -* This function save descriptors that has been comsumed in available +* This function save descriptors that has been consumed in available * ring * * @param vid
@@ -796,7 +796,7 @@ rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx,/** * Set packed inflight descriptor and get corresponding inflight entry * -* This function save descriptors that has been comsumed +* This function save descriptors that has been consumed * * @param vid * vhost device ID
Signature · 1 line
2.30.2
PATCH 16/18 ip_frag: fix typos
In reply to Stephen HemmingerMinor typos in comment.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/ip_frag/rte_ipv4_reassembly.c +1 -1
@@ -80,7 +80,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp)/* * Process new mbuf with fragment of IPV4 packet. -* Incoming mbuf should have it's l2_len/l3_len fields setuped correclty. +* Incoming mbuf should have it's l2_len/l3_len fields setup correctly. * @param tbl * Table where to lookup/add the fragmented packet. * @param mb
Signature · 1 line
2.30.2
PATCH 17/18 test: fix spelling errors in comments
In reply to Stephen HemmingerLots of little typos
Signed-off-by Stephen Hemminger <[email protected]>
--- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_compressdev_test_buffer.h | 4 ++-- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_malloc.c | 4 ++-- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_timer.c | 2 +- 17 files changed, 31 insertions(+), 31 deletions(-)
app/test/test_atomic.c +1 -1
@@ -88,7 +88,7 @@* * - Invoke ``test_atomic_exchange`` on each lcore. Before doing * anything else, the cores wait for a synchronization event. -* Each core then does the follwoing for N iterations: +* Each core then does the following for N iterations: * * Generate a new token with a data integrity check * Exchange the new token for previously generated token
app/test/test_barrier.c +1 -1
@@ -66,7 +66,7 @@ struct plock_test {struct lcore_plock_test {struct plock_test *pt[2 ];/* shared, lock-protected data */ uint64_t sum[2 ];/* local copy of the shared data */ -uint64_t iter;/* number of iterations to perfom */ +uint64_t iter;/* number of iterations to perform */ uint32_t lc;/* given lcore id */ };
app/test/test_bpf.c +1 -1
@@ -2391,7 +2391,7 @@ static const struct ebpf_insn test_call5_prog[] = { }, }; -/* String comparision impelementation, return 0 if equal else difference */ +/* String comparison implementation, return 0 if equal else difference */ static uint32_t dummy_func5 (const char *s1,const char *s2) {
app/test/test_compressdev.c +1 -1
@@ -2035,7 +2035,7 @@ test_deflate_comp_decomp(const struct interim_data_params *int_data, test_priv_data.all_decomp_data = &all_decomp_data; test_priv_data.decomp_produced_data_size = &decomp_produced_data_size; - test_priv_data.num_priv_xforms =0 ;/* it's used for deompression only */ + test_priv_data.num_priv_xforms =0 ;/* it's used for decompression only */ capa =rte_compressdev_capability_get (0 ,RTE_COMP_ALGO_DEFLATE );if (capa ==NULL ) {
app/test/test_compressdev_test_buffer.h +2 -2
@@ -105,7 +105,7 @@ static const char test_buf_shakespeare[] ="\n" "OLIVER |\n" " |\n" -"JAQUES (JAQUES DE BOYS:) | sons of Sir Rowland de Boys.\n" +"JACQUES (JACQUES DE BOYS:) | sons of Sir Rowland de Boys.\n" " |\n" "ORLANDO |\n" "\n"
@@ -168,7 +168,7 @@ static const char test_buf_shakespeare[] =" bequeathed me by will but poor a thousand crowns,\n" " and, as thou sayest, charged my brother, on his\n" " blessing, to breed me well: and there begins my\n" -" sadness. My brother Jaques he keeps at school, and\n" +" sadness. My brother Jacques he keeps at school, and\n" " report speaks goldenly of his profit: for my part,\n" " he keeps me rustically at home, or, to speak more\n" " properly, stays me here at home unkept; for call you\n"
app/test/test_func_reentrancy.c +3 -3
@@ -242,7 +242,7 @@ hash_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple times simultaneously */ +/* create multiple times simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (hash_name,sizeof (hash_name),"fr_test_%d_%d" , lcore_self, i); hash_params.name = hash_name;
@@ -306,7 +306,7 @@ fbk_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (fbk_name,sizeof (fbk_name),"fr_test_%d_%d" , lcore_self, i); fbk_params.name = fbk_name;
@@ -368,7 +368,7 @@ lpm_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_LPM_ITER_TIMES ; i++) {snprintf (lpm_name,sizeof (lpm_name),"fr_test_%d_%d" , lcore_self, i); lpm =rte_lpm_create (lpm_name,SOCKET_ID_ANY , &config);
app/test/test_ipsec.c +1 -1
@@ -654,7 +654,7 @@ create_crypto_session(struct ipsec_unitest_params *ut,if (s ==NULL )return -ENOMEM ; -/* initiliaze SA crypto session for device */ +/* initialize SA crypto session for device */ rc =rte_cryptodev_sym_session_init (dev_id, s, ut->crypto_xforms, qp->mp_session_private);if (rc ==0 ) {
app/test/test_link_bonding.c +1 -1
@@ -3041,7 +3041,7 @@ test_balance_tx_burst_slave_tx_fail(void) first_tx_fail_idx =TEST_BAL_SLAVE_TX_FAIL_BURST_SIZE_1 -TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; -/* copy mbuf referneces for expected transmission failures */ +/* copy mbuf references for expected transmission failures */ for (i =0 ; i <TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; i++) expected_fail_pkts[i] = pkts_burst_1[i + first_tx_fail_idx];
app/test/test_lpm.c +3 -3
@@ -179,7 +179,7 @@ test3(void) status =rte_lpm_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -217,7 +217,7 @@ test4(void) status =rte_lpm_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -255,7 +255,7 @@ test5(void) status =rte_lpm_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
app/test/test_lpm6.c +7 -7
@@ -261,7 +261,7 @@ test4(void) status =rte_lpm6_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -299,7 +299,7 @@ test5(void) status =rte_lpm6_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -337,7 +337,7 @@ test6(void) status =rte_lpm6_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -375,7 +375,7 @@ test7(void) status =rte_lpm6_lookup_bulk_func (NULL , ip, next_hop_return,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -413,7 +413,7 @@ test8(void) status =rte_lpm6_delete_bulk_func (NULL , ip, depth,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -433,7 +433,7 @@ test8(void)/* * Call add, lookup and delete for a single rule with depth < 24. * Check all the combinations for the first three bytes that result in a hit. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test9 (void )
@@ -1738,7 +1738,7 @@ test27(void)* Call add, lookup and delete for a single rule with maximum 21bit next_hop * size. * Check that next_hop returned from lookup is equal to provisioned value. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test28 (void )
app/test/test_malloc.c +2 -2
@@ -603,7 +603,7 @@ test_realloc_numa(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 )printf ("WARNING: realloc_socket test needs memory on multiple sockets!\n" );
@@ -971,7 +971,7 @@ test_alloc_socket(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 ) {printf ("WARNING: alloc_socket test needs memory on multiple sockets!\n" ); }
app/test/test_mbuf.c +1 -1
@@ -1148,7 +1148,7 @@ test_refcnt_mbuf(void)rte_eal_mp_wait_lcore (); -/* check that we porcessed all references */ +/* check that we processed all references */ tref =0 ; main_lcore =rte_get_main_lcore ();
app/test/test_mempool.c +1 -1
@@ -628,7 +628,7 @@ test_mempool(void)if (test_mempool_basic_ex (mp_nocache) <0 )GOTO_ERR (ret, err); -/* mempool operation test based on single producer and single comsumer */ +/* mempool operation test based on single producer and single consumer */ if (test_mempool_sp_sc () <0 )GOTO_ERR (ret, err);
app/test/test_mempool_perf.c +1 -1
@@ -88,7 +88,7 @@ static uint32_t synchro;static unsigned n_get_bulk;static unsigned n_put_bulk; -/* number of objects retrived from mempool before putting them back */ +/* number of objects retrieved from mempool before putting them back */ static unsigned n_keep;/* number of enqueues / dequeues */
app/test/test_meter.c +3 -3
@@ -444,7 +444,7 @@ tm_test_srtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -551,7 +551,7 @@ tm_test_trtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -648,7 +648,7 @@ tm_test_trtcm_rfc4115_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
app/test/test_pmd_perf.c +1 -1
@@ -753,7 +753,7 @@ test_pmd_perf(void)"rte_eth_dev_start: err=%d, port=%d\n" , ret, portid); -/* always eanble promiscuous */ +/* always enable promiscuous */ ret =rte_eth_promiscuous_enable (portid);if (ret !=0 ) rte_exit(EXIT_FAILURE,
app/test/test_timer.c +1 -1
@@ -432,7 +432,7 @@ timer_basic_cb(struct rte_timer *tim, void *arg)return ; } -/* Explicitelly stop timer 0. Once stop() called, we can even +/* Explicitly stop timer 0. Once stop() called, we can even * erase the content of the structure: it is not referenced * anymore by any code (in case of dynamic structure, it can * be freed) */
Signature · 1 line
2.30.2
PATCH 18/18 test-pmd: fix spelling errors in comments
In reply to Stephen HemmingerMore typos
Signed-off-by Stephen Hemminger <[email protected]>
--- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
app/test-pmd/cmdline.c +1 -1
@@ -3670,7 +3670,7 @@ parse_item_list(const char *str, const char *item_name, unsigned int max_items,return nb_item;/* -* Then, check that all values in the list are differents. +* Then, check that all values in the list are different. * No optimization here... */ for (i =0 ; i < nb_item; i++) {
app/test-pmd/config.c +2 -2
@@ -2777,7 +2777,7 @@ port_rss_reta_info(portid_t port_id, }/* -* Displays the RSS hash functions of a port, and, optionaly, the RSS hash +* Displays the RSS hash functions of a port, and, optionally, the RSS hash * key of the port. */ void
@@ -4932,7 +4932,7 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx) { port->mc_addr_nb--;if (addr_idx == port->mc_addr_nb) { -/* No need to recompact the set of multicast addressses. */ +/* No need to recompact the set of multicast addresses. */ if (port->mc_addr_nb ==0 ) {/* free the pool of multicast addresses. */ free (port->mc_addr_pool);
app/test-pmd/icmpecho.c +1 -1
@@ -54,7 +54,7 @@ arp_op_name(uint16_t arp_op)default :break ; } -return "Unkwown ARP op" ; +return "Unknown ARP op" ; } static const char *
Signature · 1 line
2.30.2
v2 cover Fix spelling errors
In reply to Stephen HemmingerAfter finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments.
v2 - checkpatch wants more than just subject
remove autocorrect of historical text
Stephen Hemminger (18):
node: fix typos
ipsec: fix spelling errors
eventdev: fix typo in comment
power: fix typo in comment
rcu: fix typo in comment
bpf: fix spelling in comments
acl: fix spelling errors
eal: fix typos in comments
net: fix spelling error in gtp comment
bbdev: fix typo in comment
pipeline: fix spellin error in comment
hash: fix typo in comment
rib: fix typo in comment
sched: fix typo in comment
vhost: fix typo in comment
ip_frag: fix typos
test-pmd: fix spelling errors in comments
test: fix spelling errors in comments
app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_malloc.c | 4 ++-- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_timer.c | 2 +- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- lib/bbdev/rte_bbdev.c | 2 +- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_validate.c | 4 ++-- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- lib/eventdev/rte_event_timer_adapter.c | 2 +- lib/hash/rte_thash.c | 2 +- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- lib/net/rte_gtp.h | 6 +++--- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- lib/pipeline/rte_swx_pipeline.h | 2 +- lib/power/power_acpi_cpufreq.c | 2 +- lib/rcu/rte_rcu_qsbr.h | 2 +- lib/rib/rte_rib6.c | 2 +- lib/sched/rte_sched.c | 2 +- lib/vhost/rte_vhost.h | 4 ++-- 45 files changed, 65 insertions(+), 65 deletions(-)
Signature · 1 line
2.30.2
PATCH v2 1/18 node: fix typos
Spelling errors in comments including doxygen
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
lib/node/ethdev_rx_priv.h +1 -1
@@ -71,7 +71,7 @@ struct ethdev_rx_node_main *ethdev_rx_get_node_data_get(void);* * Get the Ethernet Rx node. * -* @retrun +* @return * Pointer to the Ethernet Rx node. */ struct rte_node_register *ethdev_rx_node_get (void );
lib/node/ethdev_tx_priv.h +1 -1
@@ -50,7 +50,7 @@ struct ethdev_tx_node_main *ethdev_tx_node_data_get(void);* * Get the Ethernet Tx node. * -* @retrun +* @return * Pointer to the Ethernet Tx node. */ struct rte_node_register *ethdev_tx_node_get (void );
lib/node/ip4_rewrite_priv.h +1 -1
@@ -53,7 +53,7 @@ struct ip4_rewrite_node_main {* * Get the ipv4 rewrite node. * -* @retrun +* @return * Pointer to the ipv4 rewrite node. */ struct rte_node_register *ip4_rewrite_node_get (void );
Signature · 1 line
2.30.2
PATCH v2 2/18 ipsec: fix spelling errors
In reply to Stephen HemmingerLots of typos in comments found by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)
lib/ipsec/esp_inb.c +2 -2
@@ -415,7 +415,7 @@ trs_process_check(struct rte_mbuf *mb, struct rte_mbuf **ml,/* * packet checks for tunnel mode: -* - same as for trasnport mode +* - same as for transport mode * - esp tail next proto contains expected for that SA value */ static inline int32_t
@@ -501,7 +501,7 @@ trs_process_step3(struct rte_mbuf *mb)static inline void tun_process_step3 (struct rte_mbuf *mb,uint64_t txof_msk,uint64_t txof_val) { -/* reset mbuf metatdata: L2/L3 len, packet type */ +/* reset mbuf metadata: L2/L3 len, packet type */ mb->packet_type =RTE_PTYPE_UNKNOWN ; mb->tx_offload = (mb->tx_offload & txof_msk) | txof_val;
lib/ipsec/esp_outb.c +1 -1
@@ -525,7 +525,7 @@ cpu_outb_trs_pkt_prepare(const struct rte_ipsec_session *ss,/* * process outbound packets for SA with ESN support, -* for algorithms that require SQN.hibits to be implictly included +* for algorithms that require SQN.hibits to be implicitly included * into digest computation. * In that case we have to move ICV bytes back to their proper place. */
lib/ipsec/ipsec_sad.c +1 -1
@@ -62,7 +62,7 @@ EAL_REGISTER_TAILQ(rte_ipsec_sad_tailq)* Inserts a rule into an appropriate hash table, * updates the value for a given SPI in SPI_ONLY hash table * reflecting presence of more specific rule type in two LSBs. -* Updates a counter that reflects the number of rules whith the same SPI. +* Updates a counter that reflects the number of rules with the same SPI. */ static inline int add_specific(struct rte_ipsec_sad *sad, const void *key,
lib/ipsec/sa.c +1 -1
@@ -126,7 +126,7 @@ ipsec_sa_size(uint64_t type, uint32_t *wnd_sz, uint32_t *nb_bucket)/* * RFC 4303 recommends 64 as minimum window size. * there is no point to use ESN mode without SQN window, -* so make sure we have at least 64 window when ESN is enalbed. +* so make sure we have at least 64 window when ESN is enabled. */ wsz = ((type &RTE_IPSEC_SATP_ESN_MASK ) == RTE_IPSEC_SATP_ESN_DISABLE) ?
lib/ipsec/sa.h +1 -1
@@ -116,7 +116,7 @@ struct rte_ipsec_sa {* In case of SA handled by multiple threads *sqn* cacheline * could be shared by multiple cores. * To minimise performance impact, we try to locate in a separate -* place from other frequently accesed data. +* place from other frequently accessed data. */ union {uint64_t outb;
Signature · 1 line
2.30.2
PATCH v2 3/18 eventdev: fix typo in comment
In reply to Stephen HemmingerTypo in comment found by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/eventdev/rte_event_timer_adapter.c +1 -1
@@ -493,7 +493,7 @@ event_buffer_flush(struct event_buffer *bufp, uint8_t dev_id, uint8_t port_id,RTE_ASSERT (head_idx <EVENT_BUFFER_SZ && tail_idx <EVENT_BUFFER_SZ ); -/* Determine the largest contigous run we can attempt to enqueue to the +/* Determine the largest contiguous run we can attempt to enqueue to the * event device. */ if (head_idx > tail_idx)
Signature · 1 line
2.30.2
PATCH v2 4/18 power: fix typo in comment
In reply to Stephen HemmingerMore spelling errors caught by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/power/power_acpi_cpufreq.c +1 -1
@@ -159,7 +159,7 @@ power_get_available_freqs(struct acpi_power_info *pi) goto out; } -/* Store the available frequncies into power context */ +/* Store the available frequencies into power context */ for (i =0 , pi->nb_freqs =0 ; i < count; i++) {POWER_DEBUG_TRACE ("Lcore %u frequency[%d]: %s\n" , pi->lcore_id, i, freqs[i]);
Signature · 1 line
2.30.2
PATCH v2 5/18 rcu: fix typo in comment
In reply to Stephen HemmingerAnother codespell find.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rcu/rte_rcu_qsbr.h +1 -1
@@ -362,7 +362,7 @@ rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id)/* The reader can go offline only after the load of the * data structure is completed. i.e. any load of the -* data strcture can not move after this store. +* data structure can not move after this store. */ __atomic_store_n(&v->qsbr_cnt[thread_id].cnt,
Signature · 1 line
2.30.2
PATCH v2 6/18 bpf: fix spelling in comments
In reply to Stephen HemmingerFound by running codespell on the bpf implementation.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_validate.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
lib/bpf/bpf_jit_x86.c +1 -1
@@ -1245,7 +1245,7 @@ emit_epilog(struct bpf_jit_state *st)uint32_t i;int32_t spil, ofs; -/* if we allready have an epilog generate a jump to it */ +/* if we already have an epilog generate a jump to it */ if (st->exit.num++ !=0 ) {emit_abs_jmp (st, st->exit.off);return ;
lib/bpf/bpf_validate.c +2 -2
@@ -1723,7 +1723,7 @@ static const struct bpf_ins_check ins_chk[UINT8_MAX + 1] = {/* * make sure that instruction syntax is valid, -* and it fields don't violate partciular instrcution type restrictions. +* and it fields don't violate particular instruction type restrictions. */ static const char *check_syntax (const struct ebpf_insn *ins)
@@ -1981,7 +1981,7 @@ validate(struct bpf_verifier *bvf)/* * construct CFG, jcc nodes have to outgoing edges, -* 'exit' nodes - none, all others nodes have exaclty one +* 'exit' nodes - none, all others nodes have exactly one * outgoing edge. */ switch (ins->code) {
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments
2021-09-09 11:10 (UTC-0700), Stephen Hemminger:
[...]
lib/bpf/bpf_validate.c static const struct bpf_ins_check ins_chk[UINT8_MAX + 1] = { · line 1726
Quoted 10 lines
lib/bpf/bpf_validate.c +1
-1@@ -1723,7 +1723,7 @@ static const struct bpf_ins_check ins_chk[UINT8_MAX + 1] = {/* * make sure that instruction syntax is valid, -* and it fields don't violate partciular instrcution type restrictions. +* and it fields don't violate particular instruction type restrictions.
Also "it" -> "its".
lib/bpf/bpf_validate.c validate(struct bpf_verifier *bvf) · line 1984
Quoted 9 lines
lib/bpf/bpf_validate.c +1
-1*/ static const char *check_syntax (const struct ebpf_insn *ins)@@ -1981,7 +1981,7 @@ validate(struct bpf_verifier *bvf)/* * construct CFG, jcc nodes have to outgoing edges, -* 'exit' nodes - none, all others nodes have exaclty one +* 'exit' nodes - none, all others nodes have exactly one
Also "others" -> "other".
Quoted 3 lines
lib/bpf/bpf_validate.c +0
-0* outgoing edge. */ switch (ins->code) {
Re: [dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments
Quoted 20 lines · On Thu, 9 Sep 2021 22:49:56 +0300 Dmitry Kozlyuk <[email protected]>…
2021-09-09 11:10 (UTC-0700), Stephen Hemminger:
[...]lib/bpf/bpf_validate.c static const struct bpf_ins_check ins_chk[UINT8_MAX + 1] = { · line 1726
Quoted 10 lines
lib/bpf/bpf_validate.c +1
-1@@ -1723,7 +1723,7 @@ static const struct bpf_ins_check ins_chk[UINT8_MAX + 1] = {/* * make sure that instruction syntax is valid, -* and it fields don't violate partciular instrcution type restrictions. +* and it fields don't violate particular instruction type restrictions. Also "it" -> "its".
Quoted 5 lines
lib/bpf/bpf_validate.c +0
-0*/ static const char *check_syntax (const struct ebpf_insn *ins)@@ -1981,7 +1981,7 @@ validate(struct bpf_verifier *bvf)
Quoted 11 lines
lib/bpf/bpf_validate.c validate(struct bpf_verifier *bvf) · line 1984
Quoted 4 lines
lib/bpf/bpf_validate.c +1
-1/* * construct CFG, jcc nodes have to outgoing edges, -* 'exit' nodes - none, all others nodes have exaclty one +* 'exit' nodes - none, all others nodes have exactly one Also "others" -> "other".
Quoted 3 lines
lib/bpf/bpf_validate.c +0
-0* outgoing edge. */ switch (ins->code) {
Good catch, codespell and others don't check grammar.
PATCH v2 7/18 acl: fix spelling errors
In reply to Stephen HemmingerLots of little typos in comments
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
lib/acl/acl.h +2 -2
@@ -45,7 +45,7 @@ struct rte_acl_bitset {* Each transition is 64 bit value with the following format: * | node_type_specific : 32 | node_type : 3 | node_addr : 29 | * For all node types except RTE_ACL_NODE_MATCH, node_addr is an index -* to the start of the node in the transtions array. +* to the start of the node in the transitions array. * Few different node types are used: * RTE_ACL_NODE_MATCH: * node_addr value is and index into an array that contains the return value
@@ -66,7 +66,7 @@ struct rte_acl_bitset {* RTE_ACL_NODE_SINGLE: * always transitions to the same node regardless of the input value. * RTE_ACL_NODE_DFA: -* that node consits of up to 256 transitions. +* that node consists of up to 256 transitions. * In attempt to conserve space all transitions are divided into 4 consecutive * groups, by 64 transitions per group: * group64[i] contains transitions[i * 64, .. i * 64 + 63].
lib/acl/acl_bld.c +1 -1
@@ -1494,7 +1494,7 @@ acl_set_data_indexes(struct rte_acl_ctx *ctx)/* * Internal routine, performs 'build' phase of trie generation: * - setups build context. -* - analizes given set of rules. +* - analyzes given set of rules. * - builds internal tree(s). */ static int
lib/acl/acl_run_avx2.h +1 -1
@@ -125,7 +125,7 @@ acl_process_matches_avx2x8(const struct rte_acl_ctx *ctx,/* For each transition: put low 32 into tr_lo and high 32 into tr_hi */ ACL_TR_HILO (mm256, __m256, t0, t1, lo, hi); -/* Keep transitions wth NOMATCH intact. */ +/* Keep transitions with NOMATCH intact. */ *tr_lo =_mm256_blendv_epi8 (*tr_lo, lo, matches); *tr_hi =_mm256_blendv_epi8 (*tr_hi, hi, matches); }
Signature · 1 line
2.30.2
PATCH v2 8/18 eal: fix typos in comments
In reply to Stephen HemmingerMinor spelling errors.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
lib/eal/include/rte_function_versioning.h +1 -1
@@ -15,7 +15,7 @@/* * Provides backwards compatibility when updating exported functions. -* When a symol is exported from a library to provide an API, it also provides a +* When a symbol is exported from a library to provide an API, it also provides a * calling convention (ABI) that is embodied in its name, return type, * arguments, etc. On occasion that function may need to change to accommodate * new functionality, behavior, etc. When that occurs, it is desirable to
lib/eal/windows/include/fnmatch.h +1 -1
@@ -30,7 +30,7 @@ extern "C" {* with the given regular expression pattern. * * @param pattern -* regular expression notation decribing the pattern to match +* regular expression notation describing the pattern to match * * @param string * source string to searcg for the pattern
Signature · 1 line
2.30.2
PATCH v2 9/18 net: fix spelling error in gtp comment
In reply to Stephen HemmingerMore codespell finds.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/net/rte_gtp.h +3 -3
@@ -64,9 +64,9 @@ struct rte_gtp_hdr_ext_word {/** GTP header length */ #define RTE_ETHER_GTP_HLEN \ (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr)) -/* GTP next protocal type */ -#define RTE_GTP_TYPE_IPV4 0x40/**< GTP next protocal type IPv4 */ -#define RTE_GTP_TYPE_IPV6 0x60/**< GTP next protocal type IPv6 */ +/* GTP next protocol type */ +#define RTE_GTP_TYPE_IPV4 0x40/**< GTP next protocol type IPv4 */ +#define RTE_GTP_TYPE_IPV6 0x60/**< GTP next protocol type IPv6 */ /* GTP destination port number */ #define RTE_GTPC_UDP_PORT 2123/**< GTP-C UDP destination port */ #define RTE_GTPU_UDP_PORT 2152/**< GTP-U UDP destination port */
Signature · 1 line
2.30.2
PATCH v2 10/18 bbdev: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/bbdev/rte_bbdev.c +1 -1
@@ -138,7 +138,7 @@ rte_bbdev_data_alloc(void) }/* -* Find data alocated for the device or if not found return first unused bbdev +* Find data allocated for the device or if not found return first unused bbdev * data. If all structures are in use and none is used by the device return * NULL. */
Signature · 1 line
2.30.2
PATCH v2 11/18 pipeline: fix spellin error in comment
In reply to Stephen HemmingerMinor typo
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/pipeline/rte_swx_pipeline.h +1 -1
@@ -620,7 +620,7 @@ struct rte_swx_pipeline_selector_params {const char *group_id_field_name;/** The set of fields used to select (through a hashing scheme) the -* member within the current group. Inputs into the seletion operation. +* member within the current group. Inputs into the selection operation. * Restriction: All the selector fields must be part of the same struct, * i.e. part of the same header or part of the meta-data structure. */
Signature · 1 line
2.30.2
PATCH v2 12/18 hash: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/hash/rte_thash.c +1 -1
@@ -26,7 +26,7 @@ EAL_REGISTER_TAILQ(rte_thash_tailq)/** * Table of some irreducible polinomials over GF(2). -* For lfsr they are reperesented in BE bit order, and +* For lfsr they are represented in BE bit order, and * x^0 is masked out. * For example, poly x^5 + x^2 + 1 will be represented * as (101001b & 11111b) = 01001b = 0x9
Signature · 1 line
2.30.2
PATCH v2 13/18 rib: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rib/rte_rib6.c +1 -1
@@ -199,7 +199,7 @@ rte_rib6_lookup_exact(struct rte_rib6 *rib, }/* -* Traverses on subtree and retreeves more specific routes +* Traverses on subtree and retrieves more specific routes * for a given in args ip/depth prefix * last = NULL means the first invocation */
Signature · 1 line
2.30.2
PATCH v2 14/18 sched: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/sched/rte_sched.c +1 -1
@@ -579,7 +579,7 @@ rte_sched_subport_config_qsize(struct rte_sched_subport *subport) subport->qsize_add[0 ] =0 ; -/* Strict prority traffic class */ +/* Strict priority traffic class */ for (i =1 ; i <RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE ; i++) subport->qsize_add[i] = subport->qsize_add[i-1 ] + subport->qsize[i-1 ];
Signature · 1 line
2.30.2
PATCH v2 15/18 vhost: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/vhost/rte_vhost.h +2 -2
@@ -776,7 +776,7 @@ rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx,/** * Set split inflight descriptor. * -* This function save descriptors that has been comsumed in available +* This function save descriptors that has been consumed in available * ring * * @param vid
@@ -796,7 +796,7 @@ rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx,/** * Set packed inflight descriptor and get corresponding inflight entry * -* This function save descriptors that has been comsumed +* This function save descriptors that has been consumed * * @param vid * vhost device ID
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v2 15/18] vhost: fix typo in comment
Quoted 12 lines · Stephen Hemminger
Yet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>--- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)lib/vhost/rte_vhost.h +0
-0
lib/vhost/rte_vhost.h rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx, · line 779
Quoted 5 lines
lib/vhost/rte_vhost.h +1
-1@@ -776,7 +776,7 @@ rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx,/** * Set split inflight descriptor. * -* This function save descriptors that has been comsumed in available +* This function save descriptors that has been consumed in available
While at it:
s/has/have/
lib/vhost/rte_vhost.h rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx, · line 799
Quoted 9 lines
lib/vhost/rte_vhost.h +1
-1* ring * * @param vid @@ -796,7 +796,7 @@ rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx,/** * Set packed inflight descriptor and get corresponding inflight entry * -* This function save descriptors that has been comsumed +* This function save descriptors that has been consumed
Ditto.
lib/vhost/rte_vhost.h rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx, · line 802
Quoted 4 lines
lib/vhost/rte_vhost.h +0
-0* * @param vid * vhost device ID
Maxime
PATCH v2 16/18 ip_frag: fix typos
In reply to Stephen HemmingerMinor typos in comment.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/ip_frag/rte_ipv4_reassembly.c +1 -1
@@ -80,7 +80,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp)/* * Process new mbuf with fragment of IPV4 packet. -* Incoming mbuf should have it's l2_len/l3_len fields setuped correclty. +* Incoming mbuf should have it's l2_len/l3_len fields setup correctly. * @param tbl * Table where to lookup/add the fragmented packet. * @param mb
Signature · 1 line
2.30.2
PATCH v2 17/18 test-pmd: fix spelling errors in comments
In reply to Stephen HemmingerMore typos
Signed-off-by Stephen Hemminger <[email protected]>
--- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
app/test-pmd/cmdline.c +1 -1
@@ -3670,7 +3670,7 @@ parse_item_list(const char *str, const char *item_name, unsigned int max_items,return nb_item;/* -* Then, check that all values in the list are differents. +* Then, check that all values in the list are different. * No optimization here... */ for (i =0 ; i < nb_item; i++) {
app/test-pmd/config.c +2 -2
@@ -2777,7 +2777,7 @@ port_rss_reta_info(portid_t port_id, }/* -* Displays the RSS hash functions of a port, and, optionaly, the RSS hash +* Displays the RSS hash functions of a port, and, optionally, the RSS hash * key of the port. */ void
@@ -4932,7 +4932,7 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx) { port->mc_addr_nb--;if (addr_idx == port->mc_addr_nb) { -/* No need to recompact the set of multicast addressses. */ +/* No need to recompact the set of multicast addresses. */ if (port->mc_addr_nb ==0 ) {/* free the pool of multicast addresses. */ free (port->mc_addr_pool);
app/test-pmd/icmpecho.c +1 -1
@@ -54,7 +54,7 @@ arp_op_name(uint16_t arp_op)default :break ; } -return "Unkwown ARP op" ; +return "Unknown ARP op" ; } static const char *
Signature · 1 line
2.30.2
PATCH v2 18/18 test: fix spelling errors in comments
In reply to Stephen HemmingerLots of little typos.
Signed-off-by Stephen Hemminger <[email protected]>
--- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_malloc.c | 4 ++-- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_timer.c | 2 +- 16 files changed, 29 insertions(+), 29 deletions(-)
app/test/test_atomic.c +1 -1
@@ -88,7 +88,7 @@* * - Invoke ``test_atomic_exchange`` on each lcore. Before doing * anything else, the cores wait for a synchronization event. -* Each core then does the follwoing for N iterations: +* Each core then does the following for N iterations: * * Generate a new token with a data integrity check * Exchange the new token for previously generated token
app/test/test_barrier.c +1 -1
@@ -66,7 +66,7 @@ struct plock_test {struct lcore_plock_test {struct plock_test *pt[2 ];/* shared, lock-protected data */ uint64_t sum[2 ];/* local copy of the shared data */ -uint64_t iter;/* number of iterations to perfom */ +uint64_t iter;/* number of iterations to perform */ uint32_t lc;/* given lcore id */ };
app/test/test_bpf.c +1 -1
@@ -2391,7 +2391,7 @@ static const struct ebpf_insn test_call5_prog[] = { }, }; -/* String comparision impelementation, return 0 if equal else difference */ +/* String comparison implementation, return 0 if equal else difference */ static uint32_t dummy_func5 (const char *s1,const char *s2) {
app/test/test_compressdev.c +1 -1
@@ -2035,7 +2035,7 @@ test_deflate_comp_decomp(const struct interim_data_params *int_data, test_priv_data.all_decomp_data = &all_decomp_data; test_priv_data.decomp_produced_data_size = &decomp_produced_data_size; - test_priv_data.num_priv_xforms =0 ;/* it's used for deompression only */ + test_priv_data.num_priv_xforms =0 ;/* it's used for decompression only */ capa =rte_compressdev_capability_get (0 ,RTE_COMP_ALGO_DEFLATE );if (capa ==NULL ) {
app/test/test_func_reentrancy.c +3 -3
@@ -242,7 +242,7 @@ hash_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple times simultaneously */ +/* create multiple times simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (hash_name,sizeof (hash_name),"fr_test_%d_%d" , lcore_self, i); hash_params.name = hash_name;
@@ -306,7 +306,7 @@ fbk_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (fbk_name,sizeof (fbk_name),"fr_test_%d_%d" , lcore_self, i); fbk_params.name = fbk_name;
@@ -368,7 +368,7 @@ lpm_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_LPM_ITER_TIMES ; i++) {snprintf (lpm_name,sizeof (lpm_name),"fr_test_%d_%d" , lcore_self, i); lpm =rte_lpm_create (lpm_name,SOCKET_ID_ANY , &config);
app/test/test_ipsec.c +1 -1
@@ -654,7 +654,7 @@ create_crypto_session(struct ipsec_unitest_params *ut,if (s ==NULL )return -ENOMEM ; -/* initiliaze SA crypto session for device */ +/* initialize SA crypto session for device */ rc =rte_cryptodev_sym_session_init (dev_id, s, ut->crypto_xforms, qp->mp_session_private);if (rc ==0 ) {
app/test/test_link_bonding.c +1 -1
@@ -3041,7 +3041,7 @@ test_balance_tx_burst_slave_tx_fail(void) first_tx_fail_idx =TEST_BAL_SLAVE_TX_FAIL_BURST_SIZE_1 -TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; -/* copy mbuf referneces for expected transmission failures */ +/* copy mbuf references for expected transmission failures */ for (i =0 ; i <TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; i++) expected_fail_pkts[i] = pkts_burst_1[i + first_tx_fail_idx];
app/test/test_lpm.c +3 -3
@@ -179,7 +179,7 @@ test3(void) status =rte_lpm_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -217,7 +217,7 @@ test4(void) status =rte_lpm_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -255,7 +255,7 @@ test5(void) status =rte_lpm_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
app/test/test_lpm6.c +7 -7
@@ -261,7 +261,7 @@ test4(void) status =rte_lpm6_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -299,7 +299,7 @@ test5(void) status =rte_lpm6_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -337,7 +337,7 @@ test6(void) status =rte_lpm6_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -375,7 +375,7 @@ test7(void) status =rte_lpm6_lookup_bulk_func (NULL , ip, next_hop_return,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -413,7 +413,7 @@ test8(void) status =rte_lpm6_delete_bulk_func (NULL , ip, depth,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -433,7 +433,7 @@ test8(void)/* * Call add, lookup and delete for a single rule with depth < 24. * Check all the combinations for the first three bytes that result in a hit. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test9 (void )
@@ -1738,7 +1738,7 @@ test27(void)* Call add, lookup and delete for a single rule with maximum 21bit next_hop * size. * Check that next_hop returned from lookup is equal to provisioned value. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test28 (void )
app/test/test_malloc.c +2 -2
@@ -603,7 +603,7 @@ test_realloc_numa(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 )printf ("WARNING: realloc_socket test needs memory on multiple sockets!\n" );
@@ -971,7 +971,7 @@ test_alloc_socket(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 ) {printf ("WARNING: alloc_socket test needs memory on multiple sockets!\n" ); }
app/test/test_mbuf.c +1 -1
@@ -1148,7 +1148,7 @@ test_refcnt_mbuf(void)rte_eal_mp_wait_lcore (); -/* check that we porcessed all references */ +/* check that we processed all references */ tref =0 ; main_lcore =rte_get_main_lcore ();
app/test/test_mempool.c +1 -1
@@ -628,7 +628,7 @@ test_mempool(void)if (test_mempool_basic_ex (mp_nocache) <0 )GOTO_ERR (ret, err); -/* mempool operation test based on single producer and single comsumer */ +/* mempool operation test based on single producer and single consumer */ if (test_mempool_sp_sc () <0 )GOTO_ERR (ret, err);
app/test/test_mempool_perf.c +1 -1
@@ -88,7 +88,7 @@ static uint32_t synchro;static unsigned n_get_bulk;static unsigned n_put_bulk; -/* number of objects retrived from mempool before putting them back */ +/* number of objects retrieved from mempool before putting them back */ static unsigned n_keep;/* number of enqueues / dequeues */
app/test/test_meter.c +3 -3
@@ -444,7 +444,7 @@ tm_test_srtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -551,7 +551,7 @@ tm_test_trtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -648,7 +648,7 @@ tm_test_trtcm_rfc4115_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
app/test/test_pmd_perf.c +1 -1
@@ -753,7 +753,7 @@ test_pmd_perf(void)"rte_eth_dev_start: err=%d, port=%d\n" , ret, portid); -/* always eanble promiscuous */ +/* always enable promiscuous */ ret =rte_eth_promiscuous_enable (portid);if (ret !=0 ) rte_exit(EXIT_FAILURE,
app/test/test_timer.c +1 -1
@@ -432,7 +432,7 @@ timer_basic_cb(struct rte_timer *tim, void *arg)return ; } -/* Explicitelly stop timer 0. Once stop() called, we can even +/* Explicitly stop timer 0. Once stop() called, we can even * erase the content of the structure: it is not referenced * anymore by any code (in case of dynamic structure, it can * be freed) */
Signature · 1 line
2.30.2
v2 cover fix spelling errors
In reply to Stephen HemmingerAfter finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments.
v2 - more spelling fixes in bpf library
Stephen Hemminger (18):
node: fix typos
ipsec: fix spelling errors
eventdev: fix typo in comment
power: fix typo in comment
rcu: fix typo in comment
bpf: fix spelling in comments
acl: fix spelling errors
eal: fix typos in comments
net: fix spelling error in gtp comment
bbdev: fix typo in comment
pipeline: fix spellin error in comment
hash: fix typo in comment
rib: fix typo in comment
sched: fix typo in comment
vhost: fix typo in comment
ip_frag: fix typos
test-pmd: fix spelling errors in comments
test: fix spelling errors in comments
app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_malloc.c | 4 ++-- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_timer.c | 2 +- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- lib/bbdev/rte_bbdev.c | 2 +- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_load_elf.c | 2 +- lib/bpf/bpf_pkt.c | 2 +- lib/bpf/bpf_validate.c | 8 ++++---- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- lib/eventdev/rte_event_timer_adapter.c | 2 +- lib/hash/rte_thash.c | 2 +- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- lib/net/rte_gtp.h | 6 +++--- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- lib/pipeline/rte_swx_pipeline.h | 2 +- lib/power/power_acpi_cpufreq.c | 2 +- lib/rcu/rte_rcu_qsbr.h | 2 +- lib/rib/rte_rib6.c | 2 +- lib/sched/rte_sched.c | 2 +- lib/vhost/rte_vhost.h | 4 ++-- 47 files changed, 69 insertions(+), 69 deletions(-)
Signature · 1 line
2.30.2
PATCH v2 1/18 node: fix typos
Spelling errors in comments including doxygen
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
lib/node/ethdev_rx_priv.h +1 -1
@@ -71,7 +71,7 @@ struct ethdev_rx_node_main *ethdev_rx_get_node_data_get(void);* * Get the Ethernet Rx node. * -* @retrun +* @return * Pointer to the Ethernet Rx node. */ struct rte_node_register *ethdev_rx_node_get (void );
lib/node/ethdev_tx_priv.h +1 -1
@@ -50,7 +50,7 @@ struct ethdev_tx_node_main *ethdev_tx_node_data_get(void);* * Get the Ethernet Tx node. * -* @retrun +* @return * Pointer to the Ethernet Tx node. */ struct rte_node_register *ethdev_tx_node_get (void );
lib/node/ip4_rewrite_priv.h +1 -1
@@ -53,7 +53,7 @@ struct ip4_rewrite_node_main {* * Get the ipv4 rewrite node. * -* @retrun +* @return * Pointer to the ipv4 rewrite node. */ struct rte_node_register *ip4_rewrite_node_get (void );
Signature · 1 line
2.30.2
PATCH v2 2/18 ipsec: fix spelling errors
In reply to Stephen HemmingerLots of typos in comments found by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)
lib/ipsec/esp_inb.c +2 -2
@@ -415,7 +415,7 @@ trs_process_check(struct rte_mbuf *mb, struct rte_mbuf **ml,/* * packet checks for tunnel mode: -* - same as for trasnport mode +* - same as for transport mode * - esp tail next proto contains expected for that SA value */ static inline int32_t
@@ -501,7 +501,7 @@ trs_process_step3(struct rte_mbuf *mb)static inline void tun_process_step3 (struct rte_mbuf *mb,uint64_t txof_msk,uint64_t txof_val) { -/* reset mbuf metatdata: L2/L3 len, packet type */ +/* reset mbuf metadata: L2/L3 len, packet type */ mb->packet_type =RTE_PTYPE_UNKNOWN ; mb->tx_offload = (mb->tx_offload & txof_msk) | txof_val;
lib/ipsec/esp_outb.c +1 -1
@@ -525,7 +525,7 @@ cpu_outb_trs_pkt_prepare(const struct rte_ipsec_session *ss,/* * process outbound packets for SA with ESN support, -* for algorithms that require SQN.hibits to be implictly included +* for algorithms that require SQN.hibits to be implicitly included * into digest computation. * In that case we have to move ICV bytes back to their proper place. */
lib/ipsec/ipsec_sad.c +1 -1
@@ -62,7 +62,7 @@ EAL_REGISTER_TAILQ(rte_ipsec_sad_tailq)* Inserts a rule into an appropriate hash table, * updates the value for a given SPI in SPI_ONLY hash table * reflecting presence of more specific rule type in two LSBs. -* Updates a counter that reflects the number of rules whith the same SPI. +* Updates a counter that reflects the number of rules with the same SPI. */ static inline int add_specific(struct rte_ipsec_sad *sad, const void *key,
lib/ipsec/sa.c +1 -1
@@ -126,7 +126,7 @@ ipsec_sa_size(uint64_t type, uint32_t *wnd_sz, uint32_t *nb_bucket)/* * RFC 4303 recommends 64 as minimum window size. * there is no point to use ESN mode without SQN window, -* so make sure we have at least 64 window when ESN is enalbed. +* so make sure we have at least 64 window when ESN is enabled. */ wsz = ((type &RTE_IPSEC_SATP_ESN_MASK ) == RTE_IPSEC_SATP_ESN_DISABLE) ?
lib/ipsec/sa.h +1 -1
@@ -116,7 +116,7 @@ struct rte_ipsec_sa {* In case of SA handled by multiple threads *sqn* cacheline * could be shared by multiple cores. * To minimise performance impact, we try to locate in a separate -* place from other frequently accesed data. +* place from other frequently accessed data. */ union {uint64_t outb;
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v2 02/18] ipsec: fix spelling errors
Quoted 86 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen Hemminger
Sent: Monday, September 13, 2021 5:10 PM
To: [email protected]
Cc: Stephen Hemminger <[email protected]>
Subject: [dpdk-dev] [PATCH v2 02/18] ipsec: fix spelling errorsLots of typos in comments found by codespell
Signed-off-by Stephen Hemminger <[email protected]>--- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)lib/ipsec/esp_inb.c +2
-2@@ -415,7 +415,7 @@ trs_process_check(struct rte_mbuf *mb, struct rte_mbuf **ml,/* * packet checks for tunnel mode: -* - same as for trasnport mode +* - same as for transport mode * - esp tail next proto contains expected for that SA value */ static inline int32_t@@ -501,7 +501,7 @@ trs_process_step3(struct rte_mbuf *mb)static inline void tun_process_step3 (struct rte_mbuf *mb,uint64_t txof_msk,uint64_t txof_val) { -/* reset mbuf metatdata: L2/L3 len, packet type */ +/* reset mbuf metadata: L2/L3 len, packet type */ mb->packet_type =RTE_PTYPE_UNKNOWN ; mb->tx_offload = (mb->tx_offload & txof_msk) | txof_val;lib/ipsec/esp_outb.c +1
-1@@ -525,7 +525,7 @@ cpu_outb_trs_pkt_prepare(const struct rte_ipsec_session *ss,/* * process outbound packets for SA with ESN support, -* for algorithms that require SQN.hibits to be implictly included +* for algorithms that require SQN.hibits to be implicitly included * into digest computation. * In that case we have to move ICV bytes back to their proper place. */ lib/ipsec/ipsec_sad.c +1
-1@@ -62,7 +62,7 @@ EAL_REGISTER_TAILQ(rte_ipsec_sad_tailq)* Inserts a rule into an appropriate hash table, * updates the value for a given SPI in SPI_ONLY hash table * reflecting presence of more specific rule type in two LSBs. -* Updates a counter that reflects the number of rules whith the same SPI. +* Updates a counter that reflects the number of rules with the same SPI. */ static inline int add_specific(struct rte_ipsec_sad *sad, const void *key,lib/ipsec/sa.c +1
-1@@ -126,7 +126,7 @@ ipsec_sa_size(uint64_t type, uint32_t *wnd_sz, uint32_t *nb_bucket)/* * RFC 4303 recommends 64 as minimum window size. * there is no point to use ESN mode without SQN window, -* so make sure we have at least 64 window when ESN is enalbed. +* so make sure we have at least 64 window when ESN is enabled. */ wsz = ((type &RTE_IPSEC_SATP_ESN_MASK ) == RTE_IPSEC_SATP_ESN_DISABLE) ?lib/ipsec/sa.h +0
-0
lib/ipsec/sa.h struct rte_ipsec_sa {
Quoted 9 lines
lib/ipsec/sa.h +1
-2@@ -116,7 +116,7 @@ struct rte_ipsec_sa {* In case of SA handled by multiple threads *sqn* cacheline * could be shared by multiple cores. * To minimise performance impact, we try to locate in a separate -* place from other frequently accesed data. +* place from other frequently accessed data. */ union {uint64_t outb; --
Quoted 1 line
2.30.2
PATCH v2 3/18 eventdev: fix typo in comment
In reply to Stephen HemmingerTypo in comment found by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/eventdev/rte_event_timer_adapter.c +1 -1
@@ -493,7 +493,7 @@ event_buffer_flush(struct event_buffer *bufp, uint8_t dev_id, uint8_t port_id,RTE_ASSERT (head_idx <EVENT_BUFFER_SZ && tail_idx <EVENT_BUFFER_SZ ); -/* Determine the largest contigous run we can attempt to enqueue to the +/* Determine the largest contiguous run we can attempt to enqueue to the * event device. */ if (head_idx > tail_idx)
Signature · 1 line
2.30.2
PATCH v2 4/18 power: fix typo in comment
In reply to Stephen HemmingerMore spelling errors caught by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/power/power_acpi_cpufreq.c +1 -1
@@ -159,7 +159,7 @@ power_get_available_freqs(struct acpi_power_info *pi) goto out; } -/* Store the available frequncies into power context */ +/* Store the available frequencies into power context */ for (i =0 , pi->nb_freqs =0 ; i < count; i++) {POWER_DEBUG_TRACE ("Lcore %u frequency[%d]: %s\n" , pi->lcore_id, i, freqs[i]);
Signature · 1 line
2.30.2
PATCH v2 5/18 rcu: fix typo in comment
In reply to Stephen HemmingerAnother codespell find.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rcu/rte_rcu_qsbr.h +1 -1
@@ -362,7 +362,7 @@ rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id)/* The reader can go offline only after the load of the * data structure is completed. i.e. any load of the -* data strcture can not move after this store. +* data structure can not move after this store. */ __atomic_store_n(&v->qsbr_cnt[thread_id].cnt,
Signature · 1 line
2.30.2
PATCH v2 6/18 bpf: fix spelling in comments
In reply to Stephen HemmingerFound by running codespell on the bpf implementation.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_load_elf.c | 2 +- lib/bpf/bpf_pkt.c | 2 +- lib/bpf/bpf_validate.c | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-)
lib/bpf/bpf_jit_x86.c +1 -1
@@ -1245,7 +1245,7 @@ emit_epilog(struct bpf_jit_state *st)uint32_t i;int32_t spil, ofs; -/* if we allready have an epilog generate a jump to it */ +/* if we already have an epilog generate a jump to it */ if (st->exit.num++ !=0 ) {emit_abs_jmp (st, st->exit.off);return ;
lib/bpf/bpf_load_elf.c +1 -1
@@ -80,7 +80,7 @@ resolve_xsym(const char *sn, size_t ofs, struct ebpf_insn *ins, size_t ins_sz,if (type ==RTE_BPF_XTYPE_FUNC ) {/* we don't support multiple functions per BPF module, -* so treat EBPF_PSEUDO_CALL to extrernal function +* so treat EBPF_PSEUDO_CALL to external function * as an ordinary EBPF_CALL. */ if (ins[idx].src_reg ==EBPF_PSEUDO_CALL ) {
lib/bpf/bpf_pkt.c +1 -1
@@ -169,7 +169,7 @@ bpf_eth_cbh_add(struct bpf_eth_cbh *cbh, uint16_t port, uint16_t queue) }/* -* BPF packet processing routinies. +* BPF packet processing routines. */ static inline uint32_t
lib/bpf/bpf_validate.c +4 -4
@@ -1723,7 +1723,7 @@ static const struct bpf_ins_check ins_chk[UINT8_MAX + 1] = {/* * make sure that instruction syntax is valid, -* and it fields don't violate partciular instrcution type restrictions. +* and its fields don't violate particular instruction type restrictions. */ static const char *check_syntax (const struct ebpf_insn *ins)
@@ -1954,7 +1954,7 @@ log_loop(const struct bpf_verifier *bvf)* First pass goes though all instructions in the set, checks that each * instruction is a valid one (correct syntax, valid field values, etc.) * and constructs control flow graph (CFG). -* Then deapth-first search is performed over the constructed graph. +* Then depth-first search is performed over the constructed graph. * Programs with unreachable instructions and/or loops will be rejected. */ static int
@@ -1981,7 +1981,7 @@ validate(struct bpf_verifier *bvf)/* * construct CFG, jcc nodes have to outgoing edges, -* 'exit' nodes - none, all others nodes have exaclty one +* 'exit' nodes - none, all other nodes have exactly one * outgoing edge. */ switch (ins->code) {
@@ -2251,7 +2251,7 @@ evaluate(struct bpf_verifier *bvf) idx =get_node_idx (bvf, node); op = ins[idx].code; -/* for jcc node make a copy of evaluatoion state */ +/* for jcc node make a copy of evaluation state */ if (node->nb_edge >1 ) rc |=save_eval_state (bvf, node);
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments
Quoted 6 lines
Found by running codespell on the bpf implementation.
Signed-off-by Stephen Hemminger <[email protected]>---
Quoted 2 lines
--
2.30.2
PATCH v2 7/18 acl: fix spelling errors
In reply to Stephen HemmingerLots of little typos in comments
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
lib/acl/acl.h +2 -2
@@ -45,7 +45,7 @@ struct rte_acl_bitset {* Each transition is 64 bit value with the following format: * | node_type_specific : 32 | node_type : 3 | node_addr : 29 | * For all node types except RTE_ACL_NODE_MATCH, node_addr is an index -* to the start of the node in the transtions array. +* to the start of the node in the transitions array. * Few different node types are used: * RTE_ACL_NODE_MATCH: * node_addr value is and index into an array that contains the return value
@@ -66,7 +66,7 @@ struct rte_acl_bitset {* RTE_ACL_NODE_SINGLE: * always transitions to the same node regardless of the input value. * RTE_ACL_NODE_DFA: -* that node consits of up to 256 transitions. +* that node consists of up to 256 transitions. * In attempt to conserve space all transitions are divided into 4 consecutive * groups, by 64 transitions per group: * group64[i] contains transitions[i * 64, .. i * 64 + 63].
lib/acl/acl_bld.c +1 -1
@@ -1494,7 +1494,7 @@ acl_set_data_indexes(struct rte_acl_ctx *ctx)/* * Internal routine, performs 'build' phase of trie generation: * - setups build context. -* - analizes given set of rules. +* - analyzes given set of rules. * - builds internal tree(s). */ static int
lib/acl/acl_run_avx2.h +1 -1
@@ -125,7 +125,7 @@ acl_process_matches_avx2x8(const struct rte_acl_ctx *ctx,/* For each transition: put low 32 into tr_lo and high 32 into tr_hi */ ACL_TR_HILO (mm256, __m256, t0, t1, lo, hi); -/* Keep transitions wth NOMATCH intact. */ +/* Keep transitions with NOMATCH intact. */ *tr_lo =_mm256_blendv_epi8 (*tr_lo, lo, matches); *tr_hi =_mm256_blendv_epi8 (*tr_hi, hi, matches); }
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v2 07/18] acl: fix spelling errors
Quoted 51 lines
Lots of little typos in comments
Signed-off-by Stephen Hemminger <[email protected]>--- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)lib/acl/acl.h +2
-2@@ -45,7 +45,7 @@ struct rte_acl_bitset {* Each transition is 64 bit value with the following format: * | node_type_specific : 32 | node_type : 3 | node_addr : 29 | * For all node types except RTE_ACL_NODE_MATCH, node_addr is an index -* to the start of the node in the transtions array. +* to the start of the node in the transitions array. * Few different node types are used: * RTE_ACL_NODE_MATCH: * node_addr value is and index into an array that contains the return value @@ -66,7 +66,7 @@ struct rte_acl_bitset {* RTE_ACL_NODE_SINGLE: * always transitions to the same node regardless of the input value. * RTE_ACL_NODE_DFA: -* that node consits of up to 256 transitions. +* that node consists of up to 256 transitions. * In attempt to conserve space all transitions are divided into 4 consecutive * groups, by 64 transitions per group: * group64[i] contains transitions[i * 64, .. i * 64 + 63]. lib/acl/acl_bld.c +1
-1@@ -1494,7 +1494,7 @@ acl_set_data_indexes(struct rte_acl_ctx *ctx)/* * Internal routine, performs 'build' phase of trie generation: * - setups build context. -* - analizes given set of rules. +* - analyzes given set of rules. * - builds internal tree(s). */ static intlib/acl/acl_run_avx2.h +0
-0
lib/acl/acl_run_avx2.h acl_process_matches_avx2x8(const struct rte_acl_ctx *ctx,
Quoted 9 lines
lib/acl/acl_run_avx2.h +1
-2@@ -125,7 +125,7 @@ acl_process_matches_avx2x8(const struct rte_acl_ctx *ctx,/* For each transition: put low 32 into tr_lo and high 32 into tr_hi */ ACL_TR_HILO (mm256, __m256, t0, t1, lo, hi); -/* Keep transitions wth NOMATCH intact. */ +/* Keep transitions with NOMATCH intact. */ *tr_lo =_mm256_blendv_epi8 (*tr_lo, lo, matches); *tr_hi =_mm256_blendv_epi8 (*tr_hi, hi, matches); } --
Quoted 1 line
2.30.2
PATCH v2 8/18 eal: fix typos in comments
In reply to Stephen HemmingerMinor spelling errors.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
lib/eal/include/rte_function_versioning.h +1 -1
@@ -15,7 +15,7 @@/* * Provides backwards compatibility when updating exported functions. -* When a symol is exported from a library to provide an API, it also provides a +* When a symbol is exported from a library to provide an API, it also provides a * calling convention (ABI) that is embodied in its name, return type, * arguments, etc. On occasion that function may need to change to accommodate * new functionality, behavior, etc. When that occurs, it is desirable to
lib/eal/windows/include/fnmatch.h +1 -1
@@ -30,7 +30,7 @@ extern "C" {* with the given regular expression pattern. * * @param pattern -* regular expression notation decribing the pattern to match +* regular expression notation describing the pattern to match * * @param string * source string to searcg for the pattern
Signature · 1 line
2.30.2
PATCH v2 9/18 net: fix spelling error in gtp comment
In reply to Stephen HemmingerMore codespell finds.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/net/rte_gtp.h +3 -3
@@ -64,9 +64,9 @@ struct rte_gtp_hdr_ext_word {/** GTP header length */ #define RTE_ETHER_GTP_HLEN \ (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr)) -/* GTP next protocal type */ -#define RTE_GTP_TYPE_IPV4 0x40/**< GTP next protocal type IPv4 */ -#define RTE_GTP_TYPE_IPV6 0x60/**< GTP next protocal type IPv6 */ +/* GTP next protocol type */ +#define RTE_GTP_TYPE_IPV4 0x40/**< GTP next protocol type IPv4 */ +#define RTE_GTP_TYPE_IPV6 0x60/**< GTP next protocol type IPv6 */ /* GTP destination port number */ #define RTE_GTPC_UDP_PORT 2123/**< GTP-C UDP destination port */ #define RTE_GTPU_UDP_PORT 2152/**< GTP-U UDP destination port */
Signature · 1 line
2.30.2
PATCH v2 10/18 bbdev: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/bbdev/rte_bbdev.c +1 -1
@@ -138,7 +138,7 @@ rte_bbdev_data_alloc(void) }/* -* Find data alocated for the device or if not found return first unused bbdev +* Find data allocated for the device or if not found return first unused bbdev * data. If all structures are in use and none is used by the device return * NULL. */
Signature · 1 line
2.30.2
PATCH v2 11/18 pipeline: fix spellin error in comment
In reply to Stephen HemmingerMinor typo
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/pipeline/rte_swx_pipeline.h +1 -1
@@ -620,7 +620,7 @@ struct rte_swx_pipeline_selector_params {const char *group_id_field_name;/** The set of fields used to select (through a hashing scheme) the -* member within the current group. Inputs into the seletion operation. +* member within the current group. Inputs into the selection operation. * Restriction: All the selector fields must be part of the same struct, * i.e. part of the same header or part of the meta-data structure. */
Signature · 1 line
2.30.2
PATCH v2 12/18 hash: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/hash/rte_thash.c +1 -1
@@ -26,7 +26,7 @@ EAL_REGISTER_TAILQ(rte_thash_tailq)/** * Table of some irreducible polinomials over GF(2). -* For lfsr they are reperesented in BE bit order, and +* For lfsr they are represented in BE bit order, and * x^0 is masked out. * For example, poly x^5 + x^2 + 1 will be represented * as (101001b & 11111b) = 01001b = 0x9
Signature · 1 line
2.30.2
PATCH v2 13/18 rib: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rib/rte_rib6.c +1 -1
@@ -199,7 +199,7 @@ rte_rib6_lookup_exact(struct rte_rib6 *rib, }/* -* Traverses on subtree and retreeves more specific routes +* Traverses on subtree and retrieves more specific routes * for a given in args ip/depth prefix * last = NULL means the first invocation */
Signature · 1 line
2.30.2
PATCH v2 14/18 sched: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/sched/rte_sched.c +1 -1
@@ -579,7 +579,7 @@ rte_sched_subport_config_qsize(struct rte_sched_subport *subport) subport->qsize_add[0 ] =0 ; -/* Strict prority traffic class */ +/* Strict priority traffic class */ for (i =1 ; i <RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE ; i++) subport->qsize_add[i] = subport->qsize_add[i-1 ] + subport->qsize[i-1 ];
Signature · 1 line
2.30.2
PATCH v2 15/18 vhost: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/vhost/rte_vhost.h +2 -2
@@ -776,7 +776,7 @@ rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx,/** * Set split inflight descriptor. * -* This function save descriptors that has been comsumed in available +* This function save descriptors that has been consumed in available * ring * * @param vid
@@ -796,7 +796,7 @@ rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx,/** * Set packed inflight descriptor and get corresponding inflight entry * -* This function save descriptors that has been comsumed +* This function save descriptors that has been consumed * * @param vid * vhost device ID
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v2 15/18] vhost: fix typo in comment
Hi Stehpen,
Quoted 12 lines · Stephen Hemminger
Yet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>--- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)lib/vhost/rte_vhost.h +0
-0
lib/vhost/rte_vhost.h rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx, · line 779
Quoted 5 lines
lib/vhost/rte_vhost.h +1
-1@@ -776,7 +776,7 @@ rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx,/** * Set split inflight descriptor. * -* This function save descriptors that has been comsumed in available +* This function save descriptors that has been consumed in available
You missed my comment on v1:
s/that has been/that have been/
lib/vhost/rte_vhost.h rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx, · line 799
Quoted 9 lines
lib/vhost/rte_vhost.h +1
-1* ring * * @param vid @@ -796,7 +796,7 @@ rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx,/** * Set packed inflight descriptor and get corresponding inflight entry * -* This function save descriptors that has been comsumed +* This function save descriptors that has been consumed
Same here.
Quoted 4 lines
lib/vhost/rte_vhost.h +0
-0* * @param vid * vhost device ID
PATCH v2 16/18 ip_frag: fix typos
In reply to Stephen HemmingerMinor typos in comment.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/ip_frag/rte_ipv4_reassembly.c +1 -1
@@ -80,7 +80,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp)/* * Process new mbuf with fragment of IPV4 packet. -* Incoming mbuf should have it's l2_len/l3_len fields setuped correclty. +* Incoming mbuf should have it's l2_len/l3_len fields setup correctly. * @param tbl * Table where to lookup/add the fragmented packet. * @param mb
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v2 16/18] ip_frag: fix typos
Quoted 23 lines
Minor typos in comment.
Signed-off-by Stephen Hemminger <[email protected]>--- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/ip_frag/rte_ipv4_reassembly.c +1
-2@@ -80,7 +80,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp)/* * Process new mbuf with fragment of IPV4 packet. -* Incoming mbuf should have it's l2_len/l3_len fields setuped correclty. +* Incoming mbuf should have it's l2_len/l3_len fields setup correctly. * @param tbl * Table where to lookup/add the fragmented packet. * @param mb --
Quoted 1 line
2.30.2
PATCH v2 17/18 test-pmd: fix spelling errors in comments
In reply to Stephen HemmingerMore typos
Signed-off-by Stephen Hemminger <[email protected]>
--- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
app/test-pmd/cmdline.c +1 -1
@@ -3670,7 +3670,7 @@ parse_item_list(const char *str, const char *item_name, unsigned int max_items,return nb_item;/* -* Then, check that all values in the list are differents. +* Then, check that all values in the list are different. * No optimization here... */ for (i =0 ; i < nb_item; i++) {
app/test-pmd/config.c +2 -2
@@ -2777,7 +2777,7 @@ port_rss_reta_info(portid_t port_id, }/* -* Displays the RSS hash functions of a port, and, optionaly, the RSS hash +* Displays the RSS hash functions of a port, and, optionally, the RSS hash * key of the port. */ void
@@ -4932,7 +4932,7 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx) { port->mc_addr_nb--;if (addr_idx == port->mc_addr_nb) { -/* No need to recompact the set of multicast addressses. */ +/* No need to recompact the set of multicast addresses. */ if (port->mc_addr_nb ==0 ) {/* free the pool of multicast addresses. */ free (port->mc_addr_pool);
app/test-pmd/icmpecho.c +1 -1
@@ -54,7 +54,7 @@ arp_op_name(uint16_t arp_op)default :break ; } -return "Unkwown ARP op" ; +return "Unknown ARP op" ; } static const char *
Signature · 1 line
2.30.2
PATCH v2 18/18 test: fix spelling errors in comments
In reply to Stephen HemmingerLots of little typos.
Signed-off-by Stephen Hemminger <[email protected]>
--- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_malloc.c | 4 ++-- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_timer.c | 2 +- 16 files changed, 29 insertions(+), 29 deletions(-)
app/test/test_atomic.c +1 -1
@@ -88,7 +88,7 @@* * - Invoke ``test_atomic_exchange`` on each lcore. Before doing * anything else, the cores wait for a synchronization event. -* Each core then does the follwoing for N iterations: +* Each core then does the following for N iterations: * * Generate a new token with a data integrity check * Exchange the new token for previously generated token
app/test/test_barrier.c +1 -1
@@ -66,7 +66,7 @@ struct plock_test {struct lcore_plock_test {struct plock_test *pt[2 ];/* shared, lock-protected data */ uint64_t sum[2 ];/* local copy of the shared data */ -uint64_t iter;/* number of iterations to perfom */ +uint64_t iter;/* number of iterations to perform */ uint32_t lc;/* given lcore id */ };
app/test/test_bpf.c +1 -1
@@ -2391,7 +2391,7 @@ static const struct ebpf_insn test_call5_prog[] = { }, }; -/* String comparision impelementation, return 0 if equal else difference */ +/* String comparison implementation, return 0 if equal else difference */ static uint32_t dummy_func5 (const char *s1,const char *s2) {
app/test/test_compressdev.c +1 -1
@@ -2035,7 +2035,7 @@ test_deflate_comp_decomp(const struct interim_data_params *int_data, test_priv_data.all_decomp_data = &all_decomp_data; test_priv_data.decomp_produced_data_size = &decomp_produced_data_size; - test_priv_data.num_priv_xforms =0 ;/* it's used for deompression only */ + test_priv_data.num_priv_xforms =0 ;/* it's used for decompression only */ capa =rte_compressdev_capability_get (0 ,RTE_COMP_ALGO_DEFLATE );if (capa ==NULL ) {
app/test/test_func_reentrancy.c +3 -3
@@ -242,7 +242,7 @@ hash_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple times simultaneously */ +/* create multiple times simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (hash_name,sizeof (hash_name),"fr_test_%d_%d" , lcore_self, i); hash_params.name = hash_name;
@@ -306,7 +306,7 @@ fbk_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (fbk_name,sizeof (fbk_name),"fr_test_%d_%d" , lcore_self, i); fbk_params.name = fbk_name;
@@ -368,7 +368,7 @@ lpm_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_LPM_ITER_TIMES ; i++) {snprintf (lpm_name,sizeof (lpm_name),"fr_test_%d_%d" , lcore_self, i); lpm =rte_lpm_create (lpm_name,SOCKET_ID_ANY , &config);
app/test/test_ipsec.c +1 -1
@@ -653,7 +653,7 @@ create_crypto_session(struct ipsec_unitest_params *ut,if (s ==NULL )return -ENOMEM ; -/* initiliaze SA crypto session for device */ +/* initialize SA crypto session for device */ rc =rte_cryptodev_sym_session_init (dev_id, s, ut->crypto_xforms, qp->mp_session_private);if (rc ==0 ) {
app/test/test_link_bonding.c +1 -1
@@ -3041,7 +3041,7 @@ test_balance_tx_burst_slave_tx_fail(void) first_tx_fail_idx =TEST_BAL_SLAVE_TX_FAIL_BURST_SIZE_1 -TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; -/* copy mbuf referneces for expected transmission failures */ +/* copy mbuf references for expected transmission failures */ for (i =0 ; i <TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; i++) expected_fail_pkts[i] = pkts_burst_1[i + first_tx_fail_idx];
app/test/test_lpm.c +3 -3
@@ -179,7 +179,7 @@ test3(void) status =rte_lpm_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -217,7 +217,7 @@ test4(void) status =rte_lpm_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -255,7 +255,7 @@ test5(void) status =rte_lpm_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
app/test/test_lpm6.c +7 -7
@@ -261,7 +261,7 @@ test4(void) status =rte_lpm6_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -299,7 +299,7 @@ test5(void) status =rte_lpm6_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -337,7 +337,7 @@ test6(void) status =rte_lpm6_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -375,7 +375,7 @@ test7(void) status =rte_lpm6_lookup_bulk_func (NULL , ip, next_hop_return,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -413,7 +413,7 @@ test8(void) status =rte_lpm6_delete_bulk_func (NULL , ip, depth,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -433,7 +433,7 @@ test8(void)/* * Call add, lookup and delete for a single rule with depth < 24. * Check all the combinations for the first three bytes that result in a hit. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test9 (void )
@@ -1738,7 +1738,7 @@ test27(void)* Call add, lookup and delete for a single rule with maximum 21bit next_hop * size. * Check that next_hop returned from lookup is equal to provisioned value. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test28 (void )
app/test/test_malloc.c +2 -2
@@ -603,7 +603,7 @@ test_realloc_numa(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 )printf ("WARNING: realloc_socket test needs memory on multiple sockets!\n" );
@@ -971,7 +971,7 @@ test_alloc_socket(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 ) {printf ("WARNING: alloc_socket test needs memory on multiple sockets!\n" ); }
app/test/test_mbuf.c +1 -1
@@ -1148,7 +1148,7 @@ test_refcnt_mbuf(void)rte_eal_mp_wait_lcore (); -/* check that we porcessed all references */ +/* check that we processed all references */ tref =0 ; main_lcore =rte_get_main_lcore ();
app/test/test_mempool.c +1 -1
@@ -628,7 +628,7 @@ test_mempool(void)if (test_mempool_basic_ex (mp_nocache) <0 )GOTO_ERR (ret, err); -/* mempool operation test based on single producer and single comsumer */ +/* mempool operation test based on single producer and single consumer */ if (test_mempool_sp_sc () <0 )GOTO_ERR (ret, err);
app/test/test_mempool_perf.c +1 -1
@@ -88,7 +88,7 @@ static uint32_t synchro;static unsigned n_get_bulk;static unsigned n_put_bulk; -/* number of objects retrived from mempool before putting them back */ +/* number of objects retrieved from mempool before putting them back */ static unsigned n_keep;/* number of enqueues / dequeues */
app/test/test_meter.c +3 -3
@@ -444,7 +444,7 @@ tm_test_srtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -551,7 +551,7 @@ tm_test_trtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -648,7 +648,7 @@ tm_test_trtcm_rfc4115_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
app/test/test_pmd_perf.c +1 -1
@@ -753,7 +753,7 @@ test_pmd_perf(void)"rte_eth_dev_start: err=%d, port=%d\n" , ret, portid); -/* always eanble promiscuous */ +/* always enable promiscuous */ ret =rte_eth_promiscuous_enable (portid);if (ret !=0 ) rte_exit(EXIT_FAILURE,
app/test/test_timer.c +1 -1
@@ -432,7 +432,7 @@ timer_basic_cb(struct rte_timer *tim, void *arg)return ; } -/* Explicitelly stop timer 0. Once stop() called, we can even +/* Explicitly stop timer 0. Once stop() called, we can even * erase the content of the structure: it is not referenced * anymore by any code (in case of dynamic structure, it can * be freed) */
Signature · 1 line
2.30.2
v3 cover fix spelling errors
In reply to Stephen HemmingerAfter finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments.
v3 - incorporate feedback on vhost
fix comment formatting in test portion
v2 - checkpatch wants more than just subject
remove autocorrect of historical text
Stephen Hemminger (18):
node: fix typos
ipsec: fix spelling errors
eventdev: fix typo in comment
power: fix typo in comment
rcu: fix typo in comment
bpf: fix spelling in comments
acl: fix spelling errors
eal: fix typos in comments
net: fix spelling error in gtp comment
bbdev: fix typo in comment
pipeline: fix spellin error in comment
hash: fix typo in comment
rib: fix typo in comment
sched: fix typo in comment
vhost: fix typo in comment
ip_frag: fix typos
test-pmd: fix spelling errors in comments
test: fix spelling errors in comments
app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_fib.c | 2 +- app/test/test_fib6.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_malloc.c | 4 ++-- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_rib.c | 2 +- app/test/test_rib6.c | 2 +- app/test/test_timer.c | 2 +- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- lib/bbdev/rte_bbdev.c | 2 +- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_load_elf.c | 2 +- lib/bpf/bpf_pkt.c | 2 +- lib/bpf/bpf_validate.c | 8 ++++---- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- lib/eventdev/rte_event_timer_adapter.c | 2 +- lib/hash/rte_thash.c | 2 +- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- lib/net/rte_gtp.h | 6 +++--- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- lib/pipeline/rte_swx_pipeline.h | 2 +- lib/power/power_acpi_cpufreq.c | 2 +- lib/rcu/rte_rcu_qsbr.h | 2 +- lib/rib/rte_rib6.c | 2 +- lib/sched/rte_sched.c | 2 +- lib/vhost/rte_vhost.h | 4 ++-- 51 files changed, 73 insertions(+), 73 deletions(-)
Signature · 1 line
2.30.2
PATCH v3 1/18 node: fix typos
Spelling errors in comments including doxygen
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
lib/node/ethdev_rx_priv.h +1 -1
@@ -67,7 +67,7 @@ struct ethdev_rx_node_main *ethdev_rx_get_node_data_get(void);* * Get the Ethernet Rx node. * -* @retrun +* @return * Pointer to the Ethernet Rx node. */ struct rte_node_register *ethdev_rx_node_get (void );
lib/node/ethdev_tx_priv.h +1 -1
@@ -46,7 +46,7 @@ struct ethdev_tx_node_main *ethdev_tx_node_data_get(void);* * Get the Ethernet Tx node. * -* @retrun +* @return * Pointer to the Ethernet Tx node. */ struct rte_node_register *ethdev_tx_node_get (void );
lib/node/ip4_rewrite_priv.h +1 -1
@@ -49,7 +49,7 @@ struct ip4_rewrite_node_main {* * Get the ipv4 rewrite node. * -* @retrun +* @return * Pointer to the ipv4 rewrite node. */ struct rte_node_register *ip4_rewrite_node_get (void );
Signature · 1 line
2.30.2
PATCH v3 2/18 ipsec: fix spelling errors
In reply to Stephen HemmingerLots of typos in comments found by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)
lib/ipsec/esp_inb.c +2 -2
@@ -415,7 +415,7 @@ trs_process_check(struct rte_mbuf *mb, struct rte_mbuf **ml,/* * packet checks for tunnel mode: -* - same as for trasnport mode +* - same as for transport mode * - esp tail next proto contains expected for that SA value */ static inline int32_t
@@ -501,7 +501,7 @@ trs_process_step3(struct rte_mbuf *mb)static inline void tun_process_step3 (struct rte_mbuf *mb,uint64_t txof_msk,uint64_t txof_val) { -/* reset mbuf metatdata: L2/L3 len, packet type */ +/* reset mbuf metadata: L2/L3 len, packet type */ mb->packet_type =RTE_PTYPE_UNKNOWN ; mb->tx_offload = (mb->tx_offload & txof_msk) | txof_val;
lib/ipsec/esp_outb.c +1 -1
@@ -525,7 +525,7 @@ cpu_outb_trs_pkt_prepare(const struct rte_ipsec_session *ss,/* * process outbound packets for SA with ESN support, -* for algorithms that require SQN.hibits to be implictly included +* for algorithms that require SQN.hibits to be implicitly included * into digest computation. * In that case we have to move ICV bytes back to their proper place. */
lib/ipsec/ipsec_sad.c +1 -1
@@ -62,7 +62,7 @@ EAL_REGISTER_TAILQ(rte_ipsec_sad_tailq)* Inserts a rule into an appropriate hash table, * updates the value for a given SPI in SPI_ONLY hash table * reflecting presence of more specific rule type in two LSBs. -* Updates a counter that reflects the number of rules whith the same SPI. +* Updates a counter that reflects the number of rules with the same SPI. */ static inline int add_specific(struct rte_ipsec_sad *sad, const void *key,
lib/ipsec/sa.c +1 -1
@@ -126,7 +126,7 @@ ipsec_sa_size(uint64_t type, uint32_t *wnd_sz, uint32_t *nb_bucket)/* * RFC 4303 recommends 64 as minimum window size. * there is no point to use ESN mode without SQN window, -* so make sure we have at least 64 window when ESN is enalbed. +* so make sure we have at least 64 window when ESN is enabled. */ wsz = ((type &RTE_IPSEC_SATP_ESN_MASK ) == RTE_IPSEC_SATP_ESN_DISABLE) ?
lib/ipsec/sa.h +1 -1
@@ -116,7 +116,7 @@ struct rte_ipsec_sa {* In case of SA handled by multiple threads *sqn* cacheline * could be shared by multiple cores. * To minimise performance impact, we try to locate in a separate -* place from other frequently accesed data. +* place from other frequently accessed data. */ union {uint64_t outb;
Signature · 1 line
2.30.2
PATCH v3 3/18 eventdev: fix typo in comment
In reply to Stephen HemmingerTypo in comment found by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/eventdev/rte_event_timer_adapter.c +1 -1
@@ -493,7 +493,7 @@ event_buffer_flush(struct event_buffer *bufp, uint8_t dev_id, uint8_t port_id,RTE_ASSERT (head_idx <EVENT_BUFFER_SZ && tail_idx <EVENT_BUFFER_SZ ); -/* Determine the largest contigous run we can attempt to enqueue to the +/* Determine the largest contiguous run we can attempt to enqueue to the * event device. */ if (head_idx > tail_idx)
Signature · 1 line
2.30.2
PATCH v3 4/18 power: fix typo in comment
In reply to Stephen HemmingerMore spelling errors caught by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/power/power_acpi_cpufreq.c +1 -1
@@ -159,7 +159,7 @@ power_get_available_freqs(struct acpi_power_info *pi) goto out; } -/* Store the available frequncies into power context */ +/* Store the available frequencies into power context */ for (i =0 , pi->nb_freqs =0 ; i < count; i++) {POWER_DEBUG_TRACE ("Lcore %u frequency[%d]: %s\n" , pi->lcore_id, i, freqs[i]);
Signature · 1 line
2.30.2
PATCH v3 5/18 rcu: fix typo in comment
In reply to Stephen HemmingerAnother codespell find.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rcu/rte_rcu_qsbr.h +1 -1
@@ -362,7 +362,7 @@ rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id)/* The reader can go offline only after the load of the * data structure is completed. i.e. any load of the -* data strcture can not move after this store. +* data structure can not move after this store. */ __atomic_store_n(&v->qsbr_cnt[thread_id].cnt,
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v3 05/18] rcu: fix typo in comment
<snip>
Quoted 4 lines
Another codespell find.
Signed-off-by Stephen Hemminger <[email protected]>
Reviewed-by Honnappa Nagarahalli <[email protected]>
Quoted 20 lines
--- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/rcu/rte_rcu_qsbr.h index renamed from lib/rcu/rte_rcu_qsbr.h +0
-0
18811c1cc106..62a420a785fc100644lib/rcu/rte_rcu_qsbr.h +1
-1@@ -362,7 +362,7 @@ rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id)/* The reader can go offline only after the load of the * data structure is completed. i.e. any load of the -* data strcture can not move after this store. +* data structure can not move after this store. */ __atomic_store_n(&v->qsbr_cnt[thread_id].cnt,
--
2.30.2
PATCH v3 6/18 bpf: fix spelling in comments
In reply to Stephen HemmingerFound by running codespell on the bpf implementation.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_load_elf.c | 2 +- lib/bpf/bpf_pkt.c | 2 +- lib/bpf/bpf_validate.c | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-)
lib/bpf/bpf_jit_x86.c +1 -1
@@ -1245,7 +1245,7 @@ emit_epilog(struct bpf_jit_state *st)uint32_t i;int32_t spil, ofs; -/* if we allready have an epilog generate a jump to it */ +/* if we already have an epilog generate a jump to it */ if (st->exit.num++ !=0 ) {emit_abs_jmp (st, st->exit.off);return ;
lib/bpf/bpf_load_elf.c +1 -1
@@ -80,7 +80,7 @@ resolve_xsym(const char *sn, size_t ofs, struct ebpf_insn *ins, size_t ins_sz,if (type ==RTE_BPF_XTYPE_FUNC ) {/* we don't support multiple functions per BPF module, -* so treat EBPF_PSEUDO_CALL to extrernal function +* so treat EBPF_PSEUDO_CALL to external function * as an ordinary EBPF_CALL. */ if (ins[idx].src_reg ==EBPF_PSEUDO_CALL ) {
lib/bpf/bpf_pkt.c +1 -1
@@ -169,7 +169,7 @@ bpf_eth_cbh_add(struct bpf_eth_cbh *cbh, uint16_t port, uint16_t queue) }/* -* BPF packet processing routinies. +* BPF packet processing routines. */ static inline uint32_t
lib/bpf/bpf_validate.c +4 -4
@@ -1723,7 +1723,7 @@ static const struct bpf_ins_check ins_chk[UINT8_MAX + 1] = {/* * make sure that instruction syntax is valid, -* and it fields don't violate partciular instrcution type restrictions. +* and its fields don't violate particular instruction type restrictions. */ static const char *check_syntax (const struct ebpf_insn *ins)
@@ -1954,7 +1954,7 @@ log_loop(const struct bpf_verifier *bvf)* First pass goes though all instructions in the set, checks that each * instruction is a valid one (correct syntax, valid field values, etc.) * and constructs control flow graph (CFG). -* Then deapth-first search is performed over the constructed graph. +* Then depth-first search is performed over the constructed graph. * Programs with unreachable instructions and/or loops will be rejected. */ static int
@@ -1981,7 +1981,7 @@ validate(struct bpf_verifier *bvf)/* * construct CFG, jcc nodes have to outgoing edges, -* 'exit' nodes - none, all others nodes have exaclty one +* 'exit' nodes - none, all other nodes have exactly one * outgoing edge. */ switch (ins->code) {
@@ -2251,7 +2251,7 @@ evaluate(struct bpf_verifier *bvf) idx =get_node_idx (bvf, node); op = ins[idx].code; -/* for jcc node make a copy of evaluatoion state */ +/* for jcc node make a copy of evaluation state */ if (node->nb_edge >1 ) rc |=save_eval_state (bvf, node);
Signature · 1 line
2.30.2
PATCH v3 7/18 acl: fix spelling errors
In reply to Stephen HemmingerLots of little typos in comments
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
lib/acl/acl.h +2 -2
@@ -45,7 +45,7 @@ struct rte_acl_bitset {* Each transition is 64 bit value with the following format: * | node_type_specific : 32 | node_type : 3 | node_addr : 29 | * For all node types except RTE_ACL_NODE_MATCH, node_addr is an index -* to the start of the node in the transtions array. +* to the start of the node in the transitions array. * Few different node types are used: * RTE_ACL_NODE_MATCH: * node_addr value is and index into an array that contains the return value
@@ -66,7 +66,7 @@ struct rte_acl_bitset {* RTE_ACL_NODE_SINGLE: * always transitions to the same node regardless of the input value. * RTE_ACL_NODE_DFA: -* that node consits of up to 256 transitions. +* that node consists of up to 256 transitions. * In attempt to conserve space all transitions are divided into 4 consecutive * groups, by 64 transitions per group: * group64[i] contains transitions[i * 64, .. i * 64 + 63].
lib/acl/acl_bld.c +1 -1
@@ -1494,7 +1494,7 @@ acl_set_data_indexes(struct rte_acl_ctx *ctx)/* * Internal routine, performs 'build' phase of trie generation: * - setups build context. -* - analizes given set of rules. +* - analyzes given set of rules. * - builds internal tree(s). */ static int
lib/acl/acl_run_avx2.h +1 -1
@@ -125,7 +125,7 @@ acl_process_matches_avx2x8(const struct rte_acl_ctx *ctx,/* For each transition: put low 32 into tr_lo and high 32 into tr_hi */ ACL_TR_HILO (mm256, __m256, t0, t1, lo, hi); -/* Keep transitions wth NOMATCH intact. */ +/* Keep transitions with NOMATCH intact. */ *tr_lo =_mm256_blendv_epi8 (*tr_lo, lo, matches); *tr_hi =_mm256_blendv_epi8 (*tr_hi, hi, matches); }
Signature · 1 line
2.30.2
PATCH v3 8/18 eal: fix typos in comments
In reply to Stephen HemmingerMinor spelling errors.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
lib/eal/include/rte_function_versioning.h +1 -1
@@ -15,7 +15,7 @@/* * Provides backwards compatibility when updating exported functions. -* When a symol is exported from a library to provide an API, it also provides a +* When a symbol is exported from a library to provide an API, it also provides a * calling convention (ABI) that is embodied in its name, return type, * arguments, etc. On occasion that function may need to change to accommodate * new functionality, behavior, etc. When that occurs, it is desirable to
lib/eal/windows/include/fnmatch.h +1 -1
@@ -30,7 +30,7 @@ extern "C" {* with the given regular expression pattern. * * @param pattern -* regular expression notation decribing the pattern to match +* regular expression notation describing the pattern to match * * @param string * source string to searcg for the pattern
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v3 08/18] eal: fix typos in comments
Quoted 3 lines · Stephen Hemminger
Minor spelling errors.
Signed-off-by Stephen Hemminger <[email protected]>
Acked-by Ray Kinsella <[email protected]>
PATCH v3 9/18 net: fix spelling error in gtp comment
In reply to Stephen HemmingerMore codespell finds.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/net/rte_gtp.h +3 -3
@@ -142,9 +142,9 @@ struct rte_gtp_psc_type1_hdr {/** GTP header length */ #define RTE_ETHER_GTP_HLEN \ (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr)) -/* GTP next protocal type */ -#define RTE_GTP_TYPE_IPV4 0x40/**< GTP next protocal type IPv4 */ -#define RTE_GTP_TYPE_IPV6 0x60/**< GTP next protocal type IPv6 */ +/* GTP next protocol type */ +#define RTE_GTP_TYPE_IPV4 0x40/**< GTP next protocol type IPv4 */ +#define RTE_GTP_TYPE_IPV6 0x60/**< GTP next protocol type IPv6 */ /* GTP destination port number */ #define RTE_GTPC_UDP_PORT 2123/**< GTP-C UDP destination port */ #define RTE_GTPU_UDP_PORT 2152/**< GTP-U UDP destination port */
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v3 09/18] net: fix spelling error in gtp comment
Quoted 3 lines · Stephen Hemminger
More codespell finds.
Signed-off-by Stephen Hemminger <[email protected]>
Acked-by Olivier Matz <[email protected]>
Thanks!
PATCH v3 10/18 bbdev: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/bbdev/rte_bbdev.c +1 -1
@@ -138,7 +138,7 @@ rte_bbdev_data_alloc(void) }/* -* Find data alocated for the device or if not found return first unused bbdev +* Find data allocated for the device or if not found return first unused bbdev * data. If all structures are in use and none is used by the device return * NULL. */
Signature · 1 line
2.30.2
PATCH v3 11/18 pipeline: fix spellin error in comment
In reply to Stephen HemmingerMinor typo
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/pipeline/rte_swx_pipeline.h +1 -1
@@ -633,7 +633,7 @@ struct rte_swx_pipeline_selector_params {const char *group_id_field_name;/** The set of fields used to select (through a hashing scheme) the -* member within the current group. Inputs into the seletion operation. +* member within the current group. Inputs into the selection operation. * Restriction: All the selector fields must be part of the same struct, * i.e. part of the same header or part of the meta-data structure. */
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v3 11/18] pipeline: fix spellin error in comment
Quoted 33 lines
-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Thursday, October 14, 2021 10:56 PM
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Dumitrescu, Cristian <[email protected]>
Subject: [PATCH v3 11/18] pipeline: fix spellin error in commentMinor typo
Signed-off-by Stephen Hemminger <[email protected]>--- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/pipeline/rte_swx_pipeline.h +0
-1@@ -633,7 +633,7 @@ struct rte_swx_pipeline_selector_params {const char *group_id_field_name;/** The set of fields used to select (through a hashing scheme) the -* member within the current group. Inputs into the seletion operation.
lib/pipeline/rte_swx_pipeline.h +1
-0+* member within the current group. Inputs into the selection operation.
lib/pipeline/rte_swx_pipeline.h +0
-1* Restriction: All the selector fields must be part of the same struct, * i.e. part of the same header or part of the meta-data structure. */ --
Quoted 1 line
2.30.2
Thanks, Stephen.
PATCH v3 12/18 hash: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/hash/rte_thash.c +1 -1
@@ -28,7 +28,7 @@ EAL_REGISTER_TAILQ(rte_thash_tailq)/** * Table of some irreducible polinomials over GF(2). -* For lfsr they are reperesented in BE bit order, and +* For lfsr they are represented in BE bit order, and * x^0 is masked out. * For example, poly x^5 + x^2 + 1 will be represented * as (101001b & 11111b) = 01001b = 0x9
Signature · 1 line
2.30.2
PATCH v3 13/18 rib: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rib/rte_rib6.c +1 -1
@@ -199,7 +199,7 @@ rte_rib6_lookup_exact(struct rte_rib6 *rib, }/* -* Traverses on subtree and retreeves more specific routes +* Traverses on subtree and retrieves more specific routes * for a given in args ip/depth prefix * last = NULL means the first invocation */
Signature · 1 line
2.30.2
PATCH v3 14/18 sched: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/sched/rte_sched.c +1 -1
@@ -579,7 +579,7 @@ rte_sched_subport_config_qsize(struct rte_sched_subport *subport) subport->qsize_add[0 ] =0 ; -/* Strict prority traffic class */ +/* Strict priority traffic class */ for (i =1 ; i <RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE ; i++) subport->qsize_add[i] = subport->qsize_add[i-1 ] + subport->qsize[i-1 ];
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v3 14/18] sched: fix typo in comment
Quoted 33 lines
-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Thursday, October 14, 2021 10:56 PM
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Dumitrescu, Cristian <[email protected]>; Singh, Jasvinder <[email protected]>
Subject: [PATCH v3 14/18] sched: fix typo in commentYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>--- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/sched/rte_sched.c +1
-1@@ -579,7 +579,7 @@ rte_sched_subport_config_qsize(struct rte_sched_subport *subport) subport->qsize_add[0] = 0; -/* Strict prority traffic class */ +/* Strict priority traffic class */ for (i =1 ; i <RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE ; i++) subport->qsize_add[i] = subport->qsize_add[i-1] + subport-Quoted 1 line
qsize[i-1];
Quoted 2 lines
--
2.30.2
Thanks, Stephen.
PATCH v3 15/18 vhost: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/vhost/rte_vhost.h +2 -2
@@ -771,7 +771,7 @@ rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx,/** * Set split inflight descriptor. * -* This function save descriptors that has been comsumed in available +* This function save descriptors that have been consumed in available * ring * * @param vid
@@ -790,7 +790,7 @@ rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx,/** * Set packed inflight descriptor and get corresponding inflight entry * -* This function save descriptors that has been comsumed +* This function save descriptors that have been consumed * * @param vid * vhost device ID
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v3 15/18] vhost: fix typo in comment
Quoted 38 lines
-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Friday, October 15, 2021 5:56 AM
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Subject: [PATCH v3 15/18] vhost: fix typo in commentYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>--- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)lib/vhost/rte_vhost.h +1
-1@@ -771,7 +771,7 @@ rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx,/** * Set split inflight descriptor. * -* This function save descriptors that has been comsumed in available +* This function save descriptors that have been consumed in available * ring * * @param vid
lib/vhost/rte_vhost.h +1
-1@@ -790,7 +790,7 @@ rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx,/** * Set packed inflight descriptor and get corresponding inflight entry * -* This function save descriptors that has been comsumed +* This function save descriptors that have been consumed * * @param vid
Quoted 3 lines
* vhost device ID
--
2.30.2
Reviewed-by Chenbo Xia <[email protected]>
Thanks!
PATCH v3 16/18 ip_frag: fix typos
In reply to Stephen HemmingerMinor typos in comment.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/ip_frag/rte_ipv4_reassembly.c +1 -1
@@ -80,7 +80,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp)/* * Process new mbuf with fragment of IPV4 packet. -* Incoming mbuf should have it's l2_len/l3_len fields setuped correclty. +* Incoming mbuf should have it's l2_len/l3_len fields setup correctly. * @param tbl * Table where to lookup/add the fragmented packet. * @param mb
Signature · 1 line
2.30.2
PATCH v3 17/18 test-pmd: fix spelling errors in comments
In reply to Stephen HemmingerMore typos
Signed-off-by Stephen Hemminger <[email protected]>
--- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
app/test-pmd/cmdline.c +1 -1
@@ -3654,7 +3654,7 @@ parse_item_list(const char *str, const char *item_name, unsigned int max_items,return nb_item;/* -* Then, check that all values in the list are differents. +* Then, check that all values in the list are different. * No optimization here... */ for (i =0 ; i < nb_item; i++) {
app/test-pmd/config.c +2 -2
@@ -2777,7 +2777,7 @@ port_rss_reta_info(portid_t port_id, }/* -* Displays the RSS hash functions of a port, and, optionaly, the RSS hash +* Displays the RSS hash functions of a port, and, optionally, the RSS hash * key of the port. */ void
@@ -4950,7 +4950,7 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx) { port->mc_addr_nb--;if (addr_idx == port->mc_addr_nb) { -/* No need to recompact the set of multicast addressses. */ +/* No need to recompact the set of multicast addresses. */ if (port->mc_addr_nb ==0 ) {/* free the pool of multicast addresses. */ free (port->mc_addr_pool);
app/test-pmd/icmpecho.c +1 -1
@@ -54,7 +54,7 @@ arp_op_name(uint16_t arp_op)default :break ; } -return "Unkwown ARP op" ; +return "Unknown ARP op" ; } static const char *
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v3 17/18] test-pmd: fix spelling errors in comments
Quoted 7 lines
-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Friday, October 15, 2021 05:57
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Li, Xiaoyun <[email protected]>
Subject: [PATCH v3 17/18] test-pmd: fix spelling errors in comments
app/test-pmd: fix spelling errors in comments
Except the title,
Acked-by Xiaoyun Li <[email protected]>
Quoted 61 lines
More typos
Signed-off-by Stephen Hemminger <[email protected]>--- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)app/test-pmd/cmdline.c index renamed from app/test-pmd/cmdline.c +0
-0
826256b0b346..50af096c6a6e100644app/test-pmd/cmdline.c +1
-1@@ -3654,7 +3654,7 @@ parse_item_list(const char *str, const char *item_name, unsigned int max_items, return nb_item;/* -* Then, check that all values in the list are differents. +* Then, check that all values in the list are different. * No optimization here... */ app/test-pmd/cmdline.c +0
-0for (i =0 ; i < nb_item; i++) {app/test-pmd/config.c index renamed from app/test-pmd/config.c +0
-0
9c66329e96ee..27907c3204a9100644app/test-pmd/config.c +3
-2@@ -2777,7 +2777,7 @@ port_rss_reta_info(portid_t port_id, }/* -* Displays the RSS hash functions of a port, and, optionaly, the RSS hash +* Displays the RSS hash functions of a port, and, optionally, the RSS +hash * key of the port. */ void @@ -4950,7 +4950,7 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx) { port->mc_addr_nb--;if (addr_idx == port->mc_addr_nb) { -/* No need to recompact the set of multicast addressses. */ +/* No need to recompact the set of multicast addresses. */ if (port->mc_addr_nb ==0 ) {/* free the pool of multicast addresses. */ free (port->mc_addr_pool);app/test-pmd/icmpecho.c index renamed from app/test-pmd/icmpecho.c +0
-0
8f1d68a83afd..d6620f5f6a47100644app/test-pmd/icmpecho.c +1
-2@@ -54,7 +54,7 @@ arp_op_name(uint16_t arp_op)default :break ; } -return "Unkwown ARP op" ; +return "Unknown ARP op" ; } static const char * --2.30.2
PATCH v3 18/18 test: fix spelling errors in comments
In reply to Stephen HemmingerLots of little typos in test programs.
Signed-off-by Stephen Hemminger <[email protected]>
--- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_fib.c | 2 +- app/test/test_fib6.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_malloc.c | 4 ++-- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_rib.c | 2 +- app/test/test_rib6.c | 2 +- app/test/test_timer.c | 2 +- 20 files changed, 33 insertions(+), 33 deletions(-)
app/test/test_atomic.c +1 -1
@@ -88,7 +88,7 @@* * - Invoke ``test_atomic_exchange`` on each lcore. Before doing * anything else, the cores wait for a synchronization event. -* Each core then does the follwoing for N iterations: +* Each core then does the following for N iterations: * * Generate a new token with a data integrity check * Exchange the new token for previously generated token
app/test/test_barrier.c +1 -1
@@ -66,7 +66,7 @@ struct plock_test {struct lcore_plock_test {struct plock_test *pt[2 ];/* shared, lock-protected data */ uint64_t sum[2 ];/* local copy of the shared data */ -uint64_t iter;/* number of iterations to perfom */ +uint64_t iter;/* number of iterations to perform */ uint32_t lc;/* given lcore id */ };
app/test/test_bpf.c +1 -1
@@ -2391,7 +2391,7 @@ static const struct ebpf_insn test_call5_prog[] = { }, }; -/* String comparision impelementation, return 0 if equal else difference */ +/* String comparison implementation, return 0 if equal else difference */ static uint32_t dummy_func5 (const char *s1,const char *s2) {
app/test/test_compressdev.c +1 -1
@@ -2033,7 +2033,7 @@ test_deflate_comp_decomp(const struct interim_data_params *int_data, test_priv_data.all_decomp_data = &all_decomp_data; test_priv_data.decomp_produced_data_size = &decomp_produced_data_size; - test_priv_data.num_priv_xforms =0 ;/* it's used for deompression only */ + test_priv_data.num_priv_xforms =0 ;/* it's used for decompression only */ capa =rte_compressdev_capability_get (0 ,RTE_COMP_ALGO_DEFLATE );if (capa ==NULL ) {
app/test/test_fib.c +1 -1
@@ -159,7 +159,7 @@ test_add_del_invalid(void)RTE_TEST_ASSERT (ret <0 ,"Call succeeded with invalid parameters\n" ); -/*Create valid fib to use in rest of test. */ +/* Create valid fib to use in rest of test. */ fib =rte_fib_create (__func__,SOCKET_ID_ANY , &config);RTE_TEST_ASSERT (fib !=NULL ,"Failed to create FIB\n" );
app/test/test_fib6.c +1 -1
@@ -162,7 +162,7 @@ test_add_del_invalid(void)RTE_TEST_ASSERT (ret <0 ,"Call succeeded with invalid parameters\n" ); -/*Create valid fib to use in rest of test. */ +/* Create valid fib to use in rest of test. */ fib =rte_fib6_create (__func__,SOCKET_ID_ANY , &config);RTE_TEST_ASSERT (fib !=NULL ,"Failed to create FIB\n" );
app/test/test_func_reentrancy.c +3 -3
@@ -253,7 +253,7 @@ hash_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple times simultaneously */ +/* create multiple times simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (hash_name,sizeof (hash_name),"fr_test_%d_%d" , lcore_self, i); hash_params.name = hash_name;
@@ -321,7 +321,7 @@ fbk_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (fbk_name,sizeof (fbk_name),"fr_test_%d_%d" , lcore_self, i); fbk_params.name = fbk_name;
@@ -387,7 +387,7 @@ lpm_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_LPM_ITER_TIMES ; i++) {snprintf (lpm_name,sizeof (lpm_name),"fr_test_%d_%d" , lcore_self, i); lpm =rte_lpm_create (lpm_name,SOCKET_ID_ANY , &config);
app/test/test_ipsec.c +1 -1
@@ -653,7 +653,7 @@ create_crypto_session(struct ipsec_unitest_params *ut,if (s ==NULL )return -ENOMEM ; -/* initiliaze SA crypto session for device */ +/* initialize SA crypto session for device */ rc =rte_cryptodev_sym_session_init (dev_id, s, ut->crypto_xforms, qp->mp_session_private);if (rc ==0 ) {
app/test/test_link_bonding.c +1 -1
@@ -3041,7 +3041,7 @@ test_balance_tx_burst_slave_tx_fail(void) first_tx_fail_idx =TEST_BAL_SLAVE_TX_FAIL_BURST_SIZE_1 -TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; -/* copy mbuf referneces for expected transmission failures */ +/* copy mbuf references for expected transmission failures */ for (i =0 ; i <TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; i++) expected_fail_pkts[i] = pkts_burst_1[i + first_tx_fail_idx];
app/test/test_lpm.c +3 -3
@@ -179,7 +179,7 @@ test3(void) status =rte_lpm_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/* Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -217,7 +217,7 @@ test4(void) status =rte_lpm_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/* Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -255,7 +255,7 @@ test5(void) status =rte_lpm_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/* Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
app/test/test_lpm6.c +7 -7
@@ -261,7 +261,7 @@ test4(void) status =rte_lpm6_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/* Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -299,7 +299,7 @@ test5(void) status =rte_lpm6_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/* Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -337,7 +337,7 @@ test6(void) status =rte_lpm6_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/* Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -375,7 +375,7 @@ test7(void) status =rte_lpm6_lookup_bulk_func (NULL , ip, next_hop_return,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/* Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -413,7 +413,7 @@ test8(void) status =rte_lpm6_delete_bulk_func (NULL , ip, depth,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/* Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -433,7 +433,7 @@ test8(void)/* * Call add, lookup and delete for a single rule with depth < 24. * Check all the combinations for the first three bytes that result in a hit. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test9 (void )
@@ -1738,7 +1738,7 @@ test27(void)* Call add, lookup and delete for a single rule with maximum 21bit next_hop * size. * Check that next_hop returned from lookup is equal to provisioned value. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test28 (void )
app/test/test_malloc.c +2 -2
@@ -603,7 +603,7 @@ test_realloc_numa(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 )printf ("WARNING: realloc_socket test needs memory on multiple sockets!\n" );
@@ -971,7 +971,7 @@ test_alloc_socket(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 ) {printf ("WARNING: alloc_socket test needs memory on multiple sockets!\n" ); }
app/test/test_mbuf.c +1 -1
@@ -1148,7 +1148,7 @@ test_refcnt_mbuf(void)rte_eal_mp_wait_lcore (); -/* check that we porcessed all references */ +/* check that we processed all references */ tref =0 ; main_lcore =rte_get_main_lcore ();
app/test/test_mempool.c +1 -1
@@ -628,7 +628,7 @@ test_mempool(void)if (test_mempool_basic_ex (mp_nocache) <0 )GOTO_ERR (ret, err); -/* mempool operation test based on single producer and single comsumer */ +/* mempool operation test based on single producer and single consumer */ if (test_mempool_sp_sc () <0 )GOTO_ERR (ret, err);
app/test/test_mempool_perf.c +1 -1
@@ -88,7 +88,7 @@ static uint32_t synchro;static unsigned n_get_bulk;static unsigned n_put_bulk; -/* number of objects retrived from mempool before putting them back */ +/* number of objects retrieved from mempool before putting them back */ static unsigned n_keep;/* number of enqueues / dequeues */
app/test/test_meter.c +3 -3
@@ -444,7 +444,7 @@ tm_test_srtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -551,7 +551,7 @@ tm_test_trtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -648,7 +648,7 @@ tm_test_trtcm_rfc4115_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
app/test/test_pmd_perf.c +1 -1
@@ -753,7 +753,7 @@ test_pmd_perf(void)"rte_eth_dev_start: err=%d, port=%d\n" , ret, portid); -/* always eanble promiscuous */ +/* always enable promiscuous */ ret =rte_eth_promiscuous_enable (portid);if (ret !=0 ) rte_exit(EXIT_FAILURE,
app/test/test_rib.c +1 -1
@@ -129,7 +129,7 @@ test_insert_invalid(void)RTE_TEST_ASSERT (node ==NULL ,"Call succeeded with invalid parameters\n" ); -/*Create valid rib to use in rest of test. */ +/* Create valid rib to use in rest of test. */ rib =rte_rib_create (__func__,SOCKET_ID_ANY , &config);RTE_TEST_ASSERT (rib !=NULL ,"Failed to create RIB\n" );
app/test/test_rib6.c +1 -1
@@ -130,7 +130,7 @@ test_insert_invalid(void)RTE_TEST_ASSERT (node ==NULL ,"Call succeeded with invalid parameters\n" ); -/*Create valid rib to use in rest of test. */ +/* Create valid rib to use in rest of test. */ rib =rte_rib6_create (__func__,SOCKET_ID_ANY , &config);RTE_TEST_ASSERT (rib !=NULL ,"Failed to create RIB\n" );
app/test/test_timer.c +1 -1
@@ -432,7 +432,7 @@ timer_basic_cb(struct rte_timer *tim, void *arg)return ; } -/* Explicitelly stop timer 0. Once stop() called, we can even +/* Explicitly stop timer 0. Once stop() called, we can even * erase the content of the structure: it is not referenced * anymore by any code (in case of dynamic structure, it can * be freed) */
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH v3 18/18] test: fix spelling errors in comments
Quoted 3 lines · Stephen Hemminger
Lots of little typos in test programs.
Signed-off-by Stephen Hemminger <[email protected]>
Reviewed-by Olivier Matz <[email protected]>
v4 cover fix docbook and spelling errors
In reply to Stephen HemmingerAfter finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments.
v4 - rebase and resend
PATCH v4 1/18 node: fix docbook typos
Spelling errors in comments including doxygen
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
lib/node/ethdev_rx_priv.h +1 -1
@@ -67,7 +67,7 @@ struct ethdev_rx_node_main *ethdev_rx_get_node_data_get(void);* * Get the Ethernet Rx node. * -* @retrun +* @return * Pointer to the Ethernet Rx node. */ struct rte_node_register *ethdev_rx_node_get (void );
lib/node/ethdev_tx_priv.h +1 -1
@@ -46,7 +46,7 @@ struct ethdev_tx_node_main *ethdev_tx_node_data_get(void);* * Get the Ethernet Tx node. * -* @retrun +* @return * Pointer to the Ethernet Tx node. */ struct rte_node_register *ethdev_tx_node_get (void );
lib/node/ip4_rewrite_priv.h +1 -1
@@ -49,7 +49,7 @@ struct ip4_rewrite_node_main {* * Get the ipv4 rewrite node. * -* @retrun +* @return * Pointer to the ipv4 rewrite node. */ struct rte_node_register *ip4_rewrite_node_get (void );
Signature · 1 line
2.30.2
PATCH v4 2/18 ipsec: fix spelling errors
In reply to Stephen HemmingerLots of typos in comments found by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)
lib/ipsec/esp_inb.c +2 -2
@@ -475,7 +475,7 @@ trs_process_check(struct rte_mbuf *mb, struct rte_mbuf **ml,/* * packet checks for tunnel mode: -* - same as for trasnport mode +* - same as for transport mode * - esp tail next proto contains expected for that SA value */ static inline int32_t
@@ -561,7 +561,7 @@ trs_process_step3(struct rte_mbuf *mb)static inline void tun_process_step3 (struct rte_mbuf *mb,uint64_t txof_msk,uint64_t txof_val) { -/* reset mbuf metatdata: L2/L3 len, packet type */ +/* reset mbuf metadata: L2/L3 len, packet type */ mb->packet_type =RTE_PTYPE_UNKNOWN ; mb->tx_offload = (mb->tx_offload & txof_msk) | txof_val;
lib/ipsec/esp_outb.c +1 -1
@@ -614,7 +614,7 @@ cpu_outb_trs_pkt_prepare(const struct rte_ipsec_session *ss,/* * process outbound packets for SA with ESN support, -* for algorithms that require SQN.hibits to be implictly included +* for algorithms that require SQN.hibits to be implicitly included * into digest computation. * In that case we have to move ICV bytes back to their proper place. */
lib/ipsec/ipsec_sad.c +1 -1
@@ -62,7 +62,7 @@ EAL_REGISTER_TAILQ(rte_ipsec_sad_tailq)* Inserts a rule into an appropriate hash table, * updates the value for a given SPI in SPI_ONLY hash table * reflecting presence of more specific rule type in two LSBs. -* Updates a counter that reflects the number of rules whith the same SPI. +* Updates a counter that reflects the number of rules with the same SPI. */ static inline int add_specific(struct rte_ipsec_sad *sad, const void *key,
lib/ipsec/sa.c +1 -1
@@ -136,7 +136,7 @@ ipsec_sa_size(uint64_t type, uint32_t *wnd_sz, uint32_t *nb_bucket)/* * RFC 4303 recommends 64 as minimum window size. * there is no point to use ESN mode without SQN window, -* so make sure we have at least 64 window when ESN is enalbed. +* so make sure we have at least 64 window when ESN is enabled. */ wsz = ((type &RTE_IPSEC_SATP_ESN_MASK ) == RTE_IPSEC_SATP_ESN_DISABLE) ?
lib/ipsec/sa.h +1 -1
@@ -122,7 +122,7 @@ struct rte_ipsec_sa {* In case of SA handled by multiple threads *sqn* cacheline * could be shared by multiple cores. * To minimise performance impact, we try to locate in a separate -* place from other frequently accesed data. +* place from other frequently accessed data. */ union {uint64_t outb;
Signature · 1 line
2.30.2
Re: [PATCH v4 02/18] ipsec: fix spelling errors
Quoted 79 lines · Stephen Hemminger
Lots of typos in comments found by codespell
Signed-off-by Stephen Hemminger <[email protected]>--- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c | 2 +- lib/ipsec/sa.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)lib/ipsec/esp_inb.c +2
-2@@ -475,7 +475,7 @@ trs_process_check(struct rte_mbuf *mb, struct rte_mbuf **ml,/* * packet checks for tunnel mode: -* - same as for trasnport mode +* - same as for transport mode * - esp tail next proto contains expected for that SA value */ static inline int32_t@@ -561,7 +561,7 @@ trs_process_step3(struct rte_mbuf *mb)static inline void tun_process_step3 (struct rte_mbuf *mb,uint64_t txof_msk,uint64_t txof_val) { -/* reset mbuf metatdata: L2/L3 len, packet type */ +/* reset mbuf metadata: L2/L3 len, packet type */ mb->packet_type =RTE_PTYPE_UNKNOWN ; mb->tx_offload = (mb->tx_offload & txof_msk) | txof_val;lib/ipsec/esp_outb.c +1
-1@@ -614,7 +614,7 @@ cpu_outb_trs_pkt_prepare(const struct rte_ipsec_session *ss,/* * process outbound packets for SA with ESN support, -* for algorithms that require SQN.hibits to be implictly included +* for algorithms that require SQN.hibits to be implicitly included * into digest computation. * In that case we have to move ICV bytes back to their proper place. */ lib/ipsec/ipsec_sad.c +1
-1@@ -62,7 +62,7 @@ EAL_REGISTER_TAILQ(rte_ipsec_sad_tailq)* Inserts a rule into an appropriate hash table, * updates the value for a given SPI in SPI_ONLY hash table * reflecting presence of more specific rule type in two LSBs. -* Updates a counter that reflects the number of rules whith the same SPI. +* Updates a counter that reflects the number of rules with the same SPI. */ static inline int add_specific(struct rte_ipsec_sad *sad, const void *key,lib/ipsec/sa.c +1
-1@@ -136,7 +136,7 @@ ipsec_sa_size(uint64_t type, uint32_t *wnd_sz, uint32_t *nb_bucket)/* * RFC 4303 recommends 64 as minimum window size. * there is no point to use ESN mode without SQN window, -* so make sure we have at least 64 window when ESN is enalbed. +* so make sure we have at least 64 window when ESN is enabled. */ wsz = ((type &RTE_IPSEC_SATP_ESN_MASK ) == RTE_IPSEC_SATP_ESN_DISABLE) ?lib/ipsec/sa.h +0
-0
lib/ipsec/sa.h struct rte_ipsec_sa { · line 128
Quoted 8 lines
lib/ipsec/sa.h +1
-1@@ -122,7 +122,7 @@ struct rte_ipsec_sa {* In case of SA handled by multiple threads *sqn* cacheline * could be shared by multiple cores. * To minimise performance impact, we try to locate in a separate -* place from other frequently accesed data. +* place from other frequently accessed data. */ union {uint64_t outb;
Signature · 2 lines
Regards, Vladimir
PATCH v4 3/18 eventdev: fix typo in comment
In reply to Stephen HemmingerTypo in comment found by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/eventdev/rte_event_timer_adapter.c +1 -1
@@ -525,7 +525,7 @@ event_buffer_flush(struct event_buffer *bufp, uint8_t dev_id, uint8_t port_id,RTE_ASSERT (head_idx <EVENT_BUFFER_SZ && tail_idx <EVENT_BUFFER_SZ ); -/* Determine the largest contigous run we can attempt to enqueue to the +/* Determine the largest contiguous run we can attempt to enqueue to the * event device. */ if (head_idx > tail_idx)
Signature · 1 line
2.30.2
PATCH v4 4/18 power: fix typo in comment
In reply to Stephen HemmingerMore spelling errors caught by codespell
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/power/power_acpi_cpufreq.c +1 -1
@@ -159,7 +159,7 @@ power_get_available_freqs(struct acpi_power_info *pi) goto out; } -/* Store the available frequncies into power context */ +/* Store the available frequencies into power context */ for (i =0 , pi->nb_freqs =0 ; i < count; i++) {POWER_DEBUG_TRACE ("Lcore %u frequency[%d]: %s\n" , pi->lcore_id, i, freqs[i]);
Signature · 1 line
2.30.2
PATCH v4 5/18 rcu: fix typo in comment
In reply to Stephen HemmingerAnother codespell find.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rcu/rte_rcu_qsbr.h +1 -1
@@ -362,7 +362,7 @@ rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id)/* The reader can go offline only after the load of the * data structure is completed. i.e. any load of the -* data strcture can not move after this store. +* data structure can not move after this store. */ __atomic_store_n(&v->qsbr_cnt[thread_id].cnt,
Signature · 1 line
2.30.2
RE: [PATCH v4 05/18] rcu: fix typo in comment
<snip>
Quoted 4 lines
Another codespell find.
Signed-off-by Stephen Hemminger <[email protected]>
Thanks Stephen
Reviewed-by Honnappa Nagarahalli <[email protected]>
Quoted 20 lines
--- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/rcu/rte_rcu_qsbr.h index renamed from lib/rcu/rte_rcu_qsbr.h +0
-0
18811c1cc106..62a420a785fc100644lib/rcu/rte_rcu_qsbr.h +1
-1@@ -362,7 +362,7 @@ rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id)/* The reader can go offline only after the load of the * data structure is completed. i.e. any load of the -* data strcture can not move after this store. +* data structure can not move after this store. */ __atomic_store_n(&v->qsbr_cnt[thread_id].cnt,
--
2.30.2
PATCH v4 6/18 bpf: fix spelling in comments
In reply to Stephen HemmingerFound by running codespell on the bpf implementation.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_load_elf.c | 2 +- lib/bpf/bpf_pkt.c | 2 +- lib/bpf/bpf_validate.c | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-)
lib/bpf/bpf_jit_x86.c +1 -1
@@ -1245,7 +1245,7 @@ emit_epilog(struct bpf_jit_state *st)uint32_t i;int32_t spil, ofs; -/* if we allready have an epilog generate a jump to it */ +/* if we already have an epilog generate a jump to it */ if (st->exit.num++ !=0 ) {emit_abs_jmp (st, st->exit.off);return ;
lib/bpf/bpf_load_elf.c +1 -1
@@ -80,7 +80,7 @@ resolve_xsym(const char *sn, size_t ofs, struct ebpf_insn *ins, size_t ins_sz,if (type ==RTE_BPF_XTYPE_FUNC ) {/* we don't support multiple functions per BPF module, -* so treat EBPF_PSEUDO_CALL to extrernal function +* so treat EBPF_PSEUDO_CALL to external function * as an ordinary EBPF_CALL. */ if (ins[idx].src_reg ==EBPF_PSEUDO_CALL ) {
lib/bpf/bpf_pkt.c +1 -1
@@ -166,7 +166,7 @@ bpf_eth_cbh_add(struct bpf_eth_cbh *cbh, uint16_t port, uint16_t queue) }/* -* BPF packet processing routinies. +* BPF packet processing routines. */ static inline uint32_t
lib/bpf/bpf_validate.c +4 -4
@@ -1730,7 +1730,7 @@ static const struct bpf_ins_check ins_chk[UINT8_MAX + 1] = {/* * make sure that instruction syntax is valid, -* and it fields don't violate partciular instrcution type restrictions. +* and its fields don't violate particular instruction type restrictions. */ static const char *check_syntax (const struct ebpf_insn *ins)
@@ -1961,7 +1961,7 @@ log_loop(const struct bpf_verifier *bvf)* First pass goes though all instructions in the set, checks that each * instruction is a valid one (correct syntax, valid field values, etc.) * and constructs control flow graph (CFG). -* Then deapth-first search is performed over the constructed graph. +* Then depth-first search is performed over the constructed graph. * Programs with unreachable instructions and/or loops will be rejected. */ static int
@@ -1988,7 +1988,7 @@ validate(struct bpf_verifier *bvf)/* * construct CFG, jcc nodes have to outgoing edges, -* 'exit' nodes - none, all others nodes have exaclty one +* 'exit' nodes - none, all other nodes have exactly one * outgoing edge. */ switch (ins->code) {
@@ -2258,7 +2258,7 @@ evaluate(struct bpf_verifier *bvf) idx =get_node_idx (bvf, node); op = ins[idx].code; -/* for jcc node make a copy of evaluatoion state */ +/* for jcc node make a copy of evaluation state */ if (node->nb_edge >1 ) rc |=save_eval_state (bvf, node);
Signature · 1 line
2.30.2
PATCH v4 7/18 acl: fix spelling errors
In reply to Stephen HemmingerLots of little typos in comments
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
lib/acl/acl.h +2 -2
@@ -45,7 +45,7 @@ struct rte_acl_bitset {* Each transition is 64 bit value with the following format: * | node_type_specific : 32 | node_type : 3 | node_addr : 29 | * For all node types except RTE_ACL_NODE_MATCH, node_addr is an index -* to the start of the node in the transtions array. +* to the start of the node in the transitions array. * Few different node types are used: * RTE_ACL_NODE_MATCH: * node_addr value is and index into an array that contains the return value
@@ -66,7 +66,7 @@ struct rte_acl_bitset {* RTE_ACL_NODE_SINGLE: * always transitions to the same node regardless of the input value. * RTE_ACL_NODE_DFA: -* that node consits of up to 256 transitions. +* that node consists of up to 256 transitions. * In attempt to conserve space all transitions are divided into 4 consecutive * groups, by 64 transitions per group: * group64[i] contains transitions[i * 64, .. i * 64 + 63].
lib/acl/acl_bld.c +1 -1
@@ -1494,7 +1494,7 @@ acl_set_data_indexes(struct rte_acl_ctx *ctx)/* * Internal routine, performs 'build' phase of trie generation: * - setups build context. -* - analizes given set of rules. +* - analyzes given set of rules. * - builds internal tree(s). */ static int
lib/acl/acl_run_avx2.h +1 -1
@@ -125,7 +125,7 @@ acl_process_matches_avx2x8(const struct rte_acl_ctx *ctx,/* For each transition: put low 32 into tr_lo and high 32 into tr_hi */ ACL_TR_HILO (mm256, __m256, t0, t1, lo, hi); -/* Keep transitions wth NOMATCH intact. */ +/* Keep transitions with NOMATCH intact. */ *tr_lo =_mm256_blendv_epi8 (*tr_lo, lo, matches); *tr_hi =_mm256_blendv_epi8 (*tr_hi, hi, matches); }
Signature · 1 line
2.30.2
PATCH v4 8/18 eal: fix typos in comments
In reply to Stephen HemmingerMinor spelling errors.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
lib/eal/include/rte_function_versioning.h +1 -1
@@ -15,7 +15,7 @@/* * Provides backwards compatibility when updating exported functions. -* When a symol is exported from a library to provide an API, it also provides a +* When a symbol is exported from a library to provide an API, it also provides a * calling convention (ABI) that is embodied in its name, return type, * arguments, etc. On occasion that function may need to change to accommodate * new functionality, behavior, etc. When that occurs, it is desirable to
lib/eal/windows/include/fnmatch.h +1 -1
@@ -30,7 +30,7 @@ extern "C" {* with the given regular expression pattern. * * @param pattern -* regular expression notation decribing the pattern to match +* regular expression notation describing the pattern to match * * @param string * source string to searcg for the pattern
Signature · 1 line
2.30.2
Re: [PATCH v4 08/18] eal: fix typos in comments
Quoted 27 lines · Stephen Hemminger
Minor spelling errors.
Signed-off-by Stephen Hemminger <[email protected]>--- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)lib/eal/include/rte_function_versioning.h +1
-1@@ -15,7 +15,7 @@/* * Provides backwards compatibility when updating exported functions. -* When a symol is exported from a library to provide an API, it also provides a +* When a symbol is exported from a library to provide an API, it also provides a * calling convention (ABI) that is embodied in its name, return type, * arguments, etc. On occasion that function may need to change to accommodate * new functionality, behavior, etc. When that occurs, it is desirable to lib/eal/windows/include/fnmatch.h +0
-0
lib/eal/windows/include/fnmatch.h extern "C" { · line 36
Quoted 8 lines
lib/eal/windows/include/fnmatch.h +1
-1@@ -30,7 +30,7 @@ extern "C" {* with the given regular expression pattern. * * @param pattern -* regular expression notation decribing the pattern to match +* regular expression notation describing the pattern to match * * @param string * source string to searcg for the pattern
Acked-by Ray Kinsella <[email protected]>
PATCH v4 9/18 net: fix spelling error in gtp comment
In reply to Stephen HemmingerMore codespell finds.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/net/rte_gtp.h +3 -3
@@ -142,9 +142,9 @@ struct rte_gtp_psc_type1_hdr {/** GTP header length */ #define RTE_ETHER_GTP_HLEN \ (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr)) -/* GTP next protocal type */ -#define RTE_GTP_TYPE_IPV4 0x40/**< GTP next protocal type IPv4 */ -#define RTE_GTP_TYPE_IPV6 0x60/**< GTP next protocal type IPv6 */ +/* GTP next protocol type */ +#define RTE_GTP_TYPE_IPV4 0x40/**< GTP next protocol type IPv4 */ +#define RTE_GTP_TYPE_IPV6 0x60/**< GTP next protocol type IPv6 */ /* GTP destination port number */ #define RTE_GTPC_UDP_PORT 2123/**< GTP-C UDP destination port */ #define RTE_GTPU_UDP_PORT 2152/**< GTP-U UDP destination port */
Signature · 1 line
2.30.2
PATCH v4 10/18 bbdev: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/bbdev/rte_bbdev.c +1 -1
@@ -138,7 +138,7 @@ rte_bbdev_data_alloc(void) }/* -* Find data alocated for the device or if not found return first unused bbdev +* Find data allocated for the device or if not found return first unused bbdev * data. If all structures are in use and none is used by the device return * NULL. */
Signature · 1 line
2.30.2
PATCH v4 11/18 pipeline: fix spellin error in comment
In reply to Stephen HemmingerMinor typo
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/pipeline/rte_swx_pipeline.h +1 -1
@@ -647,7 +647,7 @@ struct rte_swx_pipeline_selector_params {const char *group_id_field_name;/** The set of fields used to select (through a hashing scheme) the -* member within the current group. Inputs into the seletion operation. +* member within the current group. Inputs into the selection operation. * Restriction: All the selector fields must be part of the same struct, * i.e. part of the same header or part of the meta-data structure. */
Signature · 1 line
2.30.2
RE: [PATCH v4 11/18] pipeline: fix spellin error in comment
Quoted 33 lines
-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Friday, November 12, 2021 12:02 AM
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Dumitrescu, Cristian <[email protected]>
Subject: [PATCH v4 11/18] pipeline: fix spellin error in commentMinor typo
Signed-off-by Stephen Hemminger <[email protected]>--- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/pipeline/rte_swx_pipeline.h +0
-1@@ -647,7 +647,7 @@ struct rte_swx_pipeline_selector_params {const char *group_id_field_name;/** The set of fields used to select (through a hashing scheme) the -* member within the current group. Inputs into the seletion operation.
lib/pipeline/rte_swx_pipeline.h +1
-0+* member within the current group. Inputs into the selection operation.
lib/pipeline/rte_swx_pipeline.h +0
-1* Restriction: All the selector fields must be part of the same struct, * i.e. part of the same header or part of the meta-data structure. */ --
Quoted 1 line
2.30.2
PATCH v4 12/18 hash: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/hash/rte_thash.c +1 -1
@@ -28,7 +28,7 @@ EAL_REGISTER_TAILQ(rte_thash_tailq)/** * Table of some irreducible polinomials over GF(2). -* For lfsr they are reperesented in BE bit order, and +* For lfsr they are represented in BE bit order, and * x^0 is masked out. * For example, poly x^5 + x^2 + 1 will be represented * as (101001b & 11111b) = 01001b = 0x9
Signature · 1 line
2.30.2
Re: [PATCH v4 12/18] hash: fix typo in comment
Quoted 13 lines · Stephen Hemminger
Yet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>--- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/hash/rte_thash.c +0
-0
lib/hash/rte_thash.c EAL_REGISTER_TAILQ(rte_thash_tailq) · line 34
Quoted 8 lines
lib/hash/rte_thash.c +1
-1@@ -28,7 +28,7 @@ EAL_REGISTER_TAILQ(rte_thash_tailq)/** * Table of some irreducible polinomials over GF(2). -* For lfsr they are reperesented in BE bit order, and +* For lfsr they are represented in BE bit order, and * x^0 is masked out. * For example, poly x^5 + x^2 + 1 will be represented * as (101001b & 11111b) = 01001b = 0x9
Signature · 2 lines
Regards, Vladimir
PATCH v4 13/18 rib: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rib/rte_rib6.c +1 -1
@@ -199,7 +199,7 @@ rte_rib6_lookup_exact(struct rte_rib6 *rib, }/* -* Traverses on subtree and retreeves more specific routes +* Traverses on subtree and retrieves more specific routes * for a given in args ip/depth prefix * last = NULL means the first invocation */
Signature · 1 line
2.30.2
Re: [PATCH v4 13/18] rib: fix typo in comment
Quoted 13 lines · Stephen Hemminger
Yet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>--- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/rib/rte_rib6.c +0
-0
lib/rib/rte_rib6.c rte_rib6_lookup_exact(struct rte_rib6 *rib, · line 205
Quoted 8 lines
lib/rib/rte_rib6.c +1
-1@@ -199,7 +199,7 @@ rte_rib6_lookup_exact(struct rte_rib6 *rib, }/* -* Traverses on subtree and retreeves more specific routes +* Traverses on subtree and retrieves more specific routes * for a given in args ip/depth prefix * last = NULL means the first invocation */
Signature · 2 lines
Regards, Vladimir
PATCH v4 14/18 sched: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/sched/rte_sched.c +1 -1
@@ -590,7 +590,7 @@ rte_sched_subport_config_qsize(struct rte_sched_subport *subport) subport->qsize_add[0 ] =0 ; -/* Strict prority traffic class */ +/* Strict priority traffic class */ for (i =1 ; i <RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE ; i++) subport->qsize_add[i] = subport->qsize_add[i-1 ] + subport->qsize[i-1 ];
Signature · 1 line
2.30.2
RE: [PATCH v4 14/18] sched: fix typo in comment
Quoted 33 lines
-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Friday, November 12, 2021 12:02 AM
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Dumitrescu, Cristian <[email protected]>; Singh, Jasvinder <[email protected]>
Subject: [PATCH v4 14/18] sched: fix typo in commentYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>--- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/sched/rte_sched.c +1
-1@@ -590,7 +590,7 @@ rte_sched_subport_config_qsize(struct rte_sched_subport *subport) subport->qsize_add[0] = 0; -/* Strict prority traffic class */ +/* Strict priority traffic class */ for (i =1 ; i <RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE ; i++) subport->qsize_add[i] = subport->qsize_add[i-1] + subport-Quoted 1 line
qsize[i-1];
Quoted 2 lines
--
2.30.2
PATCH v4 15/18 vhost: fix typo in comment
In reply to Stephen HemmingerYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/vhost/rte_vhost.h +2 -2
@@ -796,7 +796,7 @@ rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx,/** * Set split inflight descriptor. * -* This function save descriptors that has been comsumed in available +* This function save descriptors that has been consumed in available * ring * * @param vid
@@ -815,7 +815,7 @@ rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx,/** * Set packed inflight descriptor and get corresponding inflight entry * -* This function save descriptors that has been comsumed +* This function save descriptors that has been consumed * * @param vid * vhost device ID
Signature · 1 line
2.30.2
RE: [PATCH v4 15/18] vhost: fix typo in comment
Quoted 38 lines
-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Friday, November 12, 2021 8:02 AM
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Subject: [PATCH v4 15/18] vhost: fix typo in commentYet another spelling error found by codespell.
Signed-off-by Stephen Hemminger <[email protected]>--- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)lib/vhost/rte_vhost.h +1
-1@@ -796,7 +796,7 @@ rte_vhost_get_vhost_ring_inflight(int vid, uint16_t vring_idx,/** * Set split inflight descriptor. * -* This function save descriptors that has been comsumed in available +* This function save descriptors that has been consumed in available * ring * * @param vid
lib/vhost/rte_vhost.h +1
-1@@ -815,7 +815,7 @@ rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx,/** * Set packed inflight descriptor and get corresponding inflight entry * -* This function save descriptors that has been comsumed +* This function save descriptors that has been consumed * * @param vid
Quoted 3 lines
* vhost device ID
--
2.30.2
Acked-by Chenbo Xia <[email protected]>
PATCH v4 16/18 ip_frag: fix typos
In reply to Stephen HemmingerMinor typos in comment.
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/ip_frag/rte_ipv4_reassembly.c +1 -1
@@ -80,7 +80,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp)/* * Process new mbuf with fragment of IPV4 packet. -* Incoming mbuf should have it's l2_len/l3_len fields setuped correclty. +* Incoming mbuf should have it's l2_len/l3_len fields setup correctly. * @param tbl * Table where to lookup/add the fragmented packet. * @param mb
Signature · 1 line
2.30.2
PATCH v4 17/18 test-pmd: fix spelling errors in comments
In reply to Stephen HemmingerMore typos
Signed-off-by Stephen Hemminger <[email protected]>
--- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
app/test-pmd/cmdline.c +1 -1
@@ -3653,7 +3653,7 @@ parse_item_list(const char *str, const char *item_name, unsigned int max_items,return nb_item;/* -* Then, check that all values in the list are differents. +* Then, check that all values in the list are different. * No optimization here... */ for (i =0 ; i < nb_item; i++) {
app/test-pmd/config.c +2 -2
@@ -2965,7 +2965,7 @@ port_rss_reta_info(portid_t port_id, }/* -* Displays the RSS hash functions of a port, and, optionaly, the RSS hash +* Displays the RSS hash functions of a port, and, optionally, the RSS hash * key of the port. */ void
@@ -5250,7 +5250,7 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx) { port->mc_addr_nb--;if (addr_idx == port->mc_addr_nb) { -/* No need to recompact the set of multicast addressses. */ +/* No need to recompact the set of multicast addresses. */ if (port->mc_addr_nb ==0 ) {/* free the pool of multicast addresses. */ free (port->mc_addr_pool);
app/test-pmd/icmpecho.c +1 -1
@@ -54,7 +54,7 @@ arp_op_name(uint16_t arp_op)default :break ; } -return "Unkwown ARP op" ; +return "Unknown ARP op" ; } static const char *
Signature · 1 line
2.30.2
PATCH v4 18/18 test: fix spelling errors in comments
In reply to Stephen HemmingerLots of little typos.
Signed-off-by Stephen Hemminger <[email protected]>
--- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_malloc.c | 4 ++-- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_timer.c | 2 +- 16 files changed, 29 insertions(+), 29 deletions(-)
app/test/test_atomic.c +1 -1
@@ -88,7 +88,7 @@* * - Invoke ``test_atomic_exchange`` on each lcore. Before doing * anything else, the cores wait for a synchronization event. -* Each core then does the follwoing for N iterations: +* Each core then does the following for N iterations: * * Generate a new token with a data integrity check * Exchange the new token for previously generated token
app/test/test_barrier.c +1 -1
@@ -66,7 +66,7 @@ struct plock_test {struct lcore_plock_test {struct plock_test *pt[2 ];/* shared, lock-protected data */ uint64_t sum[2 ];/* local copy of the shared data */ -uint64_t iter;/* number of iterations to perfom */ +uint64_t iter;/* number of iterations to perform */ uint32_t lc;/* given lcore id */ };
app/test/test_bpf.c +1 -1
@@ -2407,7 +2407,7 @@ static const struct ebpf_insn test_call5_prog[] = { }, }; -/* String comparision impelementation, return 0 if equal else difference */ +/* String comparison implementation, return 0 if equal else difference */ static uint32_t dummy_func5 (const char *s1,const char *s2) {
app/test/test_compressdev.c +1 -1
@@ -2033,7 +2033,7 @@ test_deflate_comp_decomp(const struct interim_data_params *int_data, test_priv_data.all_decomp_data = &all_decomp_data; test_priv_data.decomp_produced_data_size = &decomp_produced_data_size; - test_priv_data.num_priv_xforms =0 ;/* it's used for deompression only */ + test_priv_data.num_priv_xforms =0 ;/* it's used for decompression only */ capa =rte_compressdev_capability_get (0 ,RTE_COMP_ALGO_DEFLATE );if (capa ==NULL ) {
app/test/test_func_reentrancy.c +3 -3
@@ -253,7 +253,7 @@ hash_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple times simultaneously */ +/* create multiple times simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (hash_name,sizeof (hash_name),"fr_test_%d_%d" , lcore_self, i); hash_params.name = hash_name;
@@ -321,7 +321,7 @@ fbk_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (fbk_name,sizeof (fbk_name),"fr_test_%d_%d" , lcore_self, i); fbk_params.name = fbk_name;
@@ -387,7 +387,7 @@ lpm_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_LPM_ITER_TIMES ; i++) {snprintf (lpm_name,sizeof (lpm_name),"fr_test_%d_%d" , lcore_self, i); lpm =rte_lpm_create (lpm_name,SOCKET_ID_ANY , &config);
app/test/test_ipsec.c +1 -1
@@ -653,7 +653,7 @@ create_crypto_session(struct ipsec_unitest_params *ut,if (s ==NULL )return -ENOMEM ; -/* initiliaze SA crypto session for device */ +/* initialize SA crypto session for device */ rc =rte_cryptodev_sym_session_init (dev_id, s, ut->crypto_xforms, qp->mp_session_private);if (rc ==0 ) {
app/test/test_link_bonding.c +1 -1
@@ -3040,7 +3040,7 @@ test_balance_tx_burst_slave_tx_fail(void) first_tx_fail_idx =TEST_BAL_SLAVE_TX_FAIL_BURST_SIZE_1 -TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; -/* copy mbuf referneces for expected transmission failures */ +/* copy mbuf references for expected transmission failures */ for (i =0 ; i <TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; i++) expected_fail_pkts[i] = pkts_burst_1[i + first_tx_fail_idx];
app/test/test_lpm.c +3 -3
@@ -179,7 +179,7 @@ test3(void) status =rte_lpm_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -217,7 +217,7 @@ test4(void) status =rte_lpm_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -255,7 +255,7 @@ test5(void) status =rte_lpm_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
app/test/test_lpm6.c +7 -7
@@ -261,7 +261,7 @@ test4(void) status =rte_lpm6_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -299,7 +299,7 @@ test5(void) status =rte_lpm6_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -337,7 +337,7 @@ test6(void) status =rte_lpm6_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -375,7 +375,7 @@ test7(void) status =rte_lpm6_lookup_bulk_func (NULL , ip, next_hop_return,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -413,7 +413,7 @@ test8(void) status =rte_lpm6_delete_bulk_func (NULL , ip, depth,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -433,7 +433,7 @@ test8(void)/* * Call add, lookup and delete for a single rule with depth < 24. * Check all the combinations for the first three bytes that result in a hit. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test9 (void )
@@ -1738,7 +1738,7 @@ test27(void)* Call add, lookup and delete for a single rule with maximum 21bit next_hop * size. * Check that next_hop returned from lookup is equal to provisioned value. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test28 (void )
app/test/test_malloc.c +2 -2
@@ -603,7 +603,7 @@ test_realloc_numa(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 )printf ("WARNING: realloc_socket test needs memory on multiple sockets!\n" );
@@ -971,7 +971,7 @@ test_alloc_socket(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 ) {printf ("WARNING: alloc_socket test needs memory on multiple sockets!\n" ); }
app/test/test_mbuf.c +1 -1
@@ -1148,7 +1148,7 @@ test_refcnt_mbuf(void)rte_eal_mp_wait_lcore (); -/* check that we porcessed all references */ +/* check that we processed all references */ tref =0 ; main_lcore =rte_get_main_lcore ();
app/test/test_mempool.c +1 -1
@@ -994,7 +994,7 @@ test_mempool(void)if (test_mempool_basic_ex (mp_nocache) <0 )GOTO_ERR (ret, err); -/* mempool operation test based on single producer and single comsumer */ +/* mempool operation test based on single producer and single consumer */ if (test_mempool_sp_sc () <0 )GOTO_ERR (ret, err);
app/test/test_mempool_perf.c +1 -1
@@ -88,7 +88,7 @@ static uint32_t synchro;static unsigned n_get_bulk;static unsigned n_put_bulk; -/* number of objects retrived from mempool before putting them back */ +/* number of objects retrieved from mempool before putting them back */ static unsigned n_keep;/* number of enqueues / dequeues */
app/test/test_meter.c +3 -3
@@ -444,7 +444,7 @@ tm_test_srtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -551,7 +551,7 @@ tm_test_trtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -648,7 +648,7 @@ tm_test_trtcm_rfc4115_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
app/test/test_pmd_perf.c +1 -1
@@ -752,7 +752,7 @@ test_pmd_perf(void)"rte_eth_dev_start: err=%d, port=%d\n" , ret, portid); -/* always eanble promiscuous */ +/* always enable promiscuous */ ret =rte_eth_promiscuous_enable (portid);if (ret !=0 ) rte_exit(EXIT_FAILURE,
app/test/test_timer.c +1 -1
@@ -432,7 +432,7 @@ timer_basic_cb(struct rte_timer *tim, void *arg)return ; } -/* Explicitelly stop timer 0. Once stop() called, we can even +/* Explicitly stop timer 0. Once stop() called, we can even * erase the content of the structure: it is not referenced * anymore by any code (in case of dynamic structure, it can * be freed) */
Signature · 1 line
2.30.2
RE: [PATCH v4 18/18] test: fix spelling errors in comments
Quoted 386 lines
-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Friday, November 12, 2021 12:02 AM
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Ananyev, Konstantin <[email protected]>; Trahe, Fiona <[email protected]>; Ashish Gupta <[email protected]>; Wang, Yipeng1 <[email protected]>; Gobriel, Sameh <[email protected]>; Richardson, Bruce <[email protected]>; Medvedkin, Vladimir <[email protected]>; Olivier Matz <[email protected]>; Andrew Rybchenko <[email protected]>; Burakov, Anatoly <[email protected]>; Honnappa Nagarahalli <[email protected]>; Iremonger, Bernard <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Dumitrescu, Cristian <[email protected]>; Robert Sanford <[email protected]>; Carrillo, Erik G <[email protected]>
Subject: [PATCH v4 18/18] test: fix spelling errors in commentsLots of little typos.
Signed-off-by Stephen Hemminger <[email protected]>--- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_malloc.c | 4 ++-- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_timer.c | 2 +- 16 files changed, 29 insertions(+), 29 deletions(-)app/test/test_atomic.c +1
-1@@ -88,7 +88,7 @@* * - Invoke ``test_atomic_exchange`` on each lcore. Before doing * anything else, the cores wait for a synchronization event. -* Each core then does the follwoing for N iterations: +* Each core then does the following for N iterations: * * Generate a new token with a data integrity check * Exchange the new token for previously generated token app/test/test_barrier.c +1
-1@@ -66,7 +66,7 @@ struct plock_test {struct lcore_plock_test {struct plock_test *pt[2 ];/* shared, lock-protected data */ uint64_t sum[2 ];/* local copy of the shared data */ -uint64_t iter;/* number of iterations to perfom */ +uint64_t iter;/* number of iterations to perform */ uint32_t lc;/* given lcore id */ };app/test/test_bpf.c +1
-1@@ -2407,7 +2407,7 @@ static const struct ebpf_insn test_call5_prog[] = { }, }; -/* String comparision impelementation, return 0 if equal else difference */ +/* String comparison implementation, return 0 if equal else difference */ static uint32_t dummy_func5 (const char *s1,const char *s2) {app/test/test_compressdev.c +0
-1@@ -2033,7 +2033,7 @@ test_deflate_comp_decomp(const struct interim_data_params *int_data, test_priv_data.all_decomp_data = &all_decomp_data; test_priv_data.decomp_produced_data_size = &decomp_produced_data_size; - test_priv_data.num_priv_xforms =0 ;/* it's used for deompression only */
app/test/test_compressdev.c +1
-0+ test_priv_data.num_priv_xforms =0 ;/* it's used for decompression only */
capa = rte_compressdev_capability_get(0,
RTE_COMP_ALGO_DEFLATE);app/test/test_compressdev.c +0
-0if (capa ==NULL ) {app/test/test_func_reentrancy.c +1
-1@@ -253,7 +253,7 @@ hash_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple times simultaneously */ +/* create multiple times simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (hash_name,sizeof (hash_name),"fr_test_%d_%d" , lcore_self, i);app/test/test_func_reentrancy.c +1
-1hash_params.name = hash_name;@@ -321,7 +321,7 @@ fbk_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (fbk_name,sizeof (fbk_name),"fr_test_%d_%d" , lcore_self, i);app/test/test_func_reentrancy.c +1
-1fbk_params.name = fbk_name;@@ -387,7 +387,7 @@ lpm_create_free(__rte_unused void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_LPM_ITER_TIMES ; i++) {snprintf (lpm_name,sizeof (lpm_name),"fr_test_%d_%d" , lcore_self, i);lpm = rte_lpm_create(lpm_name,
SOCKET_ID_ANY,
&config);app/test/test_ipsec.c +1
-1@@ -653,7 +653,7 @@ create_crypto_session(struct ipsec_unitest_params *ut, if (s == NULL) return -ENOMEM; -/* initiliaze SA crypto session for device */ +/* initialize SA crypto session for device */ rc =rte_cryptodev_sym_session_init (dev_id, s, ut->crypto_xforms, qp->mp_session_private);app/test/test_ipsec.c +0
-0if (rc ==0 ) {app/test/test_link_bonding.c +1
-1@@ -3040,7 +3040,7 @@ test_balance_tx_burst_slave_tx_fail(void) first_tx_fail_idx =TEST_BAL_SLAVE_TX_FAIL_BURST_SIZE_1 -TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; -/* copy mbuf referneces for expected transmission failures */ +/* copy mbuf references for expected transmission failures */ for (i =0 ; i <TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; i++) expected_fail_pkts[i] = pkts_burst_1[i + first_tx_fail_idx];app/test/test_lpm.c +3
-3@@ -179,7 +179,7 @@ test3(void) status =rte_lpm_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );@@ -217,7 +217,7 @@ test4(void) status =rte_lpm_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );@@ -255,7 +255,7 @@ test5(void) status =rte_lpm_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );app/test/test_lpm6.c +7
-7@@ -261,7 +261,7 @@ test4(void) status =rte_lpm6_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );@@ -299,7 +299,7 @@ test5(void) status =rte_lpm6_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );@@ -337,7 +337,7 @@ test6(void) status =rte_lpm6_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );@@ -375,7 +375,7 @@ test7(void) status =rte_lpm6_lookup_bulk_func (NULL , ip, next_hop_return,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );@@ -413,7 +413,7 @@ test8(void) status =rte_lpm6_delete_bulk_func (NULL , ip, depth,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );@@ -433,7 +433,7 @@ test8(void)/* * Call add, lookup and delete for a single rule with depth < 24. * Check all the combinations for the first three bytes that result in a hit. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test9 (void )@@ -1738,7 +1738,7 @@ test27(void)* Call add, lookup and delete for a single rule with maximum 21bit next_hop * size. * Check that next_hop returned from lookup is equal to provisioned value. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test28 (void )app/test/test_malloc.c +2
-2@@ -603,7 +603,7 @@ test_realloc_numa(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count <2 ) printf("WARNING: realloc_socket test needs memory on multiple sockets!\n");@@ -971,7 +971,7 @@ test_alloc_socket(void) } } -/* Print warnign if only a single socket, but don't fail the test */ +/* Print warning if only a single socket, but don't fail the test */ if (socket_count < 2) { printf("WARNING: alloc_socket test needs memory on multiple sockets!\n");app/test/test_malloc.c +0
-0}app/test/test_mbuf.c +1
-1@@ -1148,7 +1148,7 @@ test_refcnt_mbuf(void)rte_eal_mp_wait_lcore (); -/* check that we porcessed all references */ +/* check that we processed all references */ tref =0 ; main_lcore =rte_get_main_lcore ();app/test/test_mempool.c +0
-1@@ -994,7 +994,7 @@ test_mempool(void)if (test_mempool_basic_ex (mp_nocache) <0 )GOTO_ERR (ret, err); -/* mempool operation test based on single producer and single comsumer */
app/test/test_mempool.c +1
-0+/* mempool operation test based on single producer and single consumer */
app/test/test_mempool.c +0
-0if (test_mempool_sp_sc () <0 )GOTO_ERR (ret, err);app/test/test_mempool_perf.c +1
-1@@ -88,7 +88,7 @@ static uint32_t synchro;static unsigned n_get_bulk;static unsigned n_put_bulk; -/* number of objects retrived from mempool before putting them back */ +/* number of objects retrieved from mempool before putting them back */ static unsigned n_keep;/* number of enqueues / dequeues */ app/test/test_meter.c +3
-3@@ -444,7 +444,7 @@ tm_test_srtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;@@ -551,7 +551,7 @@ tm_test_trtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;@@ -648,7 +648,7 @@ tm_test_trtcm_rfc4115_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;app/test/test_pmd_perf.c +1
-1@@ -752,7 +752,7 @@ test_pmd_perf(void)"rte_eth_dev_start: err=%d, port=%d\n" , ret, portid); -/* always eanble promiscuous */ +/* always enable promiscuous */ ret =rte_eth_promiscuous_enable (portid);if (ret !=0 ) rte_exit(EXIT_FAILURE,app/test/test_timer.c +1
-2@@ -432,7 +432,7 @@ timer_basic_cb(struct rte_timer *tim, void *arg)return ; } -/* Explicitelly stop timer 0. Once stop() called, we can even +/* Explicitly stop timer 0. Once stop() called, we can even * erase the content of the structure: it is not referenced * anymore by any code (in case of dynamic structure, it can * be freed) */ --
Quoted 1 line
2.30.2
Re: [PATCH v4 00/18] fix docbook and spelling errors
In reply to Stephen HemmingerQuoted 6 lines · Stephen Hemminger
After finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments.
v4 - rebase and resend
There are a few typo fix in ethdev, which are sitting in my local repo for a while, can we include it into your series? I will send it as reply to this email.
Thanks,
ferruh
PATCH 1/1 ethdev: fix typos
In reply to Stephen HemmingerSigned-off-by Ferruh Yigit <[email protected]>
--- lib/ethdev/ethdev_driver.h | 4 ++-- lib/ethdev/rte_flow.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
lib/ethdev/ethdev_driver.h +2 -2
@@ -227,7 +227,7 @@ typedef int (*eth_is_removed_t)(struct rte_eth_dev *dev);* @retval -E_RTE_SECONDARY * Function was called from a secondary process instance and not supported. * @retval -ETIMEDOUT -* Attempt to enable promiscuos mode failed because of timeout. +* Attempt to enable promiscuous mode failed because of timeout. * @retval -EAGAIN * Failed to enable promiscuous mode. */
@@ -252,7 +252,7 @@ typedef int (*eth_promiscuous_enable_t)(struct rte_eth_dev *dev);* @retval -E_RTE_SECONDARY * Function was called from a secondary process instance and not supported. * @retval -ETIMEDOUT -* Attempt to disable promiscuos mode failed because of timeout. +* Attempt to disable promiscuous mode failed because of timeout. * @retval -EAGAIN * Failed to disable promiscuous mode. */
lib/ethdev/rte_flow.h +2 -2
@@ -3954,7 +3954,7 @@ enum rte_flow_conv_op {* Perform verbose error reporting if not NULL. PMDs initialize this * structure in case of error only. * @return -* 0 on success, a nagative value otherwise. +* 0 on success, a negative value otherwise. */ __rte_experimental int
@@ -4316,7 +4316,7 @@ rte_flow_conv(enum rte_flow_conv_op op,* * RTE_ETH_EVENT_FLOW_AGED event will be triggered when at least one new aged * out flow was detected after the last call to rte_flow_get_aged_flows. -* This function can be called to get the aged flows usynchronously from the +* This function can be called to get the aged flows asynchronously from the * event callback or synchronously regardless the event. * This is not safe to call rte_flow_get_aged_flows function with other flow * functions from multiple threads simultaneously.
Signature · 1 line
2.31.1
RE: [PATCH] ethdev: fix typos
Hi
Quoted 56 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Friday, November 12, 2021 2:14 PM
Subject: [PATCH] ethdev: fix typosSigned-off-by Ferruh Yigit <[email protected]>--- lib/ethdev/ethdev_driver.h | 4 ++-- lib/ethdev/rte_flow.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)lib/ethdev/ethdev_driver.h +2
-2@@ -227,7 +227,7 @@ typedef int (*eth_is_removed_t)(struct rte_eth_dev *dev);* @retval -E_RTE_SECONDARY * Function was called from a secondary process instance and not supported. * @retval -ETIMEDOUT -* Attempt to enable promiscuos mode failed because of timeout. +* Attempt to enable promiscuous mode failed because of timeout. * @retval -EAGAIN * Failed to enable promiscuous mode. */ @@ -252,7 +252,7 @@ typedef int (*eth_promiscuous_enable_t)(struct rte_eth_dev *dev);* @retval -E_RTE_SECONDARY * Function was called from a secondary process instance and not supported. * @retval -ETIMEDOUT -* Attempt to disable promiscuos mode failed because of timeout. +* Attempt to disable promiscuous mode failed because of timeout. * @retval -EAGAIN * Failed to disable promiscuous mode. */ lib/ethdev/rte_flow.h +2
-3@@ -3954,7 +3954,7 @@ enum rte_flow_conv_op {* Perform verbose error reporting if not NULL. PMDs initialize this * structure in case of error only. * @return -* 0 on success, a nagative value otherwise. +* 0 on success, a negative value otherwise. */ __rte_experimental int@@ -4316,7 +4316,7 @@ rte_flow_conv(enum rte_flow_conv_op op,* * RTE_ETH_EVENT_FLOW_AGED event will be triggered when at least one new aged * out flow was detected after the last call to rte_flow_get_aged_flows. -* This function can be called to get the aged flows usynchronously from the +* This function can be called to get the aged flows asynchronously from the * event callback or synchronously regardless the event. * This is not safe to call rte_flow_get_aged_flows function with other flow * functions from multiple threads simultaneously. --
Quoted 1 line
2.31.1
Acked-by Ori Kam <[email protected]>
Best,
Ori
Ferruh Yigit
AppliedRe: [PATCH] ethdev: fix typos
Quoted 11 lines · Ori Kam
Hi
Quoted 6 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Friday, November 12, 2021 2:14 PM
Subject: [PATCH] ethdev: fix typosSigned-off-by Ferruh Yigit <[email protected]>Acked-by Ori Kam <[email protected]>
Fixes 9039c8125730 ("ethdev: change promiscuous callbacks to return status")
Fixes 12e6e3e78fe0 ("ethdev: add API to dump device internal flow info")
Fixes 44bf3c796be3 ("ethdev: support flow aging")
Applied to dpdk-next-net/main, thanks.
Re: [PATCH v4 00/18] fix docbook and spelling errors
In reply to Stephen HemmingerQuoted 5 lines · Stephen Hemminger
After finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments.
Series squashed and applied, thanks.
Signature · 1 line
David Marchand