Skip to contentSkip to conversation

staging: wlan-ng: Fix formatting of block comments

PATCH In review Gabriel Goller 2 participants 2 messages Oct 30, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wlan-ng: Fix formatting of block comments

Fixed warnings of checkpatch.pl in prism2mib.c:
Block comments use * on subsequent lines.

---
 drivers/staging/wlan-ng/prism2mib.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/wlan-ng/prism2mib.c +6 -6
index 24ba10d6bd0b..c04fc17b3c64 100644
@@ -680,15 +680,15 @@ static int prism2mib_priv(struct mibrec *mib,
 					       (u8 *)&wpa,
 					       sizeof(wpa));
 			/*
-			pstr->len = le16_to_cpu(wpa.datalen);
-			memcpy(pstr->data, wpa.data, pstr->len);
-			*/
+			 * pstr->len = le16_to_cpu(wpa.datalen);
+			 * memcpy(pstr->data, wpa.data, pstr->len);
+			 */
 			pstr->len = 0;
 		} else {
 			/*
-			wpa.datalen = cpu_to_le16(pstr->len);
-			memcpy(wpa.data, pstr->data, pstr->len);
-			*/
+			 * wpa.datalen = cpu_to_le16(pstr->len);
+			 * memcpy(wpa.data, pstr->data, pstr->len);
+			 */
 			wpa.datalen = 0;
 
 			hfa384x_drvr_setconfig(hw,
Signature · 1 line
2.30.2
maintainer
#1 lore raw
Quoted 13 lines · Gabriel Goller

Fixed warnings of checkpatch.pl in prism2mib.c:
Block comments use * on subsequent lines.

---
 drivers/staging/wlan-ng/prism2mib.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/wlan-ng/prism2mib.c +0 -0
index 24ba10d6bd0b..c04fc17b3c64 100644

drivers/staging/wlan-ng/prism2mib.c static int prism2mib_priv(struct mibrec *mib, · line 685

Quoted 9 lines
drivers/staging/wlan-ng/prism2mib.c +3 -3
@@ -680,15 +680,15 @@ static int prism2mib_priv(struct mibrec *mib,
 					       (u8 *)&wpa,
 					       sizeof(wpa));
 			/*
-			pstr->len = le16_to_cpu(wpa.datalen);
-			memcpy(pstr->data, wpa.data, pstr->len);
-			*/
+			 * pstr->len = le16_to_cpu(wpa.datalen);
+			 * memcpy(pstr->data, wpa.data, pstr->len);
+			 */

Why keep this code at all? Please just delete it as it's obviously not being used.

thanks,

greg k-h