platform/x86: system76_acpi: fix Kconfig dependencies
Subsystems (2)
PATCH 1/1 platform/x86: system76_acpi: fix Kconfig dependencies
From: Arnd Bergmann <[email protected]>
When CONFIG_INPUT is disabled, this driver now fails to link:
ld.lld: error: undefined symbol: devm_input_allocate_device
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_add) in archivedrivers/built-in.a
ld.lld: error: undefined symbol: input_set_capability
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_add) in archivedrivers/built-in.a
ld.lld: error: undefined symbol: devm_hwmon_device_register_with_info
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_add) in archivedrivers/built-in.a
ld.lld: error: undefined symbol: battery_hook_unregister
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_remove) in archivedrivers/built-in.a
Add Kconfig dependencies for each of these three.
--- drivers/platform/x86/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
drivers/platform/x86/Kconfig +3 -0
@@ -923,6 +923,9 @@ config SONYPI_COMPAT config SYSTEM76_ACPI tristate "System76 ACPI Driver" depends on ACPI + depends on ACPI_BATTERY + depends on HWMON + depends on INPUT select NEW_LEDS select LEDS_CLASS select LEDS_TRIGGERS
Signature · 1 line
2.29.2
Quoted 13 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When
CONFIG_INPUTis disabled, this driver now fails to link:ld.lld: error: undefined symbol:
devm_input_allocate_deviceQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_add) in archivedrivers/built-in.ald.lld: error: undefined symbol:
input_set_capabilityQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_add) in archivedrivers/built-in.ald.lld: error: undefined symbol:
devm_hwmon_device_register_with_info
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_add) in archivedrivers/built-in.ald.lld: error: undefined symbol:
battery_hook_unregisterQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_remove) in archivedrivers/built-in.aAdd
Kconfigdependencies for each of these three.
Thanks! FWIW,
(See one comment below)
Quoted 13 lines
Fixes 0de30fc684b3 ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models")Fixes 95563d45b5da ("platform/x86: system76_acpi: Report temperature and fan speed")Fixes 76f7eba3e0a2 ("platform/x86: system76_acpi: Add battery charging thresholds")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/platform/x86/Kconfig | 3 +++ 1 file changed, 3 insertions(+)drivers/platform/x86/Kconfig +0
-0
drivers/platform/x86/Kconfig config SONYPI_COMPAT · line 927
Quoted 5 lines
drivers/platform/x86/Kconfig +1
-0@@ -923,6 +923,9 @@ config SONYPI_COMPAT config SYSTEM76_ACPI tristate "System76 ACPI Driver" depends on ACPI + depends on ACPI_BATTERY
ACPI_BATTERY depends on ACPI, do we need to keep ACPI above?
Quoted 5 lines
drivers/platform/x86/Kconfig +2
-0+ depends on HWMON + depends on INPUT select NEW_LEDS select LEDS_CLASSselect
LEDS_TRIGGERS
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi,
Quoted 20 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When
CONFIG_INPUTis disabled, this driver now fails to link:ld.lld: error: undefined symbol:
devm_input_allocate_deviceQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_add) in archivedrivers/built-in.ald.lld: error: undefined symbol:
input_set_capabilityQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_add) in archivedrivers/built-in.ald.lld: error: undefined symbol:
devm_hwmon_device_register_with_infoQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_add) in archivedrivers/built-in.ald.lld: error: undefined symbol:
battery_hook_unregisterQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
system76_acpi.c
platform/x86/system76_acpi.o:(system76_remove) in archivedrivers/built-in.a
Quoted 6 lines
Add
Kconfigdependencies for each of these three.Fixes 0de30fc684b3 ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models")Fixes 95563d45b5da ("platform/x86: system76_acpi: Report temperature and fan speed")Fixes 76f7eba3e0a2 ("platform/x86: system76_acpi: Add battery charging thresholds")Signed-off-by Arnd Bergmann <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
Quoted 19 lines
--- drivers/platform/x86/Kconfig | 3 +++ 1 file changed, 3 insertions(+)drivers/platform/x86/Kconfig +3
-0@@ -923,6 +923,9 @@ config SONYPI_COMPAT config SYSTEM76_ACPI tristate "System76 ACPI Driver" depends on ACPI + depends on ACPI_BATTERY + depends on HWMON + depends on INPUT select NEW_LEDS select LEDS_CLASS select LEDS_TRIGGERS