Skip to contentSkip to conversation

dmaengine: tegra210-adma: fix pm runtime unbalance

PATCH Applied Dongliang Mu 3 participants 3 messages Oct 21, 2021 – Oct 25, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: tegra210-adma: fix pm runtime unbalance

The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding") forgets to replace the pm_runtime_get_sync in the tegra_adma_probe, but removes the pm_runtime_put_noidle.

Fix this by continuing to replace pm_runtime_get_sync with pm_runtime_resume_and_get in tegra_adma_probe.

Fixes 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding")
---
 drivers/dma/tegra210-adma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/tegra210-adma.c +1 -1
index b1115a6d1935..d1dff3a29db5 100644
@@ -867,7 +867,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
 
 	pm_runtime_enable(&pdev->dev);
 
-	ret = pm_runtime_get_sync(&pdev->dev);
+	ret = pm_runtime_resume_and_get(&pdev->dev);
 	if (ret < 0)
 		goto rpm_disable;
 
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Dongliang Mu

The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding") forgets to replace the pm_runtime_get_sync in the tegra_adma_probe, but removes the pm_runtime_put_noidle.

Fix this by continuing to replace pm_runtime_get_sync with pm_runtime_resume_and_get in tegra_adma_probe.

Fixes 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding")
---
  drivers/dma/tegra210-adma.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/tegra210-adma.c +0 -0
index b1115a6d1935..d1dff3a29db5 100644

drivers/dma/tegra210-adma.c static int tegra_adma_probe(struct platform_device *pdev) · line 873

Quoted 8 lines
drivers/dma/tegra210-adma.c +1 -1
@@ -867,7 +867,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
 
  	pm_runtime_enable(&pdev->dev);
 
-	ret = pm_runtime_get_sync(&pdev->dev);
+	ret = pm_runtime_resume_and_get(&pdev->dev);
  	if (ret < 0)
  		goto rpm_disable;
 

Thanks!

Jon

Signature · 1 line
nvpublic
maintainer Applied
#2 lore raw
In reply to Dongliang Mu
Quoted 7 lines · Dongliang Mu

The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding") forgets to replace the pm_runtime_get_sync in the tegra_adma_probe, but removes the pm_runtime_put_noidle.

Fix this by continuing to replace pm_runtime_get_sync with pm_runtime_resume_and_get in tegra_adma_probe.

Applied, thanks

Signature · 1 line
~Vinod