dt-bindings: opp: Allow multi-worded OPP entry names
PATCH v3 1/1 dt-bindings: opp: Allow multi-worded OPP entry names
Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP tables use multi-word names where first part is freq and second voltage because different hardware versions use different voltages for the same freqs. Allow OPP entry to have multi-worded name separated by hyphen. This silences DT checker warnings about wrong naming scheme.
---
Changelog:
v3: - Viresh Kumar suggested that we shouldn't support postfix variant.
I dropped variant with postfix naming scheme and multi-wording support of table names.
v2: - In addition to a multi-wording support, support of the postfix
*-opp-table naming scheme is added to the updated pattern.
Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/opp/opp-v2-base.yaml +1 -1
@@ -33,7 +33,7 @@ properties: type: boolean patternProperties: - '^opp-?[0-9]+$': + '^opp(-[0-9]+)*$': type: object description: One or more OPP nodes describing voltage-current-frequency combinations.
Signature · 1 line
2.33.1
Quoted 27 lines · Dmitry Osipenko
Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP tables use multi-word names where first part is freq and second voltage because different hardware versions use different voltages for the same freqs. Allow OPP entry to have multi-worded name separated by hyphen. This silences DT checker warnings about wrong naming scheme.
Reviewed-by David Heidelberg <[email protected]>Signed-off-by Dmitry Osipenko <[email protected]>---
Changelog:
v3: - Viresh Kumar suggested that we shouldn't support postfix variant.
I dropped variant with postfix naming scheme and multi-wording support of table names.v2: - In addition to a multi-wording support, support of the postfix
*-opp-table naming scheme is added to the updated pattern.Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/opp/opp-v2-base.yaml +0
-0
Documentation/devicetree/bindings/opp/opp-v2-base.yaml properties: · line 39
Quoted 8 lines
Documentation/devicetree/bindings/opp/opp-v2-base.yaml +1
-1@@ -33,7 +33,7 @@ properties: type: boolean patternProperties: - '^opp-?[0-9]+$': + '^opp(-[0-9]+)*$': type: object description: One or more OPP nodes describing voltage-current-frequency combinations.
LGTM, will apply once Rob Acks it.
Signature · 1 line
viresh
Rob Herring
maintainerQuoted 27 lines · Dmitry Osipenko
Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP tables use multi-word names where first part is freq and second voltage because different hardware versions use different voltages for the same freqs. Allow OPP entry to have multi-worded name separated by hyphen. This silences DT checker warnings about wrong naming scheme.
Reviewed-by David Heidelberg <[email protected]>Signed-off-by Dmitry Osipenko <[email protected]>---
Changelog:
v3: - Viresh Kumar suggested that we shouldn't support postfix variant.
I dropped variant with postfix naming scheme and multi-wording support of table names.v2: - In addition to a multi-wording support, support of the postfix
*-opp-table naming scheme is added to the updated pattern.Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/opp/opp-v2-base.yaml +0
-0
Documentation/devicetree/bindings/opp/opp-v2-base.yaml properties: · line 36
Quoted 5 lines
Documentation/devicetree/bindings/opp/opp-v2-base.yaml +1
-1@@ -33,7 +33,7 @@ properties: type: boolean patternProperties: - '^opp-?[0-9]+$': + '^opp(-[0-9]+)*$':
This drops support for cases like 'opp1' which there are a ton of. It should be '^opp(-?[0-9]+)*$' if we want to keep that support.
I'd love to be stricter, but trying to find a balance.
Rob
28.10.2021 00:19, Rob Herring пишет:
Quoted 30 lines · Dmitry Osipenko
Quoted 29 lines
Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP tables use multi-word names where first part is freq and second voltage because different hardware versions use different voltages for the same freqs. Allow OPP entry to have multi-worded name separated by hyphen. This silences DT checker warnings about wrong naming scheme.
Reviewed-by David Heidelberg <[email protected]>Signed-off-by Dmitry Osipenko <[email protected]>---
Changelog:
v3: - Viresh Kumar suggested that we shouldn't support postfix variant.
I dropped variant with postfix naming scheme and multi-wording support of table names.v2: - In addition to a multi-wording support, support of the postfix
*-opp-table naming scheme is added to the updated pattern.Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/opp/opp-v2-base.yaml +0
-0@@ -33,7 +33,7 @@ properties: type: boolean
Quoted 8 lines
Documentation/devicetree/bindings/opp/opp-v2-base.yaml properties: · line 36
Quoted 3 lines
Documentation/devicetree/bindings/opp/opp-v2-base.yaml +1
-1patternProperties: - '^opp-?[0-9]+$': + '^opp(-[0-9]+)*$':This drops support for cases like 'opp1' which there are a ton of. It should be '^opp(-?[0-9]+)*$' if we want to keep that support.
I'd love to be stricter, but trying to find a balance.
Good catch, let me make v4.