lib: adding .arch field in tst_test structure
PATCH v2 1/3 lib: adding .arch field in tst_test structure
Testcases for specified arch should be limited on that only being supported platform to run, we now create a function tst_on_arch to achieve this new feature in LTP library. All you need to run a test on the expected arch is to set the '.arch' string in the 'struct tst_test' to choose the required arch list. e.g. '.arch = "x86_64 i386"'.
--- doc/test-writing-guidelines.txt | 26 ++++++++++ include/tst_arch.h | 16 ++++++ include/tst_test.h | 7 ++- lib/tst_arch.c | 92 +++++++++++++++++++++++++++++++++ 4 files changed, 140 insertions(+), 1 deletion(-) create mode 100644 include/tst_arch.h create mode 100644 lib/tst_arch.c
doc/test-writing-guidelines.txt +26 -0
@@ -1668,6 +1668,32 @@ sturct tst_test test = { }; ------------------------------------------------------------------------------- +2.2.30 Testing on specified architecture +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +Testcases for specified arch should be limited on that only being supported +platform to run, we now create a function tst_on_arch to achieve this new +feature in LTP library. All you need to run a test on the expected arch is +to set the '.arch' string in the 'struct tst_test' to choose the required +arch list. e.g. '.arch = "x86_64 i386"'. + +[source,c] +------------------------------------------------------------------------------- +#include "tst_test.h" + +static void setup(void) +{ + ... +} + +static struct tst_test test = { + ... + .setup = setup, + .arch = "x86_64 i386", + ... +} +------------------------------------------------------------------------------- + 2.3 Writing a testcase in shell ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/tst_arch.h new file +16 -0
@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later +* Copyright (c) 2019 Li Wang <[email protected]> +*/ + +#ifndef TST_ARCH_H__ +#define TST_ARCH_H__ + +/* +* Check if test platform is in the given arch list. If yes return 1, +* otherwise return 0. +* +* @arch, NULL or vliad arch list +*/ +int tst_on_arch (const char *arch); + +#endif /* TST_ARCH_H__ */
include/tst_test.h +6 -1
@@ -28,6 +28,7 @@#include "tst_atomic.h" #include "tst_kvercmp.h" #include "tst_clone.h" +#include "tst_arch.h" #include "tst_kernel.h" #include "tst_minmax.h" #include "tst_get_bad_addr.h"
@@ -114,6 +115,8 @@ struct tst_test {const char *min_kver; +const char *arch; +/* If set the test is compiled out */ const char *tconf_msg;
@@ -253,7 +256,6 @@ const char *tst_strstatus(int status);unsigned int tst_timeout_remaining (void );void tst_set_timeout (int timeout); -/* * Returns path to the test temporary directory in a newly allocated buffer. */
@@ -265,6 +267,9 @@ static struct tst_test test;int main (int argc,char *argv[]) { +if (!tst_on_arch (test.arch)) +tst_brk (TCONF ,"Test needs running on %s arch!" , test.arch); +tst_run_tcases (argc, argv, &test); }
lib/tst_arch.c new file +92 -0
92 lines not on this page · raw message
Signature · 1 line
2.20.1
PATCH v2 2/3 testcase: taking use of .arch in tst_test
This is a demo for .arch usage:
1. ptrace07.c, cve-2017-17053.c, meltdown.c
--- testcases/cve/cve-2017-17053.c | 1 + testcases/cve/meltdown.c | 9 +-------- testcases/kernel/syscalls/ptrace/ptrace07.c | 8 +++----- 3 files changed, 5 insertions(+), 13 deletions(-)
testcases/cve/cve-2017-17053.c +1 -0
@@ -162,6 +162,7 @@ void run(void) }static struct tst_test test = { + .arch ="x86_64 i386" , .forks_child =1 , .setup = setup, .cleanup = cleanup,
testcases/cve/meltdown.c +1 -8
@@ -20,8 +20,6 @@#include "config.h" #include "tst_test.h" -#if defined(__x86_64__) || defined(__i386__) -#include <stdio.h> #include <string.h> #include <signal.h>
@@ -382,15 +380,10 @@ static void cleanup(void) }static struct tst_test test = { + .arch ="x86_64 i386" , .needs_root =1 , .setup = setup, .test_all = run, .cleanup = cleanup, .min_kver ="2.6.32" }; - -#else /* #if defined(__x86_64__) || defined(__i386__) */ - -TST_TEST_TCONF ("not x86_64 or i386" ); - -#endif /* #else #if defined(__x86_64__) || defined(__i386__) */
testcases/kernel/syscalls/ptrace/ptrace07.c +3 -5
@@ -60,13 +60,13 @@# define NT_X86_XSTATE 0x202#endif -#ifdef __x86_64__static void check_regs_loop (uint32_t initval) {const unsigned long num_iters =1000000000 ;uint32_t xmm0[4 ] = { initval, initval, initval, initval };int status =1 ; +#ifdef __x86_64__ asmvolatile (" movdqu %0, %%xmm0\n" " mov %0, %%rbx\n" "1: dec %2\n"
@@ -80,6 +80,7 @@ static void check_regs_loop(uint32_t initval)"3:\n" : "+m" (xmm0), "+r" (status) : "r" (num_iters) : "rax", "rbx", "xmm0"); +#endif if (status) { tst_res(TFAIL,
@@ -188,10 +189,7 @@ static void do_test(void)static struct tst_test test = { .test_all = do_test, + .arch ="x86_64" , .forks_child =1 , .needs_checkpoints =1 , }; - -#else /* !__x86_64__ */ -TST_TEST_TCONF ("this test is only supported on x86_64" ); -#endif /* __x86_64__ */
Signature · 1 line
2.20.1
PATCH v2 2/3 testcase: taking use of .arch in tst_test
Hi Li,
Quoted 4 lines
This is a demo for .arch usage:
1.ptrace07.c,cve-2017-17053.c,meltdown.cSigned-off-by Li Wang <[email protected]>
Kind regards,
Petr
PATCH v2 3/3 testcase: get rid of compiling errors
In reply to Li Wang--- configure.ac | 1 + testcases/cve/meltdown.c | 5 +++++ 2 files changed, 6 insertions(+)
configure.ac +1 -0
@@ -58,6 +58,7 @@ AC_CHECK_HEADERS([ \ sys/shm.h \ sys/ustat.h \ sys/xattr.h \ + emmintrin.h \ ]) AC_CHECK_FUNCS([ \
testcases/cve/meltdown.c +5 -0
@@ -29,6 +29,7 @@#include <ctype.h> #include <sys/utsname.h> +#ifdef HAVE_EMMINTRIN_H #include <emmintrin.h> #include "libtsc.h"
@@ -387,3 +388,7 @@ static struct tst_test test = { .cleanup = cleanup, .min_kver ="2.6.32" }; + +#else /* HAVE_EMMINTRIN_H */ +TST_TEST_TCONF ("<emmintrin.h> is not supported" ); +#endif
Signature · 1 line
2.20.1
PATCH v2 3/3 testcase: get rid of compiling errors
Hi Li,
Quoted 1 line
Signed-off-by Li Wang <[email protected]>
Thanks this patchset.
Quoted 10 lines
--- configure.ac | 1 + testcases/cve/meltdown.c | 5 +++++ 2 files changed, 6 insertions(+)configure.ac +0
-0
configure.ac AC_CHECK_HEADERS([ \ · line 61
Quoted 4 lines
configure.ac +1
-0@@ -58,6 +58,7 @@ AC_CHECK_HEADERS([ \ sys/shm.h \ sys/ustat.h \ sys/xattr.h \ + emmintrin.h \
Just AC_CHECK_HEADERS is sorted alphabetically since a50338cac. But this can be amended during merging.
Kind regards,
Petr
Quoted 23 lines
configure.ac +0
-0]) AC_CHECK_FUNCS([ \testcases/cve/meltdown.c +5
-0@@ -29,6 +29,7 @@#include <ctype.h> #include <sys/utsname.h> +#ifdef HAVE_EMMINTRIN_H #include <emmintrin.h> #include "libtsc.h" @@ -387,3 +388,7 @@ static struct tst_test test = { .cleanup = cleanup, .min_kver ="2.6.32" }; + +#else /* HAVE_EMMINTRIN_H */ +TST_TEST_TCONF ("<emmintrin.h> is not supported" ); +#endif
PATCH v2 3/3 testcase: get rid of compiling errors
In reply to Li Wang----- Original Message -----
Quoted 31 lines
Signed-off-by Li Wang <[email protected]>--- configure.ac | 1 + testcases/cve/meltdown.c | 5 +++++ 2 files changed, 6 insertions(+)configure.ac +1
-0@@ -58,6 +58,7 @@ AC_CHECK_HEADERS([ \ sys/shm.h \ sys/ustat.h \ sys/xattr.h \ + emmintrin.h \ ]) AC_CHECK_FUNCS([ \testcases/cve/meltdown.c +1
-0@@ -29,6 +29,7 @@#include <ctype.h> #include <sys/utsname.h> +#ifdef HAVE_EMMINTRIN_H #include <emmintrin.h> #include "libtsc.h"
testcases/cve/meltdown.c static struct tst_test test = { · line 394
Quoted 7 lines
testcases/cve/meltdown.c +4
-0@@ -387,3 +388,7 @@ static struct tst_test test = { .cleanup = cleanup, .min_kver ="2.6.32" }; + +#else /* HAVE_EMMINTRIN_H */ +TST_TEST_TCONF ("<emmintrin.h> is not supported" ); +#endif
This seems more complicated to me than original - extra autoconf check, extra ifdef.
I can see how tst_on_arch() would be useful. Test is valid on all arches, but needs different input/constants/code/etc.
What is the motivation for tst_test.arch? Is it to have some annotation in tst_test struct?
Quoted 7 lines
--
2.20.1--
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v2 3/3 testcase: get rid of compiling errors
Quoted 31 lines · Jan Stancek
----- Original Message -----
Quoted 29 lines
Signed-off-by Li Wang <[email protected]>--- configure.ac | 1 + testcases/cve/meltdown.c | 5 +++++ 2 files changed, 6 insertions(+)configure.ac +1
-0@@ -58,6 +58,7 @@ AC_CHECK_HEADERS([ \ sys/shm.h \ sys/ustat.h \ sys/xattr.h \ + emmintrin.h \ ]) AC_CHECK_FUNCS([ \testcases/cve/meltdown.c +1
-0@@ -29,6 +29,7 @@#include <ctype.h> #include <sys/utsname.h> +#ifdef HAVE_EMMINTRIN_H #include <emmintrin.h>
Quoted 13 lines
testcases/cve/meltdown.c static struct tst_test test = { · line 394
Quoted 9 lines
testcases/cve/meltdown.c +4
-0#include "libtsc.h" @@ -387,3 +388,7 @@ static struct tst_test test = { .cleanup = cleanup, .min_kver ="2.6.32" }; + +#else /* HAVE_EMMINTRIN_H */ +TST_TEST_TCONF ("<emmintrin.h> is not supported" ); +#endif This seems more complicated to me than original - extra autoconf check, extra ifdef.
Indeed.
I choose meltdown.c as a demo randomly, this patch is to solve the compiling error after removing ifdef __arch__ from code. So, as you can see the tst_test.arch is not perfect, but it could be used for some general situations.
Quoted 3 lines
I can see how
tst_on_arch()would be useful. Test is valid on all arches, but needs different input/constants/code/etc.
That's the original reason I exported it in patch v1.
Cyril and I have discussed this part, we think tst_on_arch() is not cleaner than ifdefs, so it's not suggested to use it directly in a test case.
Quoted 4 lines
What is the motivation for tst_test.arch? Is it to have some annotation in
tst_teststruct?
The first motivation is to save LTP user from arch ifdefs, moves the information from code to tst_test metadata, but seems that it can not be completely replaced because of the specific assembly inline. So I still hope to find a better way for that, even not go with this tst_test.arch.
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20190618/f15ba24d/attachment.html>
PATCH v2 1/3 lib: adding .arch field in tst_test structure
In reply to Li WangHi Li,
Quoted 7 lines
Testcases for specified arch should be limited on that only being supported platform to run, we now create a function
tst_on_archto achieve this new feature in LTP library. All you need to run a test on the expected arch is to set the '.arch' string in the 'structtst_test' to choose the required arch list. e.g. '.arch = "x86_64i386"'.Signed-off-by Li Wang <[email protected]>
LGTM. FYI there is also HOST_CPU variable (since 00ff2c348f), but that does not help your patch.
Quoted 14 lines
--- doc/test-writing-guidelines.txt | 26 ++++++++++ include/tst_arch.h | 16 ++++++ include/tst_test.h | 7 ++- lib/tst_arch.c | 92 +++++++++++++++++++++++++++++++++ 4 files changed, 140 insertions(+), 1 deletion(-) create mode 100644 include/tst_arch.h create mode 100644 lib/tst_arch.cdoc/test-writing-guidelines.txt +0
-0
doc/test-writing-guidelines.txt sturct tst_test test = { · line 1671
Quoted 4 lines
doc/test-writing-guidelines.txt +1
-0@@ -1668,6 +1668,32 @@ sturct tst_test test = { }; ------------------------------------------------------------------------------- +2.2.30 Testing on specified architecture
^ maybe specific?
Kind regards,
Petr
PATCH v2 1/3 lib: adding .arch field in tst_test structure
Quoted 35 lines · Petr Vorel
Hi Li,
Quoted 1 line
Testcases for specified arch should be limited on that only being
supported
Quoted 2 lines
platform to run, we now create a function
tst_on_archto achieve this new feature in LTP library. All you need to run a test on the expected archis
Quoted 4 lines
to set the '.arch' string in the 'struct
tst_test' to choose the required arch list. e.g. '.arch = "x86_64i386"'.Signed-off-by Li Wang <[email protected]>Reviewed-by Petr Vorel <[email protected]>LGTM. FYI there is also
HOST_CPUvariable (since00ff2c348f), but that does not help your patch.Review
Quoted 10 lines
--- doc/test-writing-guidelines.txt | 26 ++++++++++ include/tst_arch.h | 16 ++++++ include/tst_test.h | 7 ++- lib/tst_arch.c | 92 +++++++++++++++++++++++++++++++++ 4 files changed, 140 insertions(+), 1 deletion(-) create mode 100644 include/tst_arch.h create mode 100644 lib/tst_arch.c(quoted diff) +0
-0
b/doc/test-writing-guidelines.txtdoc/test-writing-guidelines.txt sturct tst_test test = { · line 1669
Quoted 6 lines
index
f1912dc12..b4fba0190100644doc/test-writing-guidelines.txt +0
-0@@ -1668,6 +1668,32 @@ sturct tst_test test = { };-------------------------------------------------------------------------------
Quoted 3 lines
doc/test-writing-guidelines.txt sturct tst_test test = { · line 1671
Quoted 1 line
doc/test-writing-guidelines.txt +1
-0+2.2.30 Testing on specified architecture^ maybe specific?
Agree.
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20190618/4025d50c/attachment.html>
PATCH v2 1/3 lib: adding .arch field in tst_test structure
In reply to Li WangHi Li,
Quoted 5 lines
Testcases for specified arch should be limited on that only being supported platform to run, we now create a function
tst_on_archto achieve this new feature in LTP library. All you need to run a test on the expected arch is to set the '.arch' string in the 'structtst_test' to choose the required arch list. e.g. '.arch = "x86_64i386"'.
Just one note, strings are error prone. I wonder if defining constants and using array would be too complicated for this use case.
Kind regards,
Petr
PATCH v2 1/3 lib: adding .arch field in tst_test structure
Quoted 4 lines · Petr Vorel
Hi Li,
Quoted 1 line
Testcases for specified arch should be limited on that only being
supported
Quoted 9 lines
Quoted 2 lines
platform to run, we now create a function
tst_on_archto achieve this new feature in LTP library. All you need to run a test on the expected archis
Quoted 2 lines
to set the '.arch' string in the 'struct
tst_test' to choose the required arch list. e.g. '.arch = "x86_64i386"'.Just one note, strings are error prone. I wonder if defining constants and using
array would be too complicated for this use case.
I thought about that array way, but it seems a bit complicted in using. Yes, strings are easy to involve typo but we can make a check in library.
Thanks for review.
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20190618/0d4c72f7/attachment.html>
PATCH v2 1/3 lib: adding .arch field in tst_test structure
Hi Li,
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Testcases for specified arch should be limited on that only being
supported
Quoted 2 lines
platform to run, we now create a function
tst_on_archto achieve this new feature in LTP library. All you need to run a test on the expected archis
Quoted 2 lines
to set the '.arch' string in the 'struct
tst_test' to choose the required arch list. e.g. '.arch = "x86_64i386"'.
Quoted 7 lines
Quoted 3 lines
Just one note, strings are error prone. I wonder if defining constants and using
array would be too complicated for this use case.I thought about that array way, but it seems a bit complicted in using. Yes, strings are easy to involve typo but we can make a check in library.
OK, agree :).
Quoted 1 line
Thanks for review.
Kind regards,
Petr
Hello Li,
Quoted 5 lines · Li Wang
Testcases for specified arch should be limited on that only being supported platform to run, we now create a function
tst_on_archto achieve this new feature in LTP library. All you need to run a test on the expected arch is to set the '.arch' string in the 'structtst_test' to choose the required arch list. e.g. '.arch = "x86_64i386"'.
What is the status of this patch series? Is there a V3?
Maybe another option would be to check the kernel config?
Signature · 5 lines
Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Richard,
Quoted 5 lines · Richard Palethorpe
Hello Li,
Quoted 1 line · Li Wang
Testcases for specified arch should be limited on that only being
Quoted 9 lines
supported
Quoted 2 lines
platform to run, we now create a function
tst_on_archto achieve this new feature in LTP library. All you need to run a test on the expected archis
Quoted 2 lines
to set the '.arch' string in the 'struct
tst_test' to choose the required arch list. e.g. '.arch = "x86_64i386"'.What is the status of this patch series? Is there a V3?
Um, I can't recall why the V3 development for .arch was suspended.
Maybe we thought there is not much sense to replace ifdef __arch__ from code at that moment.
Now, if that can benefit the tst_test metadata more in the next runltp-ng. Should we keep going to work out the patch V3?
@Cyril Hrubis <[email protected]> any suggestions?
Quoted 3 lines
Maybe another option would be to check the kernel config?
That maybe works, but I'm not sure if that can distinguish i386/x86_64 or ppc64/ppc64le.
Signature · 2 lines
Regards, Li Wang
Signature · 2 lines
-- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 10 lines
Um, I can't recall why the V3 development for .arch was suspended.
Maybe we thought there is not much sense to replace ifdef
__arch__from code at that moment.Now, if that can benefit the
tst_testmetadata more in the next runltp-ng. Should we keep going to work out the patch V3?@Cyril Hrubis <[email protected]> any suggestions?
Hmm, I guess that I said that it still makes to add the metadata, at least array of supported architectures in the test_test structure would be a good addition.
However the hard part would be keeping the actual code and metadata in sync, we still have to keep the ifdefs in the code.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 7 lines · Cyril Hrubis
Hi!
Quoted 6 lines
Um, I can't recall why the V3 development for .arch was suspended.
Maybe we thought there is not much sense to replace ifdef
__arch__from code at that moment.
Quoted 8 lines
Quoted 1 line
Now, if that can benefit the
tst_testmetadata more in the nextrunltp-ng.
Quoted 3 lines
Should we keep going to work out the patch V3?
@Cyril Hrubis <[email protected]> any suggestions?
Hmm, I guess that I said that it still makes to add the metadata, at
Agreed.
Quoted 3 lines
least array of supported architectures in the
test_teststructure would be a good addition.
I guess defining .arch as a string and making a valid check will be enough. Array for that sounds a bit complicated in use.
Quoted 4 lines
However the hard part would be keeping the actual code and metadata in sync, we still have to keep the ifdefs in the code.
Yes, some inline assemble require ifdefs.
Btw, I look back at the reviews and find Jan said:
"I can see how tst_on_arch() would be useful. Test is valid
on all arches, but needs different input/constants/code/etc."
That may be a slight reason for keeping tst_on_arch.
Signature · 2 lines
Regards, Li Wang
Signature · 2 lines
-- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 6 lines
Quoted 3 lines
least array of supported architectures in the
test_teststructure would be a good addition.I guess defining .arch as a string and making a valid check will be enough. Array for that sounds a bit complicated in use.
Quite the opposite, it should be an array of strings, so that it's easy to work with such as:
.supported_archs = (const char *const []){"x86_64", "ppc64le", NULL},We can put it into a single string delimited by a space, but that would be more complicated to work with.
Quoted 11 lines
Quoted 3 lines
However the hard part would be keeping the actual code and metadata in sync, we still have to keep the ifdefs in the code.
Yes, some inline assemble require ifdefs.
Btw, I look back at the reviews and find Jan said:
"I can see howtst_on_arch()would be useful. Test is valid
on all arches, but needs different input/constants/code/etc."That may be a slight reason for keeping
tst_on_arch.
I guess that we should reviewe the code we have, I guess that there are a few tests where we can get rid of a few ifdefs by doing the checks dynamically.
Also I guess that it would be slightly easier to work with as an enum, so that we can do:
switch (tst_arch) {
case TST_X86_64:
...
break;
case TST_PPC64_LE:
...
break;
default:
...
break;
}instead of:
if (!strcmp(tst_arch, "x86_64")) ... else if (!strmcp(tst_arch, ...))) ... else ...
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hello,
Quoted 32 lines · Cyril Hrubis
Hi!
Quoted 6 lines
Quoted 3 lines
least array of supported architectures in the
test_teststructure would be a good addition.I guess defining .arch as a string and making a valid check will be enough. Array for that sounds a bit complicated in use.
Quite the opposite, it should be an array of strings, so that it's easy to work with such as:
.supported_archs = (const char *const []){"x86_64", "ppc64le", NULL},We can put it into a single string delimited by a space, but that would be more complicated to work with.
Quoted 11 lines
Quoted 3 lines
However the hard part would be keeping the actual code and metadata in sync, we still have to keep the ifdefs in the code.
Yes, some inline assemble require ifdefs.
Btw, I look back at the reviews and find Jan said:
"I can see howtst_on_arch()would be useful. Test is valid
on all arches, but needs different input/constants/code/etc."That may be a slight reason for keeping
tst_on_arch.I guess that we should reviewe the code we have, I guess that there are a few tests where we can get rid of a few ifdefs by doing the checks dynamically.
Quoted 8 lines
Also I guess that it would be slightly easier to work with as an enum, so that we can do:
switch (tst_arch) { case TST_X86_64: ... break; case TST_PPC64_LE:
I prefer enum as well. As an aside, we don't want to include LE in ppc64. If someone finds that the byte order is significant for a test then we can add ppc64le or ppc64be. Also at some point we may need to add a "machine" field for e.g. POWER8, i386 etc.
Which btw, I have some buildroot and QEMU scripts which can be used to test ppc64 BE and any other machine you have the hardware or QEMU emulator for.
https://gitlab.com/Palethorpe/cross
Quoted 14 lines
... break; default: ... break; }instead of:
if (!strcmp(tst_arch, "x86_64")) ... else if (!strmcp(tst_arch, ...))) ... else ...
Signature · 5 lines
Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 28 lines
Quoted 4 lines
Quite the opposite, it should be an array of strings, so that it's easy to work with such as:
.supported_archs = (const char *const []){"x86_64", "ppc64le",NULL},
Quoted 23 lines
We can put it into a single string delimited by a space, but that would be more complicated to work with.
Quoted 11 lines
Quoted 3 lines
However the hard part would be keeping the actual code and metadata in sync, we still have to keep the ifdefs in the code.
Yes, some inline assemble require ifdefs.
Btw, I look back at the reviews and find Jan said:
"I can see howtst_on_arch()would be useful. Test is valid
on all arches, but needs different input/constants/code/etc."That may be a slight reason for keeping
tst_on_arch.I guess that we should reviewe the code we have, I guess that there are a few tests where we can get rid of a few ifdefs by doing the checks dynamically.
Also I guess that it would be slightly easier to work with as an enum, so that we can do:
Quoted 8 lines
Quoted 5 lines
switch (tst_arch) { case TST_X86_64: ... break; case TST_PPC64_LE:I prefer enum as well. As an aside, we don't want to include LE in
Sure, but I'm now thinking to extend the tst_arch as a structure so that could also be used in a string:
enum tst_arch_type {
TST_I386,
TST_X86_64,
...
TST_SPARC,
};
/*
* This tst_arch is to save the system architecture for
* using in the whole test case.
*/
extern struct arch {
const char name[16];
enum tst_arch_type type;
} tst_arch;then we just can do simply in case:
switch (tst_arch.type) {
case TST_X86_64:
...
break;Quoted 2 lines
ppc64. If someone finds that the byte order is significant for a test
Yes, or we can read info via uname() into 'utsname.machine' for ppc64le if really needed.
Quoted 3 lines
then we can add ppc64le or ppc64be. Also at some point we may need to add a "machine" field for e.g. POWER8, i386 etc.
Adding a new field '.machine' maybe not be necessary if just for POWER8/9/10, or can we find a way to combine them together with .supported_arch? Umm, I'm still hesitating.
Quoted 6 lines
Which btw, I have some buildroot and QEMU scripts which can be used to test ppc64 BE and any other machine you have the hardware or QEMU emulator for.
Thanks for sharing.
Signature · 2 lines
Regards, Li Wang
Signature · 2 lines
-- Mailing list info: https://lists.linux.it/listinfo/ltp
Hell Li,
Quoted 35 lines · Li Wang
Quoted 26 lines
Quite the opposite, it should be an array of strings, so that it's easy to work with such as:
.supported_archs = (const char *const []){"x86_64", "ppc64le", NULL},We can put it into a single string delimited by a space, but that would be more complicated to work with.
Quoted 11 lines
Quoted 3 lines
However the hard part would be keeping the actual code and metadata in sync, we still have to keep the ifdefs in the code.
Yes, some inline assemble require ifdefs.
Btw, I look back at the reviews and find Jan said:
"I can see howtst_on_arch()would be useful. Test is valid
on all arches, but needs different input/constants/code/etc."That may be a slight reason for keeping
tst_on_arch.I guess that we should reviewe the code we have, I guess that there are a few tests where we can get rid of a few ifdefs by doing the checks dynamically.
Quoted 8 lines
Also I guess that it would be slightly easier to work with as an enum, so that we can do:
switch (tst_arch) { case TST_X86_64: ... break; case TST_PPC64_LE:
Quoted 4 lines
I prefer enum as well. As an aside, we don't want to include LE in
Sure, but I'm now thinking to extend the
tst_archas a structure so that could also be used in a string:
+1
Quoted 30 lines
enum tst_arch_type { TST_I386, TST_X86_64, ... TST_SPARC, }; /* * This tst_arch is to save the system architecture for * using in the whole test case. */ extern struct arch { const char name[16]; enum tst_arch_type type; } tst_arch;then we just can do simply in case:
switch (tst_arch.type) { case TST_X86_64: ... break;ppc64. If someone finds that the byte order is significant for a test
Yes, or we can read info via
uname()into 'utsname.machine' for ppc64le if really needed.
Quoted 6 lines
then we can add ppc64le or ppc64be. Also at some point we may need to add a "machine" field for e.g. POWER8, i386 etc.
Adding a new field '.machine' maybe not be necessary if just for POWER8/9/10, or can we find a way to combine them together with .supported_arch? Umm, I'm still hesitating.
If it's required then I guess you could add it to the tst_arch_type as an optional field. Perhaps as cpu_model. Or it could be added to a separate section for required hardware.
Quoted 9 lines
Which btw, I have some buildroot and QEMU scripts which can be used to test ppc64 BE and any other machine you have the hardware or QEMU emulator for.
https://gitlab.com/Palethorpe/cross
Thanks for sharing.
Signature · 5 lines
Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 15 lines
Quoted 11 lines
Quoted 8 lines
Also I guess that it would be slightly easier to work with as an enum, so that we can do:
switch (tst_arch) { case TST_X86_64: ... break; case TST_PPC64_LE:I prefer enum as well. As an aside, we don't want to include LE in
Sure, but I'm now thinking to extend the
tst_archas a structure so that could also be used in a string:
Quoted 15 lines
enum tst_arch_type {
TST_I386,
TST_X86_64,
...
TST_SPARC,
};
/*
* This tst_arch is to save the system architecture for
* using in the whole test case.
*/
extern struct arch {
const char name[16];
enum tst_arch_type type;
} tst_arch;Or we can add a function to translate the enums into strings as:
const char *tst_arch_name(enum tst_arch arch);
Quoted 16 lines
then we just can do simply in case:
switch (tst_arch.type) { case TST_X86_64: ... break;Quoted 2 lines
ppc64. If someone finds that the byte order is significant for a test
Yes, or we can read info via
uname()into 'utsname.machine' for ppc64le if really needed.
Quoted 7 lines
Quoted 3 lines
then we can add ppc64le or ppc64be. Also at some point we may need to add a "machine" field for e.g. POWER8, i386 etc.
Adding a new field '.machine' maybe not be necessary if just for POWER8/9/10, or can we find a way to combine them together with .supported_arch? Umm, I'm still hesitating.
This is going to get complicated quite fast. I do not think that we need such granularity now, but if we ever do I think it can be done as a subtype. E.g.:
enum tst_arch {
TST_X86,
TST_X86_64,
TST_PPC64,
};enum tst_x86_subarch {
TST_386,
TST_486,
TST_686,
};enum tst_ppc_subarch {
{
TST_POWER8,
TST_POWER9,
TST_POWER10,
};Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp