mm: kmemleak: alloc gray object for reserved region with direct map.
Subsystems (2)
PATCH 1/1 mm: kmemleak: alloc gray object for reserved region with direct map.
Reserved regions with direct mapping may contain references to other regions. CMA region with fixed location is reserved without creating kmemleak_object for it.
So add them as gray kmemleak objects.
--- drivers/of/fdt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/of/fdt.c +5 -1
@@ -26,6 +26,7 @@#include <linux/serial_core.h> #include <linux/sysfs.h> #include <linux/random.h> +#include <linux/kmemleak.h> #include <asm/setup.h> /* for COMMAND_LINE_SIZE */ #include <asm/page.h>
@@ -522,9 +523,12 @@ static int __init __reserved_mem_reserve_reg(unsigned long node, size =dt_mem_next_cell (dt_root_size_cells, &prop);if (size && -early_init_dt_reserve_memory_arch (base, size, nomap) ==0 ) +early_init_dt_reserve_memory_arch (base, size, nomap) ==0 ) {pr_debug ("Reserved memory: reserved region for node '%s': base %pa, size %lu MiB\n" , uname, &base, (unsigned long )(size /SZ_1M )); +if (!nomap) +kmemleak_alloc_phys (base, size,0 ,0 ); + }else pr_info ("Reserved memory: failed to reserve memory for node '%s': base %pa, size %lu MiB\n" , uname, &base, (unsigned long )(size /SZ_1M ));
Signature · 1 line
2.30.2
Quoted 5 lines · Calvin Zhang
Reserved regions with direct mapping may contain references to other regions. CMA region with fixed location is reserved without creating
kmemleak_objectfor it.So add them as gray kmemleak objects.
Do you get any kmemleak false positives without this patch? It would be good to include them in the commit message.
Without seeing a false positive caused by this, I'm not convinced it is the right approach. You mentioned CMA but telling kmemleak about the whole CMA region is a pretty big hammer. I'd rather add individual kmemleak_alloc_*() calls in cma_alloc().
Signature · 1 line
Catalin
Quoted 9 lines · Catalin Marinas
Quoted 5 lines · Calvin Zhang
Reserved regions with direct mapping may contain references to other regions. CMA region with fixed location is reserved without creating
kmemleak_objectfor it.So add them as gray kmemleak objects.
Do you get any kmemleak false positives without this patch? It would be good to include them in the commit message.
Sorry, no. I thought it was possible before I saw this commit:620951e27457 ("mm/cma: make kmemleak ignore CMA regions").
Quoted 5 lines
Without seeing a false positive caused by this, I'm not convinced it is the right approach. You mentioned CMA but telling kmemleak about the whole CMA region is a pretty big hammer. I'd rather add individual kmemleak_alloc_*() calls in
cma_alloc().
Yeah, I agree.
--
Calvin