Skip to contentSkip to conversation

staging: rtl8723bs: replace printk(KERN_CRIT...) by netdev_crit()

PATCH In review Satoshi Ikeke 2 participants 2 messages Nov 20, 2021 – Nov 25, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: replace printk(KERN_CRIT...) by netdev_crit()

Replace printk(KERN_CRIT...) by netdev_crit() for more uniform error reporting. Issue found by checkpatch.

---
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/os_dep/sdio_intf.c +1 -1
index 490431484524..8c90cb3a68ed 100644
@@ -73,7 +73,7 @@ static int sdio_alloc_irq(struct dvobj_priv *dvobj)
 	err = sdio_claim_irq(func, &sd_sync_int_hdl);
 	if (err) {
 		dvobj->drv_dbg.dbg_sdio_alloc_irq_error_cnt++;
-		printk(KERN_CRIT "%s: sdio_claim_irq FAIL(%d)!\n", __func__, err);
+		netdev_crit(dvobj->if1->pnetdev, "%s: sdio_claim_irq FAIL(%d)!\n", __func__, err);
 	} else {
 		dvobj->drv_dbg.dbg_sdio_alloc_irq_cnt++;
 		dvobj->irq_alloc = 1;
Signature · 1 line
2.30.2
maintainer
#1 lore raw
Quoted 1 line · Satoshi Ikeke

Replace printk(KERN_CRIT...) by netdev_crit() for more uniform error reporting. Issue found by checkpatch.

Please properly wrap your changelog comments at the correct line width.

Please fix up and send a v2.

thanks,

greg k-h