Skip to contentSkip to conversation

printk: Remove printk.h inclusion in percpu.h

PATCH In review Andy Shevchenko 3 participants 8 messages Nov 12, 2021 – Nov 15, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 printk: Remove printk.h inclusion in percpu.h

After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI") the printk.h is not needed anymore in percpu.h.

Moreover make headerdep complains (an excerpt)

In file included from linux/printk.h,

                 from linux/dynamic_debug.h:188
                 from linux/printk.h:559 <-- here
                 from linux/percpu.h:9
                 from linux/idr.h:17

include/net/9p/client.h:13: warning: recursive header inclusion

Yeah, it's not a root cause of this, but removing will help to reduce the noise.

Fixes 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI")
---
 include/linux/percpu.h | 1 -
 1 file changed, 1 deletion(-)
include/linux/percpu.h +0 -1
index 98a9371133f8..ae4004e7957e 100644
@@ -6,7 +6,6 @@
 #include <linux/preempt.h>
 #include <linux/smp.h>
 #include <linux/cpumask.h>
-#include <linux/printk.h>
 #include <linux/pfn.h>
 #include <linux/init.h>
 
Signature · 1 line
2.33.0
maintainer Acked-by on v1 1/1
#1 lore raw

Hello,

Quoted 36 lines · Andy Shevchenko

After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI") the printk.h is not needed anymore in percpu.h.

Moreover make headerdep complains (an excerpt)

In file included from linux/printk.h,

                 from linux/dynamic_debug.h:188
                 from linux/printk.h:559 <-- here
                 from linux/percpu.h:9
                 from linux/idr.h:17

include/net/9p/client.h:13: warning: recursive header inclusion

Yeah, it's not a root cause of this, but removing will help to reduce the noise.

Fixes 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI")
---
 include/linux/percpu.h | 1 -
 1 file changed, 1 deletion(-)
include/linux/percpu.h +0 -1
index 98a9371133f8..ae4004e7957e 100644
@@ -6,7 +6,6 @@
 #include <linux/preempt.h>
 #include <linux/smp.h>
 #include <linux/cpumask.h>
-#include <linux/printk.h>
 #include <linux/pfn.h>
 #include <linux/init.h>
 
Signature · 1 line
2.33.0

Hey Andrew, it doesn't seem like I have anything big coming through percpu, do you mind taking this. I might have some stuff due to sh, but I'm still working on that with them.

Thanks,
Dennis

Reviewed-by
#2 lore raw
Quoted 13 lines · Dennis Zhou
Quoted 12 lines · Andy Shevchenko

After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI") the printk.h is not needed anymore in percpu.h.

Moreover make headerdep complains (an excerpt)

In file included from linux/printk.h,

                 from linux/dynamic_debug.h:188
                 from linux/printk.h:559 <-- here
                 from linux/percpu.h:9
                 from linux/idr.h:17

include/net/9p/client.h:13: warning: recursive header inclusion

Quoted 5 lines
Quoted 5 lines

Yeah, it's not a root cause of this, but removing will help to reduce the noise.

Fixes 42a0bb3f7138 ("printk/nmi: generic solution for safe printk

in NMI")

Yup, the include was there because of printk_func_t definition that was removed by the above commit.

Quoted 3 lines

Hey Andrew, it doesn't seem like I have anything big coming through percpu, do you mind taking this. I might have some stuff due to sh, but I'm still working on that with them.

I assume that either Andrew or Dennis will take this patch.

Best Regards,
Petr

#3 lore raw
Quoted 23 lines · Petr Mladek
Quoted 13 lines · Dennis Zhou
Quoted 12 lines · Andy Shevchenko

After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI") the printk.h is not needed anymore in percpu.h.

Moreover make headerdep complains (an excerpt)

In file included from linux/printk.h,

                 from linux/dynamic_debug.h:188
                 from linux/printk.h:559 <-- here
                 from linux/percpu.h:9
                 from linux/idr.h:17

include/net/9p/client.h:13: warning: recursive header inclusion

Quoted 5 lines
Quoted 5 lines

Yeah, it's not a root cause of this, but removing will help to reduce the noise.

Fixes 42a0bb3f7138 ("printk/nmi: generic solution for safe printk

in NMI")

Yup, the include was there because of printk_func_t definition that was removed by the above commit.

Quoted 7 lines
Quoted 3 lines

Hey Andrew, it doesn't seem like I have anything big coming through percpu, do you mind taking this. I might have some stuff due to sh, but I'm still working on that with them.

I assume that either Andrew or Dennis will take this patch.

I assumed you take it, that's why I haven't Cc'ed Andrew in the first place, but it seems you have a consensus with Dennis that Andrew is the best maintainer to take this. So, I'll send v2 with tags and Cc to him.

Thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 30 lines · Andy Shevchenko
Quoted 29 lines · Petr Mladek
Quoted 13 lines · Dennis Zhou
Quoted 12 lines · Andy Shevchenko

After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI") the printk.h is not needed anymore in percpu.h.

Moreover make headerdep complains (an excerpt)

In file included from linux/printk.h,

                 from linux/dynamic_debug.h:188
                 from linux/printk.h:559 <-- here
                 from linux/percpu.h:9
                 from linux/idr.h:17

include/net/9p/client.h:13: warning: recursive header inclusion

Quoted 5 lines
Quoted 5 lines

Yeah, it's not a root cause of this, but removing will help to reduce the noise.

Fixes 42a0bb3f7138 ("printk/nmi: generic solution for safe printk

in NMI")

Yup, the include was there because of printk_func_t definition that was removed by the above commit.

Quoted 3 lines

Hey Andrew, it doesn't seem like I have anything big coming through percpu, do you mind taking this. I might have some stuff due to sh, but I'm still working on that with them.

Quoted 5 lines
Quoted 1 line

I assume that either Andrew or Dennis will take this patch.

I assumed you take it, that's why I haven't Cc'ed Andrew in the first place, but it seems you have a consensus with Dennis that Andrew is the best maintainer to take this. So, I'll send v2 with tags and Cc to him.

No problem, I am going to take it, in a hour or so. I did not want to make chaos when Denis asked Andrew. But it is not worth resending the patch.

Best Regards,
Petr

#5 lore raw
Quoted 2 lines · Petr Mladek
Quoted 1 line · Andy Shevchenko

On Mon, Nov 15, 2021 at 10:48:04AM +0100, Petr Mladek wrote:

...

Quoted 6 lines
Quoted 3 lines

I assumed you take it, that's why I haven't Cc'ed Andrew in the first place, but it seems you have a consensus with Dennis that Andrew is the best maintainer to take this. So, I'll send v2 with tags and Cc to him.

No problem, I am going to take it, in a hour or so. I did not want to make chaos when Denis asked Andrew. But it is not worth resending the patch.

Thanks!

If needed something from me, just ping.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw
In reply to Petr Mladek
Quoted 31 lines · Petr Mladek
Quoted 30 lines · Andy Shevchenko
Quoted 29 lines · Petr Mladek
Quoted 13 lines · Dennis Zhou
Quoted 12 lines · Andy Shevchenko

After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI") the printk.h is not needed anymore in percpu.h.

Moreover make headerdep complains (an excerpt)

In file included from linux/printk.h,

                 from linux/dynamic_debug.h:188
                 from linux/printk.h:559 <-- here
                 from linux/percpu.h:9
                 from linux/idr.h:17

include/net/9p/client.h:13: warning: recursive header inclusion

Quoted 5 lines
Quoted 5 lines

Yeah, it's not a root cause of this, but removing will help to reduce the noise.

Fixes 42a0bb3f7138 ("printk/nmi: generic solution for safe printk

in NMI")

Yup, the include was there because of printk_func_t definition that was removed by the above commit.

Quoted 3 lines

Hey Andrew, it doesn't seem like I have anything big coming through percpu, do you mind taking this. I might have some stuff due to sh, but I'm still working on that with them.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

I assume that either Andrew or Dennis will take this patch.

I assumed you take it, that's why I haven't Cc'ed Andrew in the first place, but it seems you have a consensus with Dennis that Andrew is the best maintainer to take this. So, I'll send v2 with tags and Cc to him.

No problem, I am going to take it, in a hour or so. I did not want to make chaos when Denis asked Andrew. But it is not worth resending the patch.

The patch is comitted in printk/linux.git, branch for-5.16-fixup.

I am going to add it into pull request for 5.16-rc2 with another fix.

Best Regards,
Petr

maintainer
#7 lore raw
Quoted 41 lines · Petr Mladek
Quoted 31 lines · Petr Mladek
Quoted 30 lines · Andy Shevchenko
Quoted 29 lines · Petr Mladek
Quoted 13 lines · Dennis Zhou
Quoted 12 lines · Andy Shevchenko

After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI") the printk.h is not needed anymore in percpu.h.

Moreover make headerdep complains (an excerpt)

In file included from linux/printk.h,

                 from linux/dynamic_debug.h:188
                 from linux/printk.h:559 <-- here
                 from linux/percpu.h:9
                 from linux/idr.h:17

include/net/9p/client.h:13: warning: recursive header inclusion

Quoted 5 lines
Quoted 5 lines

Yeah, it's not a root cause of this, but removing will help to reduce the noise.

Fixes 42a0bb3f7138 ("printk/nmi: generic solution for safe printk

in NMI")

Yup, the include was there because of printk_func_t definition that was removed by the above commit.

Quoted 3 lines

Hey Andrew, it doesn't seem like I have anything big coming through percpu, do you mind taking this. I might have some stuff due to sh, but I'm still working on that with them.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

I assume that either Andrew or Dennis will take this patch.

I assumed you take it, that's why I haven't Cc'ed Andrew in the first place, but it seems you have a consensus with Dennis that Andrew is the best maintainer to take this. So, I'll send v2 with tags and Cc to him.

No problem, I am going to take it, in a hour or so. I did not want to make chaos when Denis asked Andrew. But it is not worth resending the patch.

Quoted 6 lines

The patch is comitted in printk/linux.git, branch for-5.16-fixup.

I am going to add it into pull request for 5.16-rc2 with another fix.

Best Regards,
Petr

Thanks Petr!

In general I would take it, it just depends on other circumstances such as if I'm carrying anything or if there is any other bigger issues with other mm. Right now I'm dealing with mm as a fix for hotplug in percpu has been pulled and I'm not terribly happy about it.

I appreciate being looped in and made aware of the changes. Thank you Andy and Petr.

Thanks,
Dennis