Skip to contentSkip to conversation

Documentation: Add minimum pahole version

PATCH Superseded Arnaldo Carvalho de Melo 3 participants 4 messages Nov 16, 2021 – Nov 18, 2021

Subsystems (5)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: Add minimum pahole version

A report was made in https://github.com/acmel/dwarves/issues/26 about pahole not being listed in the process/changes.rst file as being needed for building the kernel, address that.

---
 Documentation/process/changes.rst | 9 +++++++++
 1 file changed, 9 insertions(+)
Documentation/process/changes.rst +9 -0
index e35ab74a0f804b04..c45f167a1b6c02a4 100644
@@ -35,6 +35,7 @@ GNU make               3.81             make --version
 binutils               2.23             ld -v
 flex                   2.5.35           flex --version
 bison                  2.0              bison --version
+pahole                 1.16             pahole --version
 util-linux             2.10o            fdformat --version
 kmod                   13               depmod -V
 e2fsprogs              1.41.4           e2fsck -V
@@ -108,6 +109,14 @@ Bison
 Since Linux 4.16, the build system generates parsers
 during build.  This requires bison 2.0 or later.
 
+pahole:
+-------
+
+Since Linux 5.2 the build system generates BTF (BPF Type Format) from DWARF in
+vmlinux, a bit later from kernel modules as well, if CONFIG_DEBUG_INFO_BTF is
+selected.  This requires pahole v1.16 or later. It is found in the 'dwarves' or
+'pahole' distro packages or from https://fedorapeople.org/~acme/dwarves/.
+
 Perl
 ----
 
Signature · 1 line
2.31.1
Acked-by on v1 1/1
#1 lore raw
Quoted 31 lines · Arnaldo Carvalho de Melo

A report was made in https://github.com/acmel/dwarves/issues/26 about pahole not being listed in the process/changes.rst file as being needed for building the kernel, address that.

---
 Documentation/process/changes.rst | 9 +++++++++
 1 file changed, 9 insertions(+)
Documentation/process/changes.rst +1 -0
index e35ab74a0f804b04..c45f167a1b6c02a4 100644
@@ -35,6 +35,7 @@ GNU make               3.81             make --version
 binutils               2.23             ld -v
 flex                   2.5.35           flex --version
 bison                  2.0              bison --version
+pahole                 1.16             pahole --version
 util-linux             2.10o            fdformat --version
 kmod                   13               depmod -V
 e2fsprogs              1.41.4           e2fsck -V

Documentation/process/changes.rst Bison · line 116

Quoted 8 lines
Documentation/process/changes.rst +5 -0
@@ -108,6 +109,14 @@ Bison
 Since Linux 4.16, the build system generates parsers
 during build.  This requires bison 2.0 or later.
 
+pahole:
+-------
+
+Since Linux 5.2 the build system generates BTF (BPF Type Format) from DWARF in
+vmlinux, a bit later from kernel modules as well, if CONFIG_DEBUG_INFO_BTF is

I'd probably emphasize a bit more that pahole is required only if CONFIG_DEBUG_INFO_BTF is selected by moving "If CONFIG_DEBUG_INFO_BTF is selected, " to the front. But either way looks good.

Quoted 9 lines
Documentation/process/changes.rst +3 -1
+selected.  This requires pahole v1.16 or later. It is found in the 'dwarves' or
+'pahole' distro packages or from https://fedorapeople.org/~acme/dwarves/.
+
 Perl
 ----
 
--

2.31.1

maintainer
#2 lore raw
Quoted 36 lines · Andrii Nakryiko
Quoted 34 lines · Arnaldo Carvalho de Melo

A report was made in https://github.com/acmel/dwarves/issues/26 about pahole not being listed in the process/changes.rst file as being needed for building the kernel, address that.

---
  Documentation/process/changes.rst | 9 +++++++++
  1 file changed, 9 insertions(+)
Documentation/process/changes.rst +1 -0
index e35ab74a0f804b04..c45f167a1b6c02a4 100644
@@ -35,6 +35,7 @@ GNU make               3.81             make --version
  binutils               2.23             ld -v
  flex                   2.5.35           flex --version
  bison                  2.0              bison --version
+pahole                 1.16             pahole --version
  util-linux             2.10o            fdformat --version
  kmod                   13               depmod -V
  e2fsprogs              1.41.4           e2fsck -V
@@ -108,6 +109,14 @@ Bison
  Since Linux 4.16, the build system generates parsers
  during build.  This requires bison 2.0 or later.
 
Quoted 9 lines

Documentation/process/changes.rst Bison · line 116

Quoted 5 lines
Documentation/process/changes.rst +5 -0
+pahole:
+-------
+
+Since Linux 5.2 the build system generates BTF (BPF Type Format) from DWARF in
+vmlinux, a bit later from kernel modules as well, if CONFIG_DEBUG_INFO_BTF is

I'd probably emphasize a bit more that pahole is required only if CONFIG_DEBUG_INFO_BTF is selected by moving "If CONFIG_DEBUG_INFO_BTF is selected, " to the front. But either way looks good.

+1, I presume Jonathan will later pick up the v2?

Quoted 11 lines
Quoted 9 lines
Documentation/process/changes.rst +3 -1
+selected.  This requires pahole v1.16 or later. It is found in the 'dwarves' or
+'pahole' distro packages or from https://fedorapeople.org/~acme/dwarves/.
+
  Perl
  ----
 
--

2.31.1

#3 lore raw

Em Wed, Nov 17, 2021 at 11:33:24PM +0100, Daniel Borkmann escreveu:

Quoted 47 lines · Andrii Nakryiko
Quoted 36 lines
Quoted 34 lines · Arnaldo Carvalho de Melo

A report was made in https://github.com/acmel/dwarves/issues/26 about pahole not being listed in the process/changes.rst file as being needed for building the kernel, address that.

---
  Documentation/process/changes.rst | 9 +++++++++
  1 file changed, 9 insertions(+)
Documentation/process/changes.rst +1 -0
index e35ab74a0f804b04..c45f167a1b6c02a4 100644
@@ -35,6 +35,7 @@ GNU make               3.81             make --version
  binutils               2.23             ld -v
  flex                   2.5.35           flex --version
  bison                  2.0              bison --version
+pahole                 1.16             pahole --version
  util-linux             2.10o            fdformat --version
  kmod                   13               depmod -V
  e2fsprogs              1.41.4           e2fsck -V
@@ -108,6 +109,14 @@ Bison
  Since Linux 4.16, the build system generates parsers
  during build.  This requires bison 2.0 or later.
 
Quoted 9 lines

Documentation/process/changes.rst Bison · line 116

Quoted 5 lines
Documentation/process/changes.rst +5 -0
+pahole:
+-------
+
+Since Linux 5.2 the build system generates BTF (BPF Type Format) from DWARF in
+vmlinux, a bit later from kernel modules as well, if CONFIG_DEBUG_INFO_BTF is

I'd probably emphasize a bit more that pahole is required only if CONFIG_DEBUG_INFO_BTF is selected by moving "If CONFIG_DEBUG_INFO_BTF is selected, " to the front. But either way looks good.

Quoted 1 line

+1, I presume Jonathan will later pick up the v2?

I'll resubmit later.

- Arnaldo

Quoted 11 lines
Quoted 11 lines
Quoted 9 lines
Documentation/process/changes.rst +3 -1
+selected.  This requires pahole v1.16 or later. It is found in the 'dwarves' or
+'pahole' distro packages or from https://fedorapeople.org/~acme/dwarves/.
+
  Perl
  ----
 
--

2.31.1

Signature · 1 line
- Arnaldo