Skip to contentSkip to conversation

remoteproc: qcom: pas: Add missing power-domain "mxc" for CDSP

PATCH Applied Sibi Sankar 2 participants 3 messages Jun 24, 2021 – Dec 15, 2021

Subsystems (3)
Stable branch Arm Qualcomm mailing list Remote processor (remoteproc)
lore
Share & tools
lore

Sibi Sankar

author
#0 lore raw

PATCH 1/1 remoteproc: qcom: pas: Add missing power-domain "mxc" for CDSP

Add missing power-domain "mxc" required by CDSP PAS remoteproc on SM8350 SoC.

Fixes e8b4e9a21af7 ("remoteproc: qcom: pas: Add SM8350 PAS remoteprocs")
Signed-off-by Sibi Sankar <[email protected]>
Cc [email protected]

---

The device tree and pas documentation lists mcx as a required pd for cdsp. Looks like it was missed while adding the proxy pds in the pas driver. Bjorn/Vinod you'll need to test this patch before picking it up.

 drivers/remoteproc/qcom_q6v5_pas.c | 1 +
 1 file changed, 1 insertion(+)
drivers/remoteproc/qcom_q6v5_pas.c +1 -0
index b921fc26cd04..ad20065dbdea 100644
@@ -661,6 +661,7 @@ static const struct adsp_data sm8350_cdsp_resource = {
 	},
 	.proxy_pd_names = (char*[]){
 		"cx",
+		"mxc",
 		NULL
 	},
 	.ssr_name = "cdsp",
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Tested-by on v1 1/1
#1 lore raw
Quoted 12 lines · Sibi Sankar

Add missing power-domain "mxc" required by CDSP PAS remoteproc on SM8350 SoC.

Fixes e8b4e9a21af7 ("remoteproc: qcom: pas: Add SM8350 PAS remoteprocs")
Signed-off-by Sibi Sankar <[email protected]>
Cc [email protected]

---

The device tree and pas documentation lists mcx as a required pd for cdsp. Looks like it was missed while adding the proxy pds in the pas driver. Bjorn/Vinod you'll need to test this patch before picking it up.

At least on the HDK mxc seems to be optional given the current system state, but I don't see any regressions so let's land this before we put the system in a state where it would matter.

Tested-by Bjorn Andersson <[email protected]>

Regards,
Bjorn

Quoted 19 lines
 drivers/remoteproc/qcom_q6v5_pas.c | 1 +
 1 file changed, 1 insertion(+)
drivers/remoteproc/qcom_q6v5_pas.c +1 -0
index b921fc26cd04..ad20065dbdea 100644
@@ -661,6 +661,7 @@ static const struct adsp_data sm8350_cdsp_resource = {
 	},
 	.proxy_pd_names = (char*[]){
 		"cx",
+		"mxc",
 		NULL
 	},
 	.ssr_name = "cdsp",
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Applied
#2 lore raw

Re: (subset) [PATCH] remoteproc: qcom: pas: Add missing power-domain "mxc" for CDSP

In reply to Sibi Sankar
Quoted 4 lines · Sibi Sankar

Add missing power-domain "mxc" required by CDSP PAS remoteproc on SM8350 SoC.

Applied, thanks!

[1/1] remoteproc: qcom: pas: Add missing power-domain "mxc" for CDSP

      commit: dd585d9bfbf06fd08a6326c82978be1f06e7d1bd

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>