Skip to contentSkip to conversation

mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs

PATCH In review Ed Schaller 3 participants 7 messages Nov 22, 2021 – Nov 23, 2021 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs

Add new IDs of the Intel Lakefield chip to the list of supported devices.

---
 drivers/mfd/intel-lpss-pci.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/mfd/intel-lpss-pci.c +7 -0
index a872b4485eac..9700e5acd0cd 100644
@@ -359,7 +359,14 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
 	/* LKF */
 	{ PCI_VDEVICE(INTEL, 0x98a8), (kernel_ulong_t)&bxt_uart_info },
 	{ PCI_VDEVICE(INTEL, 0x98a9), (kernel_ulong_t)&bxt_uart_info },
+	{ PCI_VDEVICE(INTEL, 0x98aa), (kernel_ulong_t)&bxt_info },
+	{ PCI_VDEVICE(INTEL, 0x98c5), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98c6), (kernel_ulong_t)&bxt_i2c_info },
 	{ PCI_VDEVICE(INTEL, 0x98c7), (kernel_ulong_t)&bxt_uart_info },
+	{ PCI_VDEVICE(INTEL, 0x98e8), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98e9), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98ea), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98eb), (kernel_ulong_t)&bxt_i2c_info },
 	/* SPT-LP */
 	{ PCI_VDEVICE(INTEL, 0x9d27), (kernel_ulong_t)&spt_uart_info },
 	{ PCI_VDEVICE(INTEL, 0x9d28), (kernel_ulong_t)&spt_uart_info },
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Ed Schaller

Add new IDs of the Intel Lakefield chip to the list of supported devices.

Thank you for the patch, it LGTM,

Quoted 26 lines
---
 drivers/mfd/intel-lpss-pci.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/mfd/intel-lpss-pci.c +7 -0
index a872b4485eac..9700e5acd0cd 100644
@@ -359,7 +359,14 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
 	/* LKF */
 	{ PCI_VDEVICE(INTEL, 0x98a8), (kernel_ulong_t)&bxt_uart_info },
 	{ PCI_VDEVICE(INTEL, 0x98a9), (kernel_ulong_t)&bxt_uart_info },
+	{ PCI_VDEVICE(INTEL, 0x98aa), (kernel_ulong_t)&bxt_info },
+	{ PCI_VDEVICE(INTEL, 0x98c5), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98c6), (kernel_ulong_t)&bxt_i2c_info },
 	{ PCI_VDEVICE(INTEL, 0x98c7), (kernel_ulong_t)&bxt_uart_info },
+	{ PCI_VDEVICE(INTEL, 0x98e8), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98e9), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98ea), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98eb), (kernel_ulong_t)&bxt_i2c_info },
 	/* SPT-LP */
 	{ PCI_VDEVICE(INTEL, 0x9d27), (kernel_ulong_t)&spt_uart_info },
 	{ PCI_VDEVICE(INTEL, 0x9d28), (kernel_ulong_t)&spt_uart_info },
Signature · 1 line
2.30.2
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 23 lines · Andy Shevchenko
Quoted 2 lines · Ed Schaller

Add new IDs of the Intel Lakefield chip to the list of supported devices.

Thank you for the patch, it LGTM,

Quoted 16 lines
---
 drivers/mfd/intel-lpss-pci.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/mfd/intel-lpss-pci.c +3 -0
index a872b4485eac..9700e5acd0cd 100644
@@ -359,7 +359,14 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
 	/* LKF */
 	{ PCI_VDEVICE(INTEL, 0x98a8), (kernel_ulong_t)&bxt_uart_info },
 	{ PCI_VDEVICE(INTEL, 0x98a9), (kernel_ulong_t)&bxt_uart_info },
+	{ PCI_VDEVICE(INTEL, 0x98aa), (kernel_ulong_t)&bxt_info },
+	{ PCI_VDEVICE(INTEL, 0x98c5), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98c6), (kernel_ulong_t)&bxt_i2c_info },
Quoted 8 lines

drivers/mfd/intel-lpss-pci.c static const struct pci_device_id intel_lpss_pci_ids[] = { · line 372

Quoted 8 lines
drivers/mfd/intel-lpss-pci.c +4 -0
 	{ PCI_VDEVICE(INTEL, 0x98c7), (kernel_ulong_t)&bxt_uart_info },
+	{ PCI_VDEVICE(INTEL, 0x98e8), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98e9), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98ea), (kernel_ulong_t)&bxt_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0x98eb), (kernel_ulong_t)&bxt_i2c_info },
 	/* SPT-LP */
 	{ PCI_VDEVICE(INTEL, 0x9d27), (kernel_ulong_t)&spt_uart_info },
 	{ PCI_VDEVICE(INTEL, 0x9d28), (kernel_ulong_t)&spt_uart_info },

Odd. This didn't make it into my inbox.

Would you mind gathering Andy's R-b and re-sending please Ed?

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
#3 lore raw
Quoted 7 lines · Lee Jones
Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Ed Schaller

Add new IDs of the Intel Lakefield chip to the list of supported devices.

Thank you for the patch, it LGTM,

...

Quoted 1 line

Odd. This didn't make it into my inbox.

Hmm... Maybe it's sorted out due to linux-gpio@ vs. linux-kernel@ ML?

Quoted 1 line

Would you mind gathering Andy's R-b and re-sending please Ed?

Ed, please Cc also to LKML.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines · Lee Jones
Quoted 4 lines · Andy Shevchenko
Quoted 2 lines · Ed Schaller

Add new IDs of the Intel Lakefield chip to the list of supported devices.

Quoted 8 lines
Quoted 2 lines
Quoted 2 lines

Thank you for the patch, it LGTM,

...

Quoted 1 line

Odd. This didn't make it into my inbox.

Hmm... Maybe it's sorted out due to linux-gpio@ vs. linux-kernel@ ML?

No, I mean it doesn't appear anywhere in my mail.

Including LKML et al. sub-folders.

Quoted 3 lines
Quoted 1 line

Would you mind gathering Andy's R-b and re-sending please Ed?

Ed, please Cc also to LKML.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
#5 lore raw
Quoted 3 lines · Lee Jones
Quoted 2 lines · Andy Shevchenko
Quoted 1 line · Lee Jones

On Mon, 22 Nov 2021, Andy Shevchenko wrote:

...

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Odd. This didn't make it into my inbox.

Hmm... Maybe it's sorted out due to linux-gpio@ vs. linux-kernel@ ML?

No, I mean it doesn't appear anywhere in my mail.

Including LKML et al. sub-folders.

I see, this is indeed odd.

Signature · 2 lines
With Best Regards,
Andy Shevchenko

A message that is not in the archive (sent off-list or not yet received): CAJo6XL_DfWcVbT92X8fsd=mvs9AkzNQ2A1hPJpeGxrqC3BuL=g@mail.gmail.com

#7 lore raw
Quoted 16 lines · Ed Schaller
Quoted 13 lines · Andy Shevchenko
Quoted 3 lines · Lee Jones
Quoted 2 lines · Andy Shevchenko
Quoted 1 line · Lee Jones

On Mon, 22 Nov 2021, Andy Shevchenko wrote:

...

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Odd. This didn't make it into my inbox.

Hmm... Maybe it's sorted out due to linux-gpio@ vs. linux-kernel@ ML?

No, I mean it doesn't appear anywhere in my mail.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Including LKML et al. sub-folders.

I see, this is indeed odd.

I submitted again with Andy's RB.

I'd suspect spam filters given the issues I've had with that domain before.

Ah yes, that would make sense. Thanks for resubmitting.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog