Skip to contentSkip to conversation

dt-bindings: regulator: maxim,max8973: Document interrupts property

PATCH In review Thierry Reding 4 participants 5 messages Dec 6, 2021 – Dec 7, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: regulator: maxim,max8973: Document interrupts property

From: Thierry Reding <[email protected]>

One of the examples in the bindings has an interrupts property and the Linux kernel driver has support for requesting an interrupt as well. It looks like the absence from the bindings was just an oversight. Add the property to make sure the examples can be validated.

---
 Documentation/devicetree/bindings/regulator/maxim,max8973.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/regulator/maxim,max8973.yaml +3 -0
index 54522827265b..35c53e27f78c 100644
@@ -86,6 +86,9 @@ properties:
   reg:
     maxItems: 1
 
+  interrupts:
+    maxItems: 1
+
 required:
   - compatible
   - reg
Signature · 1 line
2.33.1
maintainer
#1 lore raw
Quoted 6 lines · Thierry Reding

From: Thierry Reding <[email protected]>

One of the examples in the bindings has an interrupts property and the Linux kernel driver has support for requesting an interrupt as well. It looks like the absence from the bindings was just an oversight. Add the property to make sure the examples can be validated.

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.

Reviewed-by on v1 1/1
#2 lore raw
In reply to Thierry Reding
Quoted 17 lines · Thierry Reding

From: Thierry Reding <[email protected]>

One of the examples in the bindings has an interrupts property and the Linux kernel driver has support for requesting an interrupt as well. It looks like the absence from the bindings was just an oversight. Add the property to make sure the examples can be validated.

---
 Documentation/devicetree/bindings/regulator/maxim,max8973.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/regulator/maxim,max8973.yaml +0 -0
index 54522827265b..35c53e27f78c 100644

Documentation/devicetree/bindings/regulator/maxim,max8973.yaml properties: · line 91

Quoted 6 lines
Documentation/devicetree/bindings/regulator/maxim,max8973.yaml +3 -0
@@ -86,6 +86,9 @@ properties:
   reg:
     maxItems: 1
 
+  interrupts:
+    maxItems: 1
+

The subject prefix should be "regulator: dt-bindings: ...".

Best regards,
Krzysztof

maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Thierry Reding
Quoted 7 lines · Thierry Reding

From: Thierry Reding <[email protected]>

One of the examples in the bindings has an interrupts property and the Linux kernel driver has support for requesting an interrupt as well. It looks like the absence from the bindings was just an oversight. Add the property to make sure the examples can be validated.

Quoted 5 lines
---
 Documentation/devicetree/bindings/regulator/maxim,max8973.yaml | 3 +++
 1 file changed, 3 insertions(+)
maintainer
#4 lore raw
In reply to Thierry Reding
Quoted 8 lines · Thierry Reding

From: Thierry Reding <[email protected]>

One of the examples in the bindings has an interrupts property and the Linux kernel driver has support for requesting an interrupt as well. It looks like the absence from the bindings was just an oversight. Add the property to make sure the examples can be validated.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] dt-bindings: regulator: maxim,max8973: Document interrupts property

      commit: 4aafc5c61b4c2be920b8a56b11279c5fadb8a6bf

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark