Skip to contentSkip to conversation

dt-bindings: usb: Add missing properties used in examples

PATCH In review Rob Herring 3 participants 4 messages Dec 6, 2021 – Dec 8, 2021

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: usb: Add missing properties used in examples

With 'unevaluatedProperties' support implemented, the following warnings are generated in the usb examples:

Documentation/devicetree/bindings/usb/intel,keembay-dwc3.example.dt.yaml: usb: usb@34000000: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/usb/snps,dwc3.example.dt.yaml: usb@4a030000: Unevaluated properties are not allowed ('reg' was unexpected)

Add the missing property definitions.

Cc Greg Kroah-Hartman <[email protected]>
Cc Ahmad Zainie <[email protected]>
Cc Felipe Balbi <[email protected]>
---
 .../devicetree/bindings/usb/intel,keembay-dwc3.yaml         | 3 +++
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml        | 6 ++++++
 2 files changed, 9 insertions(+)
Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml +3 -0
index 43b91ab62004..d3511f48cd55 100644
@@ -13,6 +13,9 @@ properties:
   compatible:
     const: intel,keembay-dwc3
 
+  reg:
+    maxItems: 1
+
   clocks:
     maxItems: 4
 
Documentation/devicetree/bindings/usb/snps,dwc3.yaml +6 -0
index 25ac2c93dc6c..d29ffcd27472 100644
@@ -36,6 +36,9 @@ properties:
         - const: synopsys,dwc3
           deprecated: true
 
+  reg:
+    maxItems: 1
+
   interrupts:
     description:
       It's either a single common DWC3 interrupt (dwc_usb3) or individual
@@ -65,6 +68,9 @@ properties:
         - enum: [bus_early, ref, suspend]
         - true
 
+  iommus:
+    maxItems: 1
+
   usb-phy:
     minItems: 1
     items:
Signature · 1 line
2.32.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the following warnings are generated in the usb examples:

Documentation/devicetree/bindings/usb/intel,keembay-dwc3.example.dt.yaml: usb: usb@34000000: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/usb/snps,dwc3.example.dt.yaml: usb@4a030000: Unevaluated properties are not allowed ('reg' was unexpected)

Add the missing property definitions.

Cc Greg Kroah-Hartman <[email protected]>
Cc Ahmad Zainie <[email protected]>
Cc Felipe Balbi <[email protected]>
Quoted 4 lines
---
 .../devicetree/bindings/usb/intel,keembay-dwc3.yaml         | 3 +++
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml        | 6 ++++++
 2 files changed, 9 insertions(+)

Do you want me to take these in my tree? If not, you can take them in yours:

Which ever is easier for you.

greg k-h

author maintainer
#2 lore raw
Quoted 19 lines · Greg Kroah-Hartman
Quoted 13 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the following warnings are generated in the usb examples:

Documentation/devicetree/bindings/usb/intel,keembay-dwc3.example.dt.yaml: usb: usb@34000000: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/usb/snps,dwc3.example.dt.yaml: usb@4a030000: Unevaluated properties are not allowed ('reg' was unexpected)

Add the missing property definitions.

Cc Greg Kroah-Hartman <[email protected]>
Cc Ahmad Zainie <[email protected]>
Cc Felipe Balbi <[email protected]>
Quoted 4 lines
---
 .../devicetree/bindings/usb/intel,keembay-dwc3.yaml         | 3 +++
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml        | 6 ++++++
 2 files changed, 9 insertions(+)
Quoted 5 lines

Do you want me to take these in my tree? If not, you can take them in yours:

Which ever is easier for you.

I'll take them.

Rob

Reviewed-by on v1 1/1
#3 lore raw
In reply to Rob Herring
Quoted 13 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the following warnings are generated in the usb examples:

Documentation/devicetree/bindings/usb/intel,keembay-dwc3.example.dt.yaml: usb: usb@34000000: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/usb/snps,dwc3.example.dt.yaml: usb@4a030000: Unevaluated properties are not allowed ('reg' was unexpected)

Add the missing property definitions.

Cc Greg Kroah-Hartman <[email protected]>
Cc Ahmad Zainie <[email protected]>
Cc Felipe Balbi <[email protected]>
Quoted 4 lines
---
 .../devicetree/bindings/usb/intel,keembay-dwc3.yaml         | 3 +++
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml        | 6 ++++++
 2 files changed, 9 insertions(+)