Skip to contentSkip to conversation

perf tools: remove unneeded variable

PATCH In review [email protected] 2 participants 2 messages Nov 22, 2021 – Nov 28, 2021 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf tools: remove unneeded variable

From: ran jianping <[email protected]>

Fix the following coccicheck review:
./tools/perf/util/evlist.c:1303:5-8: Unneeded variable

Remove unneeded variable used to store return value.

---
 tools/perf/util/evlist.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/perf/util/evlist.c +1 -2
index 5f92319ce258..d64fe767f583 100644
@@ -1300,7 +1300,6 @@ static int evlist__create_syswide_maps(struct evlist *evlist)
 {
 	struct perf_cpu_map *cpus;
 	struct perf_thread_map *threads;
-	int err = -ENOMEM;
 
 	/*
 	 * Try reading /sys/devices/system/cpu/online to get
@@ -1325,7 +1324,7 @@ static int evlist__create_syswide_maps(struct evlist *evlist)
 out_put:
 	perf_cpu_map__put(cpus);
 out:
-	return err;
+	return -ENOMEM;
 }
 
 int evlist__open(struct evlist *evlist)
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Mon, Nov 22, 2021 at 01:41:59AM +0000, [email protected] wrote:

From: ran jianping <[email protected]>

Fix the following coccicheck review:
./tools/perf/util/evlist.c:1303:5-8: Unneeded variable

Remove unneeded variable used to store return value.

thanks,
jirka

Quoted 28 lines
---
 tools/perf/util/evlist.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/perf/util/evlist.c +1 -2
index 5f92319ce258..d64fe767f583 100644
@@ -1300,7 +1300,6 @@ static int evlist__create_syswide_maps(struct evlist *evlist)
 {
 	struct perf_cpu_map *cpus;
 	struct perf_thread_map *threads;
-	int err = -ENOMEM;
 
 	/*
 	 * Try reading /sys/devices/system/cpu/online to get
@@ -1325,7 +1324,7 @@ static int evlist__create_syswide_maps(struct evlist *evlist)
 out_put:
 	perf_cpu_map__put(cpus);
 out:
-	return err;
+	return -ENOMEM;
 }
 
 int evlist__open(struct evlist *evlist)
Signature · 1 line
2.25.1