Skip to contentSkip to conversation

can: mcp251x: Get rid of duplicate of_node assignment

PATCH In review Andy Shevchenko 2 participants 8 messages Dec 2, 2021 – Jan 5, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 can: mcp251x: Get rid of duplicate of_node assignment

GPIO library does copy the of_node from the parent device of the GPIO chip, there is no need to repeat this in the individual drivers. Remove assignment here.

For the details one may look into the of_gpio_dev_init() implementation.

---
 drivers/net/can/spi/mcp251x.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/can/spi/mcp251x.c +0 -3
index 0579ab74f728..0cec808e8727 100644
@@ -600,9 +600,6 @@ static int mcp251x_gpio_setup(struct mcp251x_priv *priv)
 	gpio->ngpio = ARRAY_SIZE(mcp251x_gpio_names);
 	gpio->names = mcp251x_gpio_names;
 	gpio->can_sleep = true;
-#ifdef CONFIG_OF_GPIO
-	gpio->of_node = priv->spi->dev.of_node;
-#endif
 
 	return devm_gpiochip_add_data(&priv->spi->dev, gpio, priv);
 }
Signature · 1 line
2.33.0
#1 lore raw
Quoted 5 lines · Andy Shevchenko

GPIO library does copy the of_node from the parent device of the GPIO chip, there is no need to repeat this in the individual drivers. Remove assignment here.

For the details one may look into the of_gpio_dev_init() implementation.

Marc, what do you think about this change?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 8 lines · Andy Shevchenko
Quoted 5 lines · Andy Shevchenko

GPIO library does copy the of_node from the parent device of the GPIO chip, there is no need to repeat this in the individual drivers. Remove assignment here.

For the details one may look into the of_gpio_dev_init() implementation.

Marc, what do you think about this change?

LGTM, added to linux-can-next/testing.

regards,
Marc

Signature · 4 lines
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
#3 lore raw
Quoted 2 lines · Marc Kleine-Budde
Quoted 1 line · Andy Shevchenko

On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:

...

Quoted 3 lines
Quoted 1 line

Marc, what do you think about this change?

LGTM, added to linux-can-next/testing.

Thanks for applying this and hi311x patches!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 11 lines · Andy Shevchenko
Quoted 2 lines · Marc Kleine-Budde
Quoted 1 line · Andy Shevchenko

On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:

...

Quoted 3 lines
Quoted 1 line

Marc, what do you think about this change?

LGTM, added to linux-can-next/testing.

Thanks for applying this and hi311x patches!

Can we have a chance to see it in the v5.17-rc1?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Marc Kleine-Budde
Quoted 1 line · Andy Shevchenko

On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:

...

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Marc, what do you think about this change?

LGTM, added to linux-can-next/testing.

Thanks for applying this and hi311x patches!

Can we have a chance to see it in the v5.17-rc1?

Yes:
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.17-20220105

'about to send that PR.

regards,
Marc

Signature · 4 lines
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
#6 lore raw
Quoted 12 lines · Marc Kleine-Budde
Quoted 11 lines · Andy Shevchenko
Quoted 10 lines · Andy Shevchenko
Quoted 2 lines · Marc Kleine-Budde
Quoted 1 line · Andy Shevchenko

On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:

...

Quoted 3 lines
Quoted 1 line

Marc, what do you think about this change?

LGTM, added to linux-can-next/testing.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Thanks for applying this and hi311x patches!

Can we have a chance to see it in the v5.17-rc1?

Yes:
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.17-20220105

'about to send that PR.

Cool, thanks! Happy new year!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#7 lore raw
Quoted 8 lines · Andy Shevchenko
Quoted 6 lines
Quoted 1 line

Can we have a chance to see it in the v5.17-rc1?

Yes:
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.17-20220105

'about to send that PR.

Cool, thanks! Happy new year!

Thanks. Happy new year, too!

regards,
Marc

Signature · 4 lines
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |