dt-bindings: spi: cadence-quadspi: document "cdns,qspi-nor-ver-00-10"
Subsystems (3)
Dinh Nguyen
maintainerPATCH v2 1/3 dt-bindings: spi: cadence-quadspi: document "cdns,qspi-nor-ver-00-10"
The QSPI controller on Intel's SoCFPGA platform does not implement the CQSPI_REG_WR_COMPLETION_CTRL register, thus a write to this register results in a crash.
The module/revision ID is written in the MODULE_ID register. For this variance, bits 23-8 is 0x0010.
Introduce the dts binding "cdns,qspi-nor-ver-00-10" to differentiate the hardware.
---
v2: change binding to "cdns,qspi-nor-0010" to be more generic for other
platforms
--- Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml +1 -0
@@ -29,6 +29,7 @@ properties: - ti,am654-ospi - intel,lgm-qspi - xlnx,versal-ospi-1.0 + - cdns,qspi-nor-ver-00-10 - const: cdns,qspi-nor - const: cdns,qspi-nor
Signature · 1 line
2.25.1
Dinh Nguyen
maintainerPATCH 3/3 spi: cadence-quadspi: change socfpga-qspi to "cdns,qspi-nor-ver-00-10"
To make the "intel,socfpga-qspi" more generic, change the binding to "cdns,qspi-nor-ver-00-10". The "0010" represents the Module/Revision ID number that is in the MODULE_ID register.
--- drivers/spi/spi-cadence-quadspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/spi/spi-cadence-quadspi.c +3 -3
@@ -1869,7 +1869,7 @@ static const struct cqspi_driver_platdata intel_lgm_qspi = { .quirks = CQSPI_DISABLE_DAC_MODE, }; -static const struct cqspi_driver_platdata socfpga_qspi = { +static const struct cqspi_driver_platdata cdns_qspi_0010 = { .quirks =CQSPI_NO_SUPPORT_WR_COMPLETION , };
@@ -1902,8 +1902,8 @@ static const struct of_device_id cqspi_dt_ids[] = { .data = (void *)&versal_ospi, }, { - .compatible = "intel,socfpga-qspi", - .data = (void *)&socfpga_qspi, + .compatible = "cdns,qspi-nor-ver-00-10", + .data = (void *)&cdns_qspi_0010, }, {/* end of table */ } };
Signature · 1 line
2.25.1
Dinh Nguyen
maintainerPATCH v2 2/3 ARM: dts: socfpga: change qspi to "cdns,qspi-nor-ver-00-10"
In reply to Dinh NguyenBecause of commit 9cb2ff111712 ("spi: cadence-quadspi: Disable Auto-HW polling"), which does a write to the CQSPI_REG_WR_COMPLETION_CTRL register regardless of any condition. Well, the Cadence QuadSPI controller on Intel's SoCFPGA platforms does not implement the CQSPI_REG_WR_COMPLETION_CTRL register, thus a write to this register results in a crash!
So starting with v5.16, I introduced the patch98d948eb833 ("spi: cadence-quadspi: fix write completion support"), which adds the dts property "cdns,qspi-nor-ver-00-10" that is specific for versions that doesn't have the CQSPI_REG_WR_COMPLETION_CTRL register implemented.
---
v2: use both "cdns,qspi-nor" and "cdns,qspi-nor-0010"
--- arch/arm/boot/dts/socfpga.dtsi | 2 +- arch/arm/boot/dts/socfpga_arria10.dtsi | 2 +- arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 +- arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/socfpga.dtsi +1 -1
@@ -782,7 +782,7 @@ ocram: sram@ffff0000 { }; qspi: spi@ff705000 { - compatible = "cdns,qspi-nor"; + compatible = "cdns,qspi-nor-ver-00-10", "cdns,qspi-nor"; #address-cells = <1>; #size-cells = <0>; reg = <0xff705000 0x1000>,
arch/arm/boot/dts/socfpga_arria10.dtsi +1 -1
@@ -756,7 +756,7 @@ usb0-ecc@ff8c8800 { }; qspi: spi@ff809000 { - compatible = "cdns,qspi-nor"; + compatible = "cdns,qspi-nor-ver-00-10", "cdns,qspi-nor"; #address-cells = <1>; #size-cells = <0>; reg = <0xff809000 0x100>,
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +1 -1
@@ -594,7 +594,7 @@ emac0-tx-ecc@ff8c0400 { }; qspi: spi@ff8d2000 { - compatible = "cdns,qspi-nor"; + compatible = "cdns,qspi-nor-ver-00-10", "cdns,qspi-nor"; #address-cells = <1>; #size-cells = <0>; reg = <0xff8d2000 0x100>,
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi +1 -1
@@ -628,7 +628,7 @@ sdmmca-ecc@ff8c8c00 { }; qspi: spi@ff8d2000 { - compatible = "cdns,qspi-nor"; + compatible = "cdns,qspi-nor-ver-00-10", "cdns,qspi-nor"; #address-cells = <1>; #size-cells = <0>; reg = <0xff8d2000 0x100>,
Signature · 1 line
2.25.1
Mark Brown
maintainerQuoted 3 lines · Dinh Nguyen
The QSPI controller on Intel's SoCFPGA platform does not implement the
CQSPI_REG_WR_COMPLETION_CTRLregister, thus a write to this register results in a crash.
This is the third copy of this you've sent today with no differences I've spotted between them - what's the story here?
Dinh Nguyen
maintainerQuoted 8 lines · Mark Brown
Quoted 3 lines · Dinh Nguyen
The QSPI controller on Intel's SoCFPGA platform does not implement the
CQSPI_REG_WR_COMPLETION_CTRLregister, thus a write to this register results in a crash.This is the third copy of this you've sent today with no differences I've spotted between them - what's the story here?
Apologies, I didn't get a confirmation that the 1st 2 copies went through. Please ignore the 1st and 2nd copies.
Sorry for the noise!
Dinh
Quoted 6 lines · Dinh Nguyen
The QSPI controller on Intel's SoCFPGA platform does not implement the
CQSPI_REG_WR_COMPLETION_CTRLregister, thus a write to this register results in a crash.The module/revision ID is written in the
MODULE_IDregister. For this variance, bits 23-8 is0x0010.
When I looked at your original patches I was under the impression that this was a SoCFPGA specific thing and did not apply to other implementation of the IP in general.
If this is indeed a generic thing and we can detect it via the MODULE_ID register [0], then why not just read that register at probe time and apply this quirk based on the ID? Why then do we need a separate compatible at all?
[0] I would like to see it stated explicitly somewhere that version 0x0010 does not support the WR_COMPLETION_CTRL register.
Signature · 3 lines
Regards, Pratyush Yadav Texas Instruments Inc.
Quoted 13 lines · Pratyush Yadav
Quoted 6 lines · Dinh Nguyen
The QSPI controller on Intel's SoCFPGA platform does not implement the
CQSPI_REG_WR_COMPLETION_CTRLregister, thus a write to this register results in a crash.The module/revision ID is written in the
MODULE_IDregister. For this variance, bits 23-8 is0x0010.When I looked at your original patches I was under the impression that this was a SoCFPGA specific thing and did not apply to other implementation of the IP in general.
Quoted 8 lines
If this is indeed a generic thing and we can detect it via the
MODULE_IDregister [0], then why not just read that register at probe time and apply this quirk based on the ID? Why then do we need a separate compatible at all?[0] I would like to see it stated explicitly somewhere that version
0x0010does not support theWR_COMPLETION_CTRLregister.
I cannot for sure confirm that this condition applies to only 0x0010 version of the
IP. I can verify that the IP that is in all 3 generations of SoCFPGA devices, all haveMODULE_ID value of 0x0010 and all do not have the WR_COMPLETION_CTRL register implemented.
I'm almost certain this feature is not SoCFPGA specific, but
since I only had SoCFPGA hardware, that was my initial patch. I made the mistake of not CC'ing the devicetree maintainers until I sent the DTS binding patch change,
and he rightly suggested making the binding something more generic.
I do like your idea of making a determination in the driver without being dependent
on a dts binding. I'd like to know the impetus behind your original patch of removing the
dependency of "if (f_pdata->dtr)" for the write to the WR_COMPLETION_CTRL register? Perhaps there's some other common property that we can key off for why the register
is not implemented?
Dinh
Rob Herring
maintainerQuoted 23 lines · Dinh Nguyen
Quoted 13 lines · Pratyush Yadav
Quoted 6 lines · Dinh Nguyen
The QSPI controller on Intel's SoCFPGA platform does not implement the
CQSPI_REG_WR_COMPLETION_CTRLregister, thus a write to this register results in a crash.The module/revision ID is written in the
MODULE_IDregister. For this variance, bits 23-8 is0x0010.When I looked at your original patches I was under the impression that this was a SoCFPGA specific thing and did not apply to other implementation of the IP in general.
Quoted 8 lines
If this is indeed a generic thing and we can detect it via the
MODULE_IDregister [0], then why not just read that register at probe time and apply this quirk based on the ID? Why then do we need a separate compatible at all?[0] I would like to see it stated explicitly somewhere that version
0x0010does not support theWR_COMPLETION_CTRLregister.
Quoted 6 lines
I cannot for sure confirm that this condition applies to only
0x0010version of the
IP. I can verify that the IP that is in all 3 generations of SoCFPGA devices, all haveMODULE_IDvalue of0x0010and all do not have theWR_COMPLETION_CTRLregister implemented.
Then for the same reason, you shouldn't be trying to have a 'generic' compatible.
Quoted 6 lines
I'm almost certain this feature is not SoCFPGA specific, but
since I only had SoCFPGA hardware, that was my initial patch. I made the mistake of not CC'ing the devicetree maintainers until I sent the DTS binding patch change,
and he rightly suggested making the binding something more generic.
That is completely the opposite of what I said. You had something genericish to Intel platforms. You should make the compatible(s) SoC specific.
Quoted 11 lines
I do like your idea of making a determination in the driver without being dependent
on a dts binding. I'd like to know the impetus behind your original patch of removing the
dependency of "if (f_pdata->dtr)" for the write to theWR_COMPLETION_CTRLregister? Perhaps there's some other common property that we can key off for why the register
is not implemented?Dinh
Quoted 42 lines · Rob Herring
Quoted 23 lines · Dinh Nguyen
Quoted 13 lines · Pratyush Yadav
Quoted 6 lines · Dinh Nguyen
The QSPI controller on Intel's SoCFPGA platform does not implement the
CQSPI_REG_WR_COMPLETION_CTRLregister, thus a write to this register results in a crash.The module/revision ID is written in the
MODULE_IDregister. For this variance, bits 23-8 is0x0010.When I looked at your original patches I was under the impression that this was a SoCFPGA specific thing and did not apply to other implementation of the IP in general.
Quoted 8 lines
If this is indeed a generic thing and we can detect it via the
MODULE_IDregister [0], then why not just read that register at probe time and apply this quirk based on the ID? Why then do we need a separate compatible at all?[0] I would like to see it stated explicitly somewhere that version
0x0010does not support theWR_COMPLETION_CTRLregister.Quoted 6 lines
I cannot for sure confirm that this condition applies to only
0x0010version of the
IP. I can verify that the IP that is in all 3 generations of SoCFPGA devices, all haveMODULE_IDvalue of0x0010and all do not have theWR_COMPLETION_CTRLregister implemented.Then for the same reason, you shouldn't be trying to have a 'generic' compatible.
Quoted 6 lines
I'm almost certain this feature is not SoCFPGA specific, but
since I only had SoCFPGA hardware, that was my initial patch. I made the mistake of not CC'ing the devicetree maintainers until I sent the DTS binding patch change,
and he rightly suggested making the binding something more generic.
Quoted 5 lines
That is completely the opposite of what I said. You had something genericish to Intel platforms. You should make the compatible(s) SoC specific.
Sorry, I must have misunderstood. The same QSPI controller is used across the entire SoCFPGA class of SoCs, so I don't know what you mean by SoC specific?
Dinh
Quoted 23 lines · Dinh Nguyen
Quoted 13 lines · Pratyush Yadav
Quoted 6 lines · Dinh Nguyen
The QSPI controller on Intel's SoCFPGA platform does not implement the
CQSPI_REG_WR_COMPLETION_CTRLregister, thus a write to this register results in a crash.The module/revision ID is written in the
MODULE_IDregister. For this variance, bits 23-8 is0x0010.When I looked at your original patches I was under the impression that this was a SoCFPGA specific thing and did not apply to other implementation of the IP in general.
Quoted 8 lines
If this is indeed a generic thing and we can detect it via the
MODULE_IDregister [0], then why not just read that register at probe time and apply this quirk based on the ID? Why then do we need a separate compatible at all?[0] I would like to see it stated explicitly somewhere that version
0x0010does not support theWR_COMPLETION_CTRLregister.
Quoted 6 lines
I cannot for sure confirm that this condition applies to only
0x0010version of the
IP. I can verify that the IP that is in all 3 generations of SoCFPGA devices, all haveMODULE_IDvalue of0x0010and all do not have theWR_COMPLETION_CTRLregister implemented.
I agree with Rob here. If you are not sure that this is a generic IP thing then you should not use a generic compatible.
Quoted 7 lines
I'm almost certain this feature is not SoCFPGA specific, but
since I only had SoCFPGA hardware, that was my initial patch. I made the mistake of not CC'ing the devicetree maintainers until I sent the DTS binding patch change,
and he rightly suggested making the binding something more generic.
Quoted 8 lines
I do like your idea of making a determination in the driver without being dependent
on a dts binding. I'd like to know the impetus behind your original patch of removing the
dependency of "if (f_pdata->dtr)" for the write to theWR_COMPLETION_CTRLregister? Perhaps there's some other common property that we can key off for why the register
is not implemented?
Please read the comment just above that line ;-)
/*
* SPI NAND flashes require the address of the status register to be
* passed in the Read SR command. Also, some SPI NOR flashes like the
* cypress Semper flash expect a 4-byte dummy address in the Read SR
* command in DTR mode.
*
* But this controller does not support address phase in the Read SR
* command when doing auto-HW polling. So, disable write completion
* polling on the controller's side. spinand and spi-nor will take
* care of polling the status register.
*/
Signature · 3 lines
Regards, Pratyush Yadav Texas Instruments Inc.
Dinh Nguyen
maintainerQuoted 31 lines · Pratyush Yadav
Quoted 23 lines · Dinh Nguyen
Quoted 13 lines · Pratyush Yadav
Quoted 6 lines · Dinh Nguyen
The QSPI controller on Intel's SoCFPGA platform does not implement the
CQSPI_REG_WR_COMPLETION_CTRLregister, thus a write to this register results in a crash.The module/revision ID is written in the
MODULE_IDregister. For this variance, bits 23-8 is0x0010.When I looked at your original patches I was under the impression that this was a SoCFPGA specific thing and did not apply to other implementation of the IP in general.
Quoted 8 lines
If this is indeed a generic thing and we can detect it via the
MODULE_IDregister [0], then why not just read that register at probe time and apply this quirk based on the ID? Why then do we need a separate compatible at all?[0] I would like to see it stated explicitly somewhere that version
0x0010does not support theWR_COMPLETION_CTRLregister.Quoted 6 lines
I cannot for sure confirm that this condition applies to only
0x0010version of the
IP. I can verify that the IP that is in all 3 generations of SoCFPGA devices, all haveMODULE_IDvalue of0x0010and all do not have theWR_COMPLETION_CTRLregister implemented.
Quoted 3 lines
I agree with Rob here. If you are not sure that this is a generic IP thing then you should not use a generic compatible.
I think using the binding of "intel,socfpga-qspi" should be fine? If we go by the MODULE_ID value as a indicator of versions, then the version hasn't changed for all revisions of the SoCFPGA, dating back to the original Cyclone5, which was introduced in 2012.
Thanks,
Dinh
Quoted 39 lines · Dinh Nguyen
Quoted 31 lines · Pratyush Yadav
Quoted 23 lines · Dinh Nguyen
Quoted 13 lines · Pratyush Yadav
Quoted 6 lines · Dinh Nguyen
The QSPI controller on Intel's SoCFPGA platform does not implement the
CQSPI_REG_WR_COMPLETION_CTRLregister, thus a write to this register results in a crash.The module/revision ID is written in the
MODULE_IDregister. For this variance, bits 23-8 is0x0010.When I looked at your original patches I was under the impression that this was a SoCFPGA specific thing and did not apply to other implementation of the IP in general.
Quoted 8 lines
If this is indeed a generic thing and we can detect it via the
MODULE_IDregister [0], then why not just read that register at probe time and apply this quirk based on the ID? Why then do we need a separate compatible at all?[0] I would like to see it stated explicitly somewhere that version
0x0010does not support theWR_COMPLETION_CTRLregister.Quoted 6 lines
I cannot for sure confirm that this condition applies to only
0x0010version of the
IP. I can verify that the IP that is in all 3 generations of SoCFPGA devices, all haveMODULE_IDvalue of0x0010and all do not have theWR_COMPLETION_CTRLregister implemented.Quoted 3 lines
I agree with Rob here. If you are not sure that this is a generic IP thing then you should not use a generic compatible.
Quoted 4 lines
I think using the binding of "intel,socfpga-qspi" should be fine? If we go by the
MODULE_IDvalue as a indicator of versions, then the version hasn't changed for all revisions of the SoCFPGA, dating back to the original Cyclone5, which was introduced in 2012.
Yes, I think you should keep using the SoC specific binding unless you can find some documentation from Cadence that says all parts with this MODULE_ID value don't have the WR_COMPLETION_CTRL register.
Signature · 3 lines
Regards, Pratyush Yadav Texas Instruments Inc.