arm64: fdt: fix membock add/cap ordering
Subsystems (2)
v2 cover arm64: fdt: fix membock add/cap ordering
In fact, V2 tackles this issue at efi_init() for both arm64 and risc-v.
Since in Zhen Lei's series "[PATCH v17 00/10] support reserving crashkernel above 4G on arm64 kdump", [8/10] is self-standing and meaningful. I abstract and utilize it.
I make a small change in it in order to use early_init_dt_check_for_usable_mem_range() outside of/fdt. (Cc: Zhen, please let me know if it is not fine for you.)
So finally these two patches can be applied as candidates for
[1]: https://lore.kernel.org/all/[email protected]/
v1 -> v2:
Adopt Rob's suggestion to callearly_init_dt_check_for_usable_mem_range() from efi_init()
Cc: Rob Herring <[email protected]>
Cc: Zhen Lei <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Mike Rapoport <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Frank Rowand <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Nick Terrell <[email protected]>
Cc: [email protected]
To: [email protected]
To: [email protected]
Pingfan Liu (1):
efi: apply memblock cap after memblock_add()
Zhen Lei (1):
of: fdt: Aggregate the processing of "linux,usable-memory-range"
drivers/firmware/efi/efi-init.c | 7 +++++++ drivers/of/fdt.c | 18 +++++++++++++----- include/linux/of_fdt.h | 1 + 3 files changed, 21 insertions(+), 5 deletions(-)
Signature · 1 line
2.31.1
PATCH v2 1/2 of: fdt: Aggregate the processing of "linux, usable-memory-range"
From: Zhen Lei <[email protected]>
Currently, we parse the "linux,usable-memory-range" property in early_init_dt_scan_chosen(), to obtain the specified memory range of the crash kernel. We then reserve the required memory after early_init_dt_scan_memory() has identified all available physical memory. Because the two pieces of code are separated far, the readability and maintainability are reduced. So bring them together.
(change the prototype of early_init_dt_check_for_usable_mem_range(), in order to use it outside)
To: [email protected]
To: [email protected]
---
I keep the Signed-off-by, Tested-by, Acked-by and Reviewed-by, since I think that the prototype change is not significant. early_init_dt_check_for_usable_mem_range() only handle chosen node, and it is fine to isolate this info inside the function itself so later easier to be used outside.
Sorry if you disagree, please let me know.
drivers/of/fdt.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)
drivers/of/fdt.c +13 -5
@@ -965,18 +965,23 @@ static void __init early_init_dt_check_for_elfcorehdr(unsigned long node) elfcorehdr_addr, elfcorehdr_size); } -static phys_addr_t cap_mem_addr; -static phys_addr_t cap_mem_size; +static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND ;/** * early_init_dt_check_for_usable_mem_range - Decode usable memory range * location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (unsigned long node) +static void __init early_init_dt_check_for_usable_mem_range (void ) {const __be32 *prop;int len; +phys_addr_t cap_mem_addr; +phys_addr_t cap_mem_size; +unsigned long node = chosen_node_offset; + +if ((long )node <0 ) +return ;pr_debug ("Looking for usable-memory-range property... " );
@@ -989,6 +994,8 @@ static void __init early_init_dt_check_for_usable_mem_range(unsigned long node)pr_debug ("cap_mem_start=%pa cap_mem_size=%pa\n" , &cap_mem_addr, &cap_mem_size); + +memblock_cap_memory_range (cap_mem_addr, cap_mem_size); }#ifdef CONFIG_SERIAL_EARLYCON
@@ -1137,9 +1144,10 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname, (strcmp(uname, "chosen") != 0 && strcmp(uname, "chosen@0") != 0))return 0 ; + chosen_node_offset = node; +early_init_dt_check_for_initrd (node);early_init_dt_check_for_elfcorehdr (node); -early_init_dt_check_for_usable_mem_range (node);/* Retrieve command line */ p =of_get_flat_dt_prop (node,"bootargs" , &l);
@@ -1275,7 +1283,7 @@ void __init early_init_dt_scan_nodes(void)of_scan_flat_dt (early_init_dt_scan_memory,NULL );/* Handle linux,usable-memory-range property */ -memblock_cap_memory_range (cap_mem_addr, cap_mem_size); +early_init_dt_check_for_usable_mem_range (); }bool __init early_init_dt_scan (void *params)
Signature · 1 line
2.31.1
PATCH v2 2/2 efi: apply memblock cap after memblock_add()
In reply to Pingfan LiuOn arm64, during kdump kernel saves vmcore, it runs into the following bug:
...
[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34
...
This bug introduced by commit b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling"), which moves memblock_cap_memory_range() to fdt, but it breaches the rules that memblock_cap_memory_range() should come after memblock_add() etc as said in commit e888fa7bb882 ("memblock: Check memory add/cap ordering").
As a consequence, the virtual address set up by copy_oldmem_page() does not bail out from the test of virt_addr_valid() in check_heap_object(), and finally hits the BUG_ON().
Since memblock allocator has no idea about when the memblock is fully populated, while efi_init() is aware, so tackling this issue by calling the interface early_init_dt_check_for_usable_mem_range() exposed by of/fdt.
To: [email protected]
To: [email protected]
--- drivers/firmware/efi/efi-init.c | 7 +++++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 1 + 3 files changed, 9 insertions(+), 1 deletion(-)
drivers/firmware/efi/efi-init.c +7 -0
@@ -235,6 +235,13 @@ void __init efi_init(void) }reserve_regions (); +#ifdef CONFIG_OF_FLATTREE +/* +* For memblock manipulation, the cap should come after the memblock_add(). +* And now, memblock is fully populated, it is time to do capping. +*/ +early_init_dt_check_for_usable_mem_range (); +#endif efi_esrt_init ();efi_mokvar_table_init ();
drivers/of/fdt.c +1 -1
@@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;* location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (void ) +void __init early_init_dt_check_for_usable_mem_range (void ) {const __be32 *prop;int len;
include/linux/of_fdt.h +1 -0
@@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, int depth, void *data);extern int early_init_dt_scan_memory (unsigned long node,const char *uname,int depth,void *data); +extern void early_init_dt_check_for_usable_mem_range (void );extern int early_init_dt_scan_chosen_stdout (void );extern void early_init_fdt_scan_reserved_mem (void );extern void early_init_fdt_reserve_self (void );
Signature · 1 line
2.31.1
Re: [PATCHv2 2/2] efi: apply memblock cap after memblock_add()
Quoted 79 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").As a consequence, the virtual address set up by
copy_oldmem_page()does not bail out from the test ofvirt_addr_valid()incheck_heap_object(), and finally hits theBUG_ON().Since memblock allocator has no idea about when the memblock is fully populated, while
efi_init()is aware, so tackling this issue by calling the interfaceearly_init_dt_check_for_usable_mem_range()exposed by of/fdt.Fixes b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling")Signed-off-by Pingfan Liu <[email protected]>Cc Rob Herring <[email protected]>Cc Zhen Lei <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Andrew Morton <[email protected]>Cc Mike Rapoport <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Frank Rowand <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Nick Terrell <[email protected]>To: [email protected]
To: [email protected]--- drivers/firmware/efi/efi-init.c | 7 +++++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 1 + 3 files changed, 9 insertions(+), 1 deletion(-)drivers/firmware/efi/efi-init.c +0
-0
drivers/firmware/efi/efi-init.c void __init efi_init(void) · line 238
Quoted 4 lines
drivers/firmware/efi/efi-init.c +1
-0@@ -235,6 +235,13 @@ void __init efi_init(void) }reserve_regions (); +#ifdef CONFIG_OF_FLATTREE
Add a static inline stub to avoid this ifdef.
Quoted 37 lines
drivers/firmware/efi/efi-init.c +6
-0+/* +* For memblock manipulation, the cap should come after the memblock_add(). +* And now, memblock is fully populated, it is time to do capping. +*/ +early_init_dt_check_for_usable_mem_range (); +#endif efi_esrt_init ();efi_mokvar_table_init ();drivers/of/fdt.c +1
-1@@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;* location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (void ) +void __init early_init_dt_check_for_usable_mem_range (void ) {const __be32 *prop;int len;include/linux/of_fdt.h +1
-1@@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, int depth, void *data);extern int early_init_dt_scan_memory (unsigned long node,const char *uname,int depth,void *data); +extern void early_init_dt_check_for_usable_mem_range (void );extern int early_init_dt_scan_chosen_stdout (void );extern void early_init_fdt_scan_reserved_mem (void );extern void early_init_fdt_reserve_self (void ); --2.31.1
Re: [PATCHv2 2/2] efi: apply memblock cap after memblock_add()
Quoted 82 lines · Rob Herring
Quoted 81 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").As a consequence, the virtual address set up by
copy_oldmem_page()does not bail out from the test ofvirt_addr_valid()incheck_heap_object(), and finally hits theBUG_ON().Since memblock allocator has no idea about when the memblock is fully populated, while
efi_init()is aware, so tackling this issue by calling the interfaceearly_init_dt_check_for_usable_mem_range()exposed by of/fdt.Fixes b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling")Signed-off-by Pingfan Liu <[email protected]>Cc Rob Herring <[email protected]>Cc Zhen Lei <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Andrew Morton <[email protected]>Cc Mike Rapoport <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Frank Rowand <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Nick Terrell <[email protected]>To: [email protected]
To: [email protected]--- drivers/firmware/efi/efi-init.c | 7 +++++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 1 + 3 files changed, 9 insertions(+), 1 deletion(-)drivers/firmware/efi/efi-init.c +0
-0@@ -235,6 +235,13 @@ void __init efi_init(void) }
Quoted 5 lines
drivers/firmware/efi/efi-init.c void __init efi_init(void) · line 238
Quoted 2 lines
drivers/firmware/efi/efi-init.c +1
-0reserve_regions (); +#ifdef CONFIG_OF_FLATTREE Add a static inline stub to avoid this ifdef.
Thanks for the suggestion.
I will follow up with V3 to this patch.
Regards,
Pingfan
Quoted 42 lines
Quoted 35 lines
drivers/firmware/efi/efi-init.c +6
-0+/* +* For memblock manipulation, the cap should come after the memblock_add(). +* And now, memblock is fully populated, it is time to do capping. +*/ +early_init_dt_check_for_usable_mem_range (); +#endif efi_esrt_init ();efi_mokvar_table_init ();drivers/of/fdt.c +1
-1@@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;* location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (void ) +void __init early_init_dt_check_for_usable_mem_range (void ) {const __be32 *prop;int len;include/linux/of_fdt.h +1
-1@@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, int depth, void *data);extern int early_init_dt_scan_memory (unsigned long node,const char *uname,int depth,void *data); +extern void early_init_dt_check_for_usable_mem_range (void );extern int early_init_dt_scan_chosen_stdout (void );extern void early_init_fdt_scan_reserved_mem (void );extern void early_init_fdt_reserve_self (void ); --Quoted 2 lines
2.31.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v3 1/1 efi: apply memblock cap after memblock_add()
In reply to Pingfan LiuOn arm64, during kdump kernel saves vmcore, it runs into the following bug:
...
[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34
...
This bug introduced by commit b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling"), which moves memblock_cap_memory_range() to fdt, but it breaches the rules that memblock_cap_memory_range() should come after memblock_add() etc as said in commit e888fa7bb882 ("memblock: Check memory add/cap ordering").
As a consequence, the virtual address set up by copy_oldmem_page() does not bail out from the test of virt_addr_valid() in check_heap_object(), and finally hits the BUG_ON().
Since memblock allocator has no idea about when the memblock is fully populated, while efi_init() is aware, so tackling this issue by calling the interface early_init_dt_check_for_usable_mem_range() exposed by of/fdt.
To: [email protected]
To: [email protected]
---
v2 -> v3:
use static inline stub to avoid #ifdef according to Rob's suggestion
drivers/firmware/efi/efi-init.c | 5 +++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-)
drivers/firmware/efi/efi-init.c +5 -0
@@ -235,6 +235,11 @@ void __init efi_init(void) }reserve_regions (); +/* +* For memblock manipulation, the cap should come after the memblock_add(). +* And now, memblock is fully populated, it is time to do capping. +*/ +early_init_dt_check_for_usable_mem_range ();efi_esrt_init ();efi_mokvar_table_init ();
drivers/of/fdt.c +1 -1
@@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;* location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (void ) +void __init early_init_dt_check_for_usable_mem_range (void ) {const __be32 *prop;int len;
include/linux/of_fdt.h +2 -0
@@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, int depth, void *data);extern int early_init_dt_scan_memory (unsigned long node,const char *uname,int depth,void *data); +extern void early_init_dt_check_for_usable_mem_range (void );extern int early_init_dt_scan_chosen_stdout (void );extern void early_init_fdt_scan_reserved_mem (void );extern void early_init_fdt_reserve_self (void );
@@ -86,6 +87,7 @@ extern void unflatten_and_copy_device_tree(void);extern void early_init_devtree (void *);extern void early_get_first_memblock_info (void *,phys_addr_t *);#else /* CONFIG_OF_EARLY_FLATTREE */ +static inline void early_init_dt_check_for_usable_mem_range (void ) {}static inline int early_init_dt_scan_chosen_stdout (void ) {return -ENODEV ; }static inline void early_init_fdt_scan_reserved_mem (void ) {}static inline void early_init_fdt_reserve_self (void ) {}
Signature · 1 line
2.31.1
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
Quoted 36 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34
Quoted 7 lines
...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").
void __init early_init_dt_scan_nodes(void)
{
//(1) -->early_init_dt_check_for_usable_mem_range, fill cap_mem_addr
rc = of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);
//(2) --> early_init_dt_add_memory_arch --> memblock_add()
of_scan_flat_dt(early_init_dt_scan_memory, NULL);
//(3)
memblock_cap_memory_range(cap_mem_addr, cap_mem_size);
}I didn't get it. The above step (1),(2),(3) comply with commit e888fa7bb882 ("memblock: Check memory add/cap ordering")
Did you see the warning?pr_warn("%s: No memory registered yet\n", __func__);
Quoted 83 lines
As a consequence, the virtual address set up by
copy_oldmem_page()does not bail out from the test ofvirt_addr_valid()incheck_heap_object(), and finally hits theBUG_ON().Since memblock allocator has no idea about when the memblock is fully populated, while
efi_init()is aware, so tackling this issue by calling the interfaceearly_init_dt_check_for_usable_mem_range()exposed by of/fdt.Fixes b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling")Signed-off-by Pingfan Liu <[email protected]>Cc Rob Herring <[email protected]>Cc Zhen Lei <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Andrew Morton <[email protected]>Cc Mike Rapoport <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Frank Rowand <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Nick Terrell <[email protected]>To: [email protected]
To: [email protected]
---
v2 -> v3:
use static inline stub to avoid #ifdef according to Rob's suggestiondrivers/firmware/efi/efi-init.c | 5 +++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-)drivers/firmware/efi/efi-init.c +5
-0@@ -235,6 +235,11 @@ void __init efi_init(void) }reserve_regions (); +/* +* For memblock manipulation, the cap should come after the memblock_add(). +* And now, memblock is fully populated, it is time to do capping. +*/ +early_init_dt_check_for_usable_mem_range ();efi_esrt_init ();efi_mokvar_table_init ();drivers/of/fdt.c +1
-1@@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;* location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (void ) +void __init early_init_dt_check_for_usable_mem_range (void ) {const __be32 *prop;int len;include/linux/of_fdt.h +2
-0@@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, int depth, void *data);extern int early_init_dt_scan_memory (unsigned long node,const char *uname,int depth,void *data); +extern void early_init_dt_check_for_usable_mem_range (void );extern int early_init_dt_scan_chosen_stdout (void );extern void early_init_fdt_scan_reserved_mem (void );extern void early_init_fdt_reserve_self (void );@@ -86,6 +87,7 @@ extern void unflatten_and_copy_device_tree(void);extern void early_init_devtree (void *);extern void early_get_first_memblock_info (void *,phys_addr_t *);#else /* CONFIG_OF_EARLY_FLATTREE */ +static inline void early_init_dt_check_for_usable_mem_range (void ) {}static inline int early_init_dt_scan_chosen_stdout (void ) {return -ENODEV ; }static inline void early_init_fdt_scan_reserved_mem (void ) {}static inline void early_init_fdt_reserve_self (void ) {}
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
Quoted 59 lines · Leizhen (ThunderTown)
Quoted 36 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34Quoted 7 lines
...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").void
__initearly_init_dt_scan_nodes(void){ //(1) -->early_init_dt_check_for_usable_mem_range, fill cap_mem_addr rc = of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line); //(2) --> early_init_dt_add_memory_arch --> memblock_add() of_scan_flat_dt(early_init_dt_scan_memory, NULL); //(3) memblock_cap_memory_range(cap_mem_addr, cap_mem_size); }
Quoted 3 lines
I didn't get it. The above step (1),(2),(3) comply with commit
e888fa7bb882("memblock: Check memory add/cap ordering")
Well, at this scope, it does. But from a larger scope, let's say on arm64,setup_arch
...
setup_machine_fdt(); //which holds your case
...
efi_init(); //which call memblock_add, and breach the ordering.
Quoted 3 lines
Did you see the warning?
pr_warn("%s: No memory registered yet\n", __func__);
Yes, I did see this message, which brings me to commit e888fa7bb882 ("memblock: Check memory add/cap ordering")
I am also curious why this bug does not be discovered. Is CONFIG_EFI on at your case?
Thanks,
Pingfan
Quoted 88 lines
Quoted 76 lines
As a consequence, the virtual address set up by
copy_oldmem_page()does not bail out from the test ofvirt_addr_valid()incheck_heap_object(), and finally hits theBUG_ON().Since memblock allocator has no idea about when the memblock is fully populated, while
efi_init()is aware, so tackling this issue by calling the interfaceearly_init_dt_check_for_usable_mem_range()exposed by of/fdt.Fixes b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling")Signed-off-by Pingfan Liu <[email protected]>Cc Rob Herring <[email protected]>Cc Zhen Lei <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Andrew Morton <[email protected]>Cc Mike Rapoport <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Frank Rowand <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Nick Terrell <[email protected]>To: [email protected]
To: [email protected]
---
v2 -> v3:
use static inline stub to avoid #ifdef according to Rob's suggestiondrivers/firmware/efi/efi-init.c | 5 +++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-)drivers/firmware/efi/efi-init.c +5
-0@@ -235,6 +235,11 @@ void __init efi_init(void) }reserve_regions (); +/* +* For memblock manipulation, the cap should come after the memblock_add(). +* And now, memblock is fully populated, it is time to do capping. +*/ +early_init_dt_check_for_usable_mem_range ();efi_esrt_init ();efi_mokvar_table_init ();drivers/of/fdt.c +1
-1@@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;* location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (void ) +void __init early_init_dt_check_for_usable_mem_range (void ) {const __be32 *prop;int len;include/linux/of_fdt.h +1
-0@@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, int depth, void *data);extern int early_init_dt_scan_memory (unsigned long node,const char *uname,int depth,void *data); +extern void early_init_dt_check_for_usable_mem_range (void );extern int early_init_dt_scan_chosen_stdout (void );extern void early_init_fdt_scan_reserved_mem (void );extern void early_init_fdt_reserve_self (void );include/linux/of_fdt.h extern void unflatten_and_copy_device_tree(void); · line 93
Quoted 7 lines
include/linux/of_fdt.h +1
-0@@ -86,6 +87,7 @@ extern void unflatten_and_copy_device_tree(void);extern void early_init_devtree (void *);extern void early_get_first_memblock_info (void *,phys_addr_t *);#else /* CONFIG_OF_EARLY_FLATTREE */ +static inline void early_init_dt_check_for_usable_mem_range (void ) {}static inline int early_init_dt_scan_chosen_stdout (void ) {return -ENODEV ; }static inline void early_init_fdt_scan_reserved_mem (void ) {}static inline void early_init_fdt_reserve_self (void ) {}_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
Quoted 71 lines · Pingfan Liu
Quoted 59 lines · Leizhen (ThunderTown)
Quoted 36 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34Quoted 7 lines
...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").void
__initearly_init_dt_scan_nodes(void){ //(1) -->early_init_dt_check_for_usable_mem_range, fill cap_mem_addr rc = of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line); //(2) --> early_init_dt_add_memory_arch --> memblock_add() of_scan_flat_dt(early_init_dt_scan_memory, NULL); //(3) memblock_cap_memory_range(cap_mem_addr, cap_mem_size); }Quoted 3 lines
I didn't get it. The above step (1),(2),(3) comply with commit
e888fa7bb882("memblock: Check memory add/cap ordering")Well, at this scope, it does. But from a larger scope, let's say on arm64,
setup_arch
...
setup_machine_fdt(); //which holds your case
...
efi_init(); //which callmemblock_add, and breach the ordering.
Quoted 8 lines
Quoted 3 lines
Did you see the warning?
pr_warn("%s: No memory registered yet\n", __func__);Yes, I did see this message, which brings me to commit
e888fa7bb882("memblock: Check memory add/cap ordering")I am also curious why this bug does not be discovered. Is
CONFIG_EFIon at your case?
Yes, Both X86 and ARM64, CONFIG_EFI=y. I used the defconfig.
Quoted 94 lines
Thanks,
Pingfan
Quoted 80 lines
Quoted 80 lines
As a consequence, the virtual address set up by
copy_oldmem_page()does not bail out from the test ofvirt_addr_valid()incheck_heap_object(), and finally hits theBUG_ON().Since memblock allocator has no idea about when the memblock is fully populated, while
efi_init()is aware, so tackling this issue by calling the interfaceearly_init_dt_check_for_usable_mem_range()exposed by of/fdt.Fixes b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling")Signed-off-by Pingfan Liu <[email protected]>Cc Rob Herring <[email protected]>Cc Zhen Lei <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Andrew Morton <[email protected]>Cc Mike Rapoport <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Frank Rowand <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Nick Terrell <[email protected]>To: [email protected]
To: [email protected]
---
v2 -> v3:
use static inline stub to avoid #ifdef according to Rob's suggestiondrivers/firmware/efi/efi-init.c | 5 +++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-)drivers/firmware/efi/efi-init.c +5
-0@@ -235,6 +235,11 @@ void __init efi_init(void) }reserve_regions (); +/* +* For memblock manipulation, the cap should come after the memblock_add(). +* And now, memblock is fully populated, it is time to do capping. +*/ +early_init_dt_check_for_usable_mem_range ();efi_esrt_init ();efi_mokvar_table_init ();drivers/of/fdt.c +1
-1@@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;* location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (void ) +void __init early_init_dt_check_for_usable_mem_range (void ) {const __be32 *prop;int len;include/linux/of_fdt.h +2
-0@@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, int depth, void *data);extern int early_init_dt_scan_memory (unsigned long node,const char *uname,int depth,void *data); +extern void early_init_dt_check_for_usable_mem_range (void );extern int early_init_dt_scan_chosen_stdout (void );extern void early_init_fdt_scan_reserved_mem (void );extern void early_init_fdt_reserve_self (void );@@ -86,6 +87,7 @@ extern void unflatten_and_copy_device_tree(void);extern void early_init_devtree (void *);extern void early_get_first_memblock_info (void *,phys_addr_t *);#else /* CONFIG_OF_EARLY_FLATTREE */ +static inline void early_init_dt_check_for_usable_mem_range (void ) {}static inline int early_init_dt_scan_chosen_stdout (void ) {return -ENODEV ; }Quoted 8 lines
include/linux/of_fdt.h extern void unflatten_and_copy_device_tree(void); · line 93
Quoted 3 lines
include/linux/of_fdt.h +0
-0static inline void early_init_fdt_scan_reserved_mem (void ) {}static inline void early_init_fdt_reserve_self (void ) {}_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel.
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
Quoted 77 lines · Leizhen (ThunderTown)
Quoted 74 lines · Pingfan Liu
Quoted 59 lines · Leizhen (ThunderTown)
Quoted 36 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34Quoted 7 lines
...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").void
__initearly_init_dt_scan_nodes(void){ //(1) -->early_init_dt_check_for_usable_mem_range, fill cap_mem_addr rc = of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line); //(2) --> early_init_dt_add_memory_arch --> memblock_add() of_scan_flat_dt(early_init_dt_scan_memory, NULL); //(3) memblock_cap_memory_range(cap_mem_addr, cap_mem_size); }Quoted 3 lines
I didn't get it. The above step (1),(2),(3) comply with commit
e888fa7bb882("memblock: Check memory add/cap ordering")Well, at this scope, it does. But from a larger scope, let's say on arm64,
setup_arch
...
setup_machine_fdt(); //which holds your case
...
efi_init(); //which callmemblock_add, and breach the ordering.Quoted 3 lines
Did you see the warning?
pr_warn("%s: No memory registered yet\n", __func__);
Quoted 8 lines
Quoted 5 lines
Yes, I did see this message, which brings me to commit
e888fa7bb882("memblock: Check memory add/cap ordering")I am also curious why this bug does not be discovered. Is
CONFIG_EFIon at your case?Yes, Both X86 and ARM64,
CONFIG_EFI=y. I used the defconfig.
Maybe due to different md?
Because efi_init()->reserve_regions()->early_init_dt_add_memory_arch()->memblock_add() on arm64, if is_memory(md). This is the path breaching the rule during my test.
Thanks
Pingfan
Quoted 99 lines
Quoted 92 lines
Thanks,
Pingfan
Quoted 80 lines
Quoted 80 lines
As a consequence, the virtual address set up by
copy_oldmem_page()does not bail out from the test ofvirt_addr_valid()incheck_heap_object(), and finally hits theBUG_ON().Since memblock allocator has no idea about when the memblock is fully populated, while
efi_init()is aware, so tackling this issue by calling the interfaceearly_init_dt_check_for_usable_mem_range()exposed by of/fdt.Fixes b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling")Signed-off-by Pingfan Liu <[email protected]>Cc Rob Herring <[email protected]>Cc Zhen Lei <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Andrew Morton <[email protected]>Cc Mike Rapoport <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Frank Rowand <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Nick Terrell <[email protected]>To: [email protected]
To: [email protected]
---
v2 -> v3:
use static inline stub to avoid #ifdef according to Rob's suggestiondrivers/firmware/efi/efi-init.c | 5 +++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-)drivers/firmware/efi/efi-init.c +5
-0@@ -235,6 +235,11 @@ void __init efi_init(void) }reserve_regions (); +/* +* For memblock manipulation, the cap should come after the memblock_add(). +* And now, memblock is fully populated, it is time to do capping. +*/ +early_init_dt_check_for_usable_mem_range ();efi_esrt_init ();efi_mokvar_table_init ();drivers/of/fdt.c +1
-1@@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;* location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (void ) +void __init early_init_dt_check_for_usable_mem_range (void ) {const __be32 *prop;int len;include/linux/of_fdt.h +2
-0@@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, int depth, void *data);extern int early_init_dt_scan_memory (unsigned long node,const char *uname,int depth,void *data); +extern void early_init_dt_check_for_usable_mem_range (void );extern int early_init_dt_scan_chosen_stdout (void );extern void early_init_fdt_scan_reserved_mem (void );extern void early_init_fdt_reserve_self (void );@@ -86,6 +87,7 @@ extern void unflatten_and_copy_device_tree(void);extern void early_init_devtree (void *);extern void early_get_first_memblock_info (void *,phys_addr_t *);#else /* CONFIG_OF_EARLY_FLATTREE */ +static inline void early_init_dt_check_for_usable_mem_range (void ) {}static inline int early_init_dt_scan_chosen_stdout (void ) {return -ENODEV ; }Quoted 8 lines
include/linux/of_fdt.h extern void unflatten_and_copy_device_tree(void); · line 93
Quoted 3 lines
include/linux/of_fdt.h +0
-0static inline void early_init_fdt_scan_reserved_mem (void ) {}static inline void early_init_fdt_reserve_self (void ) {}_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernelQuoted 2 lines
.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
In reply to Leizhen (ThunderTown)Quoted 78 lines · Leizhen (ThunderTown)
Quoted 74 lines · Pingfan Liu
Quoted 59 lines · Leizhen (ThunderTown)
Quoted 36 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34Quoted 7 lines
...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").void
__initearly_init_dt_scan_nodes(void){ //(1) -->early_init_dt_check_for_usable_mem_range, fill cap_mem_addr rc = of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line); //(2) --> early_init_dt_add_memory_arch --> memblock_add() of_scan_flat_dt(early_init_dt_scan_memory, NULL); //(3) memblock_cap_memory_range(cap_mem_addr, cap_mem_size); }Quoted 3 lines
I didn't get it. The above step (1),(2),(3) comply with commit
e888fa7bb882("memblock: Check memory add/cap ordering")Well, at this scope, it does. But from a larger scope, let's say on arm64,
setup_arch
...
setup_machine_fdt(); //which holds your case
...
efi_init(); //which callmemblock_add, and breach the ordering.Quoted 3 lines
Did you see the warning?
pr_warn("%s: No memory registered yet\n", __func__);
Quoted 7 lines
Quoted 5 lines
Yes, I did see this message, which brings me to commit
e888fa7bb882("memblock: Check memory add/cap ordering")I am also curious why this bug does not be discovered. Is
CONFIG_EFIon at your case?Yes, Both X86 and ARM64,
CONFIG_EFI=y. I used the defconfig.
Are you booting using EFI though? efi_init() removes all memblocks that may have been setup from the DT and adds memblocks using the EFI memory map information.
Rob
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
Quoted 83 lines · Rob Herring
Quoted 81 lines · Leizhen (ThunderTown)
Quoted 77 lines · Pingfan Liu
Quoted 59 lines · Leizhen (ThunderTown)
Quoted 36 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34Quoted 7 lines
...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").void
__initearly_init_dt_scan_nodes(void){ //(1) -->early_init_dt_check_for_usable_mem_range, fill cap_mem_addr rc = of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line); //(2) --> early_init_dt_add_memory_arch --> memblock_add() of_scan_flat_dt(early_init_dt_scan_memory, NULL); //(3) memblock_cap_memory_range(cap_mem_addr, cap_mem_size); }Quoted 3 lines
I didn't get it. The above step (1),(2),(3) comply with commit
e888fa7bb882("memblock: Check memory add/cap ordering")Well, at this scope, it does. But from a larger scope, let's say on arm64,
setup_arch
...
setup_machine_fdt(); //which holds your case
...
efi_init(); //which callmemblock_add, and breach the ordering.Quoted 3 lines
Did you see the warning?
pr_warn("%s: No memory registered yet\n", __func__);Yes, I did see this message, which brings me to commit
e888fa7bb882("memblock: Check memory add/cap ordering")
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
I am also curious why this bug does not be discovered. Is
CONFIG_EFIon at your case?Yes, Both X86 and ARM64,
CONFIG_EFI=y. I used the defconfig.Are you booting using EFI though?
efi_init()removes all memblocks that may have been setup from the DT and adds memblocks using the EFI memory map information.
Sorry, I tested it with QEMU. I checked that efi_system_table is not exist.
Quoted 4 lines
Rob
.
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
In reply to Pingfan LiuQuoted 72 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").As a consequence, the virtual address set up by
copy_oldmem_page()does not bail out from the test ofvirt_addr_valid()incheck_heap_object(), and finally hits theBUG_ON().Since memblock allocator has no idea about when the memblock is fully populated, while
efi_init()is aware, so tackling this issue by calling the interfaceearly_init_dt_check_for_usable_mem_range()exposed by of/fdt.Fixes b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling")Signed-off-by Pingfan Liu <[email protected]>Cc Rob Herring <[email protected]>Cc Zhen Lei <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Andrew Morton <[email protected]>Cc Mike Rapoport <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Frank Rowand <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Nick Terrell <[email protected]>To: [email protected]
To: [email protected]
---
v2 -> v3:
use static inline stub to avoid #ifdef according to Rob's suggestion
Quoted 4 lines
drivers/firmware/efi/efi-init.c | 5 +++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-)
Looks good to me. I'll apply and send to Linus once the EFI folks ack this.
Rob
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
Quoted 74 lines · Rob Herring
Quoted 72 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").As a consequence, the virtual address set up by
copy_oldmem_page()does not bail out from the test ofvirt_addr_valid()incheck_heap_object(), and finally hits theBUG_ON().Since memblock allocator has no idea about when the memblock is fully populated, while
efi_init()is aware, so tackling this issue by calling the interfaceearly_init_dt_check_for_usable_mem_range()exposed by of/fdt.Fixes b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling")Signed-off-by Pingfan Liu <[email protected]>Cc Rob Herring <[email protected]>Cc Zhen Lei <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Andrew Morton <[email protected]>Cc Mike Rapoport <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Frank Rowand <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Nick Terrell <[email protected]>To: [email protected]
To: [email protected]
---
v2 -> v3:
use static inline stub to avoid #ifdef according to Rob's suggestion
Quoted 7 lines
Quoted 4 lines
drivers/firmware/efi/efi-init.c | 5 +++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-)Looks good to me. I'll apply and send to Linus once the EFI folks ack this.
Where needed in the series,
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
In reply to Pingfan LiuQuoted 71 lines · Pingfan Liu
On arm64, during kdump kernel saves vmcore, it runs into the following bug:
...[ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! [ 15.159707] ------------[ cut here ]------------ [ 15.164311] kernel BUG at mm/usercopy.c:99! [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 15.228073] pc : usercopy_abort+0x9c/0xa0 [ 15.232074] lr : usercopy_abort+0x9c/0xa0 [ 15.236070] sp : ffff8000121abba0 [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b [ 15.310593] Call trace: [ 15.313027] usercopy_abort+0x9c/0xa0 [ 15.316677] __check_heap_object+0xd4/0xf0 [ 15.320762] __check_object_size.part.0+0x160/0x1e0 [ 15.325628] __check_object_size+0x2c/0x40 [ 15.329711] copy_oldmem_page+0x7c/0x140 [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 [ 15.342920] read_vmcore+0x28/0x34 [ 15.346309] proc_reg_read+0xb4/0xf0 [ 15.349871] vfs_read+0xb8/0x1f0 [ 15.353088] ksys_read+0x74/0x100 [ 15.356390] __arm64_sys_read+0x28/0x34...
This bug introduced by commit
b261dba2fdb2("arm64: kdump: Remove custom linux,usable-memory-range handling"), which movesmemblock_cap_memory_range()to fdt, but it breaches the rules thatmemblock_cap_memory_range()should come aftermemblock_add()etc as said in commite888fa7bb882("memblock: Check memory add/cap ordering").As a consequence, the virtual address set up by
copy_oldmem_page()does not bail out from the test ofvirt_addr_valid()incheck_heap_object(), and finally hits theBUG_ON().Since memblock allocator has no idea about when the memblock is fully populated, while
efi_init()is aware, so tackling this issue by calling the interfaceearly_init_dt_check_for_usable_mem_range()exposed by of/fdt.Fixes b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling")Signed-off-by Pingfan Liu <[email protected]>Cc Rob Herring <[email protected]>Cc Zhen Lei <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Andrew Morton <[email protected]>Cc Mike Rapoport <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Frank Rowand <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Nick Terrell <[email protected]>To: [email protected]
To: [email protected]
---
v2 -> v3:
use static inline stub to avoid #ifdef according to Rob's suggestion
Quoted 5 lines
drivers/firmware/efi/efi-init.c | 5 +++++ drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-)
Applied, thanks!
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
In reply to Pingfan Liudrivers/of/fdt.c static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND; · line 975
Quoted 11 lines · Pingfan Liu
drivers/of/fdt.c +1
-1@@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;* location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (void ) +void __init early_init_dt_check_for_usable_mem_range (void )
Why do I see a parameter 'node'?
master:
drivers/of/fdt.c:976:static void __init early_init_dt_check_for_usable_mem_range(unsigned long node)
next:
drivers/of/fdt.c:980:static void __init early_init_dt_check_for_usable_mem_range(unsigned long node)
Quoted 24 lines
drivers/of/fdt.c +0
-0{const __be32 *prop;int len;include/linux/of_fdt.h +2
-0@@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, int depth, void *data);extern int early_init_dt_scan_memory (unsigned long node,const char *uname,int depth,void *data); +extern void early_init_dt_check_for_usable_mem_range (void );extern int early_init_dt_scan_chosen_stdout (void );extern void early_init_fdt_scan_reserved_mem (void );extern void early_init_fdt_reserve_self (void );@@ -86,6 +87,7 @@ extern void unflatten_and_copy_device_tree(void);extern void early_init_devtree (void *);extern void early_get_first_memblock_info (void *,phys_addr_t *);#else /* CONFIG_OF_EARLY_FLATTREE */ +static inline void early_init_dt_check_for_usable_mem_range (void ) {}static inline int early_init_dt_scan_chosen_stdout (void ) {return -ENODEV ; }static inline void early_init_fdt_scan_reserved_mem (void ) {}static inline void early_init_fdt_reserve_self (void ) {}
Re: [PATCHv3] efi: apply memblock cap after memblock_add()
Quoted 4 lines · Leizhen (ThunderTown)
Quoted 1 line · Pingfan Liu
Quoted 12 lines
drivers/of/fdt.c static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND; · line 975
Quoted 10 lines
drivers/of/fdt.c +1
-1@@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;* location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range (void ) +void __init early_init_dt_check_for_usable_mem_range (void )Why do I see a parameter 'node'?
Sorry, I just saw that the patch 1/2 in v2 was also applied.
Quoted 31 lines
master:
drivers/of/fdt.c:976:static void__initearly_init_dt_check_for_usable_mem_range(unsigned long node)next:
drivers/of/fdt.c:980:static void__initearly_init_dt_check_for_usable_mem_range(unsigned long node)Quoted 24 lines
drivers/of/fdt.c +0
-0{const __be32 *prop;int len;include/linux/of_fdt.h +2
-0@@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, int depth, void *data);extern int early_init_dt_scan_memory (unsigned long node,const char *uname,int depth,void *data); +extern void early_init_dt_check_for_usable_mem_range (void );extern int early_init_dt_scan_chosen_stdout (void );extern void early_init_fdt_scan_reserved_mem (void );extern void early_init_fdt_reserve_self (void );@@ -86,6 +87,7 @@ extern void unflatten_and_copy_device_tree(void);extern void early_init_devtree (void *);extern void early_get_first_memblock_info (void *,phys_addr_t *);#else /* CONFIG_OF_EARLY_FLATTREE */ +static inline void early_init_dt_check_for_usable_mem_range (void ) {}static inline int early_init_dt_scan_chosen_stdout (void ) {return -ENODEV ; }static inline void early_init_fdt_scan_reserved_mem (void ) {}static inline void early_init_fdt_reserve_self (void ) {}