Skip to contentSkip to conversation

dt-bindings: net: wireless: mt76: Fix 8-bit property sizes

PATCH Applied Rob Herring 1 participant 2 messages Jan 7, 2022 – Jan 11, 2022

Subsystems (6)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: net: wireless: mt76: Fix 8-bit property sizes

The '/bits/ 8' notation applies the next <> list of values. Another <> list is encoded as 32-bits by default. IOW, each <> list needs to be preceeded with '/bits/ 8'.

While the dts format allows this, as a rule we don't mix sizes for DT properties since all size information is lost in the dtb file.

---
 .../devicetree/bindings/net/wireless/mediatek,mt76.yaml       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml +2 -2
index 1489d3c1cd6e..269cd63fb544 100644
@@ -191,9 +191,9 @@ examples:
                    channels = <36 48>;
                    rates-ofdm = /bits/ 8 <23 23 23 23 23 23 23 23>;
                    rates-mcs = /bits/ 8 <1 23 23 23 23 23 23 23 23 23 23>,
-                                        <3 22 22 22 22 22 22 22 22 22 22>;
+                               /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22>;
                    rates-ru = /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22 22 22>,
-                                       <4 20 20 20 20 20 20 20 20 20 20 20 20>;
+                              /bits/ 8 <4 20 20 20 20 20 20 20 20 20 20 20 20>;
                };
                b1 {
                    channels = <100 181>;
Signature · 1 line
2.32.0
author maintainer Applied
#1 lore raw
Quoted 4 lines · Rob Herring

The '/bits/ 8' notation applies the next <> list of values. Another <> list is encoded as 32-bits by default. IOW, each <> list needs to be preceeded with '/bits/ 8'.

Quoted 8 lines

While the dts format allows this, as a rule we don't mix sizes for DT properties since all size information is lost in the dtb file.

---
 .../devicetree/bindings/net/wireless/mediatek,mt76.yaml       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks!